@calmo/task-runner 3.3.0 → 3.4.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.github/dependabot.yml +7 -7
- package/.github/workflows/ci.yml +4 -4
- package/.jules/backlog_maniac.md +4 -0
- package/.jules/nexus.md +1 -0
- package/.jules/sentinel.md +1 -0
- package/.releaserc.json +2 -7
- package/AGENTS.md +8 -2
- package/CHANGELOG.md +181 -167
- package/README.md +23 -23
- package/coverage/coverage-final.json +8 -7
- package/coverage/index.html +7 -7
- package/coverage/lcov-report/index.html +7 -7
- package/coverage/lcov-report/src/EventBus.ts.html +28 -22
- package/coverage/lcov-report/src/TaskGraphValidationError.ts.html +130 -0
- package/coverage/lcov-report/src/TaskGraphValidator.ts.html +166 -151
- package/coverage/lcov-report/src/TaskRunner.ts.html +69 -54
- package/coverage/lcov-report/src/TaskRunnerBuilder.ts.html +29 -5
- package/coverage/lcov-report/src/TaskRunnerExecutionConfig.ts.html +1 -1
- package/coverage/lcov-report/src/TaskStateManager.ts.html +1 -1
- package/coverage/lcov-report/src/WorkflowExecutor.ts.html +21 -12
- package/coverage/lcov-report/src/contracts/RunnerEvents.ts.html +1 -1
- package/coverage/lcov-report/src/contracts/index.html +1 -1
- package/coverage/lcov-report/src/index.html +23 -8
- package/coverage/lcov-report/src/strategies/DryRunExecutionStrategy.ts.html +4 -4
- package/coverage/lcov-report/src/strategies/RetryingExecutionStrategy.ts.html +30 -12
- package/coverage/lcov-report/src/strategies/StandardExecutionStrategy.ts.html +5 -5
- package/coverage/lcov-report/src/strategies/index.html +1 -1
- package/coverage/lcov.info +296 -278
- package/coverage/src/EventBus.ts.html +28 -22
- package/coverage/src/TaskGraphValidationError.ts.html +130 -0
- package/coverage/src/TaskGraphValidator.ts.html +166 -151
- package/coverage/src/TaskRunner.ts.html +69 -54
- package/coverage/src/TaskRunnerBuilder.ts.html +29 -5
- package/coverage/src/TaskRunnerExecutionConfig.ts.html +1 -1
- package/coverage/src/TaskStateManager.ts.html +1 -1
- package/coverage/src/WorkflowExecutor.ts.html +21 -12
- package/coverage/src/contracts/RunnerEvents.ts.html +1 -1
- package/coverage/src/contracts/index.html +1 -1
- package/coverage/src/index.html +23 -8
- package/coverage/src/strategies/DryRunExecutionStrategy.ts.html +4 -4
- package/coverage/src/strategies/RetryingExecutionStrategy.ts.html +30 -12
- package/coverage/src/strategies/StandardExecutionStrategy.ts.html +5 -5
- package/coverage/src/strategies/index.html +1 -1
- package/dist/EventBus.js +13 -11
- package/dist/EventBus.js.map +1 -1
- package/dist/TaskGraphValidationError.d.ts +9 -0
- package/dist/TaskGraphValidationError.js +13 -0
- package/dist/TaskGraphValidationError.js.map +1 -0
- package/dist/TaskGraphValidator.js +9 -9
- package/dist/TaskGraphValidator.js.map +1 -1
- package/dist/TaskRunner.js +2 -1
- package/dist/TaskRunner.js.map +1 -1
- package/dist/TaskRunnerBuilder.js.map +1 -1
- package/dist/WorkflowExecutor.js +2 -1
- package/dist/WorkflowExecutor.js.map +1 -1
- package/dist/index.d.ts +1 -0
- package/dist/index.js +1 -0
- package/dist/index.js.map +1 -1
- package/dist/strategies/RetryingExecutionStrategy.js +3 -1
- package/dist/strategies/RetryingExecutionStrategy.js.map +1 -1
- package/dist/strategies/StandardExecutionStrategy.js +1 -1
- package/dist/strategies/StandardExecutionStrategy.js.map +1 -1
- package/openspec/AGENTS.md +81 -15
- package/openspec/changes/{add-concurrency-control → archive/2026-01-18-add-concurrency-control}/proposal.md +7 -4
- package/openspec/changes/archive/2026-01-18-add-concurrency-control/tasks.md +10 -0
- package/openspec/changes/archive/2026-01-18-add-external-task-cancellation/proposal.md +4 -1
- package/openspec/changes/archive/2026-01-18-add-external-task-cancellation/tasks.md +2 -1
- package/openspec/changes/archive/2026-01-18-add-integration-tests/proposal.md +3 -0
- package/openspec/changes/archive/2026-01-18-add-integration-tests/tasks.md +1 -0
- package/openspec/changes/archive/2026-01-18-add-task-retry-policy/proposal.md +3 -0
- package/openspec/changes/archive/2026-01-18-add-task-retry-policy/tasks.md +1 -0
- package/openspec/changes/archive/2026-01-18-add-workflow-preview/proposal.md +3 -0
- package/openspec/changes/archive/2026-01-18-add-workflow-preview/tasks.md +1 -0
- package/openspec/changes/archive/2026-01-18-refactor-core-architecture/proposal.md +3 -0
- package/openspec/changes/archive/2026-01-18-refactor-core-architecture/tasks.md +1 -0
- package/openspec/changes/feat-per-task-timeout/proposal.md +11 -6
- package/openspec/changes/feat-per-task-timeout/tasks.md +1 -1
- package/openspec/project.md +21 -15
- package/package.json +1 -1
- package/src/EventBus.ts +18 -16
- package/src/TaskGraph.ts +8 -8
- package/src/TaskGraphValidationError.ts +15 -0
- package/src/TaskGraphValidator.ts +148 -143
- package/src/TaskRunner.ts +47 -42
- package/src/TaskRunnerBuilder.ts +11 -3
- package/src/WorkflowExecutor.ts +13 -10
- package/src/contracts/ITaskGraphValidator.ts +12 -12
- package/src/contracts/ValidationError.ts +6 -6
- package/src/contracts/ValidationResult.ts +4 -4
- package/src/index.ts +1 -0
- package/src/strategies/DryRunExecutionStrategy.ts +3 -3
- package/src/strategies/RetryingExecutionStrategy.ts +15 -9
- package/src/strategies/StandardExecutionStrategy.ts +4 -4
- package/test-report.xml +109 -107
- package/openspec/changes/add-concurrency-control/tasks.md +0 -9
|
@@ -25,7 +25,7 @@
|
|
|
25
25
|
<div class='fl pad1y space-right2'>
|
|
26
26
|
<span class="strong">100% </span>
|
|
27
27
|
<span class="quiet">Statements</span>
|
|
28
|
-
<span class='fraction'>
|
|
28
|
+
<span class='fraction'>16/16</span>
|
|
29
29
|
</div>
|
|
30
30
|
|
|
31
31
|
|
|
@@ -39,14 +39,14 @@
|
|
|
39
39
|
<div class='fl pad1y space-right2'>
|
|
40
40
|
<span class="strong">100% </span>
|
|
41
41
|
<span class="quiet">Functions</span>
|
|
42
|
-
<span class='fraction'>
|
|
42
|
+
<span class='fraction'>5/5</span>
|
|
43
43
|
</div>
|
|
44
44
|
|
|
45
45
|
|
|
46
46
|
<div class='fl pad1y space-right2'>
|
|
47
47
|
<span class="strong">100% </span>
|
|
48
48
|
<span class="quiet">Lines</span>
|
|
49
|
-
<span class='fraction'>
|
|
49
|
+
<span class='fraction'>16/16</span>
|
|
50
50
|
</div>
|
|
51
51
|
|
|
52
52
|
|
|
@@ -147,7 +147,9 @@
|
|
|
147
147
|
<a name='L82'></a><a href='#L82'>82</a>
|
|
148
148
|
<a name='L83'></a><a href='#L83'>83</a>
|
|
149
149
|
<a name='L84'></a><a href='#L84'>84</a>
|
|
150
|
-
<a name='L85'></a><a href='#L85'>85</a
|
|
150
|
+
<a name='L85'></a><a href='#L85'>85</a>
|
|
151
|
+
<a name='L86'></a><a href='#L86'>86</a>
|
|
152
|
+
<a name='L87'></a><a href='#L87'>87</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral"> </span>
|
|
151
153
|
<span class="cline-any cline-neutral"> </span>
|
|
152
154
|
<span class="cline-any cline-neutral"> </span>
|
|
153
155
|
<span class="cline-any cline-neutral"> </span>
|
|
@@ -158,7 +160,7 @@
|
|
|
158
160
|
<span class="cline-any cline-neutral"> </span>
|
|
159
161
|
<span class="cline-any cline-neutral"> </span>
|
|
160
162
|
<span class="cline-any cline-neutral"> </span>
|
|
161
|
-
<span class="cline-any cline-yes">
|
|
163
|
+
<span class="cline-any cline-yes">63x</span>
|
|
162
164
|
<span class="cline-any cline-neutral"> </span>
|
|
163
165
|
<span class="cline-any cline-neutral"> </span>
|
|
164
166
|
<span class="cline-any cline-neutral"> </span>
|
|
@@ -213,6 +215,7 @@
|
|
|
213
215
|
<span class="cline-any cline-yes">14x</span>
|
|
214
216
|
<span class="cline-any cline-yes">14x</span>
|
|
215
217
|
<span class="cline-any cline-yes">14x</span>
|
|
218
|
+
<span class="cline-any cline-yes">14x</span>
|
|
216
219
|
<span class="cline-any cline-yes">1x</span>
|
|
217
220
|
<span class="cline-any cline-yes">1x</span>
|
|
218
221
|
<span class="cline-any cline-neutral"> </span>
|
|
@@ -231,6 +234,7 @@
|
|
|
231
234
|
<span class="cline-any cline-neutral"> </span>
|
|
232
235
|
<span class="cline-any cline-neutral"> </span>
|
|
233
236
|
<span class="cline-any cline-neutral"> </span>
|
|
237
|
+
<span class="cline-any cline-neutral"> </span>
|
|
234
238
|
<span class="cline-any cline-neutral"> </span></td><td class="text"><pre class="prettyprint lang-js">import {
|
|
235
239
|
ListenerMap,
|
|
236
240
|
RunnerEventListener,
|
|
@@ -294,23 +298,25 @@ export class EventBus<TContext> {
|
|
|
294
298
|
| undefined;
|
|
295
299
|
if (listeners) {
|
|
296
300
|
for (const listener of listeners) {
|
|
297
|
-
|
|
298
|
-
|
|
299
|
-
|
|
300
|
-
result
|
|
301
|
-
|
|
302
|
-
|
|
303
|
-
|
|
304
|
-
|
|
305
|
-
|
|
301
|
+
Promise.resolve().then(() => {
|
|
302
|
+
try {
|
|
303
|
+
const result = listener(data);
|
|
304
|
+
if (result instanceof Promise) {
|
|
305
|
+
result.catch((error) => {
|
|
306
|
+
console.error(
|
|
307
|
+
`Error in event listener for ${String(event)}:`,
|
|
308
|
+
error
|
|
309
|
+
);
|
|
310
|
+
});
|
|
311
|
+
}
|
|
312
|
+
} catch (error) {
|
|
313
|
+
// Prevent listener errors from bubbling up
|
|
314
|
+
console.error(
|
|
315
|
+
`Error in event listener for ${String(event)}:`,
|
|
316
|
+
error
|
|
317
|
+
);
|
|
306
318
|
}
|
|
307
|
-
}
|
|
308
|
-
// Prevent listener errors from bubbling up
|
|
309
|
-
console.error(
|
|
310
|
-
`Error in event listener for ${String(event)}:`,
|
|
311
|
-
error
|
|
312
|
-
);
|
|
313
|
-
}
|
|
319
|
+
});
|
|
314
320
|
}
|
|
315
321
|
}
|
|
316
322
|
}
|
|
@@ -322,7 +328,7 @@ export class EventBus<TContext> {
|
|
|
322
328
|
<div class='footer quiet pad2 space-top1 center small'>
|
|
323
329
|
Code coverage generated by
|
|
324
330
|
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
|
|
325
|
-
at 2026-01-
|
|
331
|
+
at 2026-01-18T21:02:31.377Z
|
|
326
332
|
</div>
|
|
327
333
|
<script src="../prettify.js"></script>
|
|
328
334
|
<script>
|
|
@@ -0,0 +1,130 @@
|
|
|
1
|
+
|
|
2
|
+
<!doctype html>
|
|
3
|
+
<html lang="en">
|
|
4
|
+
|
|
5
|
+
<head>
|
|
6
|
+
<title>Code coverage report for src/TaskGraphValidationError.ts</title>
|
|
7
|
+
<meta charset="utf-8" />
|
|
8
|
+
<link rel="stylesheet" href="../prettify.css" />
|
|
9
|
+
<link rel="stylesheet" href="../base.css" />
|
|
10
|
+
<link rel="shortcut icon" type="image/x-icon" href="../favicon.png" />
|
|
11
|
+
<meta name="viewport" content="width=device-width, initial-scale=1" />
|
|
12
|
+
<style type='text/css'>
|
|
13
|
+
.coverage-summary .sorter {
|
|
14
|
+
background-image: url(../sort-arrow-sprite.png);
|
|
15
|
+
}
|
|
16
|
+
</style>
|
|
17
|
+
</head>
|
|
18
|
+
|
|
19
|
+
<body>
|
|
20
|
+
<div class='wrapper'>
|
|
21
|
+
<div class='pad1'>
|
|
22
|
+
<h1><a href="../index.html">All files</a> / <a href="index.html">src</a> TaskGraphValidationError.ts</h1>
|
|
23
|
+
<div class='clearfix'>
|
|
24
|
+
|
|
25
|
+
<div class='fl pad1y space-right2'>
|
|
26
|
+
<span class="strong">100% </span>
|
|
27
|
+
<span class="quiet">Statements</span>
|
|
28
|
+
<span class='fraction'>3/3</span>
|
|
29
|
+
</div>
|
|
30
|
+
|
|
31
|
+
|
|
32
|
+
<div class='fl pad1y space-right2'>
|
|
33
|
+
<span class="strong">100% </span>
|
|
34
|
+
<span class="quiet">Branches</span>
|
|
35
|
+
<span class='fraction'>0/0</span>
|
|
36
|
+
</div>
|
|
37
|
+
|
|
38
|
+
|
|
39
|
+
<div class='fl pad1y space-right2'>
|
|
40
|
+
<span class="strong">100% </span>
|
|
41
|
+
<span class="quiet">Functions</span>
|
|
42
|
+
<span class='fraction'>1/1</span>
|
|
43
|
+
</div>
|
|
44
|
+
|
|
45
|
+
|
|
46
|
+
<div class='fl pad1y space-right2'>
|
|
47
|
+
<span class="strong">100% </span>
|
|
48
|
+
<span class="quiet">Lines</span>
|
|
49
|
+
<span class='fraction'>3/3</span>
|
|
50
|
+
</div>
|
|
51
|
+
|
|
52
|
+
|
|
53
|
+
</div>
|
|
54
|
+
<p class="quiet">
|
|
55
|
+
Press <em>n</em> or <em>j</em> to go to the next uncovered block, <em>b</em>, <em>p</em> or <em>k</em> for the previous block.
|
|
56
|
+
</p>
|
|
57
|
+
<template id="filterTemplate">
|
|
58
|
+
<div class="quiet">
|
|
59
|
+
Filter:
|
|
60
|
+
<input type="search" id="fileSearch">
|
|
61
|
+
</div>
|
|
62
|
+
</template>
|
|
63
|
+
</div>
|
|
64
|
+
<div class='status-line high'></div>
|
|
65
|
+
<pre><table class="coverage">
|
|
66
|
+
<tr><td class="line-count quiet"><a name='L1'></a><a href='#L1'>1</a>
|
|
67
|
+
<a name='L2'></a><a href='#L2'>2</a>
|
|
68
|
+
<a name='L3'></a><a href='#L3'>3</a>
|
|
69
|
+
<a name='L4'></a><a href='#L4'>4</a>
|
|
70
|
+
<a name='L5'></a><a href='#L5'>5</a>
|
|
71
|
+
<a name='L6'></a><a href='#L6'>6</a>
|
|
72
|
+
<a name='L7'></a><a href='#L7'>7</a>
|
|
73
|
+
<a name='L8'></a><a href='#L8'>8</a>
|
|
74
|
+
<a name='L9'></a><a href='#L9'>9</a>
|
|
75
|
+
<a name='L10'></a><a href='#L10'>10</a>
|
|
76
|
+
<a name='L11'></a><a href='#L11'>11</a>
|
|
77
|
+
<a name='L12'></a><a href='#L12'>12</a>
|
|
78
|
+
<a name='L13'></a><a href='#L13'>13</a>
|
|
79
|
+
<a name='L14'></a><a href='#L14'>14</a>
|
|
80
|
+
<a name='L15'></a><a href='#L15'>15</a>
|
|
81
|
+
<a name='L16'></a><a href='#L16'>16</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral"> </span>
|
|
82
|
+
<span class="cline-any cline-neutral"> </span>
|
|
83
|
+
<span class="cline-any cline-neutral"> </span>
|
|
84
|
+
<span class="cline-any cline-neutral"> </span>
|
|
85
|
+
<span class="cline-any cline-neutral"> </span>
|
|
86
|
+
<span class="cline-any cline-neutral"> </span>
|
|
87
|
+
<span class="cline-any cline-neutral"> </span>
|
|
88
|
+
<span class="cline-any cline-neutral"> </span>
|
|
89
|
+
<span class="cline-any cline-yes">9x</span>
|
|
90
|
+
<span class="cline-any cline-neutral"> </span>
|
|
91
|
+
<span class="cline-any cline-neutral"> </span>
|
|
92
|
+
<span class="cline-any cline-yes">9x</span>
|
|
93
|
+
<span class="cline-any cline-yes">9x</span>
|
|
94
|
+
<span class="cline-any cline-neutral"> </span>
|
|
95
|
+
<span class="cline-any cline-neutral"> </span>
|
|
96
|
+
<span class="cline-any cline-neutral"> </span></td><td class="text"><pre class="prettyprint lang-js">import { ValidationResult } from "./contracts/ValidationResult.js";
|
|
97
|
+
|
|
98
|
+
/**
|
|
99
|
+
* Error thrown when a task graph fails validation.
|
|
100
|
+
* Contains the validation result with detailed error information.
|
|
101
|
+
*/
|
|
102
|
+
export class TaskGraphValidationError extends Error {
|
|
103
|
+
constructor(
|
|
104
|
+
public result: ValidationResult,
|
|
105
|
+
message: string
|
|
106
|
+
) {
|
|
107
|
+
super(message);
|
|
108
|
+
this.name = "TaskGraphValidationError";
|
|
109
|
+
}
|
|
110
|
+
}
|
|
111
|
+
</pre></td></tr></table></pre>
|
|
112
|
+
|
|
113
|
+
<div class='push'></div><!-- for sticky footer -->
|
|
114
|
+
</div><!-- /wrapper -->
|
|
115
|
+
<div class='footer quiet pad2 space-top1 center small'>
|
|
116
|
+
Code coverage generated by
|
|
117
|
+
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
|
|
118
|
+
at 2026-01-18T21:02:31.377Z
|
|
119
|
+
</div>
|
|
120
|
+
<script src="../prettify.js"></script>
|
|
121
|
+
<script>
|
|
122
|
+
window.onload = function () {
|
|
123
|
+
prettyPrint();
|
|
124
|
+
};
|
|
125
|
+
</script>
|
|
126
|
+
<script src="../sorter.js"></script>
|
|
127
|
+
<script src="../block-navigation.js"></script>
|
|
128
|
+
</body>
|
|
129
|
+
</html>
|
|
130
|
+
|
|
@@ -46,7 +46,7 @@
|
|
|
46
46
|
<div class='fl pad1y space-right2'>
|
|
47
47
|
<span class="strong">100% </span>
|
|
48
48
|
<span class="quiet">Lines</span>
|
|
49
|
-
<span class='fraction'>
|
|
49
|
+
<span class='fraction'>55/55</span>
|
|
50
50
|
</div>
|
|
51
51
|
|
|
52
52
|
|
|
@@ -226,7 +226,12 @@
|
|
|
226
226
|
<a name='L161'></a><a href='#L161'>161</a>
|
|
227
227
|
<a name='L162'></a><a href='#L162'>162</a>
|
|
228
228
|
<a name='L163'></a><a href='#L163'>163</a>
|
|
229
|
-
<a name='L164'></a><a href='#L164'>164</a
|
|
229
|
+
<a name='L164'></a><a href='#L164'>164</a>
|
|
230
|
+
<a name='L165'></a><a href='#L165'>165</a>
|
|
231
|
+
<a name='L166'></a><a href='#L166'>166</a>
|
|
232
|
+
<a name='L167'></a><a href='#L167'>167</a>
|
|
233
|
+
<a name='L168'></a><a href='#L168'>168</a>
|
|
234
|
+
<a name='L169'></a><a href='#L169'>169</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral"> </span>
|
|
230
235
|
<span class="cline-any cline-neutral"> </span>
|
|
231
236
|
<span class="cline-any cline-neutral"> </span>
|
|
232
237
|
<span class="cline-any cline-neutral"> </span>
|
|
@@ -243,27 +248,27 @@
|
|
|
243
248
|
<span class="cline-any cline-neutral"> </span>
|
|
244
249
|
<span class="cline-any cline-neutral"> </span>
|
|
245
250
|
<span class="cline-any cline-neutral"> </span>
|
|
246
|
-
<span class="cline-any cline-yes">
|
|
251
|
+
<span class="cline-any cline-yes">61x</span>
|
|
247
252
|
<span class="cline-any cline-neutral"> </span>
|
|
248
253
|
<span class="cline-any cline-neutral"> </span>
|
|
249
|
-
<span class="cline-any cline-yes">
|
|
250
|
-
<span class="cline-any cline-yes">
|
|
251
|
-
<span class="cline-any cline-yes">
|
|
254
|
+
<span class="cline-any cline-yes">61x</span>
|
|
255
|
+
<span class="cline-any cline-yes">61x</span>
|
|
256
|
+
<span class="cline-any cline-yes">20158x</span>
|
|
252
257
|
<span class="cline-any cline-yes">3x</span>
|
|
253
258
|
<span class="cline-any cline-neutral"> </span>
|
|
254
259
|
<span class="cline-any cline-neutral"> </span>
|
|
255
260
|
<span class="cline-any cline-neutral"> </span>
|
|
256
261
|
<span class="cline-any cline-neutral"> </span>
|
|
257
262
|
<span class="cline-any cline-neutral"> </span>
|
|
258
|
-
<span class="cline-any cline-yes">
|
|
263
|
+
<span class="cline-any cline-yes">20155x</span>
|
|
259
264
|
<span class="cline-any cline-neutral"> </span>
|
|
260
265
|
<span class="cline-any cline-neutral"> </span>
|
|
261
266
|
<span class="cline-any cline-neutral"> </span>
|
|
262
267
|
<span class="cline-any cline-neutral"> </span>
|
|
263
|
-
<span class="cline-any cline-yes">
|
|
264
|
-
<span class="cline-any cline-yes">
|
|
265
|
-
<span class="cline-any cline-yes">
|
|
266
|
-
<span class="cline-any cline-yes">
|
|
268
|
+
<span class="cline-any cline-yes">61x</span>
|
|
269
|
+
<span class="cline-any cline-yes">20158x</span>
|
|
270
|
+
<span class="cline-any cline-yes">20169x</span>
|
|
271
|
+
<span class="cline-any cline-yes">7x</span>
|
|
267
272
|
<span class="cline-any cline-neutral"> </span>
|
|
268
273
|
<span class="cline-any cline-neutral"> </span>
|
|
269
274
|
<span class="cline-any cline-neutral"> </span>
|
|
@@ -274,10 +279,12 @@
|
|
|
274
279
|
<span class="cline-any cline-neutral"> </span>
|
|
275
280
|
<span class="cline-any cline-neutral"> </span>
|
|
276
281
|
<span class="cline-any cline-neutral"> </span>
|
|
277
|
-
<span class="cline-any cline-yes">
|
|
282
|
+
<span class="cline-any cline-yes">61x</span>
|
|
283
|
+
<span class="cline-any cline-yes">9x</span>
|
|
278
284
|
<span class="cline-any cline-neutral"> </span>
|
|
279
|
-
<span class="cline-any cline-
|
|
280
|
-
<span class="cline-any cline-yes">
|
|
285
|
+
<span class="cline-any cline-neutral"> </span>
|
|
286
|
+
<span class="cline-any cline-yes">61x</span>
|
|
287
|
+
<span class="cline-any cline-yes">6x</span>
|
|
281
288
|
<span class="cline-any cline-neutral"> </span>
|
|
282
289
|
<span class="cline-any cline-neutral"> </span>
|
|
283
290
|
<span class="cline-any cline-neutral"> </span>
|
|
@@ -301,6 +308,8 @@
|
|
|
301
308
|
<span class="cline-any cline-yes">20139x</span>
|
|
302
309
|
<span class="cline-any cline-neutral"> </span>
|
|
303
310
|
<span class="cline-any cline-neutral"> </span>
|
|
311
|
+
<span class="cline-any cline-neutral"> </span>
|
|
312
|
+
<span class="cline-any cline-neutral"> </span>
|
|
304
313
|
<span class="cline-any cline-yes">5x</span>
|
|
305
314
|
<span class="cline-any cline-yes">5x</span>
|
|
306
315
|
<span class="cline-any cline-yes">5x</span>
|
|
@@ -327,8 +336,9 @@
|
|
|
327
336
|
<span class="cline-any cline-neutral"> </span>
|
|
328
337
|
<span class="cline-any cline-neutral"> </span>
|
|
329
338
|
<span class="cline-any cline-neutral"> </span>
|
|
330
|
-
<span class="cline-any cline-yes">
|
|
331
|
-
<span class="cline-any cline-yes">
|
|
339
|
+
<span class="cline-any cline-yes">9x</span>
|
|
340
|
+
<span class="cline-any cline-yes">9x</span>
|
|
341
|
+
<span class="cline-any cline-neutral"> </span>
|
|
332
342
|
<span class="cline-any cline-neutral"> </span>
|
|
333
343
|
<span class="cline-any cline-neutral"> </span>
|
|
334
344
|
<span class="cline-any cline-neutral"> </span>
|
|
@@ -395,162 +405,167 @@ import { ValidationError } from "./contracts/ValidationError.js";
|
|
|
395
405
|
import { TaskGraph } from "./TaskGraph.js";
|
|
396
406
|
|
|
397
407
|
export class TaskGraphValidator implements ITaskGraphValidator {
|
|
398
|
-
|
|
399
|
-
|
|
400
|
-
|
|
401
|
-
|
|
402
|
-
|
|
403
|
-
|
|
404
|
-
|
|
405
|
-
|
|
406
|
-
|
|
407
|
-
|
|
408
|
-
|
|
409
|
-
|
|
410
|
-
|
|
411
|
-
// 1. Check for duplicate tasks
|
|
412
|
-
const taskIds = new Set<string>();
|
|
413
|
-
for (const task of taskGraph.tasks) {
|
|
414
|
-
if (taskIds.has(task.id)) {
|
|
415
|
-
errors.push({
|
|
416
|
-
type: "duplicate_task",
|
|
417
|
-
message: `Duplicate task detected with ID: ${task.id}`,
|
|
418
|
-
details: { taskId: task.id }
|
|
419
|
-
});
|
|
420
|
-
} else {
|
|
421
|
-
taskIds.add(task.id);
|
|
422
|
-
}
|
|
423
|
-
}
|
|
424
|
-
|
|
425
|
-
// 2. Check for missing dependencies
|
|
426
|
-
for (const task of taskGraph.tasks) {
|
|
427
|
-
for (const dependenceId of task.dependencies) {
|
|
428
|
-
if (!taskIds.has(dependenceId)) {
|
|
429
|
-
errors.push({
|
|
430
|
-
type: "missing_dependency",
|
|
431
|
-
message: `Task '${task.id}' depends on missing task '${dependenceId}'`,
|
|
432
|
-
details: { taskId: task.id, missingDependencyId: dependenceId }
|
|
433
|
-
});
|
|
434
|
-
}
|
|
435
|
-
}
|
|
436
|
-
}
|
|
408
|
+
/**
|
|
409
|
+
* Validates a given task graph for structural integrity.
|
|
410
|
+
* Checks for:
|
|
411
|
+
* 1. Duplicate task IDs.
|
|
412
|
+
* 2. Missing dependencies (tasks that depend on non-existent IDs).
|
|
413
|
+
* 3. Circular dependencies (cycles in the graph).
|
|
414
|
+
*
|
|
415
|
+
* @param taskGraph The task graph to validate.
|
|
416
|
+
* @returns A ValidationResult object indicating the outcome of the validation.
|
|
417
|
+
*/
|
|
418
|
+
validate(taskGraph: TaskGraph): ValidationResult {
|
|
419
|
+
const errors: ValidationError[] = [];
|
|
437
420
|
|
|
438
|
-
|
|
439
|
-
|
|
440
|
-
|
|
421
|
+
// 1. Check for duplicate tasks
|
|
422
|
+
const taskIds = new Set<string>();
|
|
423
|
+
for (const task of taskGraph.tasks) {
|
|
424
|
+
if (taskIds.has(task.id)) {
|
|
425
|
+
errors.push({
|
|
426
|
+
type: "duplicate_task",
|
|
427
|
+
message: `Duplicate task detected with ID: ${task.id}`,
|
|
428
|
+
details: { taskId: task.id },
|
|
429
|
+
});
|
|
430
|
+
} else {
|
|
431
|
+
taskIds.add(task.id);
|
|
432
|
+
}
|
|
433
|
+
}
|
|
441
434
|
|
|
442
|
-
|
|
443
|
-
|
|
444
|
-
|
|
445
|
-
|
|
446
|
-
|
|
435
|
+
// 2. Check for missing dependencies
|
|
436
|
+
for (const task of taskGraph.tasks) {
|
|
437
|
+
for (const dependenceId of task.dependencies) {
|
|
438
|
+
if (!taskIds.has(dependenceId)) {
|
|
439
|
+
errors.push({
|
|
440
|
+
type: "missing_dependency",
|
|
441
|
+
message: `Task '${task.id}' depends on missing task '${dependenceId}'`,
|
|
442
|
+
details: { taskId: task.id, missingDependencyId: dependenceId },
|
|
443
|
+
});
|
|
447
444
|
}
|
|
445
|
+
}
|
|
446
|
+
}
|
|
448
447
|
|
|
449
|
-
|
|
450
|
-
|
|
451
|
-
|
|
452
|
-
|
|
453
|
-
|
|
448
|
+
// 3. Check for cycles
|
|
449
|
+
// Only run cycle detection if there are no missing dependencies, otherwise we might chase non-existent nodes.
|
|
450
|
+
const hasMissingDependencies = errors.some(
|
|
451
|
+
(e) => e.type === "missing_dependency"
|
|
452
|
+
);
|
|
454
453
|
|
|
455
|
-
|
|
456
|
-
|
|
454
|
+
if (hasMissingDependencies) {
|
|
455
|
+
return {
|
|
456
|
+
isValid: errors.length === 0,
|
|
457
|
+
errors,
|
|
458
|
+
};
|
|
459
|
+
}
|
|
457
460
|
|
|
458
|
-
|
|
459
|
-
|
|
460
|
-
|
|
461
|
-
|
|
461
|
+
// Build adjacency list
|
|
462
|
+
const adjacencyList = new Map<string, string[]>();
|
|
463
|
+
for (const task of taskGraph.tasks) {
|
|
464
|
+
adjacencyList.set(task.id, task.dependencies);
|
|
465
|
+
}
|
|
462
466
|
|
|
463
|
-
|
|
464
|
-
|
|
465
|
-
// Extract the actual cycle from the path
|
|
466
|
-
// The path might look like A -> B -> C -> B (if we started at A and found cycle B-C-B)
|
|
467
|
-
const cycleStart = path[path.length - 1];
|
|
468
|
-
const cycleStartIndex = path.indexOf(cycleStart);
|
|
469
|
-
const cyclePath = path.slice(cycleStartIndex);
|
|
467
|
+
const visited = new Set<string>();
|
|
468
|
+
const recursionStack = new Set<string>();
|
|
470
469
|
|
|
471
|
-
|
|
472
|
-
|
|
473
|
-
|
|
474
|
-
|
|
475
|
-
});
|
|
476
|
-
// Break after first cycle found to avoid spamming similar errors
|
|
477
|
-
break;
|
|
478
|
-
}
|
|
479
|
-
}
|
|
470
|
+
for (const task of taskGraph.tasks) {
|
|
471
|
+
if (visited.has(task.id)) {
|
|
472
|
+
continue;
|
|
473
|
+
}
|
|
480
474
|
|
|
481
|
-
|
|
482
|
-
|
|
483
|
-
|
|
484
|
-
|
|
485
|
-
|
|
475
|
+
const path: string[] = [];
|
|
476
|
+
if (
|
|
477
|
+
this.detectCycle(task.id, path, visited, recursionStack, adjacencyList)
|
|
478
|
+
) {
|
|
479
|
+
// Extract the actual cycle from the path
|
|
480
|
+
// The path might look like A -> B -> C -> B (if we started at A and found cycle B-C-B)
|
|
481
|
+
const cycleStart = path[path.length - 1];
|
|
482
|
+
const cycleStartIndex = path.indexOf(cycleStart);
|
|
483
|
+
const cyclePath = path.slice(cycleStartIndex);
|
|
486
484
|
|
|
487
|
-
|
|
488
|
-
|
|
489
|
-
|
|
490
|
-
|
|
491
|
-
|
|
492
|
-
|
|
493
|
-
|
|
494
|
-
|
|
485
|
+
errors.push({
|
|
486
|
+
type: "cycle",
|
|
487
|
+
message: `Cycle detected: ${cyclePath.join(" -> ")}`,
|
|
488
|
+
details: { cyclePath },
|
|
489
|
+
});
|
|
490
|
+
// Break after first cycle found to avoid spamming similar errors
|
|
491
|
+
break;
|
|
492
|
+
}
|
|
495
493
|
}
|
|
496
494
|
|
|
497
|
-
|
|
498
|
-
|
|
499
|
-
|
|
500
|
-
|
|
501
|
-
|
|
502
|
-
adjacencyList: Map<string, string[]>
|
|
503
|
-
): boolean {
|
|
504
|
-
// Use an explicit stack to avoid maximum call stack size exceeded errors
|
|
505
|
-
const stack: { taskId: string; index: number; dependencies: string[] }[] = [];
|
|
495
|
+
return {
|
|
496
|
+
isValid: errors.length === 0,
|
|
497
|
+
errors,
|
|
498
|
+
};
|
|
499
|
+
}
|
|
506
500
|
|
|
507
|
-
|
|
508
|
-
|
|
509
|
-
|
|
501
|
+
/**
|
|
502
|
+
* Creates a human-readable error message from a validation result.
|
|
503
|
+
* @param result The validation result containing errors.
|
|
504
|
+
* @returns A formatted error string.
|
|
505
|
+
*/
|
|
506
|
+
createErrorMessage(result: ValidationResult): string {
|
|
507
|
+
const errorDetails = result.errors.map((e) => e.message);
|
|
508
|
+
return `Task graph validation failed: ${errorDetails.join("; ")}`;
|
|
509
|
+
}
|
|
510
510
|
|
|
511
|
-
|
|
512
|
-
|
|
513
|
-
|
|
514
|
-
|
|
515
|
-
|
|
516
|
-
|
|
511
|
+
private detectCycle(
|
|
512
|
+
startTaskId: string,
|
|
513
|
+
path: string[],
|
|
514
|
+
visited: Set<string>,
|
|
515
|
+
recursionStack: Set<string>,
|
|
516
|
+
adjacencyList: Map<string, string[]>
|
|
517
|
+
): boolean {
|
|
518
|
+
// Use an explicit stack to avoid maximum call stack size exceeded errors
|
|
519
|
+
const stack: { taskId: string; index: number; dependencies: string[] }[] =
|
|
520
|
+
[];
|
|
517
521
|
|
|
518
|
-
|
|
519
|
-
|
|
520
|
-
|
|
522
|
+
visited.add(startTaskId);
|
|
523
|
+
recursionStack.add(startTaskId);
|
|
524
|
+
path.push(startTaskId);
|
|
521
525
|
|
|
522
|
-
|
|
523
|
-
|
|
524
|
-
|
|
526
|
+
stack.push({
|
|
527
|
+
taskId: startTaskId,
|
|
528
|
+
index: 0,
|
|
529
|
+
/* v8 ignore next */
|
|
530
|
+
dependencies: adjacencyList.get(startTaskId) ?? [],
|
|
531
|
+
});
|
|
525
532
|
|
|
526
|
-
|
|
527
|
-
|
|
528
|
-
|
|
529
|
-
return true;
|
|
530
|
-
}
|
|
533
|
+
while (stack.length > 0) {
|
|
534
|
+
const frame = stack[stack.length - 1];
|
|
535
|
+
const { taskId, dependencies } = frame;
|
|
531
536
|
|
|
532
|
-
|
|
533
|
-
|
|
534
|
-
|
|
535
|
-
path.push(dependenceId);
|
|
537
|
+
if (frame.index < dependencies.length) {
|
|
538
|
+
const dependenceId = dependencies[frame.index];
|
|
539
|
+
frame.index++;
|
|
536
540
|
|
|
537
|
-
|
|
538
|
-
|
|
539
|
-
|
|
540
|
-
|
|
541
|
-
dependencies: adjacencyList.get(dependenceId) ?? []
|
|
542
|
-
});
|
|
543
|
-
}
|
|
544
|
-
} else {
|
|
545
|
-
// Finished all dependencies for this node
|
|
546
|
-
recursionStack.delete(taskId);
|
|
547
|
-
path.pop();
|
|
548
|
-
stack.pop();
|
|
549
|
-
}
|
|
541
|
+
if (recursionStack.has(dependenceId)) {
|
|
542
|
+
// Cycle detected
|
|
543
|
+
path.push(dependenceId);
|
|
544
|
+
return true;
|
|
550
545
|
}
|
|
551
546
|
|
|
552
|
-
|
|
547
|
+
if (!visited.has(dependenceId)) {
|
|
548
|
+
visited.add(dependenceId);
|
|
549
|
+
recursionStack.add(dependenceId);
|
|
550
|
+
path.push(dependenceId);
|
|
551
|
+
|
|
552
|
+
stack.push({
|
|
553
|
+
taskId: dependenceId,
|
|
554
|
+
index: 0,
|
|
555
|
+
/* v8 ignore next */
|
|
556
|
+
dependencies: adjacencyList.get(dependenceId) ?? [],
|
|
557
|
+
});
|
|
558
|
+
}
|
|
559
|
+
} else {
|
|
560
|
+
// Finished all dependencies for this node
|
|
561
|
+
recursionStack.delete(taskId);
|
|
562
|
+
path.pop();
|
|
563
|
+
stack.pop();
|
|
564
|
+
}
|
|
553
565
|
}
|
|
566
|
+
|
|
567
|
+
return false;
|
|
568
|
+
}
|
|
554
569
|
}
|
|
555
570
|
</pre></td></tr></table></pre>
|
|
556
571
|
|
|
@@ -559,7 +574,7 @@ export class TaskGraphValidator implements ITaskGraphValidator {
|
|
|
559
574
|
<div class='footer quiet pad2 space-top1 center small'>
|
|
560
575
|
Code coverage generated by
|
|
561
576
|
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
|
|
562
|
-
at 2026-01-
|
|
577
|
+
at 2026-01-18T21:02:31.377Z
|
|
563
578
|
</div>
|
|
564
579
|
<script src="../prettify.js"></script>
|
|
565
580
|
<script>
|