@calmo/task-runner 1.2.2 → 1.2.3

package/src/WorkflowExecutor.ts

@@ -28,78 +28,97 @@ export class WorkflowExecutor<TContext> {
 
     const results = new Map<string, TaskResult>();
     const executingPromises = new Set<Promise<void>>();
+    const pendingSteps = new Set(steps);
 
-    // Helper to process pending steps and launch ready ones
-    const processPendingSteps = () => {
-      const pendingSteps = steps.filter(
-        (step) => !results.has(step.name) && !this.running.has(step.name)
-      );
+    // Initial pass
+    this.processQueue(pendingSteps, results, executingPromises);
 
-      // 1. Identify and mark skipped tasks
-      for (const step of pendingSteps) {
-        const deps = step.dependencies ?? [];
-        const failedDep = deps.find(
-          (dep) => results.has(dep) && results.get(dep)?.status !== "success"
-        );
-        if (failedDep) {
-          const result: TaskResult = {
-            status: "skipped",
-            message: `Skipped due to failed dependency: ${failedDep}`,
-          };
-          results.set(step.name, result);
-          this.eventBus.emit("taskSkipped", { step, result });
-        }
-      }
+    while (results.size < steps.length && executingPromises.size > 0) {
+      // Wait for the next task to finish
+      await Promise.race(executingPromises);
+      // After a task finishes, check for new work
+      this.processQueue(pendingSteps, results, executingPromises);
+    }
 
-      // Re-filter pending steps as some might have been skipped above
-      const readySteps = steps.filter((step) => {
-        if (results.has(step.name) || this.running.has(step.name)) return false;
-        const deps = step.dependencies ?? [];
-        return deps.every(
-          (dep) => results.has(dep) && results.get(dep)?.status === "success"
-        );
-      });
+    this.eventBus.emit("workflowEnd", { context: this.context, results });
+    return results;
+  }
 
-      // 2. Launch ready tasks
-      for (const step of readySteps) {
-        this.running.add(step.name);
-        this.eventBus.emit("taskStart", { step });
+  /**
+   * Logic to identify tasks that can be started or must be skipped.
+   * Iterate only over pending steps to avoid O(N^2) checks on completed tasks.
+   */
+  private processQueue(
+    pendingSteps: Set<TaskStep<TContext>>,
+    results: Map<string, TaskResult>,
+    executingPromises: Set<Promise<void>>
+  ): void {
+    const toRemove: TaskStep<TContext>[] = [];
+    const toRun: TaskStep<TContext>[] = [];
 
-        const taskPromise = (async () => {
-          try {
-            const result = await step.run(this.context);
-            results.set(step.name, result);
-          } catch (e) {
-            results.set(step.name, {
-              status: "failure",
-              error: e instanceof Error ? e.message : String(e),
-            });
-          } finally {
-            this.running.delete(step.name);
-            const result = results.get(step.name)!;
-            this.eventBus.emit("taskEnd", { step, result });
-          }
-        })();
+    for (const step of pendingSteps) {
+      const deps = step.dependencies ?? [];
+      let blocked = false;
+      let failedDep: string | undefined;
 
-        // Wrap the task promise to ensure we can track it in the Set
-        const trackedPromise = taskPromise.then(() => {
-          executingPromises.delete(trackedPromise);
-        });
-        executingPromises.add(trackedPromise);
+      for (const dep of deps) {
+        const depResult = results.get(dep);
+        if (!depResult) {
+          // Dependency not finished yet
+          blocked = true;
+        } else if (depResult.status !== "success") {
+          failedDep = dep;
+          break;
+        }
       }
-    };
 
-    // Initial check to start independent tasks
-    processPendingSteps();
+      if (failedDep) {
+        const result: TaskResult = {
+          status: "skipped",
+          message: `Skipped due to failed dependency: ${failedDep}`,
+        };
+        results.set(step.name, result);
+        this.eventBus.emit("taskSkipped", { step, result });
+        toRemove.push(step);
+      } else if (!blocked) {
+        toRun.push(step);
+        toRemove.push(step);
+      }
+    }
 
-    while (results.size < steps.length && executingPromises.size > 0) {
-      // Wait for the next task to finish
-      await Promise.race(executingPromises);
-      // After a task finishes, check for new work
-      processPendingSteps();
+    // Cleanup pending set
+    for (const step of toRemove) {
+      pendingSteps.delete(step);
     }
 
-    this.eventBus.emit("workflowEnd", { context: this.context, results });
-    return results;
+    // Execute ready tasks
+    for (const step of toRun) {
+      const taskPromise = this.runStep(step, results).then(() => {
+        executingPromises.delete(taskPromise);
+      });
+      executingPromises.add(taskPromise);
+    }
+  }
+
+  /**
+   * Handles the lifecycle of a single task execution.
+   */
+  private async runStep(step: TaskStep<TContext>, results: Map<string, TaskResult>): Promise<void> {
+    this.running.add(step.name);
+    this.eventBus.emit("taskStart", { step });
+
+    try {
+      const result = await step.run(this.context);
+      results.set(step.name, result);
+    } catch (e) {
+      results.set(step.name, {
+        status: "failure",
+        error: e instanceof Error ? e.message : String(e),
+      });
+    } finally {
+      this.running.delete(step.name);
+      const result = results.get(step.name)!;
+      this.eventBus.emit("taskEnd", { step, result });
+    }
   }
 }

package/src/contracts/ITaskGraphValidator.ts

@@ -11,4 +11,11 @@ export interface ITaskGraphValidator {
      * @returns A ValidationResult object indicating the outcome of the validation.
      */
     validate(taskGraph: TaskGraph): ValidationResult;
+
+    /**
+     * Creates a human-readable error message from a validation result.
+     * @param result The validation result containing errors.
+     * @returns A formatted error string.
+     */
+    createErrorMessage(result: ValidationResult): string;
 }

package/test-report.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8" ?>
-<testsuites name="vitest tests" tests="32" failures="0" errors="0" time="0.171985314">
-    <testsuite name="tests/ComplexScenario.test.ts" timestamp="2026-01-18T05:44:30.743Z" hostname="runnervmmtnos" tests="2" failures="0" errors="0" skipped="0" time="0.008824338">
-        <testcase classname="tests/ComplexScenario.test.ts" name="Complex Scenario Integration Tests &gt; 1. All steps execute when all succeed and context is hydrated" time="0.005524092">
+<testsuites name="vitest tests" tests="35" failures="0" errors="0" time="0.22304865">
+    <testsuite name="tests/ComplexScenario.test.ts" timestamp="2026-01-18T14:25:37.497Z" hostname="runnervmmtnos" tests="2" failures="0" errors="0" skipped="0" time="0.010231018">
+        <testcase classname="tests/ComplexScenario.test.ts" name="Complex Scenario Integration Tests &gt; 1. All steps execute when all succeed and context is hydrated" time="0.006235483">
             <system-out>
 Running StepA
 Running StepB
@@ -15,77 +15,85 @@ Running StepG
 
             </system-out>
         </testcase>
-        <testcase classname="tests/ComplexScenario.test.ts" name="Complex Scenario Integration Tests &gt; 2. The &apos;skip&apos; propagation works as intended if something breaks up in the tree" time="0.001386436">
+        <testcase classname="tests/ComplexScenario.test.ts" name="Complex Scenario Integration Tests &gt; 2. The &apos;skip&apos; propagation works as intended if something breaks up in the tree" time="0.00138321">
         </testcase>
     </testsuite>
-    <testsuite name="tests/EventBus.test.ts" timestamp="2026-01-18T05:44:30.744Z" hostname="runnervmmtnos" tests="1" failures="0" errors="0" skipped="0" time="0.019386386">
-        <testcase classname="tests/EventBus.test.ts" name="EventBus &gt; should handle async listeners throwing errors without crashing" time="0.017035792">
+    <testsuite name="tests/EventBus.test.ts" timestamp="2026-01-18T14:25:37.498Z" hostname="runnervmmtnos" tests="1" failures="0" errors="0" skipped="0" time="0.018978727">
+        <testcase classname="tests/EventBus.test.ts" name="EventBus &gt; should handle async listeners throwing errors without crashing" time="0.016583628">
         </testcase>
     </testsuite>
-    <testsuite name="tests/TaskGraphValidator.test.ts" timestamp="2026-01-18T05:44:30.745Z" hostname="runnervmmtnos" tests="9" failures="0" errors="0" skipped="0" time="0.010354972">
-        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should be instantiated" time="0.001917275">
+    <testsuite name="tests/TaskGraphValidator.test.ts" timestamp="2026-01-18T14:25:37.499Z" hostname="runnervmmtnos" tests="9" failures="0" errors="0" skipped="0" time="0.007340745">
+        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should be instantiated" time="0.001387989">
         </testcase>
-        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should return valid result for empty graph" time="0.00165162">
+        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should return valid result for empty graph" time="0.001089122">
         </testcase>
-        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should detect duplicate tasks" time="0.001990723">
+        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should detect duplicate tasks" time="0.001244392">
         </testcase>
-        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should detect missing dependencies" time="0.00050915">
+        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should detect missing dependencies" time="0.000319586">
         </testcase>
-        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should detect cycles" time="0.000507055">
+        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should detect cycles" time="0.000454157">
         </testcase>
-        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should return valid for a correct graph" time="0.00041269">
+        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should return valid for a correct graph" time="0.000401499">
         </testcase>
-        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should not detect cycles if missing dependencies are present" time="0.00036427">
+        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should not detect cycles if missing dependencies are present" time="0.000238875">
         </testcase>
-        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should detect more complex cycles" time="0.000319536">
+        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should detect more complex cycles" time="0.000207848">
         </testcase>
-        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should handle cycle detection with no cycles but shared dependencies" time="0.000239367">
+        <testcase classname="tests/TaskGraphValidator.test.ts" name="TaskGraphValidator &gt; should handle cycle detection with no cycles but shared dependencies" time="0.000228516">
         </testcase>
     </testsuite>
-    <testsuite name="tests/TaskRunner.test.ts" timestamp="2026-01-18T05:44:30.747Z" hostname="runnervmmtnos" tests="10" failures="0" errors="0" skipped="0" time="0.112430041">
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should run tasks in the correct sequential order" time="0.004173253">
+    <testsuite name="tests/TaskRunner.test.ts" timestamp="2026-01-18T14:25:37.501Z" hostname="runnervmmtnos" tests="10" failures="0" errors="0" skipped="0" time="0.111638951">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should run tasks in the correct sequential order" time="0.002716698">
         </testcase>
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should handle an empty list of tasks gracefully" time="0.00045054">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should handle an empty list of tasks gracefully" time="0.000317112">
         </testcase>
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should run independent tasks in parallel" time="0.099953731">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should run independent tasks in parallel" time="0.10065072">
         </testcase>
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should skip dependent tasks if a root task fails" time="0.000542632">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should skip dependent tasks if a root task fails" time="0.000465769">
         </testcase>
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should throw an error for &apos;circular dependency&apos;" time="0.002602664">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should throw an error for &apos;circular dependency&apos;" time="0.002694306">
         </testcase>
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should throw an error for &apos;missing dependency&apos;" time="0.000402671">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should throw an error for &apos;missing dependency&apos;" time="0.00041795">
         </testcase>
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should handle tasks that throw an error during execution" time="0.000365011">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should handle tasks that throw an error during execution" time="0.000376783">
         </testcase>
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should skip tasks whose dependencies are skipped" time="0.000483552">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should skip tasks whose dependencies are skipped" time="0.000786016">
         </testcase>
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should handle tasks that throw a non-Error object during execution" time="0.000424773">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should handle tasks that throw a non-Error object during execution" time="0.000431165">
         </testcase>
-        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should handle duplicate steps where one gets skipped due to failed dependency" time="0.000467091">
+        <testcase classname="tests/TaskRunner.test.ts" name="TaskRunner &gt; should handle duplicate steps where one gets skipped due to failed dependency" time="0.000468434">
         </testcase>
     </testsuite>
-    <testsuite name="tests/TaskRunnerEvents.test.ts" timestamp="2026-01-18T05:44:30.748Z" hostname="runnervmmtnos" tests="7" failures="0" errors="0" skipped="0" time="0.015344879">
-        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should fire all lifecycle events in a successful run" time="0.005483039">
+    <testsuite name="tests/TaskRunnerEvents.test.ts" timestamp="2026-01-18T14:25:37.503Z" hostname="runnervmmtnos" tests="7" failures="0" errors="0" skipped="0" time="0.012381248">
+        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should fire all lifecycle events in a successful run" time="0.00382187">
         </testcase>
-        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should fire taskSkipped event when dependency fails" time="0.004914606">
+        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should fire taskSkipped event when dependency fails" time="0.003792205">
         </testcase>
-        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should not crash if a listener throws an error" time="0.001456386">
+        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should not crash if a listener throws an error" time="0.001438714">
         </testcase>
-        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should fire workflow events even for empty step list" time="0.000272478">
+        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should fire workflow events even for empty step list" time="0.000282257">
         </testcase>
-        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should handle unsubscribe correctly" time="0.000554882">
+        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should handle unsubscribe correctly" time="0.000443788">
         </testcase>
-        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should safely handle off() when no listeners exist" time="0.000162473">
+        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should safely handle off() when no listeners exist" time="0.000271827">
         </testcase>
-        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should support multiple listeners for the same event" time="0.000345023">
+        <testcase classname="tests/TaskRunnerEvents.test.ts" name="TaskRunner Events &gt; should support multiple listeners for the same event" time="0.000377915">
         </testcase>
     </testsuite>
-    <testsuite name="tests/integration.test.ts" timestamp="2026-01-18T05:44:30.750Z" hostname="runnervmmtnos" tests="3" failures="0" errors="0" skipped="0" time="0.005644698">
-        <testcase classname="tests/integration.test.ts" name="TaskRunner Validation Integration &gt; should throw validation error with clear message for duplicate tasks" time="0.003288223">
+    <testsuite name="tests/WorkflowExecutor.test.ts" timestamp="2026-01-18T14:25:37.504Z" hostname="runnervmmtnos" tests="3" failures="0" errors="0" skipped="0" time="0.057149901">
+        <testcase classname="tests/WorkflowExecutor.test.ts" name="WorkflowExecutor &gt; should execute steps sequentially when dependencies exist" time="0.003667222">
         </testcase>
-        <testcase classname="tests/integration.test.ts" name="TaskRunner Validation Integration &gt; should throw validation error with clear message for missing dependencies" time="0.000378435">
+        <testcase classname="tests/WorkflowExecutor.test.ts" name="WorkflowExecutor &gt; should skip dependent steps if dependency fails" time="0.000479825">
         </testcase>
-        <testcase classname="tests/integration.test.ts" name="TaskRunner Validation Integration &gt; should throw validation error with clear message for cycles" time="0.000325437">
+        <testcase classname="tests/WorkflowExecutor.test.ts" name="WorkflowExecutor &gt; should run independent steps in parallel" time="0.05083559">
+        </testcase>
+    </testsuite>
+    <testsuite name="tests/integration.test.ts" timestamp="2026-01-18T14:25:37.505Z" hostname="runnervmmtnos" tests="3" failures="0" errors="0" skipped="0" time="0.00532806">
+        <testcase classname="tests/integration.test.ts" name="TaskRunner Validation Integration &gt; should throw validation error with clear message for duplicate tasks" time="0.003098401">
+        </testcase>
+        <testcase classname="tests/integration.test.ts" name="TaskRunner Validation Integration &gt; should throw validation error with clear message for missing dependencies" time="0.000340456">
+        </testcase>
+        <testcase classname="tests/integration.test.ts" name="TaskRunner Validation Integration &gt; should throw validation error with clear message for cycles" time="0.000287436">
         </testcase>
     </testsuite>
 </testsuites>