@callumvass/forgeflow-dev 0.4.3 → 0.5.0

package/agents/implementor.md

@@ -103,6 +103,10 @@ PRBODY
 gh pr create --title "My title" --body-file /tmp/pr-body.md
 ```
 
+## Commit Style
+
+Use [Conventional Commits](https://www.conventionalcommits.org/). Read `git log --oneline -10` before your first commit to match the repo's existing style. Common prefixes: `feat:`, `fix:`, `test:`, `refactor:`, `chore:`, `docs:`. Keep messages concise (under 72 chars).
+
 ## Before Committing
 
 - **Reachability check**: Every new module, class, or function you created must be imported and called from production code — not just from tests. Trace from the entry point to your new code.

package/agents/refactorer.md

@@ -37,3 +37,4 @@ You are a refactorer agent. You run after a feature has been implemented to find
 - **Keep it small**: Each refactoring should be a single, focused change.
 - **If nothing to do, say so**: "No refactoring needed" is a perfectly valid outcome.
 - **Preserve public interfaces**: Don't rename or restructure exports without updating all callers.
+- **Commit style**: Use [Conventional Commits](https://www.conventionalcommits.org/). Read `git log --oneline -10` before committing to match the repo's style. Use `refactor:` prefix.

package/extensions/index.js

@@ -419,22 +419,6 @@ function slugify(text, maxLen = 40) {
 }
 var JIRA_KEY_RE = /^[A-Z]+-\d+$/;
 var JIRA_BRANCH_RE = /feat\/([A-Z]+-\d+)/;
-async function ensureBranch(cwd, branch) {
-  const currentBranch = await exec("git branch --show-current", cwd);
-  if (currentBranch === branch) return;
-  const localExists = await exec(`git rev-parse --verify ${branch} 2>/dev/null && echo yes || echo no`, cwd);
-  if (localExists === "yes") {
-    await exec(`git checkout ${branch}`, cwd);
-    return;
-  }
-  await exec("git fetch origin", cwd);
-  const remoteExists = await exec(`git rev-parse --verify origin/${branch} 2>/dev/null && echo yes || echo no`, cwd);
-  if (remoteExists === "yes") {
-    await exec(`git checkout -b ${branch} origin/${branch}`, cwd);
-  } else {
-    await exec(`git checkout -b ${branch}`, cwd);
-  }
-}
 async function resolveIssue(cwd, issueArg) {
   if (issueArg && JIRA_KEY_RE.test(issueArg)) {
     return resolveJiraIssue(cwd, issueArg);
@@ -755,47 +739,33 @@ ${flags.customPrompt}` : "";
     };
   }
   if (resolved.branch) {
-    const localExists = await exec(`git rev-parse --verify ${resolved.branch} 2>/dev/null && echo yes || echo no`, cwd);
-    if (localExists === "yes") {
-      const ahead = await exec(`git rev-list main..${resolved.branch} --count`, cwd);
-      if (parseInt(ahead, 10) > 0) {
-        await ensureBranch(cwd, resolved.branch);
-        await exec(`git push -u origin ${resolved.branch}`, cwd);
-        const prBody = buildPrBody(cwd, resolved);
-        await createPr(cwd, resolved.title, prBody, resolved.branch);
-        const stages2 = [];
-        await refactorAndReview(cwd, signal, onUpdate, ctx, stages2, flags.skipReview);
-        return {
-          content: [{ type: "text", text: `Resumed ${issueLabel} \u2014 pushed existing commits and created PR.` }],
-          details: { pipeline: "implement", stages: stages2 }
-        };
-      }
-      await exec(`git branch -D ${resolved.branch}`, cwd);
+    const branch = resolved.branch;
+    const branchSetup = await exec(
+      `ahead=$(git rev-list main..${branch} --count 2>/dev/null || echo 0); if [ "$ahead" -gt 0 ] 2>/dev/null; then git checkout ${branch} && echo "RESUME:$ahead"; else git branch -D ${branch} 2>/dev/null; git branch -dr origin/${branch} 2>/dev/null; git checkout -b ${branch} && echo "FRESH"; fi`,
+      cwd
+    );
+    if (branchSetup.startsWith("RESUME:")) {
+      await exec(`git push -u origin ${branch}`, cwd);
+      const prBody = buildPrBody(cwd, resolved);
+      await createPr(cwd, resolved.title, prBody, branch);
+      const stages2 = [];
+      await refactorAndReview(cwd, signal, onUpdate, ctx, stages2, flags.skipReview);
+      return {
+        content: [{ type: "text", text: `Resumed ${issueLabel} \u2014 pushed existing commits and created PR.` }],
+        details: { pipeline: "implement", stages: stages2 }
+      };
     }
-    const currentBranch = await exec("git branch --show-current", cwd);
-    if (currentBranch === "main" || currentBranch === "master") {
-      const dirty = await exec("git status --porcelain", cwd);
-      if (dirty) {
-        return {
-          content: [
-            {
-              type: "text",
-              text: `Cannot switch to ${resolved.branch} \u2014 working tree is dirty. Please commit or stash your changes first.`
-            }
-          ],
-          details: { pipeline: "implement", stages: [] },
-          isError: true
-        };
-      }
+    let afterBranch = await exec("git branch --show-current", cwd);
+    if (afterBranch !== branch) {
+      await exec(`git checkout ${branch} 2>/dev/null || git checkout -b ${branch}`, cwd);
+      afterBranch = await exec("git branch --show-current", cwd);
     }
-    await ensureBranch(cwd, resolved.branch);
-    const afterBranch = await exec("git branch --show-current", cwd);
-    if (afterBranch !== resolved.branch) {
+    if (afterBranch !== branch) {
       return {
         content: [
           {
             type: "text",
-            text: `Failed to switch to ${resolved.branch} (still on ${afterBranch}). Check git state and retry.`
+            text: `Failed to switch to ${branch} (on ${afterBranch}). Setup output: ${branchSetup || "(empty)"}`
           }
         ],
         details: { pipeline: "implement", stages: [] },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@callumvass/forgeflow-dev",
-  "version": "0.4.3",
+  "version": "0.5.0",
   "type": "module",
   "description": "Dev pipeline for Pi — TDD implementation, code review, architecture, and skill discovery.",
   "keywords": [