@callumvass/forgeflow-dev 0.3.2 → 0.4.0

package/README.md

@@ -35,3 +35,7 @@ npx pi install @callumvass/forgeflow-dev
 - **opensrc** — Fetch library source code for reference
 - **stitch** — UI design reference integration
 - **plugins** — Domain-specific review plugin router
+
+## Usage examples
+
+See the [root README](../../README.md#commands) for detailed usage examples of each command.

package/agents/implementor.md

@@ -89,6 +89,20 @@ Scan `<cwd>/.forgeflow/plugins/*/PLUGIN.md` for plugins matching the `implement`
 
 For each matched plugin, read the plugin body and follow its guidance — framework-specific idioms, API patterns, common pitfalls, and conventions for the project's tech stack.
 
+## Creating PRs
+
+When creating a PR with `gh pr create`, ALWAYS write the body to a temp file and use `--body-file` instead of `--body`. The `--body` flag breaks markdown formatting due to shell escaping. Example:
+
+```bash
+cat > /tmp/pr-body.md << 'PRBODY'
+## Summary
+- description here
+
+Closes #123
+PRBODY
+gh pr create --title "My title" --body-file /tmp/pr-body.md
+```
+
 ## Before Committing
 
 - **Reachability check**: Every new module, class, or function you created must be imported and called from production code — not just from tests. Trace from the entry point to your new code.

package/extensions/index.js

@@ -377,6 +377,7 @@ function exec(cmd, cwd) {
 
 // src/utils/git.ts
 import * as fs3 from "fs";
+import * as os2 from "os";
 import * as path4 from "path";
 var PR_TEMPLATE_PATHS = [
   ".github/pull_request_template.md",
@@ -401,6 +402,18 @@ ${template}`;
   }
   return defaultBody;
 }
+async function createPr(cwd, title, body, branch) {
+  const tmp = path4.join(os2.tmpdir(), `forgeflow-pr-${Date.now()}.md`);
+  try {
+    fs3.writeFileSync(tmp, body, "utf-8");
+    await exec(`gh pr create --title "${title}" --body-file "${tmp}" --head ${branch}`, cwd);
+  } finally {
+    try {
+      fs3.unlinkSync(tmp);
+    } catch {
+    }
+  }
+}
 function slugify(text, maxLen = 40) {
   return text.toLowerCase().replace(/[^a-z0-9]+/g, "-").replace(/^-|-$/g, "").slice(0, maxLen).replace(/-$/, "");
 }
@@ -746,7 +759,7 @@ ${flags.customPrompt}` : "";
       if (parseInt(ahead, 10) > 0) {
         await exec(`git push -u origin ${resolved.branch}`, cwd);
         const prBody = buildPrBody(cwd, resolved);
-        await exec(`gh pr create --title "${resolved.title}" --body "${prBody}" --head ${resolved.branch}`, cwd);
+        await createPr(cwd, resolved.title, prBody, resolved.branch);
         const stages2 = [];
         await refactorAndReview(cwd, signal, onUpdate, ctx, stages2, flags.skipReview);
         return {
@@ -836,7 +849,7 @@ ${plan}` : "";
   const prNote = resolved.existingPR ? `
 - PR #${resolved.existingPR} already exists for this branch.` : "";
   const closeNote = isGitHub ? `
-- The PR body MUST include 'Closes #${resolved.number}' so the issue auto-closes on merge.` : `
+- The PR body MUST end with a blank line then 'Closes #${resolved.number}' on its own line (not inline with other text), so the issue auto-closes on merge.` : `
 - The PR body should reference Jira issue ${resolved.key}.`;
   const unresolvedNote = flags.autonomous ? `
 - If the plan has unresolved questions, resolve them yourself using sensible defaults. Do NOT stop and wait.` : "";
@@ -873,7 +886,7 @@ ${reason}` }],
     prNumber = await exec(`gh pr list --head "${resolved.branch}" --json number --jq '.[0].number'`, cwd);
     if (!prNumber || prNumber === "null") {
       const prBody = buildPrBody(cwd, resolved);
-      await exec(`gh pr create --title "${resolved.title}" --body "${prBody}" --head ${resolved.branch}`, cwd);
+      await createPr(cwd, resolved.title, prBody, resolved.branch);
       prNumber = await exec(`gh pr list --head "${resolved.branch}" --json number --jq '.[0].number'`, cwd);
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@callumvass/forgeflow-dev",
-  "version": "0.3.2",
+  "version": "0.4.0",
   "type": "module",
   "description": "Dev pipeline for Pi — TDD implementation, code review, architecture, and skill discovery.",
   "keywords": [