@callumvass/forgeflow-dev 0.1.0 → 0.3.1

package/extensions/index.js

@@ -5,6 +5,9 @@ var __require = /* @__PURE__ */ ((x) => typeof require !== "undefined" ? require
   throw Error('Dynamic require of "' + x + '" is not supported');
 });
 
+// ../shared/dist/confluence.js
+import { spawn } from "child_process";
+
 // ../shared/dist/constants.js
 var TOOLS_ALL = ["read", "write", "edit", "bash", "grep", "find"];
 var TOOLS_READONLY = ["read", "bash", "grep", "find"];
@@ -16,7 +19,7 @@ var SIGNALS = {
 };
 
 // ../shared/dist/run-agent.js
-import { spawn } from "child_process";
+import { spawn as spawn2 } from "child_process";
 import * as fs from "fs";
 import * as os from "os";
 import * as path from "path";
@@ -108,7 +111,7 @@ async function runAgent(agentName, task, options) {
     args.push(`Task: ${task}`);
     const exitCode = await new Promise((resolve2) => {
       const invocation = getPiInvocation(args);
-      const proc = spawn(invocation.command, invocation.args, {
+      const proc = spawn2(invocation.command, invocation.args, {
         cwd: options.cwd,
         shell: false,
         stdio: ["ignore", "pipe", "pipe"]
@@ -359,10 +362,10 @@ async function runDiscoverSkills(cwd, query, signal, onUpdate, _ctx) {
 }
 
 // src/utils/exec.ts
-import { spawn as spawn2 } from "child_process";
+import { spawn as spawn3 } from "child_process";
 function exec(cmd, cwd) {
   return new Promise((resolve2) => {
-    const proc = spawn2("bash", ["-c", cmd], { cwd, stdio: ["ignore", "pipe", "pipe"] });
+    const proc = spawn3("bash", ["-c", cmd], { cwd, stdio: ["ignore", "pipe", "pipe"] });
     let out = "";
     proc.stdout.on("data", (d) => {
       out += d.toString();
@@ -373,6 +376,31 @@ function exec(cmd, cwd) {
 }
 
 // src/utils/git.ts
+import * as fs3 from "fs";
+import * as path4 from "path";
+var PR_TEMPLATE_PATHS = [
+  ".github/pull_request_template.md",
+  ".github/PULL_REQUEST_TEMPLATE.md",
+  "pull_request_template.md",
+  "PULL_REQUEST_TEMPLATE.md",
+  ".github/PULL_REQUEST_TEMPLATE/pull_request_template.md"
+];
+function buildPrBody(cwd, issue) {
+  const isGitHub = issue.source === "github" && issue.number > 0;
+  const defaultBody = isGitHub ? `Closes #${issue.number}` : `Jira: ${issue.key}`;
+  for (const rel of PR_TEMPLATE_PATHS) {
+    const abs = path4.join(cwd, rel);
+    try {
+      const template = fs3.readFileSync(abs, "utf-8");
+      const closeRef = isGitHub ? `Closes #${issue.number}` : `Jira: ${issue.key}`;
+      return `${closeRef}
+
+${template}`;
+    } catch {
+    }
+  }
+  return defaultBody;
+}
 function slugify(text, maxLen = 40) {
   return text.toLowerCase().replace(/[^a-z0-9]+/g, "-").replace(/^-|-$/g, "").slice(0, maxLen).replace(/-$/, "");
 }
@@ -599,6 +627,12 @@ async function runReview(cwd, target, signal, onUpdate, ctx, customPrompt) {
     const pr = await exec("gh pr view --json number --jq .number 2>/dev/null", cwd);
     if (pr && pr !== "") prNumber = pr;
   }
+  if (ctx.hasUI && !customPrompt) {
+    const extra = await ctx.ui.input("Additional instructions?", "Skip");
+    if (extra != null && extra.trim() !== "") {
+      customPrompt = extra.trim();
+    }
+  }
   const result = await runReviewInline(cwd, signal, onUpdate, ctx, stages, diffCmd, "review", {
     prNumber,
     interactive: ctx.hasUI,
@@ -643,16 +677,17 @@ async function resolveQuestions(plan, ctx) {
   const sectionMatch = plan.match(/### Unresolved Questions\n([\s\S]*?)(?=\n###|$)/);
   if (!sectionMatch) return plan;
   const section = sectionMatch[1] ?? "";
-  const questions = [];
-  for (const m of section.matchAll(/^- (.+)$/gm)) {
-    if (m[1]) questions.push(m[1]);
+  const itemRe = /^(?:[-*]|\d+[.)]+|[a-z][.)]+)\s+(.+(?:\n(?!(?:[-*]|\d+[.)]+|[a-z][.)]+)\s).*)*)/gm;
+  const items = [];
+  for (const m of section.matchAll(itemRe)) {
+    if (m[0] && m[1]) items.push({ full: m[0], text: m[1] });
   }
-  if (questions.length === 0) return plan;
+  if (items.length === 0) return plan;
   let updatedSection = section;
-  for (const q of questions) {
-    const answer = await ctx.ui.input(`${q}`, "Skip to use defaults");
+  for (const item of items) {
+    const answer = await ctx.ui.input(`${item.text}`, "Skip to use defaults");
     if (answer != null && answer.trim() !== "") {
-      updatedSection = updatedSection.replace(`- ${q}`, `- ${q}
+      updatedSection = updatedSection.replace(item.full, `${item.full}
   **Answer:** ${answer.trim()}`);
     }
   }
@@ -680,6 +715,12 @@ async function runImplement(cwd, issueArg, signal, onUpdate, ctx, flags = {
 ${resolved.body}` : `Jira ${resolved.key}: ${resolved.title}
 
 ${resolved.body}`;
+  if (interactive && !flags.customPrompt) {
+    const extra = await ctx.ui.input("Additional instructions?", "Skip");
+    if (extra != null && extra.trim() !== "") {
+      flags.customPrompt = extra.trim();
+    }
+  }
   const customPromptSection = flags.customPrompt ? `
 
 ADDITIONAL INSTRUCTIONS FROM USER:
@@ -704,7 +745,7 @@ ${flags.customPrompt}` : "";
       const ahead = await exec(`git rev-list main..${resolved.branch} --count`, cwd);
       if (parseInt(ahead, 10) > 0) {
         await exec(`git push -u origin ${resolved.branch}`, cwd);
-        const prBody = isGitHub ? `Closes #${resolved.number}` : `Jira: ${resolved.key}`;
+        const prBody = buildPrBody(cwd, resolved);
         await exec(`gh pr create --title "${resolved.title}" --body "${prBody}" --head ${resolved.branch}`, cwd);
         const stages2 = [];
         await refactorAndReview(cwd, signal, onUpdate, ctx, stages2, flags.skipReview);
@@ -831,7 +872,7 @@ ${reason}` }],
     await exec(`git push -u origin ${resolved.branch}`, cwd);
     prNumber = await exec(`gh pr list --head "${resolved.branch}" --json number --jq '.[0].number'`, cwd);
     if (!prNumber || prNumber === "null") {
-      const prBody = isGitHub ? `Closes #${resolved.number}` : `Jira: ${resolved.key}`;
+      const prBody = buildPrBody(cwd, resolved);
       await exec(`gh pr create --title "${resolved.title}" --body "${prBody}" --head ${resolved.branch}`, cwd);
       prNumber = await exec(`gh pr list --head "${resolved.branch}" --json number --jq '.[0].number'`, cwd);
     }

package/package.json

@@ -1,20 +1,26 @@
 {
   "name": "@callumvass/forgeflow-dev",
-  "version": "0.1.0",
+  "version": "0.3.1",
   "type": "module",
   "description": "Dev pipeline for Pi — TDD implementation, code review, architecture, and skill discovery.",
   "keywords": [
     "pi-package"
   ],
   "license": "MIT",
+  "homepage": "https://github.com/CallumVass/forgeflow#readme",
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/callumvass/forgeflow.git",
+    "url": "git+https://github.com/CallumVass/forgeflow.git",
     "directory": "packages/dev"
   },
   "publishConfig": {
     "provenance": true
   },
+  "files": [
+    "extensions",
+    "agents",
+    "skills"
+  ],
   "pi": {
     "extensions": [
       "./extensions"

package/src/index.ts

@@ -1,380 +0,0 @@
-import { type AnyCtx, getFinalOutput, type PipelineDetails, type StageResult } from "@callumvass/forgeflow-shared";
-import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
-import { Container, Markdown, Spacer, Text } from "@mariozechner/pi-tui";
-import { Type } from "@sinclair/typebox";
-import { runArchitecture } from "./pipelines/architecture.js";
-import { runDiscoverSkills } from "./pipelines/discover-skills.js";
-import { runImplement } from "./pipelines/implement.js";
-import { runImplementAll } from "./pipelines/implement-all.js";
-import { runReview } from "./pipelines/review.js";
-
-// ─── Display helpers ──────────────────────────────────────────────────
-
-type DisplayItem = { type: "text"; text: string } | { type: "toolCall"; name: string; args: Record<string, unknown> };
-
-interface ForgeflowDevInput {
-  pipeline: string;
-  issue?: string;
-  target?: string;
-  skipPlan?: boolean;
-  skipReview?: boolean;
-  customPrompt?: string;
-}
-
-function parseImplFlags(args: string) {
-  const skipPlan = args.includes("--skip-plan");
-  const skipReview = args.includes("--skip-review");
-  const rest = args
-    .replace(/--skip-plan/g, "")
-    .replace(/--skip-review/g, "")
-    .trim();
-
-  const firstSpace = rest.indexOf(" ");
-  const issue = firstSpace === -1 ? rest : rest.slice(0, firstSpace);
-  const customPrompt =
-    firstSpace === -1
-      ? ""
-      : rest
-          .slice(firstSpace + 1)
-          .trim()
-          .replace(/^"(.*)"$/, "$1");
-
-  const flags = [skipPlan ? ", skipPlan: true" : "", skipReview ? ", skipReview: true" : ""].join("");
-  return { issue, customPrompt, flags };
-}
-
-function parseReviewArgs(args: string) {
-  const trimmed = args.trim();
-  if (!trimmed) return { target: "", customPrompt: "" };
-
-  if (trimmed.startsWith("--branch")) {
-    const afterFlag = trimmed.replace(/^--branch\s*/, "").trim();
-    const firstSpace = afterFlag.indexOf(" ");
-    if (firstSpace === -1) return { target: `--branch ${afterFlag}`, customPrompt: "" };
-    return {
-      target: `--branch ${afterFlag.slice(0, firstSpace)}`,
-      customPrompt: afterFlag
-        .slice(firstSpace + 1)
-        .trim()
-        .replace(/^"(.*)"$/, "$1"),
-    };
-  }
-
-  const firstSpace = trimmed.indexOf(" ");
-  if (firstSpace === -1) return { target: trimmed, customPrompt: "" };
-  return {
-    target: trimmed.slice(0, firstSpace),
-    customPrompt: trimmed
-      .slice(firstSpace + 1)
-      .trim()
-      .replace(/^"(.*)"$/, "$1"),
-  };
-}
-
-function getDisplayItems(messages: AnyCtx[]): DisplayItem[] {
-  const items: DisplayItem[] = [];
-  for (const msg of messages) {
-    if (msg.role === "assistant") {
-      for (const part of msg.content) {
-        if (part.type === "text") items.push({ type: "text", text: part.text });
-        else if (part.type === "toolCall") items.push({ type: "toolCall", name: part.name, args: part.arguments });
-      }
-    }
-  }
-  return items;
-}
-
-function formatToolCallShort(
-  name: string,
-  args: Record<string, unknown>,
-  fg: (c: string, t: string) => string,
-): string {
-  switch (name) {
-    case "bash": {
-      const cmd = (args.command as string) || "...";
-      return fg("muted", "$ ") + fg("toolOutput", cmd.length > 60 ? `${cmd.slice(0, 60)}...` : cmd);
-    }
-    case "read":
-      return fg("muted", "read ") + fg("accent", (args.file_path || args.path || "...") as string);
-    case "write":
-      return fg("muted", "write ") + fg("accent", (args.file_path || args.path || "...") as string);
-    case "edit":
-      return fg("muted", "edit ") + fg("accent", (args.file_path || args.path || "...") as string);
-    case "grep":
-      return fg("muted", "grep ") + fg("accent", `/${args.pattern || ""}/`);
-    case "find":
-      return fg("muted", "find ") + fg("accent", (args.pattern || "*") as string);
-    default:
-      return fg("accent", name);
-  }
-}
-
-function formatUsage(usage: { input: number; output: number; cost: number; turns: number }, model?: string): string {
-  const parts: string[] = [];
-  if (usage.turns) parts.push(`${usage.turns}t`);
-  if (usage.input) parts.push(`↑${usage.input < 1000 ? usage.input : `${Math.round(usage.input / 1000)}k`}`);
-  if (usage.output) parts.push(`↓${usage.output < 1000 ? usage.output : `${Math.round(usage.output / 1000)}k`}`);
-  if (usage.cost) parts.push(`$${usage.cost.toFixed(4)}`);
-  if (model) parts.push(model);
-  return parts.join(" ");
-}
-
-// ─── Tool registration ────────────────────────────────────────────────
-
-const ForgeflowDevParams = Type.Object({
-  pipeline: Type.String({
-    description: 'Which pipeline to run: "implement", "implement-all", "review", "architecture", or "discover-skills"',
-  }),
-  issue: Type.Optional(
-    Type.String({
-      description: "Issue number or description for implement pipeline",
-    }),
-  ),
-  target: Type.Optional(Type.String({ description: "PR number or --branch for review pipeline" })),
-  skipPlan: Type.Optional(Type.Boolean({ description: "Skip planner, implement directly (default false)" })),
-  skipReview: Type.Optional(Type.Boolean({ description: "Skip code review after implementation (default false)" })),
-  customPrompt: Type.Optional(
-    Type.String({ description: "Additional user instructions passed to agents (e.g. 'check the openapi spec')" }),
-  ),
-});
-
-function registerForgeflowDevTool(pi: ExtensionAPI) {
-  pi.registerTool({
-    name: "forgeflow-dev",
-    label: "Forgeflow Dev",
-    description: [
-      "Run forgeflow dev pipelines: implement (plan→TDD→refactor a single issue),",
-      "implement-all (loop through all open issues autonomously), review (deterministic checks→code review→judge),",
-      "architecture (analyze codebase for structural friction→create RFC issues),",
-      "discover-skills (find and install domain-specific plugins).",
-      "Each pipeline spawns specialized sub-agents with isolated context.",
-    ].join(" "),
-    parameters: ForgeflowDevParams as AnyCtx,
-
-    async execute(
-      _toolCallId: string,
-      _params: unknown,
-      signal: AbortSignal | undefined,
-      onUpdate: AnyCtx,
-      ctx: AnyCtx,
-    ) {
-      const params = _params as ForgeflowDevInput;
-      const cwd = ctx.cwd as string;
-      const sig = signal ?? new AbortController().signal;
-
-      try {
-        switch (params.pipeline) {
-          case "implement":
-            return await runImplement(cwd, params.issue ?? "", sig, onUpdate, ctx, {
-              skipPlan: params.skipPlan ?? false,
-              skipReview: params.skipReview ?? false,
-              customPrompt: params.customPrompt,
-            });
-          case "implement-all":
-            return await runImplementAll(cwd, sig, onUpdate, ctx, {
-              skipPlan: params.skipPlan ?? false,
-              skipReview: params.skipReview ?? false,
-            });
-          case "review":
-            return await runReview(cwd, params.target ?? "", sig, onUpdate, ctx, params.customPrompt);
-          case "architecture":
-            return await runArchitecture(cwd, sig, onUpdate, ctx);
-          case "discover-skills":
-            return await runDiscoverSkills(cwd, params.issue ?? "", sig, onUpdate, ctx);
-          default:
-            return {
-              content: [
-                {
-                  type: "text",
-                  text: `Unknown pipeline: ${params.pipeline}. Use: implement, implement-all, review, architecture, discover-skills`,
-                },
-              ],
-              details: { pipeline: params.pipeline, stages: [] } as PipelineDetails,
-            };
-        }
-      } finally {
-        if (ctx.hasUI) {
-          ctx.ui.setStatus("forgeflow-dev", undefined);
-          ctx.ui.setWidget("forgeflow-dev", undefined);
-        }
-      }
-    },
-
-    renderCall(_args: unknown, theme: AnyCtx) {
-      const args = _args as ForgeflowDevInput;
-      const pipeline = args.pipeline || "?";
-      let text = theme.fg("toolTitle", theme.bold("forgeflow-dev ")) + theme.fg("accent", pipeline);
-      if (args.issue) {
-        const prefix = /^[A-Z]+-\d+$/.test(args.issue) ? " " : " #";
-        text += theme.fg("dim", `${prefix}${args.issue}`);
-      }
-      if (args.target) text += theme.fg("dim", ` ${args.target}`);
-      return new Text(text, 0, 0);
-    },
-
-    renderResult(result: AnyCtx, { expanded }: { expanded: boolean }, theme: AnyCtx) {
-      const details = result.details as PipelineDetails | undefined;
-      if (!details || details.stages.length === 0) {
-        const text = result.content[0];
-        return new Text(text?.type === "text" ? text.text : "(no output)", 0, 0);
-      }
-
-      if (expanded) {
-        return renderExpanded(details, theme);
-      }
-      return renderCollapsed(details, theme);
-    },
-  });
-}
-
-// ─── Rendering ────────────────────────────────────────────────────────
-
-function renderExpanded(details: PipelineDetails, theme: AnyCtx) {
-  const container = new Container();
-  container.addChild(
-    new Text(theme.fg("toolTitle", theme.bold("forgeflow-dev ")) + theme.fg("accent", details.pipeline), 0, 0),
-  );
-  container.addChild(new Spacer(1));
-
-  for (const stage of details.stages) {
-    const icon = stageIcon(stage, theme);
-    container.addChild(new Text(`${icon} ${theme.fg("toolTitle", theme.bold(stage.name))}`, 0, 0));
-
-    const items = getDisplayItems(stage.messages);
-    for (const item of items) {
-      if (item.type === "toolCall") {
-        container.addChild(
-          new Text(
-            `  ${theme.fg("muted", "→ ")}${formatToolCallShort(item.name, item.args, theme.fg.bind(theme))}`,
-            0,
-            0,
-          ),
-        );
-      }
-    }
-
-    const output = getFinalOutput(stage.messages);
-    if (output) {
-      container.addChild(new Spacer(1));
-      try {
-        const { getMarkdownTheme } = require("@mariozechner/pi-coding-agent");
-        container.addChild(new Markdown(output.trim(), 0, 0, getMarkdownTheme()));
-      } catch {
-        container.addChild(new Text(theme.fg("toolOutput", output.slice(0, 500)), 0, 0));
-      }
-    }
-
-    const usageStr = formatUsage(stage.usage, stage.model);
-    if (usageStr) container.addChild(new Text(theme.fg("dim", usageStr), 0, 0));
-    container.addChild(new Spacer(1));
-  }
-
-  return container;
-}
-
-function renderCollapsed(details: PipelineDetails, theme: AnyCtx) {
-  let text = theme.fg("toolTitle", theme.bold("forgeflow-dev ")) + theme.fg("accent", details.pipeline);
-  for (const stage of details.stages) {
-    const icon = stageIcon(stage, theme);
-    text += `\n  ${icon} ${theme.fg("toolTitle", stage.name)}`;
-
-    if (stage.status === "running") {
-      const items = getDisplayItems(stage.messages);
-      const last = items.filter((i) => i.type === "toolCall").slice(-3);
-      for (const item of last) {
-        if (item.type === "toolCall") {
-          text += `\n    ${theme.fg("muted", "→ ")}${formatToolCallShort(item.name, item.args, theme.fg.bind(theme))}`;
-        }
-      }
-    } else if (stage.status === "done" || stage.status === "failed") {
-      const preview = stage.output.split("\n")[0]?.slice(0, 80) || "(no output)";
-      text += theme.fg("dim", ` ${preview}`);
-      const usageStr = formatUsage(stage.usage, stage.model);
-      if (usageStr) text += ` ${theme.fg("dim", usageStr)}`;
-    }
-  }
-  return new Text(text, 0, 0);
-}
-
-function stageIcon(stage: StageResult, theme: AnyCtx): string {
-  return stage.status === "done"
-    ? theme.fg("success", "✓")
-    : stage.status === "running"
-      ? theme.fg("warning", "⟳")
-      : stage.status === "failed"
-        ? theme.fg("error", "✗")
-        : theme.fg("muted", "○");
-}
-
-// ─── Extension entry point ────────────────────────────────────────────
-
-const extension: (pi: ExtensionAPI) => void = (pi) => {
-  registerForgeflowDevTool(pi);
-
-  pi.registerCommand("implement", {
-    description:
-      "Implement a single issue using TDD. Usage: /implement <issue#|JIRA-KEY> [custom prompt] [--skip-plan] [--skip-review]",
-    handler: async (args) => {
-      const { issue, customPrompt, flags } = parseImplFlags(args);
-      const promptPart = customPrompt ? `, customPrompt: "${customPrompt}"` : "";
-
-      if (issue) {
-        pi.sendUserMessage(
-          `Call the forgeflow-dev tool now with these exact parameters: pipeline="implement", issue="${issue}"${promptPart}${flags}. Do not interpret the issue number — pass it as-is.`,
-        );
-      } else {
-        pi.sendUserMessage(
-          `Call the forgeflow-dev tool now with these exact parameters: pipeline="implement"${promptPart}${flags}. No issue number provided — the tool will detect it from the current branch. Do NOT ask for an issue number.`,
-        );
-      }
-    },
-  });
-
-  pi.registerCommand("implement-all", {
-    description:
-      "Loop through all open auto-generated issues: implement, review, merge. Flags: --skip-plan, --skip-review",
-    handler: async (args) => {
-      const { flags } = parseImplFlags(args);
-
-      pi.sendUserMessage(
-        `Call the forgeflow-dev tool now with these exact parameters: pipeline="implement-all"${flags}. Do NOT ask for confirmation — run autonomously.`,
-      );
-    },
-  });
-
-  pi.registerCommand("review", {
-    description: "Run code review: deterministic checks → reviewer → judge. Usage: /review [target] [custom prompt]",
-    handler: async (args) => {
-      const { target, customPrompt } = parseReviewArgs(args);
-      const promptPart = customPrompt ? `, customPrompt: "${customPrompt}"` : "";
-      pi.sendUserMessage(
-        `Call the forgeflow-dev tool now with these exact parameters: pipeline="review"${target ? `, target="${target}"` : ""}${promptPart}. Do not interpret the target — pass it as-is.`,
-      );
-    },
-  });
-
-  pi.registerCommand("architecture", {
-    description: "Analyze codebase for architectural friction and create RFC issues",
-    handler: async () => {
-      pi.sendUserMessage(`Call the forgeflow-dev tool now with these exact parameters: pipeline="architecture".`);
-    },
-  });
-
-  pi.registerCommand("discover-skills", {
-    description: "Find and install domain-specific plugins from skills.sh for this project's tech stack",
-    handler: async (args) => {
-      const query = args.trim();
-      if (query) {
-        pi.sendUserMessage(
-          `Call the forgeflow-dev tool now with these exact parameters: pipeline="discover-skills", issue="${query}". Present the tool's output verbatim — do not summarize or reformat it.`,
-        );
-      } else {
-        pi.sendUserMessage(
-          `Call the forgeflow-dev tool now with these exact parameters: pipeline="discover-skills". Present the tool's output verbatim — do not summarize or reformat it.`,
-        );
-      }
-    },
-  });
-};
-
-export default extension;

package/src/pipelines/architecture.ts

@@ -1,67 +0,0 @@
-import { type AnyCtx, emptyStage, runAgent, TOOLS_READONLY } from "@callumvass/forgeflow-shared";
-import { AGENTS_DIR } from "../resolve.js";
-
-export async function runArchitecture(cwd: string, signal: AbortSignal, onUpdate: AnyCtx, ctx: AnyCtx) {
-  const stages = [emptyStage("architecture-reviewer")];
-  const opts = { agentsDir: AGENTS_DIR, cwd, signal, stages, pipeline: "architecture", onUpdate };
-
-  // Phase 1: Explore codebase for friction
-  const exploreResult = await runAgent(
-    "architecture-reviewer",
-    "Explore this codebase and identify architectural friction. Present numbered candidates ranked by severity.",
-    { ...opts, tools: TOOLS_READONLY },
-  );
-
-  if (exploreResult.status === "failed") {
-    return {
-      content: [{ type: "text" as const, text: `Exploration failed: ${exploreResult.output}` }],
-      details: { pipeline: "architecture", stages },
-      isError: true,
-    };
-  }
-
-  // Non-interactive: return candidates
-  if (!ctx.hasUI) {
-    return {
-      content: [{ type: "text" as const, text: exploreResult.output }],
-      details: { pipeline: "architecture", stages },
-    };
-  }
-
-  // Interactive gate: user reviews candidates, can edit/annotate
-  const edited = await ctx.ui.editor(
-    "Review architecture candidates (edit to highlight your pick)",
-    exploreResult.output,
-  );
-  const action = await ctx.ui.select("Create RFC issue for a candidate?", ["Yes — generate RFC", "Skip"]);
-
-  if (action === "Skip" || action == null) {
-    return {
-      content: [{ type: "text" as const, text: "Architecture review complete. No RFC created." }],
-      details: { pipeline: "architecture", stages },
-    };
-  }
-
-  // Phase 2: Generate RFC and create GitHub issue
-  stages.push(emptyStage("architecture-rfc"));
-  const candidateContext = edited ?? exploreResult.output;
-
-  const rfcResult = await runAgent(
-    "architecture-reviewer",
-    `Based on the following architectural analysis, generate a detailed RFC and create a GitHub issue (with label "architecture") for the highest-priority candidate — or the one the user highlighted/edited.\n\nANALYSIS:\n${candidateContext}`,
-    { ...opts, tools: TOOLS_READONLY },
-  );
-
-  // Extract issue URL/number from agent output
-  const issueMatch = rfcResult.output?.match(/https:\/\/github\.com\/[^\s]+\/issues\/(\d+)/);
-  const issueNum = issueMatch?.[1];
-  const issueUrl = issueMatch?.[0];
-  const summary = issueUrl
-    ? `Architecture RFC issue created: ${issueUrl}\n\nRun \`/implement ${issueNum}\` to implement it.`
-    : "Architecture RFC issue created.";
-
-  return {
-    content: [{ type: "text" as const, text: summary }],
-    details: { pipeline: "architecture", stages },
-  };
-}

package/src/pipelines/discover-skills.ts

@@ -1,33 +0,0 @@
-import { type AnyCtx, emptyStage, runAgent, TOOLS_ALL, TOOLS_NO_EDIT } from "@callumvass/forgeflow-shared";
-import { AGENTS_DIR } from "../resolve.js";
-
-export async function runDiscoverSkills(
-  cwd: string,
-  query: string,
-  signal: AbortSignal,
-  onUpdate: AnyCtx,
-  _ctx: AnyCtx,
-) {
-  // If query looks like specific skill names (contains commas or known skill identifiers),
-  // treat as install mode. Otherwise, discover mode.
-  const isInstall = query.includes(",") || query.includes("/");
-
-  const stages = [emptyStage("skill-discoverer")];
-  const opts = { agentsDir: AGENTS_DIR, cwd, signal, stages, pipeline: "discover-skills", onUpdate };
-
-  const task = isInstall
-    ? `Install these skills as forgeflow plugins: ${query}`
-    : query
-      ? `Discover skills related to "${query}" — recommend only, do NOT install.`
-      : "Analyze the project tech stack and discover relevant skills — recommend only, do NOT install.";
-
-  // Install mode needs write access, discover mode is read-only
-  const tools = isInstall ? TOOLS_ALL : TOOLS_NO_EDIT;
-
-  const result = await runAgent("skill-discoverer", task, { ...opts, tools });
-
-  return {
-    content: [{ type: "text" as const, text: result.output || "No skills found." }],
-    details: { pipeline: "discover-skills", stages },
-  };
-}