@calcit/ternary-tree 0.0.24 → 0.0.26

package/lib/map.mjs

@@ -1,5 +1,5 @@
 import { TernaryTreeKind, hashGenerator, } from "./types.mjs";
-import { divideTernarySizes, cmp, dataEqual } from "./utils.mjs";
+import { cmp, dataEqual } from "./utils.mjs";
 let emptyBranch = null;
 let nilResult = null;
 function getMax(tree) {
@@ -29,7 +29,6 @@ function getMin(tree) {
     }
 }
 export function getMapDepth(tree) {
-    // console.log( "calling...", tree)
     if (tree == null) {
         return 0;
     }
@@ -37,11 +36,21 @@ export function getMapDepth(tree) {
         case TernaryTreeKind.ternaryTreeLeaf:
             return 1;
         case TernaryTreeKind.ternaryTreeBranch:
-            return Math.max(getMapDepth(tree.left), getMapDepth(tree.middle), getMapDepth(tree.right)) + 1;
+            return tree.depth; // use cached depth — O(1)
         default:
             throw new Error("Unknown");
     }
 }
+function decideMapBranchDepth(left, middle, right) {
+    // Inline getMapDepth to avoid 3 indirect function calls per invocation
+    let dl = left == null ? 0 : left.kind === TernaryTreeKind.ternaryTreeLeaf ? 1 : left.depth;
+    let dm = middle == null ? 0 : middle.kind === TernaryTreeKind.ternaryTreeLeaf ? 1 : middle.depth;
+    let dr = right == null ? 0 : right.kind === TernaryTreeKind.ternaryTreeLeaf ? 1 : right.depth;
+    let d = dl > dm ? dl : dm;
+    if (dr > d)
+        d = dr;
+    return d + 1;
+}
 function createLeaf(k, v) {
     let result = {
         kind: TernaryTreeKind.ternaryTreeLeaf,
@@ -81,7 +90,8 @@ function makeTernaryTreeMap(size, offset, xs) {
                 left: createLeafFromHashEntry(leftPair),
                 middle: createLeafFromHashEntry(middlePair),
                 right: emptyBranch,
-                depth: 1,
+                depth: 2,
+                size: leftPair.pairs.length + middlePair.pairs.length,
             };
             return result;
         }
@@ -96,15 +106,21 @@ function makeTernaryTreeMap(size, offset, xs) {
                 left: createLeafFromHashEntry(leftPair),
                 middle: createLeafFromHashEntry(middlePair),
                 right: createLeafFromHashEntry(rightPair),
-                depth: 1,
+                depth: 2,
+                size: leftPair.pairs.length + middlePair.pairs.length + rightPair.pairs.length,
             };
             return result;
         }
         default: {
-            let divided = divideTernarySizes(size);
-            let left = makeTernaryTreeMap(divided.left, offset, xs);
-            let middle = makeTernaryTreeMap(divided.middle, offset + divided.left, xs);
-            let right = makeTernaryTreeMap(divided.right, offset + divided.left + divided.middle, xs);
+            // Inline divideTernarySizes to avoid heap object allocation per recursive call
+            let extra = size % 3;
+            let groupSize = (size / 3) | 0;
+            let leftSize = groupSize + (extra === 2 ? 1 : 0);
+            let middleSize = groupSize + (extra === 1 ? 1 : 0);
+            let rightSize = groupSize + (extra === 2 ? 1 : 0);
+            let left = makeTernaryTreeMap(leftSize, offset, xs);
+            let middle = makeTernaryTreeMap(middleSize, offset + leftSize, xs);
+            let right = makeTernaryTreeMap(rightSize, offset + leftSize + middleSize, xs);
             let result = {
                 kind: TernaryTreeKind.ternaryTreeBranch,
                 maxHash: getMax(right),
@@ -112,7 +128,8 @@ function makeTernaryTreeMap(size, offset, xs) {
                 left: left,
                 middle: middle,
                 right: right,
-                depth: Math.max(getMapDepth(left), getMapDepth(middle), getMapDepth(right)) + 1,
+                depth: decideMapBranchDepth(left, middle, right),
+                size: mapLen(left) + mapLen(middle) + mapLen(right),
             };
             return result;
         }
@@ -159,24 +176,21 @@ export function initTernaryTreeMap(t) {
 }
 // use for..in for performance
 export function initTernaryTreeMapFromArray(t) {
-    let groupBuffers = {};
+    // Use Map instead of Record for better performance with numeric keys
+    let groupBuffers = new Map();
     let xs = [];
-    for (let idx = 0; idx < t.length; idx++) {
+    const length = t.length;
+    for (let idx = 0; idx < length; idx++) {
         let k = t[idx][0];
         let v = t[idx][1];
         let h = hashGenerator(k);
-        if (groupBuffers[h] != null) {
-            let branch = groupBuffers[h];
-            if (branch != null) {
-                branch.push([k, v]);
-            }
-            else {
-                throw new Error("Expected referece to pairs");
-            }
+        let branch = groupBuffers.get(h);
+        if (branch != null) {
+            branch.push([k, v]);
         }
         else {
             let pairs = [[k, v]];
-            groupBuffers[h] = pairs;
+            groupBuffers.set(h, pairs);
             xs.push({
                 hash: h,
                 pairs: pairs,
@@ -205,7 +219,7 @@ export function mapLen(tree) {
         case TernaryTreeKind.ternaryTreeLeaf:
             return tree.elements.length;
         case TernaryTreeKind.ternaryTreeBranch:
-            return mapLen(tree.left) + mapLen(tree.middle) + mapLen(tree.right); // TODO
+            return tree.size; // O(1) via cached size field
         default:
             throw new Error("Unknown");
     }
@@ -267,13 +281,13 @@ export function isMapEmpty(tree) {
 }
 export function isMapOfOne(tree, counted = 0) {
     if (tree == null) {
-        return true;
+        return false;
     }
     switch (tree.kind) {
         case TernaryTreeKind.ternaryTreeLeaf:
-            return false;
+            return tree.elements.length === 1;
         case TernaryTreeKind.ternaryTreeBranch:
-            return tree.left == null && tree.middle == null && tree.right == null;
+            return mapLenBound(tree, 2) === 1;
         default:
             throw new Error("Unknown");
     }
@@ -285,11 +299,15 @@ function collectHashSortedArray(tree, acc, idx) {
     else {
         switch (tree.kind) {
             case TernaryTreeKind.ternaryTreeLeaf: {
-                for (let i = 0; i < tree.elements.length; i++) {
-                    let item = tree.elements[i];
-                    acc[idx.value] = item;
-                    idx.value = idx.value + 1;
+                // Cache elements and current index to reduce property access
+                const elements = tree.elements;
+                const length = elements.length;
+                let currentIdx = idx.value;
+                for (let i = 0; i < length; i++) {
+                    acc[currentIdx] = elements[i];
+                    currentIdx++;
                 }
+                idx.value = currentIdx;
                 break;
             }
             case TernaryTreeKind.ternaryTreeBranch: {
@@ -317,8 +335,10 @@ function collectOrderedHashEntries(tree, acc, idx) {
     else {
         switch (tree.kind) {
             case TernaryTreeKind.ternaryTreeLeaf: {
-                acc[idx.value] = { hash: tree.hash, pairs: tree.elements };
-                idx.value = idx.value + 1;
+                // Cache current index to reduce property access
+                const currentIdx = idx.value;
+                acc[currentIdx] = { hash: tree.hash, pairs: tree.elements };
+                idx.value = currentIdx + 1;
                 break;
             }
             case TernaryTreeKind.ternaryTreeBranch: {
@@ -344,85 +364,88 @@ export function contains(originalTree, item) {
     if (originalTree == null) {
         return false;
     }
-    // TODO
     // reduce redundant computation by reusing hash result
     let hx = hashGenerator(item);
     let tree = originalTree;
     whileLoop: while (tree != null) {
         if (tree.kind === TernaryTreeKind.ternaryTreeLeaf) {
             if (hx === tree.hash) {
-                let size = tree.elements.length;
+                // Cache elements length to avoid repeated property access
+                const elements = tree.elements;
+                const size = elements.length;
                 for (let idx = 0; idx < size; idx++) {
-                    let pair = tree.elements[idx];
-                    if (dataEqual(pair[0], item)) {
+                    if (dataEqual(elements[idx][0], item)) {
                         return true;
                     }
                 }
             }
             return false;
         }
-        // echo "looking for: ", hx, " ", item, " in ", tree.formatInline(true)
-        if (tree.left == null) {
+        // Optimize branch navigation with early exits
+        const left = tree.left;
+        if (left == null) {
             return false;
         }
-        if (tree.left.kind === TernaryTreeKind.ternaryTreeLeaf) {
-            if (hx < tree.left.hash) {
+        if (left.kind === TernaryTreeKind.ternaryTreeLeaf) {
+            if (hx < left.hash) {
                 return false;
             }
-            if (tree.left.hash === hx) {
-                tree = tree.left;
-                continue whileLoop; // notice, it jumps to while loop
+            if (left.hash === hx) {
+                tree = left;
+                continue whileLoop;
             }
         }
         else {
-            if (hx < tree.left.minHash) {
+            if (hx < left.minHash) {
                 return false;
             }
-            if (hx <= tree.left.maxHash) {
-                tree = tree.left;
-                continue whileLoop; // notice, it jumps to while loop
+            if (hx <= left.maxHash) {
+                tree = left;
+                continue whileLoop;
             }
         }
-        if (tree.middle == null) {
+        const middle = tree.middle;
+        if (middle == null) {
             return false;
         }
-        if (tree.middle.kind === TernaryTreeKind.ternaryTreeLeaf) {
-            if (hx < tree.middle.hash) {
+        if (middle.kind === TernaryTreeKind.ternaryTreeLeaf) {
+            if (hx < middle.hash) {
                 return false;
             }
-            if (tree.middle.hash === hx) {
-                tree = tree.middle;
-                continue whileLoop; // notice, it jumps to while loop
+            if (middle.hash === hx) {
+                tree = middle;
+                continue whileLoop;
             }
         }
         else {
-            if (hx < tree.middle.minHash) {
+            if (hx < middle.minHash) {
                 return false;
             }
-            if (hx <= tree.middle.maxHash) {
-                tree = tree.middle;
-                continue whileLoop; // notice, it jumps to while loop
+            if (hx <= middle.maxHash) {
+                tree = middle;
+                continue whileLoop;
             }
         }
-        if (tree.right == null) {
+        const right = tree.right;
+        if (right == null) {
             return false;
         }
-        if (tree.right.kind === TernaryTreeKind.ternaryTreeLeaf) {
-            if (hx < tree.right.hash) {
+        if (right.kind === TernaryTreeKind.ternaryTreeLeaf) {
+            if (hx < right.hash) {
                 return false;
             }
-            if (tree.right.hash === hx) {
-                tree = tree.right;
-                continue whileLoop; // notice, it jumps to while loop
+            if (right.hash === hx) {
+                tree = right;
+                continue whileLoop;
             }
         }
         else {
-            if (hx < tree.right.minHash) {
+            if (hx < right.minHash) {
                 return false;
             }
-            if (hx <= tree.right.maxHash) {
-                tree = tree.right;
-                continue whileLoop; // notice, it jumps to while loop
+            if (hx <= right.maxHash) {
+                tree = right;
+                continue whileLoop;
             }
         }
         return false;
@@ -434,77 +457,81 @@ export function mapGetDefault(originalTree, item, v0) {
     let tree = originalTree;
     whileLoop: while (tree != null) {
         if (tree.kind === TernaryTreeKind.ternaryTreeLeaf) {
-            let size = tree.elements.length;
+            // Cache elements array to avoid repeated property access
+            const elements = tree.elements;
+            const size = elements.length;
             for (let i = 0; i < size; i++) {
-                let pair = tree.elements[i];
-                if (dataEqual(pair[0], item)) {
-                    return pair[1];
+                if (dataEqual(elements[i][0], item)) {
+                    return elements[i][1];
                 }
             }
             return v0;
         }
-        // echo "looking for: ", hx, " ", item, " in ", tree.formatInline
-        if (tree.left == null) {
+        // Cache tree children to avoid repeated property access
+        const left = tree.left;
+        if (left == null) {
             return v0;
         }
-        if (tree.left.kind == TernaryTreeKind.ternaryTreeLeaf) {
-            if (hx < tree.left.hash) {
+        if (left.kind == TernaryTreeKind.ternaryTreeLeaf) {
+            if (hx < left.hash) {
                 return v0;
             }
-            if (tree.left.hash === hx) {
-                tree = tree.left;
-                continue whileLoop; // notice, it jumps to while loop
+            if (left.hash === hx) {
+                tree = left;
+                continue whileLoop;
             }
         }
         else {
-            if (hx < tree.left.minHash) {
+            if (hx < left.minHash) {
                 return v0;
             }
-            if (hx <= tree.left.maxHash) {
-                tree = tree.left;
-                continue whileLoop; // notice, it jumps to while loop
+            if (hx <= left.maxHash) {
+                tree = left;
+                continue whileLoop;
             }
         }
-        if (tree.middle == null) {
+        const middle = tree.middle;
+        if (middle == null) {
             return v0;
         }
-        if (tree.middle.kind == TernaryTreeKind.ternaryTreeLeaf) {
-            if (hx < tree.middle.hash) {
+        if (middle.kind == TernaryTreeKind.ternaryTreeLeaf) {
+            if (hx < middle.hash) {
                 return v0;
             }
-            if (tree.middle.hash === hx) {
-                tree = tree.middle;
-                continue whileLoop; // notice, it jumps to while loop
+            if (middle.hash === hx) {
+                tree = middle;
+                continue whileLoop;
             }
         }
         else {
-            if (hx < tree.middle.minHash) {
+            if (hx < middle.minHash) {
                 return v0;
             }
-            if (hx <= tree.middle.maxHash) {
-                tree = tree.middle;
-                continue whileLoop; // notice, it jumps to while loop
+            if (hx <= middle.maxHash) {
+                tree = middle;
+                continue whileLoop;
             }
         }
-        if (tree.right == null) {
+        const right = tree.right;
+        if (right == null) {
             return v0;
         }
-        if (tree.right.kind == TernaryTreeKind.ternaryTreeLeaf) {
-            if (hx < tree.right.hash) {
+        if (right.kind == TernaryTreeKind.ternaryTreeLeaf) {
+            if (hx < right.hash) {
                 return v0;
             }
-            if (tree.right.hash === hx) {
-                tree = tree.right;
-                continue whileLoop; // notice, it jumps to while loop
+            if (right.hash === hx) {
+                tree = right;
+                continue whileLoop;
             }
         }
         else {
-            if (hx < tree.right.minHash) {
+            if (hx < right.minHash) {
                 return v0;
             }
-            if (hx <= tree.right.maxHash) {
-                tree = tree.right;
-                continue whileLoop; // notice, it jumps to while loop
+            if (hx <= right.maxHash) {
+                tree = right;
+                continue whileLoop;
             }
         }
         return v0;
@@ -524,7 +551,7 @@ export function checkMapStructure(tree) {
                 throw new Error(`Bad hash at leaf node ${tree}`);
             }
         }
-        if (mapLenBound(tree, 2) !== 1) {
+        if (mapLenBound(tree, 2) < 1) {
             throw new Error(`Bad len at leaf node ${tree}`);
         }
     }
@@ -619,46 +646,49 @@ function assocExisted(tree, key, item, thisHash = null) {
         throw new Error("Unexpected missing hash in assoc, found not branch");
     }
     if (rangeContainsHash(tree.left, thisHash)) {
-        let result = {
+        let newLeft = assocExisted(tree.left, key, item, thisHash);
+        return {
             kind: TernaryTreeKind.ternaryTreeBranch,
             maxHash: tree.maxHash,
             minHash: tree.minHash,
-            left: assocExisted(tree.left, key, item, thisHash),
+            left: newLeft,
             middle: tree.middle,
             right: tree.right,
-            depth: 0, // TODO
+            depth: decideMapBranchDepth(newLeft, tree.middle, tree.right),
+            size: tree.size,
         };
-        return result;
     }
     if (tree.middle == null) {
         throw new Error("Unexpected missing hash in assoc, found not branch");
     }
     if (rangeContainsHash(tree.middle, thisHash)) {
-        let result = {
+        let newMiddle = assocExisted(tree.middle, key, item, thisHash);
+        return {
             kind: TernaryTreeKind.ternaryTreeBranch,
             maxHash: tree.maxHash,
             minHash: tree.minHash,
             left: tree.left,
-            middle: assocExisted(tree.middle, key, item, thisHash),
+            middle: newMiddle,
             right: tree.right,
-            depth: 0, // TODO
+            depth: decideMapBranchDepth(tree.left, newMiddle, tree.right),
+            size: tree.size,
         };
-        return result;
     }
     if (tree.right == null) {
         throw new Error("Unexpected missing hash in assoc, found not branch");
     }
     if (rangeContainsHash(tree.right, thisHash)) {
-        let result = {
+        let newRight = assocExisted(tree.right, key, item, thisHash);
+        return {
             kind: TernaryTreeKind.ternaryTreeBranch,
             maxHash: tree.maxHash,
             minHash: tree.minHash,
             left: tree.left,
             middle: tree.middle,
-            right: assocExisted(tree.right, key, item, thisHash),
-            depth: 0, // TODO
+            right: newRight,
+            depth: decideMapBranchDepth(tree.left, tree.middle, newRight),
+            size: tree.size,
         };
-        return result;
     }
     throw new Error("Unexpected missing hash in assoc, found not branch");
 }
@@ -682,7 +712,8 @@ function assocNew(tree, key, item, thisHash = null) {
                 left: tree,
                 middle: childBranch,
                 right: emptyBranch,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(tree, childBranch, emptyBranch),
+                size: mapLen(tree) + 1,
             };
             return result;
         }
@@ -699,7 +730,8 @@ function assocNew(tree, key, item, thisHash = null) {
                 left: childBranch,
                 middle: tree,
                 right: emptyBranch,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(childBranch, tree, emptyBranch),
+                size: mapLen(tree) + 1,
             };
             return result;
         }
@@ -740,7 +772,8 @@ function assocNew(tree, key, item, thisHash = null) {
                     left: childBranch,
                     middle: tree.left,
                     right: tree.middle,
-                    depth: 0, // TODO
+                    depth: decideMapBranchDepth(childBranch, tree.left, tree.middle),
+                    size: tree.size + 1,
                 };
                 return result;
             }
@@ -757,7 +790,8 @@ function assocNew(tree, key, item, thisHash = null) {
                     left: childBranch,
                     middle: tree,
                     right: emptyBranch,
-                    depth: 0, // TODO
+                    depth: decideMapBranchDepth(childBranch, tree, emptyBranch),
+                    size: tree.size + 1,
                 };
                 return result;
             }
@@ -777,7 +811,8 @@ function assocNew(tree, key, item, thisHash = null) {
                     left: tree.left,
                     middle: childBranch,
                     right: emptyBranch,
-                    depth: 0, // TODO
+                    depth: decideMapBranchDepth(tree.left, childBranch, emptyBranch),
+                    size: tree.size + 1,
                 };
                 return result;
             }
@@ -794,7 +829,8 @@ function assocNew(tree, key, item, thisHash = null) {
                     left: tree.left,
                     middle: tree.middle,
                     right: childBranch,
-                    depth: 0, // TODO
+                    depth: decideMapBranchDepth(tree.left, tree.middle, childBranch),
+                    size: tree.size + 1,
                 };
                 return result;
             }
@@ -811,73 +847,79 @@ function assocNew(tree, key, item, thisHash = null) {
                     left: tree,
                     middle: childBranch,
                     right: emptyBranch,
-                    depth: 0, // TODO
+                    depth: decideMapBranchDepth(tree, childBranch, emptyBranch),
+                    size: tree.size + 1,
                 };
                 return result;
             }
         }
         if (rangeContainsHash(tree.left, thisHash)) {
-            let result = {
+            let newLeft = assocNew(tree.left, key, item, thisHash);
+            return {
                 kind: TernaryTreeKind.ternaryTreeBranch,
                 maxHash: tree.maxHash,
                 minHash: tree.minHash,
-                left: assocNew(tree.left, key, item, thisHash),
+                left: newLeft,
                 middle: tree.middle,
                 right: tree.right,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(newLeft, tree.middle, tree.right),
+                size: tree.size + 1,
             };
-            return result;
         }
         if (rangeContainsHash(tree.middle, thisHash)) {
-            let result = {
+            let newMiddle = assocNew(tree.middle, key, item, thisHash);
+            return {
                 kind: TernaryTreeKind.ternaryTreeBranch,
                 maxHash: tree.maxHash,
                 minHash: tree.minHash,
                 left: tree.left,
-                middle: assocNew(tree.middle, key, item, thisHash),
+                middle: newMiddle,
                 right: tree.right,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(tree.left, newMiddle, tree.right),
+                size: tree.size + 1,
             };
-            return result;
         }
         if (rangeContainsHash(tree.right, thisHash)) {
-            let result = {
+            let newRight = assocNew(tree.right, key, item, thisHash);
+            return {
                 kind: TernaryTreeKind.ternaryTreeBranch,
                 maxHash: tree.maxHash,
                 minHash: tree.minHash,
                 left: tree.left,
                 middle: tree.middle,
-                right: assocNew(tree.right, key, item, thisHash),
-                depth: 0, // TODO
+                right: newRight,
+                depth: decideMapBranchDepth(tree.left, tree.middle, newRight),
+                size: tree.size + 1,
             };
-            return result;
         }
         if (tree.middle == null) {
             throw new Error("unreachable. if inside range, then middle should be here");
         }
         if (thisHash < getMin(tree.middle)) {
-            let result = {
+            let newLeft = assocNew(tree.left, key, item, thisHash);
+            return {
                 kind: TernaryTreeKind.ternaryTreeBranch,
                 maxHash: tree.maxHash,
                 minHash: tree.minHash,
-                left: assocNew(tree.left, key, item, thisHash),
+                left: newLeft,
                 middle: tree.middle,
                 right: tree.right,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(newLeft, tree.middle, tree.right),
+                size: tree.size + 1,
             };
-            return result;
         }
         else {
-            let result = {
+            let newRight = assocNew(tree.right, key, item, thisHash);
+            return {
                 kind: TernaryTreeKind.ternaryTreeBranch,
                 maxHash: tree.maxHash,
                 minHash: tree.minHash,
                 left: tree.left,
                 middle: tree.middle,
-                right: assocNew(tree.right, key, item, thisHash),
-                depth: 0, // TODO
+                right: newRight,
+                depth: decideMapBranchDepth(tree.left, tree.middle, newRight),
+                size: tree.size + 1,
             };
-            return result;
         }
     }
 }
@@ -938,7 +980,8 @@ function dissocExisted(tree, key) {
                 left: tree.middle,
                 middle: tree.right,
                 right: emptyBranch,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(tree.middle, tree.right, emptyBranch),
+                size: tree.size - 1,
             };
             return result;
         }
@@ -950,7 +993,8 @@ function dissocExisted(tree, key) {
                 left: changedBranch,
                 middle: tree.middle,
                 right: tree.right,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(changedBranch, tree.middle, tree.right),
+                size: tree.size - 1,
             };
             return result;
         }
@@ -968,7 +1012,8 @@ function dissocExisted(tree, key) {
                 left: tree.left,
                 middle: tree.right,
                 right: emptyBranch,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(tree.left, tree.right, emptyBranch),
+                size: tree.size - 1,
             };
             return result;
         }
@@ -980,7 +1025,8 @@ function dissocExisted(tree, key) {
                 left: tree.left,
                 middle: changedBranch,
                 right: tree.right,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(tree.left, changedBranch, tree.right),
+                size: tree.size - 1,
             };
             return result;
         }
@@ -995,7 +1041,8 @@ function dissocExisted(tree, key) {
                 left: tree.left,
                 middle: tree.middle,
                 right: emptyBranch,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(tree.left, tree.middle, emptyBranch),
+                size: tree.size - 1,
             };
             return result;
         }
@@ -1007,7 +1054,8 @@ function dissocExisted(tree, key) {
                 left: tree.left,
                 middle: tree.middle,
                 right: changedBranch,
-                depth: 0, // TODO
+                depth: decideMapBranchDepth(tree.left, tree.middle, changedBranch),
+                size: tree.size - 1,
             };
             return result;
         }
@@ -1025,28 +1073,38 @@ export function dissocMap(tree, key) {
 function collectToPairsArray(acc, tree) {
     if (tree != null) {
         if (tree.kind === TernaryTreeKind.ternaryTreeLeaf) {
-            for (let i = 0; i < tree.elements.length; i++) {
-                let pair = tree.elements[i];
-                acc.push(pair);
+            // Cache elements array and use batch push for better performance
+            const elements = tree.elements;
+            const length = elements.length;
+            for (let i = 0; i < length; i++) {
+                acc.push(elements[i]);
             }
         }
         else {
-            if (tree.left != null) {
-                collectToPairsArray(acc, tree.left);
+            // Cache children to avoid repeated property access
+            const left = tree.left;
+            const middle = tree.middle;
+            const right = tree.right;
+            if (left != null) {
+                collectToPairsArray(acc, left);
             }
-            if (tree.middle != null) {
-                collectToPairsArray(acc, tree.middle);
+            if (middle != null) {
+                collectToPairsArray(acc, middle);
             }
-            if (tree.right != null) {
-                collectToPairsArray(acc, tree.right);
+            if (right != null) {
+                collectToPairsArray(acc, right);
             }
         }
     }
 }
 /** similar to `toPairs`, but using Array.push directly */
 export function toPairsArray(tree) {
-    let result = [];
-    collectToPairsArray(result, tree);
+    // Pre-allocate array with known size for better performance
+    const totalSize = mapLen(tree);
+    let result = new Array(totalSize);
+    let idx = { value: 0 };
+    // Use the more efficient collectHashSortedArray instead
+    collectHashSortedArray(tree, result, idx);
     return result;
 }
 export function* toPairs(tree) {
@@ -1254,10 +1312,13 @@ export function mapMapValues(tree, f) {
     }
     switch (tree.kind) {
         case TernaryTreeKind.ternaryTreeLeaf: {
-            let newElements = new Array(tree.elements.length);
-            let size = tree.elements.length;
+            // Cache elements array and pre-allocate result
+            const elements = tree.elements;
+            const size = elements.length;
+            let newElements = new Array(size);
             for (let idx = 0; idx < size; idx++) {
-                newElements[idx] = [tree.elements[idx][0], f(tree.elements[idx][1])];
+                const element = elements[idx];
+                newElements[idx] = [element[0], f(element[1])];
             }
             let result = {
                 kind: TernaryTreeKind.ternaryTreeLeaf,
@@ -1275,6 +1336,7 @@ export function mapMapValues(tree, f) {
                 left: mapMapValues(tree.left, f),
                 middle: mapMapValues(tree.middle, f),
                 right: mapMapValues(tree.right, f),
+                size: tree.size,
             };
             return result;
         }