@caddis/cli 0.4.55 → 0.4.56

package/bundles/antigravity-plugin/skills/ship/SKILL.md

@@ -36,13 +36,16 @@ names, branch, and service identifiers — never assume.
 - Tests: run only if the user says they're needed or a gate explicitly requires them
 - Fix any failures before proceeding. Do not commit broken code.
 
-**2. STAGE + COMMIT** — Stage only the intended files, by name (never `git add -A`, `git add .` or a folder):
+**2. STAGE + COMMIT** — Stage only the intended files, by name (never `git add -A`, `git add .`, `git add -u`, a folder, or `git commit -a`):
 ```
 git status --short      # confirm what's staged
 git add <specific files>
-git commit -m "<type>(<scope>): <message>"
+git diff --cached --name-only   # must list ONLY <specific files>
+git commit -m "<type>(<scope>): <message>" -- <specific files>
 git rev-parse HEAD      # record SHA for monitoring
 ```
+If `git diff --cached --name-only` lists a path you did not change, **stop**: a peer staged it. Do not
+commit, unstage or stash it; report it. `-- <files>` commits only the named files even then.
 Use conventional commits: `fix:`, `feat:`, `chore:`, `refactor:`, `docs:`. Scope = affected module.
 
 **2b. CROSS-REVIEW TRIGGER** — `ship` has no review pause at all, which is how sixteen fixes reached production unreviewed in one day.
@@ -119,7 +122,7 @@ Small work that does not meet a trigger skips its block.
 
 ## Rules
 - Never push before preflight gates are green.
-- Never `git add -A`, `git add .` or `git add <dir>`, even after reading `git status`: stage named files only (the guard denies the first two).
+- Never `git add -A`, `git add .` or `git add <dir>`, even after reading `git status`: stage named files only (the guard denies all three, and `git add -u` and `git commit -a`). Commit with `git commit -m "..." -- <files>`, after `git diff --cached --name-only` shows only those files.
 - Do not edit a workflow file (`.gitea/workflows/` or `.github/workflows/`) to make a failing gate
   pass — fix the source.
 - Gitea lane: tag-triggered runs after `release_metadata` are expected; verify `deploy_prod` is

package/bundles/antigravity-plugin/skills/ship-merge/SKILL.md

@@ -123,7 +123,7 @@ Cleanup:       remote branch ✗ deleted / local ✗ deleted / backup ref droppe
 ## Rules
 - Never merge without: green required checks **and** the explicit human deploy-confirm.
 - Never delete a branch before its deploy is validated green.
-- Never `git add -A`, `git add .` or `git add <dir>`, even after reading `git status`: stage named files only (the guard denies the first two). Never edit a workflow file to make a gate pass.
+- Never `git add -A`, `git add .` or `git add <dir>`, even after reading `git status`: stage named files only (the guard denies all three, and `git add -u` and `git commit -a`). Commit with `git commit -m "..." -- <files>`, after `git diff --cached --name-only` shows only those files. Never edit a workflow file to make a gate pass.
 - Local-only lane: no PR, no merge — refuse and point at `/ship`.
 
 ## Skill reference

package/bundles/antigravity-plugin/skills/ship-pr/SKILL.md

@@ -56,7 +56,7 @@ source checkout; skip this step if the script is missing or the repo has no `.ca
 - Exit **1** — **stop; do not open the PR.** Show each `CHECK VIOLATION` or `ERROR` line.
   - `plan <path>: tracker done, status <s>` — run
     `caddis_tidy.py --repo-root . --apply --only <path>`, `git add` the moved plan by name,
-    commit, and run this step again.
+    commit with `git commit -m "..." -- <old path> <new path>`, and run this step again.
   - `plan <path>: tracker done, but done/<name> already exists (rename one of them)` — `--apply`
     cannot fix this; it changes nothing while the name is taken. Rename the plan or the old
     `done/` copy with `git mv`, commit, and run this step again.
@@ -146,7 +146,7 @@ human-confirmed door.
 
 ## Rules
 - **Never merges, never deploys** — no merge action exists in this command, by design.
-- Never `git add -A`, `git add .` or `git add <dir>`, even after reading `git status`: stage named files only (the guard denies the first two).
+- Never `git add -A`, `git add .` or `git add <dir>`, even after reading `git status`: stage named files only (the guard denies all three, and `git add -u` and `git commit -a`). Commit with `git commit -m "..." -- <files>`, after `git diff --cached --name-only` shows only those files.
 - Never force-push without a `backup/*-preship` recovery ref; force pushes are `--force-with-lease` only.
 - Never edit a workflow file (`.gitea/workflows/`, `.github/workflows/`) to make a gate pass — fix the source.
 - Local-only lane: refuse + point at `/ship`. On the default branch: stop + point at `/ship`.

package/bundles/antigravity-plugin/skills/writing-plans/SKILL.md

@@ -102,7 +102,7 @@ Expected: PASS
 
 ```bash
 git add tests/path/test.py src/path/file.py
-git commit -m "feat: add specific feature"
+git commit -m "feat: add specific feature" -- tests/path/test.py src/path/file.py
 ```
 ```
 

package/bundles/antigravity-plugin/warm_start_agy.py

@@ -28,6 +28,19 @@ import os
 import subprocess
 import sys
 
+# No child process of this hook opens a console window on Windows (scripts/no_window.py). agy hooks ship
+# FLAT at the plugin root with scripts/ beside them; in the source repo scripts/ is one level up.
+try:
+    _nw_here = os.path.dirname(os.path.abspath(__file__))
+    for _nw_cand in (os.path.join(_nw_here, "scripts"), os.path.join(os.path.dirname(_nw_here), "scripts")):
+        if os.path.isfile(os.path.join(_nw_cand, "no_window.py")):
+            if _nw_cand not in sys.path:
+                sys.path.insert(0, _nw_cand)
+            break
+    from no_window import NO_WINDOW_KW  # noqa: E402
+except Exception:  # pragma: no cover - defensive
+    NO_WINDOW_KW = {"creationflags": 0x08000000} if os.name == "nt" else {}
+
 _ARTIFACT_DIRS = (".caddis",)
 
 INJECT_MAX_LINES = 120      # same budget as the Claude Code hook
@@ -151,7 +164,7 @@ def resolve_relay(root: str, session_id: str = "") -> tuple[str, str | None]:
     try:
         branch = subprocess.run(
             ["git", "-C", root, "rev-parse", "--abbrev-ref", "HEAD"],
-            capture_output=True, text=True, timeout=3,
+            capture_output=True, text=True, timeout=3, **NO_WINDOW_KW,
         ).stdout.strip()
     except Exception:
         branch = ""

package/bundles/antigravity-plugin-extras/plugin.json

@@ -1,5 +1,5 @@
 {
   "name": "caddis-extras",
-  "version": "1.3.43",
+  "version": "1.3.44",
   "description": "caddis-extras — the long-tail skills for the Antigravity (agy) caddis plugin; install alongside caddis for the full set."
 }

package/bundles/antigravity-plugin-extras/skills/deploy-local/SKILL.md

@@ -80,7 +80,8 @@ Example:
 ```powershell
 git status --short
 git add <files>
-git commit -m "fix(ci): resolve deploy health check"
+git diff --cached --name-only   # only <files>; else stop and report
+git commit -m "fix(ci): resolve deploy health check" -- <files>
 git push origin main
 git rev-parse HEAD
 ```

package/bundles/antigravity-plugin-extras/skills/update-readme/SKILL.md

@@ -54,7 +54,7 @@ Use this skill when users ask to:
 ### Phase 4 — Stage only README changes for docs commit
 
 1. Stage README files only:
-   - `git add README.md **/README.md`
+   - `git add README.md <each changed README by path>` (no `**` pattern: the guard denies it)
 2. Verify staged diff contains no non-README files.
 3. Suggested conventional commit:
    - `docs(readme): document <feature summary>`

package/bundles/codex/.codex/skills/coding/refactoring/SKILL.md

@@ -128,7 +128,8 @@ Activate when:
    ```bash
    git status --short          # stage the files you changed, by name
    git add tests/test_<module>.py
-   git commit -m "chore: add tests before refactoring"
+   git diff --cached --name-only  # only the files you named
+   git commit -m "chore: add tests before refactoring" -- tests/test_<module>.py
    ```
 
 ---
@@ -387,7 +388,8 @@ DEPRECATED_VALUE = 5              # Not referenced
 
 2. **If tests pass, commit**
    ```bash
-   git commit -m "refactor: extract validation to separate method"
+   git add <files you changed>
+   git commit -m "refactor: extract validation to separate method" -- <files you changed>
    ```
 
 3. **If tests fail, revert**

package/bundles/codex/.codex/skills/devops/gh-cli/SKILL.md

@@ -168,7 +168,7 @@ gh alias set review 'pr list --search "review-requested:@me"'
 ```bash
 gh issue develop 42 --branch fix/issue-42
 git add src/auth/login.py tests/test_login.py   # named files only, never `git add .`
-git commit -m "fix: resolve login bug" && git push -u origin HEAD
+git commit -m "fix: resolve login bug" -- src/auth/login.py tests/test_login.py && git push -u origin HEAD
 gh pr create --title "fix: resolve login bug" --body "Closes #42"
 gh pr checks --watch
 gh pr merge --squash --delete-branch

package/bundles/codex/.codex/skills/devops/git-commit/SKILL.md

@@ -87,9 +87,8 @@ Optional area of change:
    # Stage specific files
    git add path/to/file1 path/to/file2
 
-   # Stage by pattern
-   git add *.test.*
-   git add src/components/*
+   # Never stage by pattern or folder (`*.test.*`, `src/components/`): a pattern also takes
+   # files you did not change, and the caddis guard denies it. Name each file.
    ```
 
    **Never stage secrets** (`.env`, `credentials.json`, private keys).

package/bundles/codex/.codex/skills/docs/writing-plans/SKILL.md

@@ -102,7 +102,7 @@ Expected: PASS
 
 ```bash
 git add tests/path/test.py src/path/file.py
-git commit -m "feat: add specific feature"
+git commit -m "feat: add specific feature" -- tests/path/test.py src/path/file.py
 ```
 ```
 

package/bundles/codex/.codex/skills/workflow/roadmap/SKILL.md

@@ -89,8 +89,26 @@ python scripts/caddis_roadmap.py recheck --roadmap <slug>
   `Depends on` milestone `done` or `not-needed`, and no open blocker other than `data-condition` (exit 1 names it),
   then runs the Exit check (300 s): pass -> `done`; fail with a `data-condition` blocker -> `code-done/data-pending`;
   fail otherwise -> an `external` blocker
-  `exit check failing (exit <n>)` (never the command's output). A milestone with no phase refs and no Exit check is
-  refused (exit 4).
+  `exit check failing (exit <n>): <tail>` (the last 3 non-empty output lines on one line, the whole reason at most
+  200 characters, masked as below). The part before `: ` is the blocker's identity: a later rollup adds no second
+  row, and `unblock --reason "exit check failing (exit <n>)"` removes every row of that prefix. A check that fails
+  on a missing environment (exit 9009/127/126, or output in its last 40 lines such as `No module named`,
+  `Cannot find module`, `ENOENT`, `run npm run build first`) is exit 3: no blocker, no PR. Either way the last 64 KB
+  of output (masked the same way) go to `.local/exit-check-<id>-<utc>.log` (the newest 10 stay), and rollup prints
+  the path. A milestone with no phase refs and no Exit check is refused (exit 4).
+  **Masked** in the reason and the log: the values of secret-named variables (`caddis_redact`); a whole
+  `-----BEGIN ... PRIVATE KEY-----` block up to its END line (or the end of the output); AWS, GitHub, Slack and JWT
+  tokens; a quoted value after a `password`/`secret`/`api_key`/`token` name, spaces included; an unquoted
+  `*PASSWORD*=`/`*TOKEN*=`-style line value; URL credentials (`scheme://***@`); and absolute paths as `<path>`: a
+  drive or UNC path up to the end of the line, a quote, `<`, `>` or `|`, and a `/home/`, `/Users/`, `/tmp/`, `/root/`,
+  `/var/`, `/etc/` or `/opt/` path up to the end of the line or a quote. Other text is published as printed.
+- **`**Exit setup:** <command>`** (optional, one per roadmap, beside `Runner host:`; no `|`) runs in the temp worktree
+  before every Exit check (900 s). It must install fresh into that worktree, for example
+  `python -m venv .venv && .venv\Scripts\pip install -e .[dev]` or `npm ci && npm run build`. Each command runs in a
+  new shell, so the Exit check must call the venv itself: `.venv\Scripts\python -m pytest tests -q`, not
+  `python -m pytest`. Never link or junction a shared venv or `node_modules`: the worktree is removed with `--force`
+  after the check. A setup that fails or times out is exit 3 and writes nothing; the runner stops
+  `BLOCKED rollup not run` and the owner decides (the stop names a docs PR that was opened but not merged).
 - **Owner-only changes:** `set` Status `not-needed`, any `set` Owner, `unblock` of an `owner-gate`, and `block --check`
   (recheck runs that command unattended later). They need `--by-owner` and are refused headless: `CADDIS_HEADLESS`
   or `CLAUDECODE` in the environment (even empty), stdin not a terminal, or on
@@ -179,8 +197,8 @@ Stops (each one notifies and releases the lock): a STOP file (`~/.caddis/STOP` o
 `caddis_spend.py` still counts across runs), a lock or batch claim that cannot be written
 (`BLOCKED claim not written`, before any session), the agy spend cap refusing a reservation, three sessions
 with no newly merged phase, a roadmap write that fails, and the **snapshot guard**: one baseline for the whole run.
-The Milestones and Blockers tables (every cell of every row, rows added, removed or moved) and the `Runner host` line
-are frozen. Every origin read (each `next`, after the runner's own writes, after each session) is compared with the
+The Milestones and Blockers tables (every cell of every row, rows added, removed or moved), the `Runner host` line
+and the `**Exit setup:**` line are frozen. Every origin read (each `next`, after the runner's own writes, after each session) is compared with the
 previous one; the only differences allowed are the exact edits the runner itself made and recorded for that read: a
 Status it set, a blocker row it added, and what a rollup's audit entry (`changes.jsonl`) says it actually wrote.
 Anything else stops the run `FAILED roadmap changed`.
@@ -206,7 +224,10 @@ refuses a plan that a roadmap lock names, at start and before every session. `-D
 the session command, the worktree and any pending rollup, skips the host check, writes no files and starts nothing; it
 does run `git fetch`, which updates the remote-tracking refs. `-GhAccount <login>` (recorded in the launch options,
 passed on by the recheck task and in the printed task) makes every gh call of the runner and of `--last-stop` use
-GH_TOKEN from `gh auth token -u <login>`; on a machine with several gh logins, give the repo's account. A gh call that
+GH_TOKEN from `gh auth token -u <login>`; on a machine with several gh logins, give the repo's account. The sessions
+never get that token, nor GH_TOKEN, GITHUB_TOKEN, GH_ENTERPRISE_TOKEN, NPM_TOKEN or NODE_AUTH_TOKEN from the
+environment; with CADDIS_HEADLESS=1 the guard denies `git push`, `gh pr merge|create`, `gh release`, a write through
+`gh api`, `gh workflow run` and package publishes. Only the runner publishes. A gh call that
 cannot answer (gh missing, 401, 404) is an error, never "not merged": the run stops
 `BLOCKED gh cannot see <repo> with account <login>`, notified and recorded.
 
@@ -223,7 +244,8 @@ phases) holds the whole plan for every other roadmap and for plan mode. At the t
 every milestone that waits only for its rollup (Status not finished, every phase merged, and the same rule as
 `next`: no blocker, dependencies finished, Owner the runner); `--last-stop` says `rollup-ready:` for such a milestone,
 so recheck restarts the runner. A sweep rollup that writes nothing stops `BLOCKED rollup of <id> wrote nothing`
-(recorded, not restartable) and is not retried or reported until the roadmap changes. The dry run lists them first. If
+(recorded, not restartable) and is not retried or reported until the roadmap changes. A rollup that exits 3 (its
+exit check or Exit setup could not run) stops `BLOCKED rollup not run: <id> ...` (not restartable; the owner decides). The dry run lists them first. If
 the owner edits the roadmap during a merge wait, the restart stops `FAILED roadmap changed ...` and names the
 recovery: `roadmap-run.ps1 -Roadmap <slug> -AcceptRoadmap` (owner only, refused headless) takes the runner lock (a live
 runner refuses it), prints the diff from the published baseline, asks you to type `accept` (or `--yes`), and accepts

package/bundles/codex/.codex/skills/workflow/roadmap/assets/review-protocol.md

@@ -1,15 +1,15 @@
 ---
 type: reference
 title: Review protocol
-description: The review method one model can rely on - invariants, inputs and writers, shared state, execute what the change promises, tests, docs, then severity (only blocking stops the merge; each finding needs a reproduction), one FINDING line per finding and an END REVIEW line. caddis_review.py sends it to every review run.
+description: The review method one model can rely on - invariants, inputs and writers, shared state, check what the change promises, tests, docs, then severity (only blocking stops the merge; each finding needs a reproduction), one FINDING line per finding and an END REVIEW line. caddis_review.py sends it to every review run.
 status: current
 ---
 
 # Review protocol (generic, any diff)
 
-You review a diff. You do NOT edit, create or delete files, and you do not commit. You may read files and run commands
-(tests, dry runs, the commands that plans, cards and docs name). Work through ALL steps in order. Do not stop at the
-first finding. Include a short section per step, in order.
+You review a diff. You read only: you have Read, Grep and Glob and no shell, so you run no test and no command, and
+you do not edit, create or delete files. The diff is in the prompt. Tests are the implementer's and CI's job. Work
+through ALL steps in order. Do not stop at the first finding. Include a short section per step, in order.
 
 ## Step 1 - Purpose and invariants
 Read the card, the plan or design section it cites, and the diff. Write the list of INVARIANTS this change must keep:
@@ -26,12 +26,14 @@ accident or on purpose? This includes the agent or session the code is meant to
 List state that two runs, two kinds of target, or two processes could share (files, locks, relays, logs, caches).
 Can they collide? Can one read the other's output as its own?
 
-## Step 4 - Execute what the change promises
-Run the tests the card names. Then run every command that the plan, its exit gates, the docs or the skill text say
-should work for this change (dry runs, the documented usage lines), exactly as written. Use the repo's OWN fixtures
-and example files, not ones you build, and run unattended scripts (hooks, runners) as they are really run (as a script,
-with a real payload). Compare risky behaviour with the parent commit when the change claims to fix or tighten
-something. Report any that fail or that cannot work as documented.
+## Step 4 - Check what the change promises
+For every command that the plan, its exit gates, the docs or the skill text say should work for this change (the
+documented usage lines, exactly as written), follow it through the code by reading: the argument parsing, the paths it
+reads and writes, the repo's OWN fixtures and example files. Read unattended scripts (hooks, runners) as they are
+really run (as a script, with a real payload). Compare risky behaviour with the code before the change (the `-` lines
+of the diff) when the change claims to fix or tighten something. Report any that would fail or that cannot work as
+documented. For a check you cannot settle by reading, write one line `not executed: <command> (reviewer has no
+shell)`.
 
 ## Step 5 - Tests
 For each new or changed test: could it pass for the wrong reason (no assertion that can fail, mocked away the thing
@@ -52,9 +54,10 @@ Severity rule. Only **blocking** stops the merge, so use it with care:
   negative test, a doc that is wrong in a way that does not make a command fail, an error message that misleads.
 - **nit** = style and wording.
 
-Every finding needs a concrete reproduction: a command, an input or a test that shows the failure, written in the
-failure scenario. A finding without a reproduction is a **nit**, whatever its severity would otherwise be. Do not
-write "might", "could in theory" or "a future change may": show it or call it a nit.
+Every finding needs a concrete reproduction: a command, an input or a test that would show the failure, written in
+the failure scenario (you do not run it; the implementer does). A finding without a reproduction is a **nit**,
+whatever its severity would otherwise be. Do not write "might", "could in theory" or "a future change may": show it
+or call it a nit.
 
 The gate exits by the findings. A **blocking** finding fails it. **should-fix** and **nit** findings do not: they are
 listed in the report under "Follow-up (not blocking)". The tool allows 3 completed review rounds for a phase; the 4th completed round

package/bundles/manifest.json

@@ -1,8 +1,8 @@
 {
-  "poolVersion": "1.3.141",
+  "poolVersion": "1.3.142",
   "bundles": {
-    "antigravity-plugin": "1.3.141",
-    "antigravity-plugin-extras": "1.3.43",
+    "antigravity-plugin": "1.3.142",
+    "antigravity-plugin-extras": "1.3.44",
     "codex": "unknown"
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@caddis/cli",
-  "version": "0.4.55",
+  "version": "0.4.56",
   "description": "Install, update and diagnose the caddis dev harness across every coding agent you use (Claude Code, agy/Antigravity, and more).",
   "keywords": [
     "caddis",