@cabify/eslint-config 2.1.4 → 3.0.1-beta-2

package/CHANGELOG.md

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.1.4] - 2024-09-12
+
 - Fixing dependencies not published properly in `v2.1.3`.
 - Revert eslint-plugin-lodash version bump because it requires ESLint v9.
 

package/configs/base.js

@@ -1,52 +1,77 @@
+const globals = require('globals');
+
 const { isPackageAvailable } = require('../utils');
 
 const isTSAvailable = isPackageAvailable('typescript');
 const isJestAvailable = isPackageAvailable('jest');
 
+const storybook = require('./storybook');
+const ts = require('./ts');
+const postcss = require('./postcss');
+
+const bestPractices = require('./best-practices');
+const errors = require('./errors');
+const es6 = require('./es6');
+const imports = require('./imports');
+const node = require('./node');
+const promises = require('./promises');
+const strict = require('./strict');
+const style = require('./style');
+const variables = require('./variables');
+const react = require('./react');
+const lodash = require('./lodash');
+const reactA11y = require('./react-a11y');
+const jest = require('./jest');
+const formats = require('./formats');
+
 const configs = [
-  './best-practices',
-  './errors',
-  './es6',
-  './imports',
-  './node',
-  './promises',
-  './strict',
-  './style',
-  './variables',
-  './react',
-  './lodash',
-  './react-a11y',
-  isJestAvailable && './jest',
+  bestPractices,
+  errors,
+  es6,
+  imports,
+  node,
+  promises,
+  strict,
+  style,
+  variables,
+  react,
+  lodash,
+  reactA11y,
+  formats,
+  isJestAvailable && jest,
 ].filter(Boolean);
 
 const overrides = [
   isTSAvailable && {
     files: ['**/*.ts', '**/*.tsx'],
     excludedFiles: '*.d.ts',
-    extends: ['./ts'],
+    ...ts,
   },
   {
     files: ['*.story.tsx', '*.stories.tsx'],
-    extends: ['./storybook'],
+    ...storybook,
   },
   {
     files: ['postcss.config.js'],
-    extends: ['./postcss'],
+    ...postcss,
   },
 ].filter(Boolean);
 
-module.exports = {
-  env: {
-    browser: true,
-    node: true,
-  },
-  extends: configs,
-  parserOptions: {
-    ecmaVersion: 2018,
-    sourceType: 'module',
-  },
-  rules: {
-    strict: 'error',
+module.exports = [
+  ...configs,
+  {
+    name: 'base-cabify-eslint-config',
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: 'module',
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+      },
+    },
+    rules: {
+      strict: 'error',
+    },
   },
-  overrides,
-};
+  ...overrides,
+];

package/configs/best-practices.js

@@ -1,4 +1,5 @@
 module.exports = {
+  name: 'best-practices-cabify-eslint-config',
   rules: {
     // enforces getter/setter pairs in objects
     'accessor-pairs': 'off',

package/configs/errors.js

@@ -1,4 +1,5 @@
 module.exports = {
+  name: 'errors-cabify-eslint-config',
   rules: {
     // Enforce “for” loop update clause moving the counter in the right direction
     // https://eslint.org/docs/rules/for-direction

package/configs/es6.js

@@ -1,15 +1,18 @@
 module.exports = {
-  env: {
-    es6: true,
-  },
-  parserOptions: {
-    ecmaVersion: 6,
-    sourceType: 'module',
-    ecmaFeatures: {
-      generators: false,
-      objectLiteralDuplicateProperties: false,
-    },
-  },
+  name: 'ES6-cabify-eslint-config',
+  // languageOptions: {
+  //   globals: {
+  //     es6: true,
+  //   },
+  //   ecmaVersion: 6,
+  //   sourceType: 'module',
+  //   parserOptions: {
+  //     ecmaFeatures: {
+  //       generators: false,
+  //       objectLiteralDuplicateProperties: false,
+  //     },
+  //   },
+  // },
 
   rules: {
     // verify super() callings in constructors

package/configs/formats.js

@@ -0,0 +1,6 @@
+const eslintPluginPrettierRecommended = require('eslint-plugin-prettier/recommended');
+
+module.exports = {
+  name: 'formats-cabify-eslint-config',
+  ...eslintPluginPrettierRecommended,
+};

package/configs/imports.js

@@ -1,9 +1,17 @@
+const importPlugin = require('eslint-plugin-import');
+const simpleImportSort = require('eslint-plugin-simple-import-sort');
+
 module.exports = {
-  env: {
-    es6: true,
+  name: 'imports-cabify-eslint-config',
+  // languageOptions: {
+  //   globals: {
+  //     es6: true,
+  //   },
+  // },
+  plugins: {
+    import: importPlugin,
+    'simple-import-sort': simpleImportSort,
   },
-  plugins: ['import', 'simple-import-sort'],
-
   settings: {
     'import/resolver': {
       node: {
@@ -107,7 +115,7 @@ module.exports = {
 
     // disallow AMD require/define
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-amd.md
-    'import/no-amd': 'error',
+    // 'import/no-amd': 'error',
 
     // No Node.js builtin modules
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-nodejs-modules.md
@@ -155,7 +163,7 @@ module.exports = {
 
     // Require a newline after the last import/require in a group
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/newline-after-import.md
-    'import/newline-after-import': 'error',
+    // 'import/newline-after-import': 'error',
 
     // Require modules with a single export to use a default export
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md

package/configs/jest.js

@@ -1,5 +1,14 @@
+const jest = require('eslint-plugin-jest');
+
 module.exports = {
-  env: { 'jest/globals': true },
-  plugins: ['jest'],
-  extends: ['plugin:jest/recommended', 'plugin:jest/style'],
+  name: 'jest-cabify-eslint-config',
+  // languageOptions: {
+  //   globals: {
+  //     'jest/globals': true,
+  //   },
+  // },
+  rules: {
+    ...jest.configs['flat/recommended'],
+    ...jest.configs['flat/styles'],
+  },
 };

package/configs/lodash.js

@@ -1,6 +1,8 @@
-module.exports = {
-  plugins: ['lodash'],
+const lodashPlugin = require('eslint-plugin-lodash');
 
+module.exports = {
+  name: 'lodash-cabify-eslint-config',
+  plugins: { lodash: lodashPlugin },
   rules: {
     'lodash/import-scope': ['error', 'method'],
   },

package/configs/node.js

@@ -1,8 +1,5 @@
 module.exports = {
-  env: {
-    node: true,
-  },
-
+  name: 'node-cabify-eslint-config',
   rules: {
     // enforce return after a callback
     'callback-return': 'off',

package/configs/postcss.js

@@ -1,4 +1,5 @@
 module.exports = {
+  name: 'post-css-cabify-eslint-config',
   rules: {
     'global-require': 'off',
   },

package/configs/promises.js

@@ -1,4 +1,5 @@
 module.exports = {
+  name: 'promises-cabify-eslint-config',
   rules: {
     'no-floating-promises': 'off',
 

package/configs/react-a11y.js

@@ -1,11 +1,16 @@
-module.exports = {
-  plugins: ['jsx-a11y', 'react'],
+const jsxAllyPlugin = require('eslint-plugin-jsx-a11y');
 
-  parserOptions: {
-    ecmaFeatures: {
-      jsx: true,
-    },
-  },
+module.exports = {
+  name: 'react-a11y-cabify-eslint-config',
+  plugins: { 'jsx-a11y': jsxAllyPlugin },
+
+  // languageOptions: {
+  //   parserOptions: {
+  //     ecmaFeatures: {
+  //       jsx: true,
+  //     },
+  //   },
+  // },
 
   rules: {
     // Enforce that anchors have content

package/configs/react.js

@@ -1,9 +1,17 @@
-module.exports = {
-  plugins: ['react', 'react-hooks'],
+const react = require('eslint-plugin-react');
+const reactHooks = require('eslint-plugin-react-hooks');
 
-  parserOptions: {
-    ecmaFeatures: {
-      jsx: true,
+module.exports = {
+  name: 'react-cabify-eslint-config',
+  plugins: {
+    react,
+    'react-hooks': reactHooks,
+  },
+  languageOptions: {
+    parserOptions: {
+      ecmaFeatures: {
+        jsx: true,
+      },
     },
   },
 

package/configs/storybook.js

@@ -1,4 +1,5 @@
 module.exports = {
+  name: 'storybook-cabify-eslint-config',
   rules: {
     'import/no-default-export': 'off',
   },

package/configs/strict.js

@@ -1,4 +1,5 @@
 module.exports = {
+  name: 'strict-cabify-eslint-config',
   rules: {
     // babel inserts `'use strict';` for us
     strict: ['error', 'never'],

package/configs/style.js

@@ -1,4 +1,5 @@
 module.exports = {
+  name: 'style-cabify-eslint-config',
   rules: {
     // require camel case names
     // TODO: semver-major (eslint 5): add ignoreDestructuring: false option

package/configs/ts.js

@@ -1,4 +1,5 @@
 module.exports = {
+  name: 'ts-cabify-eslint-config',
   plugins: ['@typescript-eslint'],
   extends: [
     'plugin:@typescript-eslint/recommended',

package/configs/variables.js

@@ -1,6 +1,7 @@
 const confusingBrowserGlobals = require('confusing-browser-globals');
 
 module.exports = {
+  name: 'variables-cabify-eslint-config',
   rules: {
     // enforce or disallow variable initializations at definition
     'init-declarations': 'off',

package/eslint.config.js

@@ -0,0 +1,3 @@
+const recommended = require('./recommended');
+
+module.exports = [...recommended];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cabify/eslint-config",
-  "version": "2.1.4",
+  "version": "3.0.1-beta-2",
   "description": "ESLint config for Cabify Javascript projects",
   "scripts": {
     "build": "echo 'No build to perform'",
@@ -33,11 +33,9 @@
     "style",
     "standards"
   ],
-  "main": "./legacy.js",
+  "main": "../recommended.js",
   "exports": {
-    ".": "./legacy.js",
-    "./legacy": "./legacy.js",
-    "./recommended": "./recommended.js"
+    ".": "./recommended.js"
   },
   "dependencies": {
     "@typescript-eslint/eslint-plugin": "^8.4.0",
@@ -51,14 +49,15 @@
     "eslint-plugin-prettier": "^5.2.1",
     "eslint-plugin-react": "^7.36.0",
     "eslint-plugin-react-hooks": "^4.6.2",
-    "eslint-plugin-simple-import-sort": "^12.1.1"
+    "eslint-plugin-simple-import-sort": "^12.1.1",
+    "globals": "^15.9.0"
   },
   "peerDependencies": {
-    "eslint": ">= 8.0.1",
+    "eslint": "9.1.0",
     "prettier": ">= 2.2.1"
   },
   "devDependencies": {
-    "eslint": "8.57.0",
+    "eslint": "9.1.0",
     "prettier": "3.3.3"
   },
   "publishConfig": {

package/recommended.js

@@ -1,3 +1,4 @@
-module.exports = {
-  extends: ['./configs/base', 'prettier'],
-};
+const base = require('./configs/base');
+const eslintConfigPrettier = require('eslint-config-prettier');
+
+module.exports = [...base, eslintConfigPrettier];

package/utils.js

@@ -3,6 +3,7 @@ module.exports = {
     try {
       // eslint-disable-next-line global-require, import/no-dynamic-require
       return !!require(packageName);
+      // eslint-disable-next-line no-unused-vars
     } catch (e) {
       return false;
     }

package/.eslintrc.js

@@ -1,3 +0,0 @@
-module.exports = {
-  extends: ['./recommended.js'],
-};

package/configs/format.js

@@ -1,4 +0,0 @@
-module.exports = {
-  plugins: ['prettier'],
-  extends: ['plugin:prettier/recommended', 'prettier'],
-};

package/legacy.js

@@ -1,3 +0,0 @@
-module.exports = {
-  extends: ['./configs/base', './configs/format'],
-};