@c9up/rover 0.1.15 → 0.1.16

package/src/retry.ts

@@ -83,9 +83,18 @@ export function computeBackoffMs(
 	return Math.min(config.maxDelayMs, Math.max(50, raw));
 }
 
+/**
+ * Global and per-transport overrides, merged over the defaults.
+ *
+ * `Partial`, because that is what the function does: it spreads whatever it is
+ * given over {@link DEFAULT_RETRY_CONFIG}, so `{ maxAttempts: 1 }` is a
+ * complete answer. Declared as the full `RetryConfig`, a config file writing
+ * exactly that was a type error for doing the supported thing — and every
+ * caller had to spell `baseDelayMs` and `factor` it did not want to change.
+ */
 export function resolveRetryConfig(
-	globalConfig: RetryConfig | undefined,
-	transportConfig: RetryConfig | undefined,
+	globalConfig: Partial<RetryConfig> | undefined,
+	transportConfig: Partial<RetryConfig> | undefined,
 ): Required<RetryConfig> {
 	// Skip entries whose value is `undefined` so a partial override doesn't
 	// clobber a default or global value. Pre-spread filter is required because

package/src/testing/FakeMail.ts

@@ -1,4 +1,4 @@
-import type { Plugin } from "@c9up/helix";
+import type { PluginApi } from "@c9up/helix";
 import { BaseMail } from "../BaseMail.js";
 import type { MailMessage, MailSendOutcome, MailTransport } from "../Mail.js";
 
@@ -340,8 +340,17 @@ export interface FakeableMailer {
  * frame) and torn down when that test ends — so capture never leaks between
  * tests. Uses the manager's own `fake()`/`restore()` (the Adonis pattern).
  */
-export function mailFake(mailer: FakeableMailer): Plugin {
-	return (api) => {
+/** The slice of helix's `PluginApi` this plugin uses. */
+export type MailPluginHost = Pick<PluginApi, "context">;
+
+export function mailFake(
+	mailer: FakeableMailer,
+): (api: MailPluginHost) => void {
+	// Typed by what it touches, not by the whole `PluginApi`: a test wiring the
+	// plugin had to build every field of it — `config`, `cliArgs`, `runner`,
+	// `emitter`, `cleanup` — to exercise a function that reads one. Same shape
+	// `@c9up/helix-plugin-ream` uses for its own host.
+	return (api: MailPluginHost) => {
 		api.context.getter("mail", (ctx) => {
 			const fake = mailer.fake();
 			ctx.cleanup(() => mailer.restore());

package/src/transports/BrevoTransport.ts

@@ -165,9 +165,12 @@ export class BrevoTransport implements MailTransport {
 function parseContact(input: string): BrevoContact {
 	const s = stripCrlf(input).trim();
 	const match = s.match(/^(.*)<([^>]+)>\s*$/);
-	if (match) {
-		const email = match[2].trim();
-		const name = match[1].trim().replace(/^"|"$/g, "").trim();
+	// Both groups are required by the pattern, so a match carries both —
+	// named rather than indexed, which is what says so.
+	const [, rawName, rawEmail] = match ?? [];
+	if (rawEmail !== undefined) {
+		const email = rawEmail.trim();
+		const name = (rawName ?? "").trim().replace(/^"|"$/g, "").trim();
 		return name ? { email, name } : { email };
 	}
 	return { email: s };

package/src/transports/SparkPostTransport.ts

@@ -177,9 +177,12 @@ export class SparkPostTransport implements MailTransport {
 function parseAddress(input: string): { email: string; name?: string } {
 	const s = stripCrlf(input).trim();
 	const match = s.match(/^(.*)<([^>]+)>\s*$/);
-	if (match) {
-		const email = match[2].trim();
-		const name = match[1].trim().replace(/^"|"$/g, "").trim();
+	// Both groups are required by the pattern, so a match carries both —
+	// named rather than indexed, which is what says so.
+	const [, rawName, rawEmail] = match ?? [];
+	if (rawEmail !== undefined) {
+		const email = rawEmail.trim();
+		const name = (rawName ?? "").trim().replace(/^"|"$/g, "").trim();
 		return name ? { email, name } : { email };
 	}
 	return { email: s };

package/src/webhooks/context.ts

@@ -37,5 +37,13 @@ export type WebhookMiddleware = (
 ) => Promise<void>;
 
 export interface WebhookEmitter {
-	emit(event: string, data: unknown): void;
+	/**
+	 * `unknown`, not `void`. `@adonisjs/events` declares
+	 * `emit(): Promise<void>` and rethrows when a listener fails and no error
+	 * handler is registered — and a `void` return ACCEPTS a promise-returning
+	 * function, so the call site reads as if there were nothing to handle.
+	 * Duck-typed, so it stays wider than Adonis's own class: a Node
+	 * EventEmitter returns boolean.
+	 */
+	emit(event: string, data: unknown): unknown;
 }

package/src/webhooks/mailgun.ts

@@ -1,5 +1,6 @@
 import { Buffer } from "node:buffer";
 import { createHmac, timingSafeEqual } from "node:crypto";
+import { emitSafely } from "../emitSafely.js";
 import type {
 	WebhookEmitter,
 	WebhookHttpContext,
@@ -94,7 +95,7 @@ export function createMailgunWebhookHandler(
 		const eventName = EVENT_MAP[data.event];
 		if (eventName) {
 			try {
-				emitter.emit(eventName, {
+				emitSafely(emitter, eventName, {
 					messageId: data.message?.headers?.["message-id"] ?? "",
 					to: data.recipient ?? "",
 					reason: data.reason,

package/src/webhooks/resend.ts

@@ -1,5 +1,6 @@
 import { Buffer } from "node:buffer";
 import { createHmac, timingSafeEqual } from "node:crypto";
+import { emitSafely } from "../emitSafely.js";
 import type {
 	WebhookEmitter,
 	WebhookHttpContext,
@@ -176,7 +177,7 @@ function emitMappedEvent(
 		? (payload.data.to[0] ?? "")
 		: (payload.data?.to ?? "");
 	try {
-		emitter.emit(mapped, {
+		emitSafely(emitter, mapped, {
 			messageId: payload.data?.email_id ?? "",
 			to,
 			reason: payload.data?.reason,

package/src/webhooks/sendgrid.ts

@@ -1,5 +1,6 @@
 import { Buffer } from "node:buffer";
 import { createPublicKey, verify } from "node:crypto";
+import { emitSafely } from "../emitSafely.js";
 import type {
 	WebhookEmitter,
 	WebhookHttpContext,
@@ -101,7 +102,7 @@ export function createSendGridWebhookHandler(
 			const mapped = EVENT_MAP[ev.event];
 			if (!mapped) continue;
 			try {
-				emitter.emit(mapped, {
+				emitSafely(emitter, mapped, {
 					messageId: ev.sg_message_id ?? "",
 					to: ev.email ?? "",
 					reason: ev.reason,