@c9up/atom 0.1.11 → 0.1.12

package/src/index.ts

@@ -26,7 +26,11 @@ export type {
 	ToMinorUnitsOptions,
 } from "./Decimal.js";
 export { Decimal } from "./Decimal.js";
-export type { MoneyFormatOptions, MoneyOptions } from "./Money.js";
+export type {
+	MoneyFormatOptions,
+	MoneyOptions,
+	MoneyRoundingOptions,
+} from "./Money.js";
 export { Money, money } from "./Money.js";
 export { isNativeAvailable } from "./native.js";
 
@@ -46,13 +50,36 @@ function isDecimalIterable(value: unknown): value is Iterable<DecimalInput> {
 	);
 }
 
-function resolveValues(
-	args: [Iterable<DecimalInput>] | DecimalInput[],
-): Iterable<DecimalInput> {
-	if (args.length === 1 && isDecimalIterable(args[0])) {
-		return args[0] as Iterable<DecimalInput>;
-	}
-	return args as DecimalInput[];
+/**
+ * What every aggregate accepts as one value.
+ *
+ * The variadic form used to be asserted back into shape — a claim about the
+ * caller's arguments made in the one place that can check them. Anything else
+ * reached `new Decimal(...)`, where an object failed as
+ * `input.trim is not a function`, naming neither the argument nor the call.
+ */
+function isDecimalValue(value: unknown): value is DecimalInput {
+	return (
+		Decimal.isDecimal(value) ||
+		typeof value === "string" ||
+		typeof value === "number" ||
+		typeof value === "bigint"
+	);
+}
+
+function toDecimalValue(value: unknown): DecimalInput {
+	if (isDecimalValue(value)) return value;
+	throw new Error(
+		`Atom aggregates take a string, number, bigint or Decimal, got ${
+			value === null ? "null" : typeof value
+		}`,
+	);
+}
+
+function resolveValues(args: readonly unknown[]): Iterable<DecimalInput> {
+	const head = args[0];
+	if (args.length === 1 && isDecimalIterable(head)) return head;
+	return args.map(toDecimalValue);
 }
 
 function sumImpl(values: Iterable<DecimalInput>): Decimal {
@@ -77,25 +104,25 @@ function avgImpl(values: Iterable<DecimalInput>): Decimal {
 }
 
 function minImpl(values: Iterable<DecimalInput>): Decimal {
-	const list = [...values].map((value) => new Decimal(value));
-	if (list.length === 0) {
+	const [first, ...rest] = [...values].map((value) => new Decimal(value));
+	if (first === undefined) {
 		throw new Error("Atom.min requires at least one value");
 	}
-	let best = list[0];
-	for (let i = 1; i < list.length; i++) {
-		if (list[i].lt(best)) best = list[i];
+	let best = first;
+	for (const candidate of rest) {
+		if (candidate.lt(best)) best = candidate;
 	}
 	return best;
 }
 
 function maxImpl(values: Iterable<DecimalInput>): Decimal {
-	const list = [...values].map((value) => new Decimal(value));
-	if (list.length === 0) {
+	const [first, ...rest] = [...values].map((value) => new Decimal(value));
+	if (first === undefined) {
 		throw new Error("Atom.max requires at least one value");
 	}
-	let best = list[0];
-	for (let i = 1; i < list.length; i++) {
-		if (list[i].gt(best)) best = list[i];
+	let best = first;
+	for (const candidate of rest) {
+		if (candidate.gt(best)) best = candidate;
 	}
 	return best;
 }
@@ -110,9 +137,14 @@ function medianImpl(
 	}
 	list.sort((a, b) => a.cmp(b));
 	const mid = Math.floor(list.length / 2);
-	if (list.length % 2 === 1) return list[mid];
+	// The empty case threw above, so both halves of the middle are present.
+	const upper = list[mid];
+	if (upper === undefined) throw new Error("Atom.median lost its middle value");
+	if (list.length % 2 === 1) return upper;
+	const lower = list[mid - 1];
+	if (lower === undefined) throw new Error("Atom.median lost its middle value");
 	const precision = options.precision ?? defaultPrecision();
-	return list[mid - 1].plus(list[mid]).div("2", { precision });
+	return lower.plus(upper).div("2", { precision });
 }
 
 function modeImpl(values: Iterable<DecimalInput>): Decimal[] {
@@ -162,32 +194,39 @@ function stddevImpl(
 	return variance.sqrt({ precision, mode });
 }
 
+/**
+ * The trailing options object of `median(values, options)` / `stddev(values,
+ * options)`, or `{}`.
+ *
+ * A `Decimal` is an object too, so excluding it is what lets the compiler
+ * check the narrowing instead of being told the answer.
+ */
+function optionsFrom<T extends MedianOptions | StddevOptions>(
+	value: DecimalInput | T | undefined,
+): T | Record<string, never> {
+	if (typeof value !== "object" || value === null) return {};
+	if (Decimal.isDecimal(value)) return {};
+	return value;
+}
+
 function parseMedianArgs(
 	args: [Iterable<DecimalInput>, MedianOptions?] | DecimalInput[],
 ): { values: Iterable<DecimalInput>; options: MedianOptions } {
-	if (args.length >= 1 && isDecimalIterable(args[0])) {
-		const values = args[0] as Iterable<DecimalInput>;
-		const options =
-			args.length > 1 && typeof args[1] === "object" && args[1] !== null
-				? (args[1] as MedianOptions)
-				: {};
-		return { values, options };
+	const head = args[0];
+	if (isDecimalIterable(head)) {
+		return { values: head, options: optionsFrom<MedianOptions>(args[1]) };
 	}
-	return { values: args as DecimalInput[], options: {} };
+	return { values: resolveValues(args), options: {} };
 }
 
 function parseStddevArgs(
 	args: [Iterable<DecimalInput>, StddevOptions?] | DecimalInput[],
 ): { values: Iterable<DecimalInput>; options: StddevOptions } {
-	if (args.length >= 1 && isDecimalIterable(args[0])) {
-		const values = args[0] as Iterable<DecimalInput>;
-		const options =
-			args.length > 1 && typeof args[1] === "object" && args[1] !== null
-				? (args[1] as StddevOptions)
-				: {};
-		return { values, options };
+	const head = args[0];
+	if (isDecimalIterable(head)) {
+		return { values: head, options: optionsFrom<StddevOptions>(args[1]) };
 	}
-	return { values: args as DecimalInput[], options: {} };
+	return { values: resolveValues(args), options: {} };
 }
 
 function sumFn(...args: [Iterable<DecimalInput>] | DecimalInput[]): Decimal {