@byu-oit/vue-decision-processing-components 8.35.13 → 8.36.0

package/DetailsCesHold.vue

@@ -64,8 +64,8 @@
       ...mapState({
         env: 'environment',
         applicantId: state => state.application.applicantId,
-        applicantFirstName: state => state.application.preferredFirstName,
-        applicantSurname: state => state.application.surname,
+        applicantFirstName: state => state.application.basic.preferredFirstName,
+        applicantSurname: state => state.application.basic.surname,
         applicantDob: state => state.application.personalRecords.dateOfBirth
       }),
       spinner () { return faSpinner },
@@ -76,12 +76,12 @@
     methods: {
       getByuId: async function () {
         try {
-          const surname = this.applicantSurname
-          const preferredFirstName = this.applicantFirstName
-          const applicantDob = new Date(this.applicantDob).toISOString().split('T')[0].trim()
+          const surname = this.applicantSurname ? this.applicantSurname.trim() : ''
+          const preferredFirstName = this.applicantFirstName ? this.applicantFirstName.trim() : ''
+          const applicantDob = this.applicantDob ? new Date(this.applicantDob).toISOString().split('T')[0].trim() : ''
           const url = this.env === 'production'
-              ? `https://api.byu.edu/byuapi/persons/v4/?preferred_first_name=${preferredFirstName.trim()}&surname=${surname.trim()}&vital_record.date_of_birth=${applicantDob.trim()}`
-              : `https://api-sandbox.byu.edu/byuapi/persons/v4/?preferred_first_name=${preferredFirstName.trim()}&surname=${surname.trim()}&vital_record.date_of_birth=${applicantDob.trim()}`
+              ? `https://api.byu.edu/byuapi/persons/v4/?preferred_first_name=${preferredFirstName}&surname=${surname}&vital_record.date_of_birth=${applicantDob}`
+              : `https://api-sandbox.byu.edu/byuapi/persons/v4/?preferred_first_name=${preferredFirstName}&surname=${surname}&vital_record.date_of_birth=${applicantDob}`
 
           const { body, status } = await window.byu.auth.request({ url })
           if (status >= 400) {

package/README.md

@@ -1,2 +1,24 @@
 # vue-decision-processing-components
+
+## Overview
 Vue.js components to be shared between the decision processing applications for the various CES Schools.
+
+## How to Use This
+
+- All Decision Processing Clients use various components from this npm package.
+
+## How to Build Locally
+
+- Currently no way to run/build locally
+- installation: npm install @byu-oit/vue-decision-processing-components
+
+## How to Publish
+- Bump version number in [package.json](./package.json#L3) using the following command in bash
+    - `npm version [patch|minor|major]`
+    - then change the commit message to follow the conventional commit message standard `git commit --amend` to something like `chore: bump version x.y.z`
+    This automatically creates a git tag if you run `git push --follow-tags` (which labels commits with the exact version that was published to npm).
+- PR to main
+- GHA publishes to npm
+
+## How to Test
+- vue-decision-processing-components can be tested by making changes to node modules in any decision-processing client and then copied to this repo to push the changes to prd.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@byu-oit/vue-decision-processing-components",
-  "version": "8.35.13",
+  "version": "8.36.0",
   "description": "Vue components shared between decision processing systems for the CES schools.",
   "dependencies": {
     "@fortawesome/fontawesome-free": "^5.15.4",

package/parsers/packetList.js

@@ -40,7 +40,6 @@ const parseTotal = json => {
 
 const parseStats = json => {
   const stats = get(json, 'stats', [])
-  console.log(`api/packetList::parseStats::stats=${JSON.stringify(stats)}`)
   const admitPeriods = stats.map(s => s.key).filter(s => /^[0-9]{5}$/.test(s))
   return stats.reduce((acc, curr) => {
     const { key, value } = curr
@@ -52,6 +51,5 @@ export default (json) => {
   const data = parseValues(json)
   const total = parseTotal(json)
   const stats = parseStats(json)
-  console.log(`api/packetList::parseResponse::stats=${JSON.stringify(stats)}`)
   return { data, total, stats }
 }

package/vuexModules/users/index.js

@@ -24,7 +24,6 @@ export const getters = {
 
 export const mutations = {
   setUsers (state, { users = [] }) {
-    console.log(`store::users::setUsers::users=${JSON.stringify(users)}`)
     state.list = users
   },
   setUserAssignmentCount (state, { byuId, count }) {