@byu-oit/vue-decision-processing-components 8.27.3 → 8.27.4

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [8.27.4](https://github.com/byu-oit/vue-decision-processing-components/compare/v8.27.3...v8.27.4) (2022-07-13)
+
+
+### Bug Fixes
+
+* sorting of test scores (was comparing strings instead of dates) ([308fb72](https://github.com/byu-oit/vue-decision-processing-components/commit/308fb728f1a5eb525472d2e438d5ddd787f09771))
+
 ### [8.27.3](https://github.com/byu-oit/vue-decision-processing-components/compare/v8.27.2...v8.27.3) (2022-06-29)
 
 ### [8.27.2](https://github.com/byu-oit/vue-decision-processing-components/compare/v8.27.1...v8.27.2) (2022-06-24)

package/DetailsTestScores.vue

@@ -69,6 +69,15 @@ import { mapGetters } from 'vuex'
 import { dateFormat } from './dateTimeFormat'
 import { sat2ActFilter } from './sat2Act'
 
+function yearMonth2Date (yearMonth) {
+  if (!/^[0-9]{4}-[0-9]{2}$/.test(yearMonth)) {
+    return yearMonth
+  }
+  const year = yearMonth.slice(0, 4)
+  const month = yearMonth.slice(5, 7)
+  return new Date(year, parseInt(month) - 1)
+}
+
 export default {
   name: 'DetailsTestScores',
   computed: {
@@ -76,10 +85,14 @@ export default {
 
     orderedTestScores() {
       // sort test scores by test date
-      const scores = this.testScores.sort((a, b) => {
-        if (!a.testDate) return 1
-        if (a.testDate > b.testDate) return 1
-        else return 0
+      const scores = this.testScores.slice().sort((a, b) => {
+        const dt1 = yearMonth2Date(a.testDate)
+        const dt2 = yearMonth2Date(b.testDate)
+        if (!dt1 instanceof Date && !dt2 instanceof Date) return 0
+        if (!dt1 instanceof Date) return 1
+        if (!dt2 instanceof Date) return -1
+
+        return dt1 < dt2 ? 1 : -1
       })
 
       // sort 'reading' before 'listening' for TOEFL test

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@byu-oit/vue-decision-processing-components",
-  "version": "8.27.3",
+  "version": "8.27.4",
   "description": "Vue components shared between decision processing systems for the CES schools.",
   "dependencies": {
     "@fortawesome/fontawesome-free": "^5.15.4",