@bytebrand/export-cars 1.9.0 → 1.10.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.9.0",
+  "version": "1.10.1",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",
@@ -21,12 +21,10 @@
     "@bytebrand/car-schema": "^3.12.24",
     "@bytebrand/chunkable": "^5.13.2",
     "@bytebrand/cronicle-helper": "^1.15.1",
-    "@bytebrand/fe-financing": "^5.4.3",
     "@bytebrand/i18n-dictionaries": "^1.4.2",
     "@bytebrand/import-helper": "^0.35.1",
     "@bytebrand/schema-tools": "^3.13.24",
     "@bytebrand/zipper": "^2.1.1",
-    "@nestjs/axios": "^0.1.0",
     "@nestjs/common": "^9.0.0",
     "@nestjs/core": "^9.0.0",
     "bottleneck": "^2.19.5",
@@ -36,12 +34,8 @@
     "lodash": "^4.17.21",
     "moment": "^2.29.4",
     "nest-commander": "^3.1.0",
-    "nest-winston": "^1.8.0",
     "reflect-metadata": "^0.1.13",
-    "rimraf": "^3.0.2",
-    "rxjs": "^7.2.0",
-    "vin-generator": "^1.0.1",
-    "winston": "^3.8.2"
+    "vin-generator": "^1.0.1"
   },
   "devDependencies": {
     "@nestjs/cli": "^9.0.0",
@@ -66,5 +60,5 @@
   "engines": {
     "node": ">=14.0.0"
   },
-  "gitHead": "16478e91b8dadf07e870437edeef4a0e82ca6627"
+  "gitHead": "b3581108ff2e4747c41c6c69facbd8a599051940"
 }

package/src/configs/alleskralle.config.ts

@@ -1,12 +1,13 @@
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
-import { ExportType, FileType } from '../enums';
+import { ExportType, FileType, ImageType } from '../enums';
 
 export class AlleskralleConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.campaign = ExportType.ALLESKRALLE;
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.ALLESKRALLE}-export`;
+    this.imageType = ImageType.default;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.ALLESKRALLE}.${FileType.XML}`,
     ];

package/src/configs/as24.config.ts

@@ -1,4 +1,4 @@
-import { ExportType } from 'src/enums';
+import { ExportType, ImageType } from 'src/enums';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -6,6 +6,7 @@ export class As24Config extends Config {
   constructor(params: Params) {
     super(params);
     this.campaign = ExportType.AS24;
+    this.imageType = ImageType.default;
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.AS24}-export`;
     this.mappingSpreadsheetTitle = 'mobile';
   }

package/src/configs/auto24.config.ts

@@ -1,11 +1,12 @@
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
-import { ExportType, FileType } from '../enums';
+import { ExportType, FileType, ImageType } from '../enums';
 
 export class Auto24Config extends Config {
   constructor(params: Params) {
     super(params);
     this.campaign = ExportType.AUTO24;
+    this.imageType = ImageType.default;
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.AUTO24}-export`;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.AUTO24}.${FileType.XML}`,

package/src/configs/autoboerse.config.ts

@@ -1,4 +1,4 @@
-import { ExportType, FileType } from 'src/enums';
+import { ExportType, FileType, ImageType } from 'src/enums';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -7,7 +7,7 @@ export class AutoboerseConfig extends Config {
     super(params);
     this.campaign = ExportType.AUTOBOERSE;
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.AUTOBOERSE}-export`;
-
+    this.imageType = ImageType.default;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.AUTOBOERSE}.${FileType.XML}`,
     ];

package/src/configs/autouncle.config.ts

@@ -1,4 +1,4 @@
-import { ExportType, FileType } from 'src/enums';
+import { ExportType, FileType, ImageType } from 'src/enums';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -6,6 +6,7 @@ export class AutouncleConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.AUTOUNCLE}-export`;
+    this.imageType = ImageType.default;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.AUTOUNCLE}.${FileType.JSON}`,
     ];

package/src/configs/by-owner.config.ts

@@ -1,13 +1,14 @@
-import { ExportType } from 'src/enums';
+import { ExportType, ImageType } from 'src/enums';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
 /**
-* @deprecated
-*/
+ * @deprecated
+ */
 export class ByOwnerConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.BY_OWNER}-export`;
+    this.imageType = ImageType.default;
   }
 }

package/src/configs/config.ts

@@ -5,6 +5,7 @@ export class Config {
   apikey: string;
   campaign: string;
   userActionsUrl: string;
+  marketingImageConfigId: number;
   upaUrl: string;
   imboUrl: string;
   imageUrl: string;
@@ -12,7 +13,6 @@ export class Config {
   imageType: ImageType;
   isNewCar: boolean;
   isCriteo: boolean;
-  criteoMarketingImagesConfigId: number;
   exportType: ExportType;
   domain: string;
   input: {
@@ -33,16 +33,9 @@ export class Config {
   dealersSpreadsheetTitle: string;
 
   protected environmentConfig = {
-    [Environment.LOCAL]: {
-      domain: 'autode-dev.de',
-      criteoMarketingImagesConfigId: 12,
-      localConvertedDirectory: 'resources/csv_dev',
-      remoteDirectory: 'import_dev',
-      imageUrl: 'https://images.autode-dev.de/cache_test',
-      baseImageUrl: 'https://images.autode-dev.de',
-    },
     [Environment.DEVELOP]: {
       domain: 'autode-dev.de',
+      fbMarketingImageId: 8,
       criteoMarketingImagesConfigId: 12,
       localConvertedDirectory: 'resources/csv_dev',
       remoteDirectory: 'import_dev',
@@ -51,6 +44,7 @@ export class Config {
     },
     [Environment.PRODUCTION]: {
       domain: 'auto.de',
+      fbMarketingImageId: 1,
       criteoMarketingImagesConfigId: 3,
       localConvertedDirectory: 'resources/csv_prod',
       remoteDirectory: 'import',
@@ -63,7 +57,6 @@ export class Config {
     this.apikey = params.apikey;
     this.exportType = params.exportType;
     this.cpc = params.cpc;
-    this.criteoMarketingImagesConfigId = this.environmentConfig[params.environment].criteoMarketingImagesConfigId;
     this.domain = this.environmentConfig[params.environment].domain;
     this.baseImageUrl = this.environmentConfig[params.environment].baseImageUrl;
     this.mappingSpreadsheetId = '147qz9sTgs1wi13ua8YKa0IgfxAn1X_qH6LkGnAnzeyY';

package/src/configs/criteo.config.ts

@@ -8,6 +8,7 @@ export class CriteoConfig extends Config {
     this.campaign = ExportType.CRITEO;
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.CRITEO}-export`;
     this.imageType = ImageType.marketing;
+    this.marketingImageConfigId = this.environmentConfig[params.environment].criteoMarketingImagesConfigId;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.CRITEO}.${FileType.XML}`,
     ];

package/src/configs/dasparking.config.ts

@@ -1,12 +1,13 @@
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
-import { ExportType, FileType } from '../enums';
+import { ExportType, FileType, ImageType } from '../enums';
 
 export class DasparkingConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.DASPARKING}-export`;
     this.campaign = ExportType.DASPARKING;
+    this.imageType = ImageType.default;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.DASPARKING}.${FileType.XML}`,
     ];

package/src/configs/eauto.config.ts

@@ -1,4 +1,4 @@
-import { ExportType, FileType } from 'src/enums';
+import { ExportType, FileType, ImageType } from 'src/enums';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -9,8 +9,7 @@ export class EautoConfig extends Config {
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.EAUTO}-export`;
     this.imageUrl = `https://images.${this.domain}/carimage`;
     this.mappingSpreadsheetTitle = 'mobile_yescar';
-    this.outputFiles = [
-      `${this.pathesConfig.localConvertedDirectory}/416.${FileType.CSV}`
-    ]
+    this.imageType = ImageType.default;
+    this.outputFiles = [`${this.pathesConfig.localConvertedDirectory}/416.${FileType.CSV}`];
   }
 }

package/src/configs/facebook-shop.config.ts

@@ -1,12 +1,14 @@
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
-import { ExportType, FileType } from '../enums';
+import { ExportType, FileType, ImageType } from '../enums';
 
 export class FacebookShopConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.FACEBOOK_SHOP}-export`;
     this.imageUrl = this.environmentConfig[params.environment].baseImageUrl;
+    this.imageType = ImageType.marketing;
+    this.marketingImageConfigId = this.environmentConfig[params.environment].fbMarketingImageId;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.FACEBOOK_SHOP}.${FileType.XML}`,
     ];

package/src/configs/fb.config.ts

@@ -1,4 +1,4 @@
-import { ExportType, FileType } from 'src/enums';
+import { ExportType, FileType, ImageType } from 'src/enums';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -7,8 +7,10 @@ export class FbConfig extends Config {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.FB}-export`;
     this.imageUrl = this.environmentConfig[params.environment].imageUrl;
+    this.imageType = ImageType.marketing;
+    this.marketingImageConfigId = this.environmentConfig[params.environment].fbMarketingImageId;
     this.outputFiles = [
-      `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.FB}.${FileType.XML}`
+      `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.FB}.${FileType.XML}`,
     ];
   }
 }

package/src/configs/google.config.ts

@@ -1,4 +1,4 @@
-import { ExportType, FileType } from 'src/enums';
+import { ExportType, FileType, ImageType } from 'src/enums';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -6,8 +6,9 @@ export class GoogleConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.GOOGLE}-export`;
+    this.imageType = ImageType.default;
     this.outputFiles = [
-      `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.GOOGLE}.${FileType.XML}`
+      `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.GOOGLE}.${FileType.XML}`,
     ];
   }
 }

package/src/configs/marktde.config.ts

@@ -1,4 +1,4 @@
-import { ExportType, FileType } from 'src/enums';
+import { ExportType, FileType, ImageType } from 'src/enums';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -9,9 +9,10 @@ export class MarktdeConfig extends Config {
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.MARKTDE}-export`;
     this.imageUrl = `https://images.${this.domain}/carimage`;
     this.mappingSpreadsheetTitle = 'mobile_yescar';
+    this.imageType = ImageType.default;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.MARKTDE}.${FileType.CSV}`,
-      `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.MARKTDE}.${FileType.ZIP}`
-    ]
+      `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.MARKTDE}.${FileType.ZIP}`,
+    ];
   }
 }

package/src/configs/meinstadt.config.ts

@@ -1,11 +1,12 @@
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
-import { ExportType, FileType } from '../enums';
+import { ExportType, FileType, ImageType } from '../enums';
 
 export class MeinstadtConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.MEINSTADT}-export`;
+    this.imageType = ImageType.default;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.MEINSTADT}.${FileType.JSON}`,
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.MEINSTADT}.${FileType.ZIP}`,

package/src/configs/yescar.config.ts

@@ -1,4 +1,4 @@
-import { ExportType } from 'src/enums';
+import { ExportType, ImageType } from 'src/enums';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -12,5 +12,6 @@ export class YescarConfig extends Config {
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.YESCAR}-export`;
     this.imageUrl = `https://images.${this.domain}/carimage`;
     this.mappingSpreadsheetTitle = 'mobile_yescar';
+    this.imageType = ImageType.default;
   }
 }

package/src/export.command.ts

@@ -1,6 +1,6 @@
 import { createInterface } from 'readline';
-import { Command, CommandRunner, InquirerService } from 'nest-commander';
-import { ConfigService } from './services/config.service';
+import { Command, CommandRunner } from 'nest-commander';
+import { ConfigService } from './services';
 import { Input } from './interfaces/input.interface';
 import { exportSchema } from './export.schema';
 import { ModuleRef } from '@nestjs/core';
@@ -13,7 +13,6 @@ import { LoggerService } from '@bytebrand/cronicle-helper';
 })
 export class ExportRunner extends CommandRunner {
   constructor(
-    private readonly inquirer: InquirerService,
     private configService: ConfigService,
     private moduleRef: ModuleRef,
   ) {

package/src/exporters/autouncle.exporter.ts

@@ -19,7 +19,7 @@ export class AutouncleExporter implements Exporter {
     private loaderService: LoaderService,
     private rulesService: RulesService,
     private moduleRef: ModuleRef,
-  ) { }
+  ) {}
 
   async export(): Promise<void> {
     const [fileName] = this.configService.config.outputFiles;
@@ -28,12 +28,12 @@ export class AutouncleExporter implements Exporter {
 
     const autouncleJsonBuilder = new AutouncleJsonBuilder(fileName);
     await autouncleJsonBuilder.buildStart();
-    
+
     const autouncleTransformer = await this.moduleRef.create(AutouncleTransformer);
 
     let firstCar = true;
     await this.loaderService.process(async (chunk: FsChunkInterface) => {
-      chunk.data = chunk.data.filter(e => this.carService.filterCar(e, this.rulesService.rules));
+      // chunk.data = chunk.data.filter(e => this.carService.filterCar(e, this.rulesService.rules));
 
       for (const data of chunk.data) {
         const ownerId = get(data.car, 'metaData.ownerId');
@@ -43,8 +43,10 @@ export class AutouncleExporter implements Exporter {
         await autouncleJsonBuilder.addItem(car, firstCar);
 
         this.carService.counter.countCar(data.images);
-        
-        if (firstCar) { firstCar = false; }
+
+        if (firstCar) {
+          firstCar = false;
+        }
       }
     });
 

package/src/exporters/fb.exporter.ts

@@ -30,9 +30,9 @@ export class FbExporter implements Exporter {
     const fbTransformer = await this.moduleRef.create(FbTransformer);
 
     await this.loaderService.process(async (chunk: FsChunkInterface) => {
-      // const chunkData = chunk.data.filter(car => this.carService.filterCar(car, this.rulesService.rules));
-      // chunk.data = null;
-      for (const data of chunk.data) {
+      const chunkData = chunk.data.filter(car => this.carService.filterCar(car, this.rulesService.rules));
+      chunk.data = null;
+      for (const data of chunkData) {
         const ownerId = get(data.car, 'metaData.ownerId', null);
         const owner = await this.carService.getOwner(ownerId);
         const car = await fbTransformer.transform({ owner, ...data });

package/src/exporters/meinstadt.exporter.ts

@@ -8,7 +8,7 @@ import { Zipper } from '@bytebrand/zipper';
 import { CarService, RulesService, LoaderService, ConfigService } from '../services';
 import { MeinstadtTransformer } from '../transformers/meinstadt.transformer';
 import { MeinstadtJsonBuilder } from '../formats/meinstadt-json.builder';
-import { MeinstadtJsonItem } from '../interfaces/export-item.interface';
+import { MeinstadtJsonItem } from '../interfaces';
 import { Exporter } from '../interfaces/exporter.interface';
 
 @Injectable()
@@ -19,7 +19,7 @@ export class MeinstadtExporter implements Exporter {
     private rulesService: RulesService,
     private loaderService: LoaderService,
     private moduleRef: ModuleRef,
-  ) { }
+  ) {}
 
   async export(): Promise<void> {
     const [fileJson, fileGZ] = this.configService.config.outputFiles;
@@ -33,14 +33,16 @@ export class MeinstadtExporter implements Exporter {
 
     let firstCar = true;
     await this.loaderService.process(async (chunk: FsChunkInterface) => {
-      chunk.data = chunk.data.filter(e => this.carService.filterCar(e, this.rulesService.rules));
+      // chunk.data = chunk.data.filter(e => this.carService.filterCar(e, this.rulesService.rules));
 
       for (const data of chunk.data) {
         const car = await meinstadtTransformer.transform({ ...data });
         await meinstadtJsonBuilder.addItem(car as MeinstadtJsonItem, firstCar);
         this.carService.counter.countCar(data.images);
 
-        if (firstCar) { firstCar = false; }
+        if (firstCar) {
+          firstCar = false;
+        }
       }
     });
 

package/src/interfaces/export-item.interface.ts

@@ -56,6 +56,11 @@ export interface Auto24XmlItem {
   companyname: string;
   extras: string;
   sellertype: string;
+  condition: string;
+  dealer_homepage_url: string;
+  dealer_email: string;
+  dealer_name: string;
+  dealer_phone: string;
 }
 
 export interface OoyyoXmlItem extends FbXmlItem {

package/src/services/images.service.ts

@@ -1,17 +1,20 @@
+import { get, toString } from 'lodash';
+
 import { Injectable } from '@nestjs/common';
-import { DataSchemes } from '@bytebrand/car-schema';
+
+import { MarketingImageConfigsInterface } from '@bytebrand/autode-request';
 import { ImboImageResponseInterface } from '@bytebrand/chunkable';
-import { get, toString } from 'lodash';
+import { DataSchemes } from '@bytebrand/car-schema';
+
+import { FB_MAX_IMAGE_COUNT_FOR_DEAFULT } from '../constants/fb.constants';
 import { isNotEmptyArray } from '../utils/validator.utils';
 import { ConfigService } from './config.service';
-import { ImageType } from '../enums';
-import { MarketingImageConfigInterface, MarketingImageConfigsInterface } from '@bytebrand/autode-request';
 import { UserService } from './user.service';
-import { FB_MAX_IMAGE_COUNT_FOR_DEAFULT } from '../constants/fb.constants';
+import { ImageType } from '../enums';
 
 @Injectable()
 export class ImagesService {
-  constructor(private readonly configService: ConfigService, private readonly userService: UserService) {}
+  constructor(private readonly configService: ConfigService, private readonly userService: UserService) { }
 
   async getImages(
     car: DataSchemes.Car,
@@ -74,7 +77,7 @@ export class ImagesService {
 
     const carId = toString(get(car, '_id', ''));
 
-    const transformedImages = this.generateImageLinks(images, carId);
+    const transformedImages = this.generateImageLinks(images.filter(i => i), carId);
     if (transformedImages.length < 17) {
       transformedImages.push(...defaultImages);
     }
@@ -90,16 +93,15 @@ export class ImagesService {
   async getMarketingImages(images: any, carId: string): Promise<string[]> {
     const imageUrl = this.configService.config.imageUrl;
     const transformedImages = this.transformImagesArrayIntoObject(images);
-    const configs = this.configService.config.isCriteo
-      ? await this.userService.getMarketingImageConfig(this.configService.config.criteoMarketingImagesConfigId)
-      : ((await this.getMarketingImageConfigs()) as any);
-    const marketingImageConfigs = this.transform(configs);
+
+    const config = await this.userService.getMarketingImageConfig(this.configService.config.marketingImageConfigId);
+    const marketingImageConfigs = config.marketingImages.map(i => ({ marketingImageCodes: i.imageCodes }));
 
     const defImages = [
-      { url: 'https://images.auto.de/carimage/noimage/7pNvWELuWhZX/large-cached.jpeg' },
-      { url: 'https://images.auto.de/carimage/noimage/GvyXmrpaf1D6/large-cached.jpeg' },
-      { url: 'https://images.auto.de/carimage/noimage/gY1zF8PXzH2W/large-cached.jpeg' },
-      { url: 'https://images.auto.de/carimage/noimage/pFyfBsqBHEso/large-cached.jpeg' },
+      'https://images.auto.de/carimage/noimage/7pNvWELuWhZX/large-cached.jpeg',
+      'https://images.auto.de/carimage/noimage/GvyXmrpaf1D6/large-cached.jpeg',
+      'https://images.auto.de/carimage/noimage/gY1zF8PXzH2W/large-cached.jpeg',
+      'https://images.auto.de/carimage/noimage/pFyfBsqBHEso/large-cached.jpeg',
     ];
 
     const imageUrls = [];
@@ -110,7 +112,7 @@ export class ImagesService {
         const imageCode = marketingImage.marketingImageCodes[i];
         const imageId = transformedImages[imageCode];
         if (imageId) {
-          imageUrls.push(this.getImagePathWithExtenstion(imageUrl, carId, imageId, configs));
+          imageUrls.push(this.getImagePathWithExtenstion(imageUrl, carId, imageId, config));
           break;
         }
       }
@@ -121,13 +123,6 @@ export class ImagesService {
     return imageUrls;
   }
 
-  async getMarketingImageConfigs(): Promise<MarketingImageConfigsInterface> {
-    const configs = await this.userService.getMarketingImageConfigs();
-    const { id } = configs.find(config => config.channelCode.includes(this.configService.config.exportType));
-
-    return this.userService.getMarketingImageConfig(id);
-  }
-
   private transformImagesArrayIntoObject(images: { [imageCode: string]: string }[]) {
     const result: { [imageCode: string]: string } = {};
     images.forEach(image => {
@@ -137,14 +132,6 @@ export class ImagesService {
     return result;
   }
 
-  private transform(config: MarketingImageConfigInterface): { marketingImageCodes: string[] }[] {
-    return config.marketingImages.map(marketingImage => {
-      return {
-        marketingImageCodes: marketingImage.imageCodes,
-      };
-    });
-  }
-
   protected getChannelPath(imageUrl: string, carId: string): string {
     return `${imageUrl}/${[carId[0], carId[1], carId[2], carId].join('/')}`;
   }

package/src/transformers/as24.transformer.ts

@@ -1,11 +1,10 @@
 import { get, isEmpty, isNil, set, toNumber, toSafeInteger, upperFirst } from 'lodash';
 import { DataSchemes } from '@bytebrand/car-schema';
 import { CarDescriptionFactory, DescriptionTypeEnum } from '@bytebrand/car-description';
-import { MappingService } from '../services/mapping.service';
+import { MappingService, UserService } from '../services';
 import { MappingRules } from '../interfaces/mapping-rules.interface';
 import { Injectable } from '@nestjs/common';
 import { LoggerService } from '@bytebrand/cronicle-helper';
-import { UserService } from '../services';
 
 @Injectable()
 export class As24Transformer {
@@ -114,7 +113,7 @@ export class As24Transformer {
 
   protected numberToNumber(field: number): number {
     const result = isNil(field) ? null : toNumber(field);
-    return (result < 0 || isNaN(result)) ? undefined : result;
+    return result < 0 || isNaN(result) ? undefined : result;
   }
 
   protected numberToInteger(field: number): number {

package/src/transformers/auto24.transfomer.ts

@@ -8,7 +8,6 @@ import { Auto24XmlItem } from '../interfaces';
 import { Injectable } from '@nestjs/common';
 import { ConfigService, ImagesService } from '../services';
 import { isNotEmptyArray } from '../utils/validator.utils';
-import { ImageType } from '../enums';
 
 @Injectable()
 export class Auto24Transformer {
@@ -20,7 +19,7 @@ export class Auto24Transformer {
 
   async transform(car: DataSchemes.Car, imboImages: ImboImageResponseInterface[]): Promise<Auto24XmlItem> {
     const carId = toString(get(car, '_id', ''));
-    const transformedImages = await this.imageService.getImages(car, imboImages, ImageType.default);
+    const transformedImages = await this.imageService.getImages(car, imboImages, this.configService.config.imageType);
     let userlink = `https://www.${this.configService.config.domain}/search/vehicle/${carId}`;
     if (this.configService.config.campaign) {
       userlink += `?source=classifieds&medium=listing&campaign=${this.configService.config.campaign}`;
@@ -49,6 +48,11 @@ export class Auto24Transformer {
       companyname: 'www.auto.de',
       extras: this.getExtrasField(car),
       sellertype: 'dealer',
+      condition: this.getCondition(car),
+      dealer_homepage_url: 'https://www.auto.de',
+      dealer_email: ' auto@auto.de',
+      dealer_name: ' Auto.de',
+      dealer_phone: '+498004030182',
     };
   }
 
@@ -133,4 +137,14 @@ export class Auto24Transformer {
       })
       .join(', ');
   }
+
+  private getCondition(car: DataSchemes.Car): string {
+    const available = {
+      selector_condition_new: 'Neu',
+      selector_condition_used: 'Gebraucht',
+      selector_unknown: 'Gebraucht',
+    };
+    const condition = get(car, 'mainData.condition', 'selector_unknown');
+    return get(available, condition);
+  }
 }