@bytebrand/export-cars 1.26.43 → 1.26.44

package/docs/meinestadt/AUDIT.md

@@ -46,8 +46,8 @@ only ones any partner export sends).
 | 2 | `make` | String | `mainData.make` | same | OK | OK |
 | 3 | `model` | String | `mainData.model` | same | placeholder `SONSTIGE` exists | sent as-is |
 | 4 | `cpc` | Float | literal `0,08` | `config.cpc` param, default **`'0.08'`** (string) | DEV event `cpc=0.99` | **BUG (ADV-325)**: hidden historical default; emitted as string |
-| 5 | `listingUrl` | String | `…/search/vehicle/<id>/?source=meineStadt&medium=cpc&campaign=listing` | `…/search/vehicle/<id>?source=classifieds&medium=listing&campaign=meinestadt` | — | UTM differs from sheet → ADV-327 (tracking, paused); unchanged |
-| 6 | `title` | String | make & model & subModel | `${make} ${model} ${subModel}` | — | `SONSTIGE` / `undefined` possible; not changed now |
+| 5 | `listingUrl` | String | `…/search/vehicle/<id>/?source=meineStadt&medium=cpc&campaign=listing` | `…/search/vehicle/<id>?source=classifieds&medium=listing&campaign=meinestadt` | — | **1.26.44**: `?source=meinestadt&medium=listing&campaign=listing` + identical `utm_*` (ADV-327, see §7) |
+| 6 | `title` | String | make & model & subModel | `${make} ${model} ${subModel}` | — | **1.26.44**: missing parts left out (no `undefined`); `SONSTIGE` still sent as-is |
 | 7 | `accidentFree` | Boolean | `mainData.accidentDamaged` | `accidentDamaged` **without inversion** | 697 `false`, 347 `null`, 0 `true` | **BUG (ADV-325)**: every known accident-free car is sent as `accidentFree:false` |
 | 8 | `city` | String | "do not include this field" | not emitted | — | OK (comply) |
 | 9 | `zip` | String | "do not include this field" | not emitted | — | OK |
@@ -61,8 +61,8 @@ only ones any partner export sends).
 | 17 | `numberOfPreviousOwners` | Number | `mainData.numberOfPreviousOwners` | same | 111 null | OK |
 | 18 | `price` | Number | `price.currentSalesPrice` | same | 1044 number | OK — end-customer purchase price (EUR), not a rate, not `price.purchasePrice` (dealer cost) |
 | 19 | `power` | Number | `engineData.powerPS`, "PS only" | `engineData.powerPS` | 1044; 6 cars where PS ≠ kW×1.36 (source data) | OK — PS, not kW |
-| 20 | `co2Emissions` | Number | `environmentEmissions.co2` | same | OK | OK |
-| 21 | `fuelConsumptionCombined` | Float | `consumption.consumptionCombined` | same | OK | OK |
+| 20 | `co2Emissions` | Number | `environmentEmissions.co2` | same | OK | **1.26.44**: Google feed EnVKV pick (WLTP first, legacy fallback; BEV 0), null when none |
+| 21 | `fuelConsumptionCombined` | Float | `consumption.consumptionCombined` | same | OK | **1.26.44**: Google feed EnVKV pick; BEV null (CBD mirrors kWh into `consumptionCombined`) |
 | 22 | `images` | **String Array** | "put image url of main image … not the image id" | `carImages[0]` → a **single string** | — | **BUG (ADV-326)**: not an array; first entry of a placeholder-padded list |
 | 23 | `equipment` | String Array / comma string (`"ABS, Klimaanlage, DAB"`) | `offer.offerDescription` | mobile.de description (markdown `**`, `\\`, dealer header/footer) | — | differs from sheet; partner question, not changed now |
 | 24 | `color` | String (DE) | `exterior.exteriorColor` | `de[...]` | e.g. `Rot` | OK |
@@ -144,3 +144,19 @@ marketing header/footer of the mobile.de description ("über 180.000 Autos …")
 ## 6. Open partner questions
 
 See `PARTNER-QUESTIONS.md`.
+
+## 7. Round 2 — export-cars 1.26.44 (12.11.2026, DEV only)
+
+Same follow-ups as the AutoUncle feed got in 1.26.41–1.26.43 (ADV-322/324), no parameters added:
+
+- `co2Emissions` / `fuelConsumptionCombined`: the Google feed's EnVKV picks (`envkvCo2Value`,
+  `envkvFuelConsumptionValue`): WLTP first, legacy only as fallback, confirmed plug-in weighted; a BEV sends
+  no fuel consumption (`null`, CBD mirrors its kWh into `consumptionCombined`) and CO2 `0`. Nothing usable → `null`.
+  Stored values are sent like in the Google / Meta feeds (no publication gate).
+- `listingUrl` (ADV-327): `?source=meinestadt&medium=listing&campaign=listing&utm_source=meinestadt&utm_medium=listing&utm_campaign=listing`.
+  Partner in `source` so the reporting views, the CRM source and GA4 all see meinestadt; no paid medium (CPC is a
+  contract attribute). web-funnel-tracking-health 1.5.5 books it (and the legacy `source=classifieds&campaign=meinestadt`
+  and the sheet's `source=meineStadt&medium=cpc`) as `CLASSIFIEDS_MEINESTADT`, family Classifieds. Pending meinestadt's OK.
+- `title`: make / model / subModel without missing parts (was `"… undefined"` when subModel is missing).
+- Unchanged: keys, order, file names, envelope, dry-run default, images (ADV-326 tests incl. 8 raw / 1 valid → `imagesCount` 1).
+

package/docs/meinestadt/PARTNER-QUESTIONS.md

@@ -32,7 +32,7 @@ only — we need the CURRENT automotive specification in writing.
     `transmissionType`, `emissionClass`, `emissionSticker`, `usageState`, `customerType`?
 12. `power`: confirm PS (not kW). `price`: confirm gross EUR purchase price.
 13. Location: our historical mapping says not to send `city`, `zip`, `latitude`, `longitude`. Still correct?
-14. `listingUrl`: required tracking parameters (historical: `source=meineStadt&medium=cpc&campaign=listing`)?
+14. `listingUrl`: required tracking parameters (historical: `source=meineStadt&medium=cpc&campaign=listing`)? DEV feed since 1.26.44 sends `source=meinestadt&medium=listing&campaign=listing` + the same `utm_*` values — OK for you?
 
 ## Images
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.43",
+  "version": "1.26.44",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/interfaces/export-item.interface.ts

@@ -88,8 +88,9 @@ export interface MeinstadtJsonItem {
   price: number;
   // PS
   power: number;
-  co2Emissions: number;
-  fuelConsumptionCombined: number;
+  // EnVKV picks (as Google), null when nothing usable
+  co2Emissions: number | null;
+  fuelConsumptionCombined: number | null;
   equipment: string;
   color: string;
   bodyType: string;

package/src/transformers/meinstadt.transformer.ts

@@ -9,6 +9,21 @@ import { de } from '@bytebrand/i18n-dictionaries';
 import { UserService } from '../services';
 import { MeinstadtJsonItem } from '../interfaces';
 import { OpenAiImageSelection } from './openai-image-fields';
+import { envkvCo2Value, envkvFuelConsumptionValue } from './google-feed-envkv';
+
+// listingUrl parameters (ADV-327, same scheme as AutoUncle ADV-324): the partner in `source`, so the
+// reporting views, the CRM source and GA4 (utm_*) all see "meinestadt". Legacy and utm pairs carry
+// identical values; paid / unpaid (CPC) is a contract attribute and is not encoded in the medium.
+export const MEINSTADT_LINK_PARAMS =
+  'source=meinestadt&medium=listing&campaign=listing&utm_source=meinestadt&utm_medium=listing&utm_campaign=listing';
+
+// make, model, subModel joined; missing parts are left out (never the text "undefined" / "null").
+export const getMeinstadtTitle = (car: DataSchemes.Car): string =>
+  ['mainData.make', 'mainData.model', 'mainData.subModel']
+    .map(path => get(car, path, null))
+    .filter(part => typeof part === 'string' && part.trim())
+    .map(part => part.trim())
+    .join(' ');
 
 /**
  * The meinestadt `images` list from the shared validated clean selection (ADV-336, same rules as
@@ -96,8 +111,8 @@ export const mapMeinstadtItem = (car: DataSchemes.Car, ctx: MeinstadtMappingCont
     make: get(car, 'mainData.make', null),
     model: get(car, 'mainData.model', null),
     cpc: ctx.cpc,
-    listingUrl: `https://www.${ctx.domain}/search/vehicle/${carId}?source=classifieds&medium=listing&campaign=meinestadt`,
-    title: `${car.mainData.make} ${car.mainData.model} ${car.mainData.subModel}`,
+    listingUrl: `https://www.${ctx.domain}/search/vehicle/${carId}?${MEINSTADT_LINK_PARAMS}`,
+    title: getMeinstadtTitle(car),
     accidentFree: toAccidentFree(get(car, 'mainData.accidentDamaged', null)),
     mileage: get(car, 'mainData.mileage', null),
     initialRegistration: toUnixSeconds(get(car, 'mainData.firstRegistration', null)),
@@ -109,8 +124,10 @@ export const mapMeinstadtItem = (car: DataSchemes.Car, ctx: MeinstadtMappingCont
     price: get(car, 'price.currentSalesPrice', null),
     // PS, not kW (workbook: "only put the value for PS")
     power: get(car, 'engineData.powerPS', null),
-    co2Emissions: get(car, 'environmentEmissions.co2', null),
-    fuelConsumptionCombined: get(car, 'consumption.consumptionCombined', null),
+    // EnVKV: the same values as the Google / AutoUncle feeds (WLTP first, legacy only as fallback;
+    // BEV: no fuel consumption, CO2 0). Nothing usable -> null.
+    co2Emissions: envkvCo2Value(car) ?? null,
+    fuelConsumptionCombined: envkvFuelConsumptionValue(car) ?? null,
     equipment: ctx.equipment,
     color: translate(get(car, 'exterior.exteriorColor', null)),
     bodyType: translate(get(car, 'mainData.category', null)),

package/test/meinstadt-mapping.test.ts

@@ -6,6 +6,8 @@ import { de } from '@bytebrand/i18n-dictionaries';
 import { MeinstadtConfig, parseMeinstadtCpc } from '../src/configs/meinstadt.config';
 import { Environment, ExportType, ImageType } from '../src/enums';
 import {
+  MEINSTADT_LINK_PARAMS,
+  getMeinstadtTitle,
   mapMeinstadtItem,
   toAccidentFree,
   toMeinstadtImages,
@@ -119,6 +121,38 @@ const tests: Array<[string, () => void | Promise<void>]> = [
     assert.equal(mapMeinstadtItem(car('l2', { 'mainData.condition': 'selector_unknown', 'mainData.mileage': 5 }), ctx()).usageState, 'Neu');
   }],
 
+  ['listingUrl (ADV-327): partner in source, identical legacy + utm pairs, no paid medium, stable per car', () => {
+    assert.equal(MEINSTADT_LINK_PARAMS, 'source=meinestadt&medium=listing&campaign=listing&utm_source=meinestadt&utm_medium=listing&utm_campaign=listing');
+    const a = mapMeinstadtItem(car('car-a'), ctx()).listingUrl;
+    assert.equal(a, `https://www.auto.de/search/vehicle/car-a?${MEINSTADT_LINK_PARAMS}`);
+    assert.equal(mapMeinstadtItem(car('car-a'), ctx()).listingUrl, a);
+    assert.notEqual(mapMeinstadtItem(car('car-b'), ctx()).listingUrl, a);
+    assert.ok(!/medium=cpc|source=classifieds/.test(a));
+  }],
+
+  ['EnVKV: WLTP picks of the Google feed, legacy only as fallback; BEV no fuel, CO2 0; 0 / missing -> null', () => {
+    const wltp = mapMeinstadtItem(car('e1', { 'consumption.wltpCombined': 5.8, 'environmentEmissions.wltpCo2': 132 }), ctx());
+    assert.deepEqual([wltp.fuelConsumptionCombined, wltp.co2Emissions], [5.8, 132]);
+    // fixture has only the legacy fields (6.1 l, 137 g) -> sent as before
+    const legacy = mapMeinstadtItem(car('e2'), ctx());
+    assert.deepEqual([legacy.fuelConsumptionCombined, legacy.co2Emissions], [6.1, 137]);
+    // CBD mirrors kWh into consumptionCombined for BEVs: never sent as fuel consumption
+    const bev = mapMeinstadtItem(car('e3', { 'consumption.fuel': 'selector_fuel_electrical', 'consumption.consumptionCombined': 16.5, 'environmentEmissions.co2': null }), ctx());
+    assert.deepEqual([bev.fuelConsumptionCombined, bev.co2Emissions], [null, 0]);
+    const none = mapMeinstadtItem(car('e4', { 'consumption.consumptionCombined': 0, 'environmentEmissions.co2': null }), ctx());
+    assert.deepEqual([none.fuelConsumptionCombined, none.co2Emissions], [null, null]);
+  }],
+
+  ['title: make model subModel, missing parts left out (never "undefined" / "null")', () => {
+    assert.equal(getMeinstadtTitle(car('t1')), 'Opel Astra 1.2 Turbo Edition');
+    assert.equal(getMeinstadtTitle(car('t2', { 'mainData.subModel': null })), 'Opel Astra');
+    assert.equal(getMeinstadtTitle(car('t3', { 'mainData.subModel': '  ' })), 'Opel Astra');
+    const noSub = car('t4');
+    delete noSub.mainData.subModel;
+    assert.equal(mapMeinstadtItem(noSub, ctx()).title, 'Opel Astra');
+    assert.equal(getMeinstadtTitle(car('t5', { 'mainData.subModel': ' 1.5 TSI ' })), 'Opel Astra 1.5 TSI');
+  }],
+
   ['item: historical keys and order, slash keys kept literally, no city/zip/lat/long', () => {
     const item = mapMeinstadtItem(car('k1'), ctx({ images: ['https://x/1.jpeg', 'https://x/2.jpeg'] }));
     assert.deepEqual(Object.keys(item), [
@@ -133,7 +167,7 @@ const tests: Array<[string, () => void | Promise<void>]> = [
       make: 'Opel',
       model: 'Astra',
       cpc: '0.99',
-      listingUrl: 'https://www.auto.de/search/vehicle/k1?source=classifieds&medium=listing&campaign=meinestadt',
+      listingUrl: 'https://www.auto.de/search/vehicle/k1?source=meinestadt&medium=listing&campaign=listing&utm_source=meinestadt&utm_medium=listing&utm_campaign=listing',
       title: 'Opel Astra 1.2 Turbo Edition',
       accidentFree: true,
       mileage: 13000,