@bytebrand/export-cars 1.26.42 → 1.26.44

package/test/autouncle-mapping.test.ts

@@ -143,15 +143,10 @@ const tests: Array<[string, () => void | Promise<void>]> = [
     assert.deepEqual([none.fuel_economy, none.co2_emission], ['', '']);
   }],
 
-  ['EnVKV: estimated values withheld by the publication gate; the CO2-derived class goes with CO2', () => {
+  ['EnVKV: the stored values are sent as in the Google / Meta feeds (no filter); WLTP class as before', () => {
     const c = car('w1', { 'consumption.wltpCombined': 5.8, 'environmentEmissions.wltpCo2': 132, 'environmentEmissions.wltpEnergyEfficiencyClass': 'D' });
     const sent = item(c);
     assert.deepEqual([sent.fuel_economy, sent.co2_emission, sent.co2_effiency_class], ['5.8', '132', 'D']);
-    const noFuel = item(c, { withheldEnvkv: ['fuel_consumption'] });
-    assert.deepEqual([noFuel.fuel_economy, noFuel.co2_emission, noFuel.co2_effiency_class], ['', '132', 'D']);
-    const noCo2 = item(c, { withheldEnvkv: ['co2_emissions'] });
-    assert.deepEqual([noCo2.fuel_economy, noCo2.co2_emission, noCo2.co2_effiency_class], ['5.8', '', '']);
-    assert.deepEqual(Object.keys(noCo2), HISTORIC_KEYS);
   }],
 
   ['seller address: the dealer\'s own address, region from the postal code table', () => {
@@ -226,26 +221,12 @@ const tests: Array<[string, () => void | Promise<void>]> = [
     assert.equal(dry.maxImages, 0);
     assert.equal(dry.feedGuard.minPublishedItems, 1);
     assert.equal(new AutouncleConfig({ ...base, autouncleDryRun: 'no' } as any).dryRun, true);
-    const gateTable = { publicationGateBqProject: 'p', publicationGateBqDataset: 'd', publicationGateBqTable: 't' };
-    const live = new AutouncleConfig({ ...base, ...gateTable, publicationGate: 'enforce', autouncleDryRun: 'false', autouncleMaxImages: '12', feedGuardMinPublishedItems: '50' } as any);
+    const live = new AutouncleConfig({ ...base, autouncleDryRun: 'false', autouncleMaxImages: '12', feedGuardMinPublishedItems: '50' } as any);
     assert.equal(live.dryRun, false);
     assert.equal(live.outputFiles[0], 'resources/autouncle-export/api_export_cars_autouncle.json');
     assert.equal(live.stateDir, 'resources/autouncle-state/export');
     assert.equal(live.maxImages, 12);
     assert.equal(live.feedGuard.minPublishedItems, 50);
-    assert.deepEqual(live.publicationGate, { mode: 'enforce', project: 'p', dataset: 'd', table: 't' });
-  }],
-
-  ['config: publication gate off by default for a dry-run; a live run needs enforce; audit / enforce need the table', () => {
-    const base = { environment: Environment.DEVELOP, exportType: ExportType.AUTOUNCLE };
-    const gateTable = { publicationGateBqProject: 'p', publicationGateBqDataset: 'd', publicationGateBqTable: 't' };
-    assert.equal(new AutouncleConfig({ ...base } as any).publicationGate, undefined);
-    assert.equal(new AutouncleConfig({ ...base, publicationGate: 'off' } as any).publicationGate, undefined);
-    assert.equal(new AutouncleConfig({ ...base, ...gateTable, publicationGate: 'Audit' } as any).publicationGate.mode, 'audit');
-    assert.throws(() => new AutouncleConfig({ ...base, autouncleDryRun: 'false' } as any), /needs publicationGate=enforce/);
-    assert.throws(() => new AutouncleConfig({ ...base, ...gateTable, publicationGate: 'audit', autouncleDryRun: 'false' } as any), /needs publicationGate=enforce/);
-    assert.throws(() => new AutouncleConfig({ ...base, publicationGate: 'enforce' } as any), /needs publicationGateBqProject/);
-    assert.throws(() => new AutouncleConfig({ ...base, publicationGate: 'strict' } as any), /must be off, audit or enforce/);
   }],
 ];
 

package/test/meinstadt-mapping.test.ts

@@ -6,6 +6,8 @@ import { de } from '@bytebrand/i18n-dictionaries';
 import { MeinstadtConfig, parseMeinstadtCpc } from '../src/configs/meinstadt.config';
 import { Environment, ExportType, ImageType } from '../src/enums';
 import {
+  MEINSTADT_LINK_PARAMS,
+  getMeinstadtTitle,
   mapMeinstadtItem,
   toAccidentFree,
   toMeinstadtImages,
@@ -119,6 +121,38 @@ const tests: Array<[string, () => void | Promise<void>]> = [
     assert.equal(mapMeinstadtItem(car('l2', { 'mainData.condition': 'selector_unknown', 'mainData.mileage': 5 }), ctx()).usageState, 'Neu');
   }],
 
+  ['listingUrl (ADV-327): partner in source, identical legacy + utm pairs, no paid medium, stable per car', () => {
+    assert.equal(MEINSTADT_LINK_PARAMS, 'source=meinestadt&medium=listing&campaign=listing&utm_source=meinestadt&utm_medium=listing&utm_campaign=listing');
+    const a = mapMeinstadtItem(car('car-a'), ctx()).listingUrl;
+    assert.equal(a, `https://www.auto.de/search/vehicle/car-a?${MEINSTADT_LINK_PARAMS}`);
+    assert.equal(mapMeinstadtItem(car('car-a'), ctx()).listingUrl, a);
+    assert.notEqual(mapMeinstadtItem(car('car-b'), ctx()).listingUrl, a);
+    assert.ok(!/medium=cpc|source=classifieds/.test(a));
+  }],
+
+  ['EnVKV: WLTP picks of the Google feed, legacy only as fallback; BEV no fuel, CO2 0; 0 / missing -> null', () => {
+    const wltp = mapMeinstadtItem(car('e1', { 'consumption.wltpCombined': 5.8, 'environmentEmissions.wltpCo2': 132 }), ctx());
+    assert.deepEqual([wltp.fuelConsumptionCombined, wltp.co2Emissions], [5.8, 132]);
+    // fixture has only the legacy fields (6.1 l, 137 g) -> sent as before
+    const legacy = mapMeinstadtItem(car('e2'), ctx());
+    assert.deepEqual([legacy.fuelConsumptionCombined, legacy.co2Emissions], [6.1, 137]);
+    // CBD mirrors kWh into consumptionCombined for BEVs: never sent as fuel consumption
+    const bev = mapMeinstadtItem(car('e3', { 'consumption.fuel': 'selector_fuel_electrical', 'consumption.consumptionCombined': 16.5, 'environmentEmissions.co2': null }), ctx());
+    assert.deepEqual([bev.fuelConsumptionCombined, bev.co2Emissions], [null, 0]);
+    const none = mapMeinstadtItem(car('e4', { 'consumption.consumptionCombined': 0, 'environmentEmissions.co2': null }), ctx());
+    assert.deepEqual([none.fuelConsumptionCombined, none.co2Emissions], [null, null]);
+  }],
+
+  ['title: make model subModel, missing parts left out (never "undefined" / "null")', () => {
+    assert.equal(getMeinstadtTitle(car('t1')), 'Opel Astra 1.2 Turbo Edition');
+    assert.equal(getMeinstadtTitle(car('t2', { 'mainData.subModel': null })), 'Opel Astra');
+    assert.equal(getMeinstadtTitle(car('t3', { 'mainData.subModel': '  ' })), 'Opel Astra');
+    const noSub = car('t4');
+    delete noSub.mainData.subModel;
+    assert.equal(mapMeinstadtItem(noSub, ctx()).title, 'Opel Astra');
+    assert.equal(getMeinstadtTitle(car('t5', { 'mainData.subModel': ' 1.5 TSI ' })), 'Opel Astra 1.5 TSI');
+  }],
+
   ['item: historical keys and order, slash keys kept literally, no city/zip/lat/long', () => {
     const item = mapMeinstadtItem(car('k1'), ctx({ images: ['https://x/1.jpeg', 'https://x/2.jpeg'] }));
     assert.deepEqual(Object.keys(item), [
@@ -133,7 +167,7 @@ const tests: Array<[string, () => void | Promise<void>]> = [
       make: 'Opel',
       model: 'Astra',
       cpc: '0.99',
-      listingUrl: 'https://www.auto.de/search/vehicle/k1?source=classifieds&medium=listing&campaign=meinestadt',
+      listingUrl: 'https://www.auto.de/search/vehicle/k1?source=meinestadt&medium=listing&campaign=listing&utm_source=meinestadt&utm_medium=listing&utm_campaign=listing',
       title: 'Opel Astra 1.2 Turbo Edition',
       accidentFree: true,
       mileage: 13000,