@bytebrand/export-cars 1.26.41 → 1.26.43

package/docs/autouncle/AUDIT.md

@@ -58,8 +58,8 @@ Dry-run is the default and writes `resources/autouncle-dryrun/`, which no Cronic
 | seller_region / city / street_address / postcode | UPA businessAddress, else mainAddress; region from the postal code table | if the table did not know the place, street/city/zip were **blanked** (664/1044 DEV cars) | dealer's own values kept, region `Deutschland` | |
 | description | offer.offerDescription | raw | same; 192/1002 empty on DEV, some contain literal `\\` line breaks (dealer data) | → Q10 |
 | images | Imbo images | default profile: `/large` (format negotiated, can be WebP), padded with **3 noimage placeholders** below 17 photos (2820 placeholder URLs on DEV) | `[{url}]`, ADV-336 clean profile, explicit `large-cached.jpeg`, every URL checked (200 + image/jpeg|png); no valid 3/4 hero → car not sent | limits → ADV-323 gate |
-| fuel_economy / co2_emission | consumption.consumptionCombined / environmentEmissions.co2 | raw legacy fields; a BEV sent its kWh (CBD mirrors it into consumptionCombined) as fuel economy | since 1.26.41: the Google feed's EnVKV picks as plain numbers (WLTP first, legacy only as fallback; confirmed plug-in weighted); BEV: fuel `""`, CO₂ `0`; estimated values withheld by the publication gate (enforce) | units → Q6 |
-| co2_effiency_class | environmentEmissions.wltpEnergyEfficiencyClass (ADV-187) | raw | same; `""` when the CO₂ value is withheld (the class is derived from CO₂) | → Q6 |
+| fuel_economy / co2_emission | consumption.consumptionCombined / environmentEmissions.co2 | raw legacy fields; a BEV sent its kWh (CBD mirrors it into consumptionCombined) as fuel economy | since 1.26.41: the Google feed's EnVKV picks as plain numbers (WLTP first, legacy only as fallback; confirmed plug-in weighted); BEV: fuel `""`, CO₂ `0`; no filter, the stored values as in the Google / Meta feeds | units → Q6 |
+| co2_effiency_class | environmentEmissions.wltpEnergyEfficiencyClass (ADV-187) | raw | same | → Q6 |
 | euro_emission_class / enviromental_sticker | environmentEmissions.* | raw selector keys | same (no schema to translate to) | → Q6 |
 
 Car-level exclusions (new, counted in the report): `duplicate_id`, `filtered`, `no_id`, `no_dealer`,
@@ -77,8 +77,10 @@ Car-level exclusions (new, counted in the report): `duplicate_id`, `filtered`, `
 8. Fail-closed: no `emptyDir`; empty / partial / stale snapshot, empty result or a drop > 20 % against the
    last good run → run blocked (exit 1, `3.1` copy does not run), last good file stays. Lock per state dir.
 9. Dry-run default; live only with `autouncleDryRun=false`.
-10. (1.26.41, 10.11) EnVKV: WLTP picks + EnVKV C8 publication gate (same params as the Google job). A live run
-    refuses to start without `publicationGate=enforce`. The run report has `envkv.estimated` per attribute.
+10. (1.26.41, 10.11) EnVKV: the Google feed's picks (WLTP first). DEV dry-run 10.11: 1731 ads, 128 BEV with fuel ""
+    and CO₂ 0, the WLTP picks changed 338 fuel / 403 CO₂ values against the legacy fields.
+    (1.26.43, 11.11) The EnVKV C8 publication gate of 1.26.41/42 was removed (user decision): like the Google and Meta
+    jobs, the feed sends the stored values without parameters. No `publicationGate*` params on this job.
 11. (1.26.41, 10.11) `back_link` parameters per ADV-324 (partner in `source`, identical utm pair).
 
 ## 5. Evidence

package/docs/autouncle/RUNBOOK.md

@@ -15,8 +15,6 @@ Not activated. Nothing below has been done on any Cronicle host.
 | `feedGuardMaxSourceAgeHours` | 26 | newest base export chunk must be younger |
 | `feedGuardMaxStaleHours` | 48 | last good file reported STALE after this |
 | `feedGuardAcceptDrop` | off | `true` for ONE run after a real stock drop |
-| `publicationGate` | off | `audit` counts estimated EnVKV values, `enforce` sends them empty. **A live run needs `enforce`** (config error otherwise). enforce fails the run if the enrichment log cannot be read |
-| `publicationGateBqProject` / `…Dataset` / `…Table` | — | CBD enrichment log table, same values as the Google job; required for audit / enforce |
 
 `String` / `Number` rules stay as they are (PROD: dealer allow-list + `metaData.imagesCount:2`).
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.41",
+  "version": "1.26.43",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/configs/autouncle.config.ts

@@ -1,7 +1,7 @@
 import { toNumber } from 'lodash';
 
 import { ExportType, FileType, ImageType } from '../enums';
-import { Params, PublicationGateConfig } from '../interfaces/params.interface';
+import { Params } from '../interfaces/params.interface';
 import { FeedGuardOptions } from '../services/feed-guard';
 import { Config } from './config';
 
@@ -55,33 +55,8 @@ export class AutouncleConfig extends Config {
       maxStaleHours: positiveNumber(params.feedGuardMaxStaleHours, AUTOUNCLE_DEFAULTS.maxStaleHours),
       acceptDrop: text(params.feedGuardAcceptDrop).toLowerCase() === 'true',
     };
-    this.publicationGate = parsePublicationGate(params);
-    // ADV-322 "do not guess emissions": a live file never goes out with unchecked EnVKV estimates.
-    if (!this.dryRun && this.publicationGate?.mode !== 'enforce') {
-      throw new Error('a live AutoUncle run (autouncleDryRun=false) needs publicationGate=enforce');
-    }
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.AUTOUNCLE}.${FileType.JSON}`,
     ];
   }
 }
-
-// Same params and rules as the Google job (GoogleConfig): off by default; audit / enforce need the
-// enrichment log table (publicationGateBqProject / Dataset / Table).
-function parsePublicationGate(params: Params): PublicationGateConfig | undefined {
-  const mode = text(params.publicationGate).toLowerCase();
-  if (!mode || mode === 'off') return undefined;
-  if (mode !== 'audit' && mode !== 'enforce') {
-    throw new Error(`publicationGate must be off, audit or enforce, got "${mode}"`);
-  }
-  const gate = {
-    mode: mode as PublicationGateConfig['mode'],
-    project: text(params.publicationGateBqProject),
-    dataset: text(params.publicationGateBqDataset),
-    table: text(params.publicationGateBqTable),
-  };
-  if (!gate.project || !gate.dataset || !gate.table) {
-    throw new Error(`publicationGate=${mode} needs publicationGateBqProject, publicationGateBqDataset and publicationGateBqTable`);
-  }
-  return gate;
-}

package/src/exporters/autouncle.exporter.ts

@@ -9,7 +9,6 @@ import { resolveOpenAiImageFields } from '../transformers/openai-image-fields';
 import { CarService, RulesService, LoaderService, ConfigService, ImagesService } from '../services';
 import { ImageUrlValidator } from '../services/image-url-validator.service';
 import { FeedGuard } from '../services/feed-guard';
-import { PublicationGate, loadPublicationGate } from '../services/publication-gate';
 import { AutouncleFeedRun, AutouncleSourceCar } from '../services/autouncle-feed-run';
 import { AutouncleConfig } from '../configs/autouncle.config';
 import { Exporter } from '../interfaces/exporter.interface';
@@ -37,16 +36,6 @@ export class AutouncleExporter implements Exporter {
     const transformer = await this.moduleRef.create(AutouncleTransformer);
     const addresses = new Map<string, Promise<AutouncleAddress | null>>();
 
-    // EnVKV C8 (ADV-322): estimated values are withheld (enforce) or only counted (audit). enforce fails
-    // the job when the enrichment log cannot be read, so the last published file stays.
-    let gate: PublicationGate;
-    try {
-      gate = await loadPublicationGate(config.publicationGate);
-    } catch (error) {
-      LoggerService.exitError(`autouncle feed not published: ${error?.message ?? error}`);
-      process.exit(1);
-    }
-
     const run = new AutouncleFeedRun(
       {
         forEachChunk: fn => this.loaderService.process((chunk: FsChunkInterface) => fn(chunk.data as AutouncleSourceCar[])),
@@ -66,7 +55,6 @@ export class AutouncleExporter implements Exporter {
         imageStats: () => validator.stats,
         translate: key => transformer.translate(key),
         guard: new FeedGuard(config.feedGuard),
-        gate,
       },
       {
         runId: config.runId,

package/src/services/autouncle-feed-run.ts

@@ -6,7 +6,6 @@ import { DataSchemes } from '@bytebrand/car-schema';
 import { AutouncleJsonBuilder } from '../formats/autouncle-json.builder';
 import { AutouncleAddress, AutouncleExclusion, getAutouncleExclusion, mapAutouncleItem } from '../transformers/autouncle.transformer';
 import { FeedGuard, FeedGuardError, LastGood, inspectSourceSnapshot } from './feed-guard';
-import { PublicationGate } from './publication-gate';
 
 export interface AutouncleSourceCar {
   car: DataSchemes.Car;
@@ -27,8 +26,6 @@ export interface AutouncleRunDeps {
   imageStats: () => Record<string, number>;
   translate: (key: string) => string;
   guard: FeedGuard;
-  // EnVKV C8 publication gate (CBD enrichment log); absent = off
-  gate?: Pick<PublicationGate, 'mode' | 'estimatedAttributes'>;
 }
 
 export interface AutouncleRunOptions {
@@ -57,8 +54,6 @@ export interface AutouncleRunReport {
   excluded: Record<string, number>;
   imagesPerItem: { min: number | null; max: number | null; total: number };
   images: Record<string, number>;
-  // published items with an estimated EnVKV value per attribute; with gate enforce those were sent empty
-  envkv: { gate: 'off' | 'audit' | 'enforce'; estimated: Record<string, number> };
   lastGood: LastGood | null;
   lastGoodAgeHours: number | null;
   stale: boolean;
@@ -98,7 +93,6 @@ export class AutouncleFeedRun {
       excluded: {},
       imagesPerItem: { min: null, max: null, total: 0 },
       images: {},
-      envkv: { gate: this.deps.gate?.mode ?? 'off', estimated: {} },
       lastGood,
       lastGoodAgeHours: guard.staleHours(lastGood, startedAt),
       stale: guard.isStale(lastGood, startedAt),
@@ -147,19 +141,11 @@ export class AutouncleFeedRun {
             continue;
           }
           const images = await this.deps.resolveImages(source);
-          const estimated = this.deps.gate ? this.deps.gate.estimatedAttributes(source.car) : [];
-          const mapped = mapAutouncleItem(source.car, {
-            domain: this.options.domain,
-            address,
-            images,
-            translate: this.deps.translate,
-            withheldEnvkv: this.deps.gate?.mode === 'enforce' ? estimated : [],
-          });
+          const mapped = mapAutouncleItem(source.car, { domain: this.options.domain, address, images, translate: this.deps.translate });
           if (mapped.ok === false) {
             increment(report.excluded, mapped.reason);
             continue;
           }
-          estimated.forEach(attribute => increment(report.envkv.estimated, attribute));
           await builder.addItem(mapped.item, first);
           first = false;
           dealers.add(ownerId);

package/src/transformers/autouncle.transformer.ts

@@ -11,7 +11,7 @@ import { DEFAULT_REGION, MIN_MILEAGES } from '../constants/autouncle.contants';
 import { AutouncleJsonItem } from '../interfaces';
 import { OpenAiImageSelection } from './openai-image-fields';
 import { toUnixSeconds } from './meinstadt.transformer';
-import { GoogleEnvkvAttribute, envkvCo2Value, envkvFuelConsumptionValue } from './google-feed-envkv';
+import { envkvCo2Value, envkvFuelConsumptionValue } from './google-feed-envkv';
 
 // back_link parameters (ADV-324): the partner in `source`, so the reporting views, the CRM source and
 // GA4 (utm_*) all see "autouncle". Legacy and utm pairs carry identical values (no parameterConflict).
@@ -46,8 +46,6 @@ export interface AutouncleMappingContext {
   images: string[];
   // German label of a selector (TranslatorExtended.translateVal)
   translate: (key: string) => string;
-  // EnVKV attributes whose value is a CBD estimate and must not be published (publication gate, enforce)
-  withheldEnvkv?: GoogleEnvkvAttribute[];
 }
 
 export type AutouncleMapResult = { ok: true; item: AutouncleJsonItem } | { ok: false; reason: AutouncleExclusion };
@@ -188,10 +186,6 @@ export const mapAutouncleItem = (car: DataSchemes.Car, ctx: AutouncleMappingCont
   const sellerId = toString(get(car, 'metaData.ownerId', '')).trim();
   const price = getAutounclePrice(get(car, 'price.currentSalesPrice', null));
   const firstRegistration = get(car, 'mainData.firstRegistration', null);
-  // EnVKV (ADV-322): the WLTP picks of the Google feed (legacy fields only as their fallback), never an
-  // estimated value. The energy class is derived from CO2, so it goes with a withheld CO2 value.
-  const withheld = ctx.withheldEnvkv ?? [];
-  const co2Withheld = withheld.includes('co2_emissions');
 
   return {
     ok: true,
@@ -223,10 +217,12 @@ export const mapAutouncleItem = (car: DataSchemes.Car, ctx: AutouncleMappingCont
       seller_id: sellerId,
       description: toString(get(car, 'offer.offerDescription', '')),
       images: ctx.images.map(url => ({ url })),
-      fuel_economy: withheld.includes('fuel_consumption') ? '' : toString(envkvFuelConsumptionValue(car) ?? ''),
-      co2_emission: co2Withheld ? '' : toString(envkvCo2Value(car) ?? ''),
+      // EnVKV (ADV-322): the same values as the Google feed (WLTP first, legacy only as fallback; BEV: no
+      // fuel, CO2 0), as plain numbers.
+      fuel_economy: toString(envkvFuelConsumptionValue(car) ?? ''),
+      co2_emission: toString(envkvCo2Value(car) ?? ''),
       // ADV-187: canonical CO2-derived WLTP class, not the unvalidated legacy NEFZ class.
-      co2_effiency_class: co2Withheld ? '' : toString(get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', '')),
+      co2_effiency_class: toString(get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', '')),
       euro_emission_class: toString(get(car, 'environmentEmissions.emissionClass', '')),
       enviromental_sticker: toString(get(car, 'environmentEmissions.emissionSticker', '')),
     },

package/test/autouncle-feed-run.test.ts

@@ -7,7 +7,7 @@ import { tmpdir } from 'os';
 import { join } from 'path';
 
 import { FeedGuard, FeedGuardError, FeedGuardOptions } from '../src/services/feed-guard';
-import { AutouncleFeedRun, AutouncleRunDeps, AutouncleSourceCar } from '../src/services/autouncle-feed-run';
+import { AutouncleFeedRun, AutouncleSourceCar } from '../src/services/autouncle-feed-run';
 import { toAutouncleImages } from '../src/transformers/autouncle.transformer';
 import { selectOpenAiImageFields } from '../src/transformers/openai-image-fields';
 import { buildImagesService } from './fixtures/images-service.harness';
@@ -63,9 +63,7 @@ const guardOptions = (world: World, extra: Partial<FeedGuardOptions> = {}): Feed
   ...extra,
 });
 
-type Gate = AutouncleRunDeps['gate'];
-
-const run = async (world: World, { at = NOW, guard = {}, gate }: { at?: Date; guard?: Partial<FeedGuardOptions>; gate?: Gate } = {}) => {
+const run = async (world: World, { at = NOW, guard = {} }: { at?: Date; guard?: Partial<FeedGuardOptions> } = {}) => {
   const forEachChunk = async (fn: (cars: AutouncleSourceCar[]) => Promise<void>) => {
     const names = (await fs.readdir(world.source)).sort((a, b) => Number(a.split('.')[1]) - Number(b.split('.')[1]));
     for (const name of names) {
@@ -87,7 +85,6 @@ const run = async (world: World, { at = NOW, guard = {}, gate }: { at?: Date; gu
       imageStats: () => ({ ok: 1 }),
       translate: key => key,
       guard: new FeedGuard(guardOptions(world, guard)),
-      gate,
     },
     {
       runId: 'test',
@@ -234,26 +231,6 @@ const tests: Array<[string, () => Promise<void>]> = [
     assert.equal(await exists(world.json), false);
   }],
 
-  ['EnVKV gate: enforce sends estimated values empty, audit only counts them; off without a gate', async () => {
-    const world = await newWorld();
-    await writeSource(world, [source('v1'), source('v2')]);
-    // v1: the CO2 value it would send is a CBD estimate
-    const estimatedAttributes = (c: any): any[] => (c._id === 'v1' ? ['co2_emissions'] : []);
-
-    const off = await run(world);
-    assert.deepEqual(off.envkv, { gate: 'off', estimated: {} });
-
-    const audit = await run(world, { at: new Date(NOW.getTime() + HOUR), gate: { mode: 'audit', estimatedAttributes } });
-    assert.deepEqual(audit.envkv, { gate: 'audit', estimated: { co2_emissions: 1 } });
-    assert.deepEqual((await readAds(world)).map((a: any) => a.co2_emission), ['137', '137']);
-
-    const enforce = await run(world, { at: new Date(NOW.getTime() + 2 * HOUR), gate: { mode: 'enforce', estimatedAttributes } });
-    assert.deepEqual(enforce.envkv, { gate: 'enforce', estimated: { co2_emissions: 1 } });
-    const ads = await readAds(world);
-    assert.deepEqual(ads.map((a: any) => [a.co2_emission, a.fuel_economy]), [['', '6.1'], ['137', '6.1']]);
-    assert.equal(ads.length, 2, 'a withheld value never drops the car');
-  }],
-
   ['second run with the same snapshot: byte-identical file (stable ids, order, links)', async () => {
     const world = await newWorld();
     await writeSource(world, [source('i1'), source('i2'), source('i3')]);

package/test/autouncle-mapping.test.ts

@@ -143,15 +143,10 @@ const tests: Array<[string, () => void | Promise<void>]> = [
     assert.deepEqual([none.fuel_economy, none.co2_emission], ['', '']);
   }],
 
-  ['EnVKV: estimated values withheld by the publication gate; the CO2-derived class goes with CO2', () => {
+  ['EnVKV: the stored values are sent as in the Google / Meta feeds (no filter); WLTP class as before', () => {
     const c = car('w1', { 'consumption.wltpCombined': 5.8, 'environmentEmissions.wltpCo2': 132, 'environmentEmissions.wltpEnergyEfficiencyClass': 'D' });
     const sent = item(c);
     assert.deepEqual([sent.fuel_economy, sent.co2_emission, sent.co2_effiency_class], ['5.8', '132', 'D']);
-    const noFuel = item(c, { withheldEnvkv: ['fuel_consumption'] });
-    assert.deepEqual([noFuel.fuel_economy, noFuel.co2_emission, noFuel.co2_effiency_class], ['', '132', 'D']);
-    const noCo2 = item(c, { withheldEnvkv: ['co2_emissions'] });
-    assert.deepEqual([noCo2.fuel_economy, noCo2.co2_emission, noCo2.co2_effiency_class], ['5.8', '', '']);
-    assert.deepEqual(Object.keys(noCo2), HISTORIC_KEYS);
   }],
 
   ['seller address: the dealer\'s own address, region from the postal code table', () => {
@@ -226,26 +221,12 @@ const tests: Array<[string, () => void | Promise<void>]> = [
     assert.equal(dry.maxImages, 0);
     assert.equal(dry.feedGuard.minPublishedItems, 1);
     assert.equal(new AutouncleConfig({ ...base, autouncleDryRun: 'no' } as any).dryRun, true);
-    const gateTable = { publicationGateBqProject: 'p', publicationGateBqDataset: 'd', publicationGateBqTable: 't' };
-    const live = new AutouncleConfig({ ...base, ...gateTable, publicationGate: 'enforce', autouncleDryRun: 'false', autouncleMaxImages: '12', feedGuardMinPublishedItems: '50' } as any);
+    const live = new AutouncleConfig({ ...base, autouncleDryRun: 'false', autouncleMaxImages: '12', feedGuardMinPublishedItems: '50' } as any);
     assert.equal(live.dryRun, false);
     assert.equal(live.outputFiles[0], 'resources/autouncle-export/api_export_cars_autouncle.json');
     assert.equal(live.stateDir, 'resources/autouncle-state/export');
     assert.equal(live.maxImages, 12);
     assert.equal(live.feedGuard.minPublishedItems, 50);
-    assert.deepEqual(live.publicationGate, { mode: 'enforce', project: 'p', dataset: 'd', table: 't' });
-  }],
-
-  ['config: publication gate off by default for a dry-run; a live run needs enforce; audit / enforce need the table', () => {
-    const base = { environment: Environment.DEVELOP, exportType: ExportType.AUTOUNCLE };
-    const gateTable = { publicationGateBqProject: 'p', publicationGateBqDataset: 'd', publicationGateBqTable: 't' };
-    assert.equal(new AutouncleConfig({ ...base } as any).publicationGate, undefined);
-    assert.equal(new AutouncleConfig({ ...base, publicationGate: 'off' } as any).publicationGate, undefined);
-    assert.equal(new AutouncleConfig({ ...base, ...gateTable, publicationGate: 'Audit' } as any).publicationGate.mode, 'audit');
-    assert.throws(() => new AutouncleConfig({ ...base, autouncleDryRun: 'false' } as any), /needs publicationGate=enforce/);
-    assert.throws(() => new AutouncleConfig({ ...base, ...gateTable, publicationGate: 'audit', autouncleDryRun: 'false' } as any), /needs publicationGate=enforce/);
-    assert.throws(() => new AutouncleConfig({ ...base, publicationGate: 'enforce' } as any), /needs publicationGateBqProject/);
-    assert.throws(() => new AutouncleConfig({ ...base, publicationGate: 'strict' } as any), /must be off, audit or enforce/);
   }],
 ];