@bytebrand/export-cars 1.26.40 → 1.26.42

package/test/criteo-mapping.test.ts

@@ -1,122 +1,122 @@
-// Run: npm test (ts-node, no test framework needed)
-// ADV-319: Criteo item mapping bugs found in the DEV feed of 27.10.2026.
-// - custom_label_0 was "[object Object] EUR mtl." for every car;
-// - a car without a rate got "<g:months>0</g:months><g:amount>0 EUR</g:amount>";
-// - a title with an apostrophe was escaped twice ("cee&amp;#39;d");
-// - an unknown energy class was sent as the literal "default".
-import * as assert from 'node:assert/strict';
-import * as fs from 'node:fs';
-import * as os from 'node:os';
-import * as path from 'node:path';
-import { CriteoTransformer } from '../src/transformers/criteo.transformer';
-import { GoogleXmlBuilder } from '../src/formats/google-xml.builder';
-
-const IMAGE = 'https://images.autode-dev.de/generated_images/0/0/0/00000000-0000-4000-8000-000000000001/criteo-Test.jpg';
-
-const baseCar = (patch: any = {}): any => ({
-  _id: '00000000-0000-4000-8000-000000000001',
-  mainData: { make: 'Volkswagen', model: 'Golf', condition: 'selector_condition_used', category: 'selector_category_limousine' },
-  price: { currentSalesPrice: 19990 },
-  offer: { availabilityMode: 'selector_availabilityMode_always' },
-  environmentEmissions: { wltpEnergyEfficiencyClass: 'selector_energyEfficiencyClass_d' },
-  rate: { monthlyInstallment: 164.6, paybackPeriod: 60 },
-  metaData: { ownerId: 'test-dealer', imagesCount: 5 },
-  ...patch,
-});
-
-const transformer = new CriteoTransformer(
-  {} as any,
-  { config: { isCriteo: true, imageType: 'marketing', domain: 'autode-dev.de' } } as any,
-  { getImages: async () => [IMAGE] } as any,
-);
-
-const renderItem = async (item: any): Promise<string> => {
-  const file = path.join(fs.mkdtempSync(path.join(os.tmpdir(), 'criteo-mapping-')), 'feed.xml');
-  const builder = new GoogleXmlBuilder(file);
-  await builder.buildStart('autode-dev.de');
-  await builder.addItem(item);
-  await builder.buildEnd();
-  return fs.readFileSync(file, 'utf8');
-};
-
-const tests: Array<[string, () => Promise<void>]> = [
-  ['custom_label_0 carries the rounded monthly rate, installment keeps months and amount', async () => {
-    const item = await transformer.transform({ car: baseCar(), images: [] });
-    assert.equal(item?.custom_label_0, '165 EUR mtl.');
-    assert.deepEqual(item?.installment, { paybackPeriod: 60, monthlyInstallment: 165 });
-    const xml = await renderItem(item);
-    assert.match(xml, /<g:months>60<\/g:months>/);
-    assert.match(xml, /<g:amount>165 EUR<\/g:amount>/);
-    assert.ok(!xml.includes('[object Object]'));
-  }],
-  ['car without a rate has no installment and no custom_label_0', async () => {
-    for (const rate of [undefined, null, {}, { monthlyInstallment: 0, paybackPeriod: 0 }, { monthlyInstallment: 199 }, { paybackPeriod: 48 }]) {
-      const item = await transformer.transform({ car: baseCar({ rate }), images: [] });
-      assert.ok(item, `item for rate ${JSON.stringify(rate)}`);
-      assert.ok(!('installment' in item), `installment for rate ${JSON.stringify(rate)}`);
-      assert.ok(!('custom_label_0' in item), `custom_label_0 for rate ${JSON.stringify(rate)}`);
-      const xml = await renderItem(item);
-      assert.ok(!xml.includes('g:installment') && !xml.includes('g:custom_label_0'));
-    }
-  }],
-  ['title with an apostrophe is escaped once, by the XML builder', async () => {
-    const item = await transformer.transform({
-      car: baseCar({ mainData: { make: 'Kia', model: "cee'd", condition: 'selector_condition_used' } }),
-      images: [],
-    });
-    assert.equal(item?.title, "Kia cee'd");
-    const xml = await renderItem(item);
-    assert.match(xml, /<g:title>Kia cee&apos;d<\/g:title>/);
-    assert.ok(!xml.includes('&amp;#39;'));
-  }],
-  ['title keeps the Mercedes / VW brand aliases (ACF-6332, ACF-6534)', async () => {
-    const vw = await transformer.transform({ car: baseCar(), images: [] });
-    assert.equal(vw?.title, 'VW Golf');
-    assert.equal(vw?.brand, 'Volkswagen');
-    const mb = await transformer.transform({
-      car: baseCar({ mainData: { make: 'Mercedes-Benz', model: 'A 180', condition: 'selector_condition_used' } }),
-      images: [],
-    });
-    assert.equal(mb?.title, 'Mercedes A 180');
-  }],
-  ['known energy class is sent, unknown or missing class leaves the element out', async () => {
-    const known = await transformer.transform({ car: baseCar(), images: [] });
-    assert.equal(known?.energy_efficiency_class, 'D');
-    for (const environmentEmissions of [{ wltpEnergyEfficiencyClass: 'selector_unknown' }, {}, undefined]) {
-      const item = await transformer.transform({ car: baseCar({ environmentEmissions }), images: [] });
-      assert.ok(item && !('energy_efficiency_class' in item));
-      const xml = await renderItem(item);
-      assert.ok(!xml.includes('g:energy_efficiency_class') && !xml.includes('>default<'));
-    }
-  }],
-  ['unchanged legacy fields: id, link params, price, condition, availability', async () => {
-    const item = await transformer.transform({ car: baseCar(), images: [] });
-    assert.equal(item?.id, '00000000-0000-4000-8000-000000000001');
-    assert.equal(
-      item?.link,
-      'https://www.autode-dev.de/search/vehicle/00000000-0000-4000-8000-000000000001?source=criteo&medium=cpc&campaign=retargeting',
-    );
-    assert.equal(item?.price, '19990 EUR');
-    assert.equal(item?.sale_price, '19990 EUR');
-    assert.equal(item?.condition, 'Gebraucht');
-    assert.equal(item?.availability, 'Sofort');
-    assert.deepEqual(Object.keys(item as any), [
-      'id', 'title', 'description', 'google_product_category', 'product_type', 'link', 'image_link', 'condition',
-      'availability', 'brand', 'price', 'sale_price', 'energy_efficiency_class', 'color', 'installment', 'custom_label_0',
-    ]);
-  }],
-];
-
-(async () => {
-  let failed = 0;
-  for (const [name, fn] of tests) {
-    try {
-      await fn();
-      console.log(`ok   ${name}`);
-    } catch (e) {
-      failed += 1;
-      console.error(`FAIL ${name}\n     ${e.message}`);
-    }
-  }
-  if (failed) process.exit(1);
-})();
+// Run: npm test (ts-node, no test framework needed)
+// ADV-319: Criteo item mapping bugs found in the DEV feed of 27.10.2026.
+// - custom_label_0 was "[object Object] EUR mtl." for every car;
+// - a car without a rate got "<g:months>0</g:months><g:amount>0 EUR</g:amount>";
+// - a title with an apostrophe was escaped twice ("cee&amp;#39;d");
+// - an unknown energy class was sent as the literal "default".
+import * as assert from 'node:assert/strict';
+import * as fs from 'node:fs';
+import * as os from 'node:os';
+import * as path from 'node:path';
+import { CriteoTransformer } from '../src/transformers/criteo.transformer';
+import { GoogleXmlBuilder } from '../src/formats/google-xml.builder';
+
+const IMAGE = 'https://images.autode-dev.de/generated_images/0/0/0/00000000-0000-4000-8000-000000000001/criteo-Test.jpg';
+
+const baseCar = (patch: any = {}): any => ({
+  _id: '00000000-0000-4000-8000-000000000001',
+  mainData: { make: 'Volkswagen', model: 'Golf', condition: 'selector_condition_used', category: 'selector_category_limousine' },
+  price: { currentSalesPrice: 19990 },
+  offer: { availabilityMode: 'selector_availabilityMode_always' },
+  environmentEmissions: { wltpEnergyEfficiencyClass: 'selector_energyEfficiencyClass_d' },
+  rate: { monthlyInstallment: 164.6, paybackPeriod: 60 },
+  metaData: { ownerId: 'test-dealer', imagesCount: 5 },
+  ...patch,
+});
+
+const transformer = new CriteoTransformer(
+  {} as any,
+  { config: { isCriteo: true, imageType: 'marketing', domain: 'autode-dev.de' } } as any,
+  { getImages: async () => [IMAGE] } as any,
+);
+
+const renderItem = async (item: any): Promise<string> => {
+  const file = path.join(fs.mkdtempSync(path.join(os.tmpdir(), 'criteo-mapping-')), 'feed.xml');
+  const builder = new GoogleXmlBuilder(file);
+  await builder.buildStart('autode-dev.de');
+  await builder.addItem(item);
+  await builder.buildEnd();
+  return fs.readFileSync(file, 'utf8');
+};
+
+const tests: Array<[string, () => Promise<void>]> = [
+  ['custom_label_0 carries the rounded monthly rate, installment keeps months and amount', async () => {
+    const item = await transformer.transform({ car: baseCar(), images: [] });
+    assert.equal(item?.custom_label_0, '165 EUR mtl.');
+    assert.deepEqual(item?.installment, { paybackPeriod: 60, monthlyInstallment: 165 });
+    const xml = await renderItem(item);
+    assert.match(xml, /<g:months>60<\/g:months>/);
+    assert.match(xml, /<g:amount>165 EUR<\/g:amount>/);
+    assert.ok(!xml.includes('[object Object]'));
+  }],
+  ['car without a rate has no installment and no custom_label_0', async () => {
+    for (const rate of [undefined, null, {}, { monthlyInstallment: 0, paybackPeriod: 0 }, { monthlyInstallment: 199 }, { paybackPeriod: 48 }]) {
+      const item = await transformer.transform({ car: baseCar({ rate }), images: [] });
+      assert.ok(item, `item for rate ${JSON.stringify(rate)}`);
+      assert.ok(!('installment' in item), `installment for rate ${JSON.stringify(rate)}`);
+      assert.ok(!('custom_label_0' in item), `custom_label_0 for rate ${JSON.stringify(rate)}`);
+      const xml = await renderItem(item);
+      assert.ok(!xml.includes('g:installment') && !xml.includes('g:custom_label_0'));
+    }
+  }],
+  ['title with an apostrophe is escaped once, by the XML builder', async () => {
+    const item = await transformer.transform({
+      car: baseCar({ mainData: { make: 'Kia', model: "cee'd", condition: 'selector_condition_used' } }),
+      images: [],
+    });
+    assert.equal(item?.title, "Kia cee'd");
+    const xml = await renderItem(item);
+    assert.match(xml, /<g:title>Kia cee&apos;d<\/g:title>/);
+    assert.ok(!xml.includes('&amp;#39;'));
+  }],
+  ['title keeps the Mercedes / VW brand aliases (ACF-6332, ACF-6534)', async () => {
+    const vw = await transformer.transform({ car: baseCar(), images: [] });
+    assert.equal(vw?.title, 'VW Golf');
+    assert.equal(vw?.brand, 'Volkswagen');
+    const mb = await transformer.transform({
+      car: baseCar({ mainData: { make: 'Mercedes-Benz', model: 'A 180', condition: 'selector_condition_used' } }),
+      images: [],
+    });
+    assert.equal(mb?.title, 'Mercedes A 180');
+  }],
+  ['known energy class is sent, unknown or missing class leaves the element out', async () => {
+    const known = await transformer.transform({ car: baseCar(), images: [] });
+    assert.equal(known?.energy_efficiency_class, 'D');
+    for (const environmentEmissions of [{ wltpEnergyEfficiencyClass: 'selector_unknown' }, {}, undefined]) {
+      const item = await transformer.transform({ car: baseCar({ environmentEmissions }), images: [] });
+      assert.ok(item && !('energy_efficiency_class' in item));
+      const xml = await renderItem(item);
+      assert.ok(!xml.includes('g:energy_efficiency_class') && !xml.includes('>default<'));
+    }
+  }],
+  ['unchanged legacy fields: id, link params, price, condition, availability', async () => {
+    const item = await transformer.transform({ car: baseCar(), images: [] });
+    assert.equal(item?.id, '00000000-0000-4000-8000-000000000001');
+    assert.equal(
+      item?.link,
+      'https://www.autode-dev.de/search/vehicle/00000000-0000-4000-8000-000000000001?source=criteo&medium=cpc&campaign=retargeting',
+    );
+    assert.equal(item?.price, '19990 EUR');
+    assert.equal(item?.sale_price, '19990 EUR');
+    assert.equal(item?.condition, 'Gebraucht');
+    assert.equal(item?.availability, 'Sofort');
+    assert.deepEqual(Object.keys(item as any), [
+      'id', 'title', 'description', 'google_product_category', 'product_type', 'link', 'image_link', 'condition',
+      'availability', 'brand', 'price', 'sale_price', 'energy_efficiency_class', 'color', 'installment', 'custom_label_0',
+    ]);
+  }],
+];
+
+(async () => {
+  let failed = 0;
+  for (const [name, fn] of tests) {
+    try {
+      await fn();
+      console.log(`ok   ${name}`);
+    } catch (e) {
+      failed += 1;
+      console.error(`FAIL ${name}\n     ${e.message}`);
+    }
+  }
+  if (failed) process.exit(1);
+})();