@bytebrand/export-cars 1.26.36 → 1.26.37

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.36",
+  "version": "1.26.37",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/exporters/facebook-shop.exporter.ts

@@ -1,6 +1,5 @@
 import { Injectable } from '@nestjs/common';
 import { ModuleRef } from '@nestjs/core';
-import { basename } from 'path';
 
 import { CronicleUtils } from '@bytebrand/cronicle-helper';
 import { FsChunkInterface } from '@bytebrand/chunkable';
@@ -25,9 +24,8 @@ export class FacebookShopExporter implements Exporter {
     await CronicleUtils.ensureDir(this.configService.config.pathesConfig.localConvertedDirectory);
     await CronicleUtils.emptyDir(this.configService.config.pathesConfig.localConvertedDirectory);
 
-    const selfUrl = `https://ftp.${this.configService.config.domain}/feeds/${basename(fileXml)}`;
     const facebookShopXmlBuilder = new FacebookShopXmlBuilder(fileXml);
-    await facebookShopXmlBuilder.buildStart(selfUrl);
+    await facebookShopXmlBuilder.buildStart();
 
     const facebookShopTransformer = await this.moduleRef.create(FacebookShopTransformer);
 

package/src/formats/facebook-shop.builder.ts

@@ -8,18 +8,17 @@ export class FacebookShopXmlBuilder extends XMLBuilderBase {
   // No xmlns:g / g: prefixes here — that namespace belongs to the old Google Merchant /
   // Facebook Shop product-catalog schema. Meta's Automotive Model Ads Vehicle Offers Feed
   // uses plain, undecorated tag names (see facebook-shop.builder field reference above).
-  async buildStart(selfUrl?: string): Promise<void> {
+  // Envelope is <listings>/<listing>, not RSS <rss><channel>/<item>: Meta Commerce Manager
+  // rejects the RSS form for a Vehicle Offers catalog as an invalid file format (ADV-369).
+  async buildStart(): Promise<void> {
     await this.write(
-      '<?xml version="1.0" encoding="utf-8"?>\n<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">' +
-        '\n<channel>\n<title>auto.de Vehicle Offers Feed</title>' +
-        '\n<description>Automotive Model Ads Vehicle Offers Feed für auto.de</description>' +
-        '\n<link>https://www.auto.de/</link>' +
-        `\n<atom:link href="${escape(selfUrl)}" rel="self" type="application/rss+xml" />\n`,
+      '<?xml version="1.0" encoding="utf-8"?>\n<listings>' +
+        '\n<title>auto.de Vehicle Offers Feed</title>\n',
     );
   }
 
   async addItem(car: FacebookShopItem): Promise<void> {
-    let item = '\n<item>\n';
+    let item = '\n<listing>\n';
 
     const { image, ...tags } = car;
 
@@ -32,7 +31,7 @@ export class FacebookShopXmlBuilder extends XMLBuilderBase {
       .map((url: string) => `<image><url>${escape(url)}</url></image>\n`)
       .join('');
 
-    item += '</item>';
+    item += '</listing>';
 
     await this.write(item);
   }
@@ -53,7 +52,7 @@ export class FacebookShopXmlBuilder extends XMLBuilderBase {
   }
 
   async buildEnd(): Promise<void> {
-    await this.write('\n</channel>\n</rss>\n');
+    await this.write('\n</listings>\n');
     await this.end();
   }
 }