@bytebrand/export-cars 1.26.33 → 1.26.35

package/docs/openai-ads/AUDIT.md

@@ -147,7 +147,7 @@ Null policy "EXCLUDE" = row not written + counted in the run report under the re
 Delta (deferred, only with API access): `products[].id = item_id`, price `{"amount": round(currentSalesPrice*100), "currency":"EUR"}`.
 
 Filters before mapping (all reasons counted in the run report):
-`imagesCount > 0` (existing `filterCar`), price valid, optional price cap (Q9), dealer `active && !blacklist` via `CarService.getOwner` (cached per dealer, failure → EXCLUDE `dealer_unknown`), title/brand/image present.
+`imagesCount > 0` (existing `filterCar`), price valid, €80k price cap (same as Google/Meta, Q9 closed 14.10; `price_cap`), dealer `active && !blacklist` via `CarService.getOwner` (cached per dealer, failure → EXCLUDE `dealer_unknown`), title/brand/image present.
 
 ---
 
@@ -177,7 +177,7 @@ Filters before mapping (all reasons counted in the run report):
 | Q6 | Description: reuse dealer summary templates (same as Google) — do they contain finance claims? Or plain generated German text only? | PM/Legal | description |
 | Q7 | `ads_metadata` keys configured in Ads Manager (if any) | Marketing | optional |
 | Q8 | `product_category` wanted? | Marketing | optional |
-| Q9 | Apply the 80k price cap of Google/Meta? | Marketing | filter |
+| Q9 | Apply the 80k price cap of Google/Meta? — **closed 14.10: yes**, same cap and resolver (1.26.34) | Marketing | done |
 | Q10 | Import method available in the account: hosted URL (needs fetch IP/auth info) or SFTP (credentials into secret store); API access (delta, upload status)? | Marketing | transport |
 | Q11 | OAI-AdsBot / OAI-SearchBot reachability of `www.auto.de` VDP and `images.auto.de` behind Cloudflare (js_challenge rules from ADV-193). Test only, no CF change without approval. | Eng + approval | go-live |
 | Q12 | Image: ADV-336 clean profile is used (no overlay). Approval of plain photos + `ext_lr_main` question open in ADV-336 | ADV-336 | image_url |
@@ -222,7 +222,7 @@ retention 15 days; reinstatement keeps the id), run report, `RUNBOOK.md`, 23 tes
 Open questions decided in code for now (each reversible by a param or a one-line change):
 Q3 `seller_name` = `auto.de` (param); Q4 reserved/sold flag → out_of_stock, and never advertised when not sent before;
 Q5 unknown condition → `used` only with a past first registration; Q6 description from structured data only;
-Q9 no price cap unless `maxCurrentSalesPrice` is set; Q7/Q8 `ads_metadata` / `product_category` not sent.
+Q9 (closed 14.10) €80k cap as Google/Meta; Q7/Q8 `ads_metadata` / `product_category` not sent.
 
 Found while running the compiled job (`node dist/main.js` with a stdin job): **export-cars reports every failed
 run as success.** nest-commander's default `serviceErrorHandler` only prints the error, and `main.ts` then

package/docs/openai-ads/RUNBOOK.md

@@ -53,7 +53,7 @@ only. By user decision it has no schedule and no failure e-mail — nothing to c
 | `openAiAdsSellerName` | `auto.de` | `seller_name` (open question Q3) |
 | `openAiAdsRetentionDays` | 15 | days an item stays as out_of_stock after it was last in stock |
 | `openAiAdsImageConcurrency` | 16 | parallel image HEAD checks against images.auto.de |
-| `maxCurrentSalesPrice` | none | optional price cap (no 80k default here, Q9) |
+| `maxCurrentSalesPrice` | 80000 | €80k selling-price cap, same as Google/Meta (decision 14.10); a valid positive value overrides, empty/invalid = 80000 |
 | `feedGuardMinSourceItems` | 1000 | DEV: set ~50 |
 | `feedGuardMinPublishedItems` | 500 | DEV: set ~20 |
 | `feedGuardMaxDropPercent` | 20 | vs the last good run |
@@ -94,6 +94,15 @@ running after a failure as before.
 Only `openai_ads` is protected: the feed guard keeps the last good file, and the job exits with code 1
 (`exitError` + exit 1 in `openai-ads.exporter.ts`). It has no chain, so this stops nothing else.
 
+## €80k price cap (`price_cap`, since 1.26.34)
+
+Decision 14.10: the OpenAI feed uses the same selling-price cap as Google/Meta. `OpenAiAdsConfig` resolves
+`maxCurrentSalesPrice` with the shared `resolveMaxFeedSalesPrice` (default `MAX_FEED_SALES_PRICE_EUR` = 80,000), and the
+shared gate `CarService.filterCar` applies it: price must be finite, > 0 and ≤ cap (80,000.00 included, 80,000.01 not).
+Cars above the cap are counted as `excluded.price_cap`. A car that was advertised and then crosses the cap stays in the
+file as out_of_stock (same id, last advertised data) via the ledger — it does not just disappear.
+⚠️ DEV google/fb/facebookshop events have carried a 20000 value in the past; check the param of any new event.
+
 ## No finance claims (`finance_claim`, since 1.26.33)
 
 OpenAI's ad policy lists "Auto loans and leasing" outside the US as "Restricted to Select Approved Advertisers"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.33",
+  "version": "1.26.35",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",
@@ -11,7 +11,7 @@
     "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
     "lint": "eslint -c .eslintrc.js --ext .ts src/",
     "start:dev": "nest start --watch",
-    "test": "ts-node --transpile-only test/google-feed-envkv.test.ts && ts-node --transpile-only test/google-feed-item-row.test.ts && ts-node --transpile-only test/publication-gate.test.ts && ts-node --transpile-only test/images-regression.test.ts && ts-node --transpile-only test/clean-images.test.ts && ts-node --transpile-only test/image-url-validator.test.ts && ts-node --transpile-only test/openai-image-fields.test.ts && ts-node --transpile-only test/openai-ads-mapping.test.ts && ts-node --transpile-only test/openai-ads-feed-run.test.ts && ts-node --transpile-only test/openai-ads-finance.test.ts && ts-node --transpile-only test/meinstadt-mapping.test.ts && ts-node --transpile-only test/meinstadt-feed-run.test.ts && ts-node --transpile-only test/autouncle-mapping.test.ts && ts-node --transpile-only test/autouncle-feed-run.test.ts"
+    "test": "ts-node --transpile-only test/google-feed-envkv.test.ts && ts-node --transpile-only test/google-feed-item-row.test.ts && ts-node --transpile-only test/publication-gate.test.ts && ts-node --transpile-only test/images-regression.test.ts && ts-node --transpile-only test/clean-images.test.ts && ts-node --transpile-only test/image-url-validator.test.ts && ts-node --transpile-only test/openai-image-fields.test.ts && ts-node --transpile-only test/openai-ads-mapping.test.ts && ts-node --transpile-only test/openai-ads-feed-run.test.ts && ts-node --transpile-only test/openai-ads-finance.test.ts && ts-node --transpile-only test/openai-ads-price-cap.test.ts && ts-node --transpile-only test/meinstadt-mapping.test.ts && ts-node --transpile-only test/meinstadt-feed-run.test.ts && ts-node --transpile-only test/autouncle-mapping.test.ts && ts-node --transpile-only test/autouncle-feed-run.test.ts"
   },
   "dependencies": {
     "@bytebrand/autode-request": "^1.19.2",

package/src/configs/config.ts

@@ -53,7 +53,8 @@ export class Config {
       criteoMarketingImagesConfigId: 12,
       localConvertedDirectory: 'resources/csv_dev',
       remoteDirectory: 'import_dev',
-      imageUrl: 'https://images.autode-dev.de/cache_test',
+      // image-generator writes marketing images (criteo, fb) to /generated_images on DEV too — same as PROD
+      imageUrl: 'https://images.autode-dev.de/generated_images',
       baseImageUrl: 'https://images.autode-dev.de',
     },
     [Environment.PRODUCTION]: {

package/src/configs/openai-ads.config.ts

@@ -1,6 +1,7 @@
 import { toNumber } from 'lodash';
 
 import { ExportType, FileType, ImageType } from '../enums';
+import { resolveMaxFeedSalesPrice } from '../constants/feed-price.constants';
 import { Params } from '../interfaces/params.interface';
 import { FeedGuardOptions } from '../services/feed-guard';
 import { Config } from './config';
@@ -50,10 +51,9 @@ export class OpenAiAdsConfig extends Config {
     this.sellerName = text(params.openAiAdsSellerName) || OPENAI_ADS_DEFAULTS.sellerName;
     this.retentionDays = positiveNumber(params.openAiAdsRetentionDays, OPENAI_ADS_DEFAULTS.retentionDays);
     this.imageConcurrency = positiveNumber(params.openAiAdsImageConcurrency, OPENAI_ADS_DEFAULTS.imageConcurrency);
-    // Shared price cap stays opt-in here (open question to Marketing): only an explicit
-    // maxCurrentSalesPrice param applies it, no 80k default as for Google/Meta.
-    const cap = positiveNumber(params.maxCurrentSalesPrice, 0);
-    this.maxCurrentSalesPrice = cap || undefined;
+    // Same €80k selling-price cap as Google/Meta (decision 14.10): a valid positive
+    // maxCurrentSalesPrice param wins, else MAX_FEED_SALES_PRICE_EUR. Applied by CarService.filterCar.
+    this.maxCurrentSalesPrice = resolveMaxFeedSalesPrice(params.maxCurrentSalesPrice);
     this.feedGuard = {
       stateDir: this.stateDir,
       minSourceItems: positiveNumber(params.feedGuardMinSourceItems, OPENAI_ADS_DEFAULTS.minSourceItems),

package/src/exporters/openai-ads.exporter.ts

@@ -1,4 +1,5 @@
 import { Injectable } from '@nestjs/common';
+import { get, toNumber } from 'lodash';
 import { FsChunkInterface } from '@bytebrand/chunkable';
 import { LoggerService } from '@bytebrand/cronicle-helper';
 import { TranslatorExtended } from '@bytebrand/schema-tools';
@@ -11,6 +12,20 @@ import { DealerStatus, OpenAiAdsFeedRun, SourceCar } from '../services/openai-ad
 import { resolveOpenAiImageFields } from '../transformers/openai-image-fields';
 import { OpenAiAdsConfig } from '../configs/openai-ads.config';
 import { Exporter } from '../interfaces/exporter.interface';
+import { OpenAiAdsExclusion } from '../interfaces/openai-ads.interface';
+
+/**
+ * CarService.filterCar decides (images, €80k cap, Cronicle rules); this only names the reason for the
+ * run report: a rejected car with a valid price above the cap counts as price_cap, else filtered.
+ */
+export const classifyPartnerFilter = (passed: boolean, source: SourceCar, cap: number | undefined): OpenAiAdsExclusion | null => {
+  if (passed) {
+    return null;
+  }
+  const price = toNumber(get(source, 'car.price.currentSalesPrice', null));
+  const hasImages = (source?.car?.metaData?.imagesCount ?? 0) > 0;
+  return cap && hasImages && Number.isFinite(price) && price > cap ? OpenAiAdsExclusion.priceCap : OpenAiAdsExclusion.filtered;
+};
 
 /**
  * ExportType.OPENAI_ADS (ADV-335). Wires the Cronicle/Nest services into OpenAiAdsFeedRun, which
@@ -35,7 +50,9 @@ export class OpenAiAdsExporter implements Exporter {
     const run = new OpenAiAdsFeedRun(
       {
         forEachChunk: fn => this.loaderService.process((chunk: FsChunkInterface) => fn(chunk.data as SourceCar[])),
-        filterCar: source => this.carService.filterCar(source, this.rulesService.rules),
+        filterCar: source => classifyPartnerFilter(
+          this.carService.filterCar(source, this.rulesService.rules), source, config.maxCurrentSalesPrice,
+        ),
         dealerStatus: ownerId => this.dealerStatus(ownerId),
         resolveImages: ({ car, images }) =>
           resolveOpenAiImageFields(this.imagesService.getCleanImages(car._id, images), validator),

package/src/interfaces/openai-ads.interface.ts

@@ -46,6 +46,8 @@ export enum OpenAiAdsExclusion {
   noId = 'no_id',
   duplicateId = 'duplicate_id',
   filtered = 'filtered',
+  // price.currentSalesPrice above the feed cap (€80k default, maxCurrentSalesPrice param)
+  priceCap = 'price_cap',
   invalidPrice = 'invalid_price',
   noTitle = 'no_title',
   noBrand = 'no_brand',

package/src/services/openai-ads-feed-run.ts

@@ -30,8 +30,9 @@ export type DealerStatus = 'active' | 'inactive' | 'unknown';
 export interface OpenAiAdsRunDeps {
   // iterates the base export snapshot chunk by chunk (LoaderService.process)
   forEachChunk: (fn: (cars: SourceCar[]) => Promise<void>) => Promise<unknown>;
-  // existing shared partner filter (images count, optional price cap, Cronicle rules)
-  filterCar: (source: SourceCar) => boolean;
+  // existing shared partner filter (images count, €80k price cap, Cronicle rules): null = passes,
+  // else the exclusion reason (price_cap or filtered)
+  filterCar: (source: SourceCar) => OpenAiAdsExclusion | null;
   dealerStatus: (ownerId: string) => Promise<DealerStatus>;
   // ADV-336 clean images, validated
   resolveImages: (source: SourceCar) => Promise<OpenAiImageSelection>;
@@ -146,8 +147,9 @@ export class OpenAiAdsFeedRun {
             continue;
           }
           seen.add(id);
-          if (!this.deps.filterCar(source)) {
-            increment(report.excluded, OpenAiAdsExclusion.filtered);
+          const filtered = this.deps.filterCar(source);
+          if (filtered) {
+            increment(report.excluded, filtered);
             continue;
           }
           const mapped = mapOpenAiAdsVehicle(source.car, mapping);

package/test/openai-ads-feed-run.test.ts

@@ -9,6 +9,7 @@ import { join } from 'path';
 import { FeedGuard, FeedGuardError, FeedGuardOptions } from '../src/services/feed-guard';
 import { DealerStatus, OpenAiAdsFeedRun, SourceCar } from '../src/services/openai-ads-feed-run';
 import { selectOpenAiImageFields } from '../src/transformers/openai-image-fields';
+import { OpenAiAdsExclusion } from '../src/interfaces/openai-ads.interface';
 import { buildImagesService } from './fixtures/images-service.harness';
 import { NOW, car, csvObjects, images, translate } from './fixtures/openai-ads.fixture';
 
@@ -69,7 +70,10 @@ const run = async (world: World, at: Date = NOW, extra: Partial<FeedGuardOptions
   const feed = new OpenAiAdsFeedRun(
     {
       forEachChunk,
-      filterCar: ({ car: c }) => (c?.metaData?.imagesCount ?? 0) > 0,
+      filterCar: ({ car: c }) => {
+        if (!((c?.metaData?.imagesCount ?? 0) > 0)) return OpenAiAdsExclusion.filtered;
+        return Number(c?.price?.currentSalesPrice) > 80_000 ? OpenAiAdsExclusion.priceCap : null;
+      },
       dealerStatus: async ownerId => world.dealers[ownerId] ?? 'active',
       resolveImages: async ({ car: c, images: list }) => {
         const clean = imagesService.getCleanImages(c._id, list);
@@ -160,6 +164,21 @@ const cases: Array<[string, () => Promise<void>]> = [
     assert.equal(back['car-1'].availability, 'in_stock');
     assert.equal(Object.keys(back).length, 5);
   }],
+  ['price crosses the €80k cap: advertised car switches to out_of_stock (same id), 80,000.00 stays', async () => {
+    const w = await newWorld();
+    await writeSource(w, [src('car-0', { 'price.currentSalesPrice': 79_990 }), src('car-1', { 'price.currentSalesPrice': 79_000 }), ...fleet(5).slice(2)]);
+    await run(w);
+    const next = new Date(NOW.getTime() + DAY);
+    await writeSource(w, [src('car-0', { 'price.currentSalesPrice': 80_000.01 }), src('car-1', { 'price.currentSalesPrice': 80_000 }), ...fleet(5).slice(2)], 2, next);
+    const report = await run(w, next);
+    const rows = byId(await published(w));
+    assert.equal(rows['car-0'].availability, 'out_of_stock');
+    assert.equal(rows['car-0'].price, '79990.00 EUR', 'last advertised data, not the new price');
+    assert.equal(rows['car-1'].availability, 'in_stock');
+    assert.equal(rows['car-1'].price, '80000.00 EUR');
+    assert.equal(report.excluded.price_cap, 1);
+    assert.deepEqual(report.outOfStock, { not_in_snapshot: 1 });
+  }],
   ['out_of_stock rows stop after the retention window', async () => {
     const w = await newWorld();
     await writeSource(w, fleet(5));

package/test/openai-ads-price-cap.test.ts

@@ -0,0 +1,69 @@
+// Run: npm test (ts-node, no test framework needed)
+// Decision 14.10: the OpenAI feed uses the same €80k selling-price cap as Google/Meta.
+import * as assert from 'node:assert/strict';
+
+import { OpenAiAdsConfig } from '../src/configs/openai-ads.config';
+import { MAX_FEED_SALES_PRICE_EUR, resolveMaxFeedSalesPrice } from '../src/constants/feed-price.constants';
+import { CarService } from '../src/services/car.service';
+import { classifyPartnerFilter } from '../src/exporters/openai-ads.exporter';
+import { OpenAiAdsExclusion as X } from '../src/interfaces/openai-ads.interface';
+import { car } from './fixtures/openai-ads.fixture';
+
+const openAiConfig = (maxCurrentSalesPrice?: string) =>
+  new OpenAiAdsConfig({ environment: 'develop', exportType: 'openai_ads', maxCurrentSalesPrice } as any);
+
+// The real shared gate, with the OpenAI config (no Cronicle rules).
+const filterCar = (config: OpenAiAdsConfig, price: unknown, imagesCount = 3) => {
+  const service = new CarService(null as any, null as any, { config } as any);
+  return service.filterCar({ car: car('id', { 'price.currentSalesPrice': price, 'metaData.imagesCount': imagesCount }) }, []);
+};
+
+const cases: Array<[string, () => void]> = [
+  ['config: default cap is the shared 80,000 (same resolver as Google/Meta)', () => {
+    assert.equal(MAX_FEED_SALES_PRICE_EUR, 80_000);
+    for (const raw of [undefined, '', '  ', 'abc', '0', '-5']) {
+      assert.equal(openAiConfig(raw).maxCurrentSalesPrice, 80_000, String(raw));
+      // google/fb/facebook-shop configs call the same resolver
+      assert.equal(openAiConfig(raw).maxCurrentSalesPrice, resolveMaxFeedSalesPrice(raw));
+    }
+  }],
+  ['config: a valid positive param wins (50000)', () => {
+    assert.equal(openAiConfig('50000').maxCurrentSalesPrice, 50_000);
+  }],
+  ['gate (CarService.filterCar): 80,000.00 included, 80,000.01 excluded', () => {
+    const config = openAiConfig();
+    assert.equal(filterCar(config, 80_000), true);
+    assert.equal(filterCar(config, '80000.00'), true);
+    assert.equal(filterCar(config, 79_999.99), true);
+    assert.equal(filterCar(config, 80_000.01), false);
+    assert.equal(filterCar(config, 222_148), false);
+    for (const bad of [0, -1, null, 'abc']) {
+      assert.equal(filterCar(config, bad), false, String(bad));
+    }
+  }],
+  ['gate with param 50000: 50,000 in, 50,000.01 out', () => {
+    const config = openAiConfig('50000');
+    assert.equal(filterCar(config, 50_000), true);
+    assert.equal(filterCar(config, 50_000.01), false);
+  }],
+  ['report reason: above the cap = price_cap; no photos or invalid price = filtered; passed = null', () => {
+    const source = (price: unknown, imagesCount = 3) => ({ car: car('id', { 'price.currentSalesPrice': price, 'metaData.imagesCount': imagesCount }), images: [] });
+    assert.equal(classifyPartnerFilter(false, source(80_000.01), 80_000), X.priceCap);
+    assert.equal(classifyPartnerFilter(false, source(95_000, 0), 80_000), X.filtered);
+    assert.equal(classifyPartnerFilter(false, source(0), 80_000), X.filtered);
+    assert.equal(classifyPartnerFilter(false, source(17_990), 80_000), X.filtered);
+    assert.equal(classifyPartnerFilter(true, source(17_990), 80_000), null);
+  }],
+];
+
+let failed = 0;
+for (const [name, fn] of cases) {
+  try {
+    fn();
+    console.log(`ok   ${name}`);
+  } catch (e) {
+    failed += 1;
+    console.error(`FAIL ${name}\n     ${e.message}`);
+  }
+}
+if (failed) process.exit(1);