@bytebrand/export-cars 1.26.30 → 1.26.31

package/docs/openai-ads/AUDIT.md

@@ -182,6 +182,7 @@ Filters before mapping (all reasons counted in the run report):
 | Q11 | OAI-AdsBot / OAI-SearchBot reachability of `www.auto.de` VDP and `images.auto.de` behind Cloudflare (js_challenge rules from ADV-193). Test only, no CF change without approval. | Eng + approval | go-live |
 | Q12 | Image: ADV-336 clean profile is used (no overlay). Approval of plain photos + `ext_lr_main` question open in ADV-336 | ADV-336 | image_url |
 | Q13 | Is a "Stable" vs "Draft" schema selector visible in your docs/account? The public page shows none on 09.10. | Marketing | — |
+| Q14 | Make mapping at import (out of feed scope): DEV car titled "Jeep SWM G01a" — model SONSTIGE, variant names SWM (a different manufacturer), so the feed sends `brand=Jeep` for a non-Jeep car. Fix belongs to the import make/model mapping (sheet / CBD), not to the exporter. | Import owner | brand correctness |
 
 ---
 

package/docs/openai-ads/RUNBOOK.md

@@ -77,6 +77,25 @@ up for the **live** output only (separate, approved step).
 | `count_drop` | > N % fewer cars than the last good run | confirm the drop is real (CBD online count, dealer offboarding), then ONE run with `feedGuardAcceptDrop=true` |
 | `locked` | another run holds `run.lock` (< 6 h) | wait; a lock older than 6 h is taken over automatically |
 
+## Known risk: other export-cars jobs report failures as success (accepted, 12.10)
+
+Every export-cars run except `openai_ads` ends with `{"complete":1,"code":0}`, even when the exporter threw:
+nest-commander's default `serviceErrorHandler` only prints the error and `main.ts` then reports success. Cronicle
+therefore treats a failed part 1 as successful and starts the chained part 2, which can upload an empty or
+partial file (Google feed incident 24.09: a 169-byte feed was uploaded and fetched by Google). Decision
+(user, 12.10): keep it — no global fix, no `chain_error` handlers, no Cronicle config change; the chains keep
+running after a failure as before.
+
+Only `openai_ads` is protected: the feed guard keeps the last good file, and the job exits with code 1
+(`exitError` + exit 1 in `openai-ads.exporter.ts`). It has no chain, so this stops nothing else.
+
+## Known source-data issues (not fixed by the feed)
+
+- Wrong make from the import mapping: e.g. DEV "Jeep SWM G01a" (model SONSTIGE, the variant names another
+  manufacturer). The feed sends the stored make as `brand`; correct it in the import make/model mapping (AUDIT Q14).
+- Handled in the feed since 1.26.30: placeholder model `SONSTIGE` is left out of title/description; UTF-8 read as
+  Latin-1/cp1252 upstream (`ü` → `ü`) is repaired.
+
 ## Rollback
 
 - Bad content published: `cp <output>.prev <output>` (the previous good file), then disable the Cronicle event.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.30",
+  "version": "1.26.31",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/services/images.service.ts

@@ -28,6 +28,11 @@ export const CLEAN_HERO_IMAGE_CODES = ['ext_f_right', 'ext_f_left'];
 // Explicit JPEG variant — the extension-less `large` URL negotiates WebP from the Accept header
 // (no Vary), so a crawler could get a different format than the one we validated.
 export const CLEAN_IMAGE_VARIANT = 'large-cached.jpeg';
+// Real exterior views the shared IMAGES_SORT_ORDER doesn't know, accepted by the clean profile only
+// (other feeds stay unchanged). Ranks sit between the last exterior view (18) and conext_* (19).
+export const CLEAN_EXTRA_IMAGE_SORT_ORDER: { [imageCode: string]: number } = {
+  ext_lr_main: 18.5,
+};
 
 @Injectable()
 export class ImagesService {
@@ -195,8 +200,9 @@ export class ImagesService {
   /**
    * Clean channel profile (ADV-336): the car's own photos only, as explicit JPEG URLs, in a
    * deterministic order — 3/4 exterior hero first, then the remaining exterior views, then the
-   * interior views (IMAGES_SORT_ORDER). Feature close-ups (`_feat_`), `conext_*` and codes the
-   * sort order doesn't know (simple_*, promo, ...) are dropped; so are repeated imageIdentifiers.
+   * interior views (IMAGES_SORT_ORDER + CLEAN_EXTRA_IMAGE_SORT_ORDER). Feature close-ups (`_feat_`),
+   * `conext_*` and codes neither order knows (simple_*, promo, ...) are dropped; so are repeated
+   * imageIdentifiers.
    * Returns [] when the car has no 3/4 exterior shot — callers skip the car, never substitute a
    * placeholder. Does not validate the URLs (see ImageUrlValidator) and never mutates `images`.
    */
@@ -214,7 +220,8 @@ export class ImagesService {
       seen.add(image.imageIdentifier);
       return true;
     });
-    const sorted = this.sortImages(eligible);
+    // stable sort, ties keep Imbo order
+    const sorted = eligible.sort((a, b) => this.getCleanSortOrder(this.getImageCode(a)) - this.getCleanSortOrder(this.getImageCode(b)));
 
     const heroIndex = CLEAN_HERO_IMAGE_CODES
       .map(code => sorted.findIndex(image => this.getImageCode(image) === code))
@@ -240,7 +247,11 @@ export class ImagesService {
   }
 
   private isCleanImageCode(imageCode: string): boolean {
-    return /^(ext|int)_/.test(imageCode) && !imageCode.includes('_feat_') && imageCode in this.IMAGES_SORT_ORDER;
+    return /^(ext|int)_/.test(imageCode) && !imageCode.includes('_feat_') && this.getCleanSortOrder(imageCode) !== undefined;
+  }
+
+  private getCleanSortOrder(imageCode: string): number | undefined {
+    return this.IMAGES_SORT_ORDER[imageCode] ?? CLEAN_EXTRA_IMAGE_SORT_ORDER[imageCode];
   }
 
   private getImageCode(image: ImboImageResponseInterface): string | undefined {

package/test/clean-images.test.ts

@@ -38,6 +38,32 @@ const cases: Array<[string, () => void | Promise<void>]> = [
     ];
     assert.deepEqual(service.getCleanImages('car', images).map(i => i.imageIdentifier), ['left', 'cowl']);
   }],
+  ['ext_lr_main (clean-only allowlist) comes after the other exterior views, before interior', () => {
+    const images = [
+      { imageIdentifier: 'dash', imageCodePredicted: 'int_f_ipanel1' },
+      { imageIdentifier: 'lr', imageCodePredicted: 'ext_lr_main-normalcar' },
+      { imageIdentifier: 'opened', imageCodePredicted: 'ext_f_right_opened' },
+      { imageIdentifier: 'back', imageCodePredicted: 'ext_b_main' },
+      { imageIdentifier: 'right', imageCodePredicted: 'ext_f_right-normalcar' },
+    ];
+    const result = service.getCleanImages('car', images);
+    assert.deepEqual(result.map(i => i.imageIdentifier), ['right', 'back', 'opened', 'lr', 'dash']);
+    assert.equal(result.find(i => i.imageIdentifier === 'lr').heroCandidate, false);
+  }],
+  ['ext_lr_main is never the hero', () => {
+    assert.deepEqual(service.getCleanImages('car', [{ imageIdentifier: 'lr', imageCodePredicted: 'ext_lr_main' }]), []);
+  }],
+  ['the clean-only allowlist does not touch the other profiles (ext_lr_main still ranks 100 there)', async () => {
+    const images = () => [
+      { imageIdentifier: 'lr', imageCodePredicted: 'ext_lr_main' },
+      { imageIdentifier: 'dash', imageCodePredicted: 'int_f_ipanel1' },
+      { imageIdentifier: 'right', imageCodePredicted: 'ext_f_right' },
+    ];
+    const urls = await service.getImages({ _id: 'car' } as any, images(), ImageType.default, true);
+    assert.deepEqual(urls.map(u => u.split('/')[5]), ['right', 'dash', 'lr']);
+    const google = await service.getExtIntDefaultImages({ _id: 'car' } as any, images(), ImageType.default, false);
+    assert.deepEqual(google.ext.map(u => u.split('/')[5]), ['lr']);
+  }],
   ['no 3/4 exterior shot: no images at all (car is skipped, no fallback hero)', () => {
     assert.deepEqual(clean('noHero'), []);
     assert.deepEqual(clean('onlyUnknown'), []);