@bytebrand/export-cars 1.26.2 → 1.26.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.2",
+  "version": "1.26.4",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/services/images.service.ts

@@ -13,7 +13,7 @@ import { ConfigService } from './config.service';
 import { UserService } from './user.service';
 import { isNotEmptyArray } from '../utils';
 import { Config } from '../configs/config';
-import { ImageSize, ImageType } from '../enums';
+import { ExportType, ImageSize, ImageType } from '../enums';
 
 @Injectable()
 export class ImagesService {
@@ -85,6 +85,8 @@ export class ImagesService {
     'https://images.auto.de/carimage/noimage/pFyfBsqBHEso/large-cached.jpeg',
   ];
 
+  private hasLoggedMarketingImageDebug = false;
+
   constructor(private readonly configService: ConfigService, private readonly userService: UserService) { }
 
   async getImages(car: DataSchemes.Car, images: ImboImageResponseInterface[], imageType: ImageType, ignoreDefImages: boolean): Promise<Array<string>> {
@@ -179,9 +181,31 @@ export class ImagesService {
     const imageUrl = this.configService.config.marketingImageUrl;
 
     const transformedImages = this.transformImagesArrayIntoObject(images);
-    const config = await this.userService.getMarketingImageConfig(this.configService.config.marketingImageConfigId);
+    // fbMarketingImageId is a hardcoded per-environment id in config.ts and has drifted from
+    // the real meta_aia config at least once (dev's id pointed at a stale, never-populated "fb"
+    // channel) — the FB feed resolves its config by channelCode instead of trusting that id.
+    const config = this.configService.config.exportType === ExportType.FB
+      ? await this.userService.getMarketingImageConfigByChannelCode('meta_aia')
+      : await this.userService.getMarketingImageConfig(this.configService.config.marketingImageConfigId);
+
+    if (!config) {
+      console.log('getMarketingImages: no marketing image config found (channelCode meta_aia missing?)');
+      return ignoreDefImages ? [] : [...this.DEFAULT_IMAGES];
+    }
+
     const marketingImageConfigs = config.marketingImages.map(i => ({ marketingImageCodes: i.imageCodes }));
 
+    if (this.configService.config.exportType === ExportType.FB && !this.hasLoggedMarketingImageDebug) {
+      this.hasLoggedMarketingImageDebug = true;
+      console.log(
+        'getMarketingImages debug —',
+        'config.id:', config.id,
+        'config.channelCode:', config.channelCode,
+        'requested imageCodes per slot:', JSON.stringify(marketingImageConfigs.map(c => c.marketingImageCodes)),
+        'photo codes available on this car:', JSON.stringify(Object.keys(transformedImages)),
+      );
+    }
+
     const imageWithUrls: Partial<ImboImageResponseInterface & { url: string }>[] = [];
     for (let i = 0; i < marketingImageConfigs.length; i++) {
       const marketingImage = marketingImageConfigs[i];

package/src/services/user.service.ts

@@ -67,4 +67,17 @@ export class UserService {
 
     return result;
   }
+
+  // The per-environment fbMarketingImageId config.ts hardcodes doesn't reliably point at the
+  // meta_aia channel (dev's id 8 turned out to be a stale, never-populated "fb" channel) —
+  // resolve by channelCode instead of trusting a fixed id.
+  async getMarketingImageConfigByChannelCode(channelCode: string): Promise<MarketingImageConfigInterface | null> {
+    const configs = await this.getMarketingImageConfigs();
+    const match = configs.find(config => config.channelCode === channelCode);
+    if (!match) {
+      return null;
+    }
+
+    return this.getMarketingImageConfig(match.id);
+  }
 }