@bytebrand/export-cars 1.26.18 → 1.26.20

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.18",
+  "version": "1.26.20",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/configs/facebook-shop.config.ts

@@ -1,13 +1,13 @@
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 import { ExportType, FileType } from '../enums';
-import { MAX_FEED_SALES_PRICE_EUR } from '../constants/feed-price.constants';
+import { resolveMaxFeedSalesPrice } from '../constants/feed-price.constants';
 
 export class FacebookShopConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.FACEBOOK_SHOP}-export`;
-    this.maxCurrentSalesPrice = MAX_FEED_SALES_PRICE_EUR;
+    this.maxCurrentSalesPrice = resolveMaxFeedSalesPrice(params.maxCurrentSalesPrice);
     this.imageUrl = this.environmentConfig[params.environment].baseImageUrl;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.FACEBOOK_SHOP}.${FileType.XML}`,

package/src/configs/fb.config.ts

@@ -1,5 +1,5 @@
 import { ExportType, FileType, ImageType } from 'src/enums';
-import { MAX_FEED_SALES_PRICE_EUR } from '../constants/feed-price.constants';
+import { resolveMaxFeedSalesPrice } from '../constants/feed-price.constants';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -7,7 +7,7 @@ export class FbConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.FB}-export`;
-    this.maxCurrentSalesPrice = MAX_FEED_SALES_PRICE_EUR;
+    this.maxCurrentSalesPrice = resolveMaxFeedSalesPrice(params.maxCurrentSalesPrice);
     this.imageUrl = this.environmentConfig[params.environment].imageUrl;
     this.imageType = ImageType.marketing;
     this.marketingImageConfigId = this.environmentConfig[params.environment].fbMarketingImageId;

package/src/configs/google.config.ts

@@ -1,5 +1,5 @@
 import { ExportType, FileType, ImageType } from 'src/enums';
-import { MAX_FEED_SALES_PRICE_EUR } from '../constants/feed-price.constants';
+import { resolveMaxFeedSalesPrice } from '../constants/feed-price.constants';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -8,7 +8,7 @@ export class GoogleConfig extends Config {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.GOOGLE}-export`;
     this.imageType = ImageType.default;
-    this.maxCurrentSalesPrice = MAX_FEED_SALES_PRICE_EUR;
+    this.maxCurrentSalesPrice = resolveMaxFeedSalesPrice(params.maxCurrentSalesPrice);
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.GOOGLE}.${FileType.XML}`,
     ];

package/src/constants/feed-price.constants.ts

@@ -1,4 +1,11 @@
+import { toNumber } from 'lodash';
+
 // Shared eligibility cap for the Google Vehicle Ads and Meta AIA/AMA feeds:
 // only cars whose end-customer selling price (price.currentSalesPrice) is
 // ≤ €80,000 may be exported. €80,000.00 itself is still included.
 export const MAX_FEED_SALES_PRICE_EUR = 80_000;
+
+// The Cronicle "Max currentSalesPrice" plugin param (a text field) can override
+// the default cap per event; empty/invalid/non-positive values fall back to it.
+export const resolveMaxFeedSalesPrice = (raw?: string): number =>
+  toNumber(raw) > 0 ? toNumber(raw) : MAX_FEED_SALES_PRICE_EUR;

package/src/interfaces/params.interface.ts

@@ -11,4 +11,7 @@ export interface Params {
   cpc?: string;
   ownerId?: string;
   metaPushPriorityCsvUrl?: string;
+  // Cronicle plugin param (text field, so it arrives as a string); overrides the
+  // default MAX_FEED_SALES_PRICE_EUR cap in the configs that apply one.
+  maxCurrentSalesPrice?: string;
 }

package/src/transformers/auto24.transfomer.ts

@@ -41,7 +41,8 @@ export class Auto24Transformer {
       fueltype: this.translateSelector(get(car, 'consumption.fuel', '')),
       consumptionK: toString(get(car, 'consumption.consumptionCombined', '')),
       co2: toString(get(car, 'environmentEmissions.co2', '')),
-      efficiencyclass: this.translateSelector(get(car, 'environmentEmissions.energyEfficiencyClass', '')),
+      // ADV-187: canonical CO2-derived WLTP class, not the unvalidated legacy NEFZ class.
+      efficiencyclass: this.translateSelector(get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', '')),
       image: transformedImages[0],
       registration: this.getRegistrationField(get(car, 'mainData.firstRegistration') as number),
       images: transformedImages,

package/src/transformers/autouncle.transformer.ts

@@ -68,7 +68,8 @@ export class AutouncleTransformer {
       images: transformed_images,
       fuel_economy: toString(get(car, 'consumption.consumptionCombined', '')),
       co2_emission: toString(get(car, 'environmentEmissions.co2', '')),
-      co2_effiency_class: toString(get(car, 'environmentEmissions.energyEfficiencyClass', '')),
+      // ADV-187: canonical CO2-derived WLTP class, not the unvalidated legacy NEFZ class.
+      co2_effiency_class: toString(get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', '')),
       euro_emission_class: toString(get(car, 'environmentEmissions.emissionClass', '')),
       enviromental_sticker: toString(get(car, 'environmentEmissions.emissionSticker', '')),
     };

package/src/transformers/awin.transformer.ts

@@ -171,7 +171,8 @@ export class AwinTransformer {
             selector_energyEfficiencyClass_g: 'G',
             selector_unknown: '',
         };
-        const energyClass = get(car, 'environmentEmissions.energyEfficiencyClass', 'selector_unknown');
+        // ADV-187: canonical CO2-derived WLTP class, not the unvalidated legacy NEFZ class.
+        const energyClass = get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', 'selector_unknown');
         return get(available, energyClass);
     }
 

package/src/transformers/criteo.transformer.ts

@@ -140,7 +140,8 @@ export class CriteoTransformer {
 			selector_energyEfficiencyClass_g: 'G',
 			selector_unknown: 'default',
 		};
-		const energyClass = get(car, 'environmentEmissions.energyEfficiencyClass', 'selector_unknown');
+		// ADV-187: canonical CO2-derived WLTP class, not the unvalidated legacy NEFZ class.
+		const energyClass = get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', 'selector_unknown');
 		return get(available, energyClass);
 	}
 

package/src/transformers/google.transformer.ts

@@ -288,8 +288,15 @@ export class GoogleTransformer {
     return value ? value.replace(/\+/g, '') : '';
   }
 
+  // ADV-187: the canonical (legally defined, CO2-derived) class lives in
+  // wltpEnergyEfficiencyClass — same field the website, PDF exposé and the
+  // Facebook feed use. The legacy NEFZ `energyEfficiencyClass` is a different
+  // (mass-relative) scale and is NOT validated against CO2, so it must not
+  // feed the BMWK Vehicle_CO2_Class certification. No fallback to the legacy
+  // field on purpose: an unknown WLTP class omits the certification instead of
+  // publishing an unvalidated one.
   private getEnergyClass(car: DataSchemes.Car): string {
-    return this.mapEnergyClass(get(car, 'environmentEmissions.energyEfficiencyClass', 'selector_unknown'));
+    return this.mapEnergyClass(get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', 'selector_unknown'));
   }
 
   private getDischargedEnergyClass(car: DataSchemes.Car): string {

package/src/transformers/mobile.transformer.ts

@@ -258,8 +258,11 @@ export class MobileTransformer {
     }
   }
 
+  // ADV-187: export the canonical CO2-derived WLTP class (not the unvalidated
+  // legacy NEFZ class) and never invent one — an unknown class is exported
+  // empty instead of the former hard-coded 'C'.
   private getEnergyEfficiencyClass(car: DataSchemes.Car): string {
-    const energyEfficiencyClass = get(car, 'environmentEmissions.energyEfficiencyClass', 'selector_unknown');
+    const energyEfficiencyClass = get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', 'selector_unknown');
     switch (energyEfficiencyClass) {
       case 'selector_energyEfficiencyClass_appp': {
         return 'A+++';
@@ -271,8 +274,9 @@ export class MobileTransformer {
         return 'A+';
       }
       case 'selector_unknown':
+      case undefined:
       case null: {
-        return 'C';
+        return '';
       }
       default: {
         return energyEfficiencyClass.slice(-1).toUpperCase();

package/src/transformers/rubrikk.transformer.ts

@@ -148,7 +148,8 @@ export class RubrikkTransformer {
       selector_energyEfficiencyClass_g: 'G',
       selector_unknown: 'default',
     };
-    const energyClass = get(car, 'environmentEmissions.energyEfficiencyClass', 'selector_unknown');
+    // ADV-187: canonical CO2-derived WLTP class, not the unvalidated legacy NEFZ class.
+    const energyClass = get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', 'selector_unknown');
     return get(available, energyClass);
   }
 

package/src/transformers/santander.transformer.ts

@@ -364,8 +364,11 @@ export class SantanderTransformer {
 		}
 	}
 
+	// ADV-187: export the canonical CO2-derived WLTP class (not the unvalidated
+	// legacy NEFZ class) and never invent one — an unknown class is exported
+	// empty instead of the former hard-coded 'C'.
 	private getEnergyEfficiencyClass(car: DataSchemes.Car): string {
-		const energyEfficiencyClass = get(car, 'environmentEmissions.energyEfficiencyClass', 'selector_unknown');
+		const energyEfficiencyClass = get(car, 'environmentEmissions.wltpEnergyEfficiencyClass', 'selector_unknown');
 		switch (energyEfficiencyClass) {
 			case 'selector_energyEfficiencyClass_appp': {
 				return 'A+++';
@@ -377,8 +380,9 @@ export class SantanderTransformer {
 				return 'A+';
 			}
 			case 'selector_unknown':
+			case undefined:
 			case null: {
-				return 'C';
+				return '';
 			}
 			default: {
 				return energyEfficiencyClass.slice(-1).toUpperCase();