@bytebrand/export-cars 1.26.17 → 1.26.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.17",
+  "version": "1.26.19",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/configs/facebook-shop.config.ts

@@ -1,13 +1,13 @@
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 import { ExportType, FileType } from '../enums';
-import { MAX_FEED_SALES_PRICE_EUR } from '../constants/feed-price.constants';
+import { resolveMaxFeedSalesPrice } from '../constants/feed-price.constants';
 
 export class FacebookShopConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.FACEBOOK_SHOP}-export`;
-    this.maxCurrentSalesPrice = MAX_FEED_SALES_PRICE_EUR;
+    this.maxCurrentSalesPrice = resolveMaxFeedSalesPrice(params.maxCurrentSalesPrice);
     this.imageUrl = this.environmentConfig[params.environment].baseImageUrl;
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.FACEBOOK_SHOP}.${FileType.XML}`,

package/src/configs/fb.config.ts

@@ -1,5 +1,5 @@
 import { ExportType, FileType, ImageType } from 'src/enums';
-import { MAX_FEED_SALES_PRICE_EUR } from '../constants/feed-price.constants';
+import { resolveMaxFeedSalesPrice } from '../constants/feed-price.constants';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -7,7 +7,7 @@ export class FbConfig extends Config {
   constructor(params: Params) {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.FB}-export`;
-    this.maxCurrentSalesPrice = MAX_FEED_SALES_PRICE_EUR;
+    this.maxCurrentSalesPrice = resolveMaxFeedSalesPrice(params.maxCurrentSalesPrice);
     this.imageUrl = this.environmentConfig[params.environment].imageUrl;
     this.imageType = ImageType.marketing;
     this.marketingImageConfigId = this.environmentConfig[params.environment].fbMarketingImageId;

package/src/configs/google.config.ts

@@ -1,5 +1,5 @@
 import { ExportType, FileType, ImageType } from 'src/enums';
-import { MAX_FEED_SALES_PRICE_EUR } from '../constants/feed-price.constants';
+import { resolveMaxFeedSalesPrice } from '../constants/feed-price.constants';
 import { Params } from '../interfaces/params.interface';
 import { Config } from './config';
 
@@ -8,7 +8,7 @@ export class GoogleConfig extends Config {
     super(params);
     this.pathesConfig.localConvertedDirectory = `resources/${ExportType.GOOGLE}-export`;
     this.imageType = ImageType.default;
-    this.maxCurrentSalesPrice = MAX_FEED_SALES_PRICE_EUR;
+    this.maxCurrentSalesPrice = resolveMaxFeedSalesPrice(params.maxCurrentSalesPrice);
     this.outputFiles = [
       `${this.pathesConfig.localConvertedDirectory}/api_export_cars_${ExportType.GOOGLE}.${FileType.XML}`,
     ];

package/src/constants/feed-price.constants.ts

@@ -1,4 +1,11 @@
+import { toNumber } from 'lodash';
+
 // Shared eligibility cap for the Google Vehicle Ads and Meta AIA/AMA feeds:
 // only cars whose end-customer selling price (price.currentSalesPrice) is
 // ≤ €80,000 may be exported. €80,000.00 itself is still included.
 export const MAX_FEED_SALES_PRICE_EUR = 80_000;
+
+// The Cronicle "Max currentSalesPrice" plugin param (a text field) can override
+// the default cap per event; empty/invalid/non-positive values fall back to it.
+export const resolveMaxFeedSalesPrice = (raw?: string): number =>
+  toNumber(raw) > 0 ? toNumber(raw) : MAX_FEED_SALES_PRICE_EUR;

package/src/exporters/facebook-shop.exporter.ts

@@ -35,7 +35,9 @@ export class FacebookShopExporter implements Exporter {
       const chunkData = chunk.data.filter(car => this.carService.filterCar(car, this.rulesService.rules));
 
       for (let i = 0; i < chunkData.length; i += 1) {
-        const data = chunk.data[i];
+        // chunkData, not chunk.data: indexing the unfiltered array here used to
+        // re-admit cars that filterCar had just rejected (and drop valid ones).
+        const data = chunkData[i];
 
         // console.time(`Transform ${data.car._id}`);
         const items = await facebookShopTransformer.transform(data);

package/src/interfaces/params.interface.ts

@@ -11,4 +11,7 @@ export interface Params {
   cpc?: string;
   ownerId?: string;
   metaPushPriorityCsvUrl?: string;
+  // Cronicle plugin param (text field, so it arrives as a string); overrides the
+  // default MAX_FEED_SALES_PRICE_EUR cap in the configs that apply one.
+  maxCurrentSalesPrice?: string;
 }