@bytebrand/export-cars 1.26.13 → 1.26.15

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.13",
+  "version": "1.26.15",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/services/images.service.ts

@@ -8,12 +8,12 @@ import { MarketingImageConfigsInterface } from '@bytebrand/autode-request';
 import { ImboImageResponseInterface } from '@bytebrand/chunkable';
 import { DataSchemes } from '@bytebrand/car-schema';
 
-import { FB_MAX_IMAGE_COUNT_FOR_DEAFULT, META_AIA_CHANNEL_CODE, META_AIA_MODE_FINANCING } from '../constants/fb.constants';
+import { FB_MAX_IMAGE_COUNT_FOR_DEAFULT, META_AIA_CHANNEL_CODE } from '../constants/fb.constants';
 import { ConfigService } from './config.service';
 import { UserService } from './user.service';
 import { isNotEmptyArray } from '../utils';
 import { Config } from '../configs/config';
-import { ExportType, ImageSize, ImageType } from '../enums';
+import { ImageSize, ImageType } from '../enums';
 
 @Injectable()
 export class ImagesService {
@@ -176,28 +176,10 @@ export class ImagesService {
   }
 
   async getMarketingImages(carId: string, images: ImboImageResponseInterface[], ignoreDefImages: boolean): Promise<string[]> {
-    const transformedImages = this.transformImagesArrayIntoObject(images);
-    // fbMarketingImageId is a hardcoded per-environment id in config.ts and has drifted from
-    // the real meta_aia config at least once (dev's id pointed at a stale, never-populated "fb"
-    // channel) — the FB feed resolves its config by channelCode instead of trusting that id.
-    const config = this.configService.config.exportType === ExportType.FB
-      ? await this.userService.getMarketingImageConfigByChannelCode(META_AIA_CHANNEL_CODE)
-      : await this.userService.getMarketingImageConfig(this.configService.config.marketingImageConfigId);
-
-    if (!config) {
-      console.log('getMarketingImages: no marketing image config found (channelCode meta_aia missing?)');
-      return ignoreDefImages ? [] : [...this.DEFAULT_IMAGES];
-    }
-
-    // marketingImageUrl AND config.imageUrl (FbConfig overrides the latter to the same
-    // per-env value right after super()) both point at the old "fb" channel's base path
-    // (/cache_test on dev, already /generated_images on prod) — not where image-generator
-    // publishes meta_aia composites. metaAiaImageUrl is derived from the un-suffixed
-    // baseImageUrl, so it's the one safe /generated_images base.
-    const imageUrl = config.channelCode === META_AIA_CHANNEL_CODE
-      ? this.configService.config.metaAiaImageUrl
-      : this.configService.config.marketingImageUrl;
+    const imageUrl = this.configService.config.marketingImageUrl;
 
+    const transformedImages = this.transformImagesArrayIntoObject(images);
+    const config = await this.userService.getMarketingImageConfig(this.configService.config.marketingImageConfigId);
     const marketingImageConfigs = config.marketingImages.map(i => ({ marketingImageCodes: i.imageCodes }));
 
     const imageWithUrls: Partial<ImboImageResponseInterface & { url: string }>[] = [];
@@ -292,13 +274,7 @@ export class ImagesService {
 
   protected getImagePathWithExtension(imageUrl: string, carId: string, imageId: string, config: MarketingImageConfigsInterface): string {
     const { channelCode, imageExtension } = config;
-    // image-generator's MetaAiaImagesService writes files as `meta-aia-financing-{imageId}` /
-    // `meta-aia-leasing-{imageId}` (hyphenated, mode baked into the name) — not derived from
-    // channelCode the way other channels are. FB only wants the financing variant.
-    const filenamePrefix = channelCode === META_AIA_CHANNEL_CODE
-      ? `meta-aia-${META_AIA_MODE_FINANCING}`
-      : channelCode.replace(/ /g, '-');
-    return `${this.getChannelPath(imageUrl, carId)}/${filenamePrefix}-${imageId}.${imageExtension}`;
+    return `${this.getChannelPath(imageUrl, carId)}/${channelCode.replace(/ /g, '-')}-${imageId}.${imageExtension}`;
   }
 
   sortImages(images: ImboImageResponseInterface[]): ImboImageResponseInterface[] {

package/src/services/user.service.ts

@@ -67,17 +67,4 @@ export class UserService {
 
     return result;
   }
-
-  // The per-environment fbMarketingImageId config.ts hardcodes doesn't reliably point at the
-  // meta_aia channel (dev's id 8 turned out to be a stale, never-populated "fb" channel) —
-  // resolve by channelCode instead of trusting a fixed id.
-  async getMarketingImageConfigByChannelCode(channelCode: string): Promise<MarketingImageConfigInterface | null> {
-    const configs = await this.getMarketingImageConfigs();
-    const match = configs.find(config => config.channelCode === channelCode);
-    if (!match) {
-      return null;
-    }
-
-    return this.getMarketingImageConfig(match.id);
-  }
 }

package/src/transformers/facebook-shop.transformer.ts

@@ -68,7 +68,8 @@ export class FacebookShopTransformer {
       return [];
     }
 
-    const vehicleId = toString(get(car, 'metaData.vehicleId', car._id));
+    // ADV-200: AIA/AMA now wants the long auto.de ID (VDP URL id), not the short metaData.vehicleId code
+    const vehicleId = toString(car._id);
     const make = toString(get(car, 'mainData.make', ''));
     const model = toString(get(car, 'mainData.model', ''));
     const price = this.getPriceValue(car);

package/src/transformers/fb.transformer.ts

@@ -30,13 +30,13 @@ import { ConfigService, ImagesService, MappingService } from '../services';
 import { FbEquipment } from './fb-equipment.transformer';
 import { isValidVin, normalizeFeedText } from '../utils';
 import { UserService } from 'src/services';
-import { ImageType } from '../enums';
 import {
   DEFAULT_ADDR1,
   DEFAULT_CITY,
   DEFAULT_ZIP,
   FB_MAX_TRIM_LENGTH,
   FB_MIN_MILEAGES,
+  META_AIA_MODE_FINANCING,
   META_PUSH_PRIORITY_ALLOWED_VALUES,
   META_PUSH_PRIORITY_STANDARD,
   TIMESTAMP_FIRST_YEAR,
@@ -72,10 +72,12 @@ export class FbTransformer {
     images: ImboImageResponseInterface[];
     owner: unknown;
   }): Promise<unknown> {
-    // ignoreDefImages=true: cars with no real photos must be excluded, not padded with
-    // placeholders (matches facebook-shop.transformer.ts's AMA feed policy).
-    const image_links = await this.imagesService.getImages(car, images, ImageType.marketing, true);
-    if (!image_links.length) {
+    // Meta AIA financing overlay is the ONLY image this feed ships — same HEAD-checked path as
+    // the AMA facebook-shop feed. getMetaAiaImage returns null when the car has no eligible photo
+    // OR the composite hasn't actually been rendered/landed on the CDN yet, so every exported item
+    // is guaranteed a real, existing image (no placeholders, no 404s, no zero-image cars).
+    const metaAiaImage = await this.imagesService.getMetaAiaImage(car._id, images, META_AIA_MODE_FINANCING);
+    if (!metaAiaImage) {
       return null;
     }
 
@@ -93,7 +95,8 @@ export class FbTransformer {
       ...dealerInfo,
       user_id: ownerId,
       custom_label_4: await this.getMetaPushPriority(ownerId),
-      vehicle_id: get(car, 'metaData.vehicleId', autodeId),
+      // ADV-200: AIA/AMA now wants the long auto.de ID (VDP URL id), not the short metaData.vehicleId code
+      vehicle_id: autodeId,
       stock_number: autodeId,
       availability: this.mapAvailability(car),
       title: this.getTitle(car),
@@ -105,7 +108,7 @@ export class FbTransformer {
       make: toString(get(car, 'mainData.make', '')),
       model: toString(get(car, 'mainData.model', '')),
       trim: this.getTrim(car),
-      image: image_links.slice(0, 20), // Meta caps the whole image array at 20 items
+      image: [metaAiaImage], // single Meta AIA financing overlay, per feed spec
       year: toString(year),
       mileage: {
         value: this.getMileage(car),