@bytebrand/export-cars 1.26.1 → 1.26.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.26.1",
+  "version": "1.26.3",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",
@@ -19,7 +19,7 @@
     "@bytebrand/car-schema": "^3.14.15",
     "@bytebrand/chunkable": "^5.19.8",
     "@bytebrand/cronicle-helper": "^1.21.8",
-    "@bytebrand/fe-financing": "^5.14.10",
+    "@bytebrand/fe-financing": "^5.14.12",
     "@bytebrand/i18n-dictionaries": "^1.5.0",
     "@bytebrand/import-helper": "^0.45.0",
     "@bytebrand/schema-tools": "^3.18.8",

package/src/configs/config.ts

@@ -16,6 +16,7 @@ export class Config {
   isNewCar: boolean;
   isCriteo: boolean;
   exportType: ExportType;
+  environment: Environment;
   domain: string;
   input: {
     stringIN: string;
@@ -59,6 +60,7 @@ export class Config {
   constructor(params: Params) {
     this.apikey = params.apikey;
     this.exportType = params.exportType;
+    this.environment = params.environment;
     this.cpc = params.cpc;
     this.domain = this.environmentConfig[params.environment].domain;
     this.baseImageUrl = this.environmentConfig[params.environment].baseImageUrl;

package/src/exporters/fb.exporter.ts

@@ -42,7 +42,7 @@ export class FbExporter implements Exporter {
         console.timeEnd(`Transform ${data.car._id}`);
 
         if (!car) {
-          console.log(`Skip car ${data.car._id} because it has no real images`);
+          console.log(`Skip car ${data.car._id} — no real images, or dealer ${ownerId} not in the priority list`);
           continue;
         }
 

package/src/formats/facebook-shop.builder.ts

@@ -1,59 +1,59 @@
-import { escape, isNil, isNumber, isString } from 'lodash';
-import { XMLBuilderBase } from '@bytebrand/cronicle-helper';
-import { FacebookShopItem } from '../interfaces';
-
-const MAX_IMAGES = 2;
-
-export class FacebookShopXmlBuilder extends XMLBuilderBase {
-  // No xmlns:g / g: prefixes here — that namespace belongs to the old Google Merchant /
-  // Facebook Shop product-catalog schema. Meta's Automotive Model Ads Vehicle Offers Feed
-  // uses plain, undecorated tag names (see facebook-shop.builder field reference above).
-  async buildStart(selfUrl?: string): Promise<void> {
-    await this.write(
-      '<?xml version="1.0" encoding="utf-8"?>\n<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">' +
-        '\n<channel>\n<title>auto.de Vehicle Offers Feed</title>' +
-        '\n<description>Automotive Model Ads Vehicle Offers Feed für auto.de</description>' +
-        '\n<link>https://www.auto.de/</link>' +
-        `\n<atom:link href="${escape(selfUrl)}" rel="self" type="application/rss+xml" />\n`,
-    );
-  }
-
-  async addItem(car: FacebookShopItem): Promise<void> {
-    let item = '\n<item>\n';
-
-    const { image, ...tags } = car;
-
-    for (const [tag, value] of Object.entries(tags)) {
-      item += this.buildTagElement(tag, value);
-    }
-
-    item += image
-      .slice(0, MAX_IMAGES)
-      .map((url: string) => `<image><url>${escape(url)}</url></image>\n`)
-      .join('');
-
-    item += '</item>';
-
-    await this.write(item);
-  }
-
-  private buildTagElement(tag: string, value: unknown): string {
-    if (isNil(value) || value === '') {
-      return '';
-    }
-    // getElement() treats falsy values as "missing" — stringify numbers first so a
-    // legitimate 0 (e.g. downpayment/term_length) still renders instead of an empty tag.
-    if (isString(value)) {
-      return this.getElement(tag, escape(value));
-    }
-    if (isNumber(value)) {
-      return this.getElement(tag, String(value));
-    }
-    return this.getElement(tag, value);
-  }
-
-  async buildEnd(): Promise<void> {
-    await this.write('\n</channel>\n</rss>\n');
-    await this.end();
-  }
-}
+import { escape, isNil, isNumber, isString } from 'lodash';
+import { XMLBuilderBase } from '@bytebrand/cronicle-helper';
+import { FacebookShopItem } from '../interfaces';
+
+const MAX_IMAGES = 2;
+
+export class FacebookShopXmlBuilder extends XMLBuilderBase {
+  // No xmlns:g / g: prefixes here — that namespace belongs to the old Google Merchant /
+  // Facebook Shop product-catalog schema. Meta's Automotive Model Ads Vehicle Offers Feed
+  // uses plain, undecorated tag names (see facebook-shop.builder field reference above).
+  async buildStart(selfUrl?: string): Promise<void> {
+    await this.write(
+      '<?xml version="1.0" encoding="utf-8"?>\n<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">' +
+        '\n<channel>\n<title>auto.de Vehicle Offers Feed</title>' +
+        '\n<description>Automotive Model Ads Vehicle Offers Feed für auto.de</description>' +
+        '\n<link>https://www.auto.de/</link>' +
+        `\n<atom:link href="${escape(selfUrl)}" rel="self" type="application/rss+xml" />\n`,
+    );
+  }
+
+  async addItem(car: FacebookShopItem): Promise<void> {
+    let item = '\n<item>\n';
+
+    const { image, ...tags } = car;
+
+    for (const [tag, value] of Object.entries(tags)) {
+      item += this.buildTagElement(tag, value);
+    }
+
+    item += image
+      .slice(0, MAX_IMAGES)
+      .map((url: string) => `<image><url>${escape(url)}</url></image>\n`)
+      .join('');
+
+    item += '</item>';
+
+    await this.write(item);
+  }
+
+  private buildTagElement(tag: string, value: unknown): string {
+    if (isNil(value) || value === '') {
+      return '';
+    }
+    // getElement() treats falsy values as "missing" — stringify numbers first so a
+    // legitimate 0 (e.g. downpayment/term_length) still renders instead of an empty tag.
+    if (isString(value)) {
+      return this.getElement(tag, escape(value));
+    }
+    if (isNumber(value)) {
+      return this.getElement(tag, String(value));
+    }
+    return this.getElement(tag, value);
+  }
+
+  async buildEnd(): Promise<void> {
+    await this.write('\n</channel>\n</rss>\n');
+    await this.end();
+  }
+}

package/src/services/images.service.ts

@@ -13,7 +13,7 @@ import { ConfigService } from './config.service';
 import { UserService } from './user.service';
 import { isNotEmptyArray } from '../utils';
 import { Config } from '../configs/config';
-import { ImageSize, ImageType } from '../enums';
+import { ExportType, ImageSize, ImageType } from '../enums';
 
 @Injectable()
 export class ImagesService {
@@ -179,7 +179,18 @@ export class ImagesService {
     const imageUrl = this.configService.config.marketingImageUrl;
 
     const transformedImages = this.transformImagesArrayIntoObject(images);
-    const config = await this.userService.getMarketingImageConfig(this.configService.config.marketingImageConfigId);
+    // fbMarketingImageId is a hardcoded per-environment id in config.ts and has drifted from
+    // the real meta_aia config at least once (dev's id pointed at a stale, never-populated "fb"
+    // channel) — the FB feed resolves its config by channelCode instead of trusting that id.
+    const config = this.configService.config.exportType === ExportType.FB
+      ? await this.userService.getMarketingImageConfigByChannelCode('meta_aia')
+      : await this.userService.getMarketingImageConfig(this.configService.config.marketingImageConfigId);
+
+    if (!config) {
+      console.log('getMarketingImages: no marketing image config found (channelCode meta_aia missing?)');
+      return ignoreDefImages ? [] : [...this.DEFAULT_IMAGES];
+    }
+
     const marketingImageConfigs = config.marketingImages.map(i => ({ marketingImageCodes: i.imageCodes }));
 
     const imageWithUrls: Partial<ImboImageResponseInterface & { url: string }>[] = [];
@@ -189,9 +200,15 @@ export class ImagesService {
         const imageCode = marketingImage.marketingImageCodes[i];
         const imageId = transformedImages[imageCode];
         if (imageId) {
+          const url = this.getImagePathWithExtension(imageUrl, carId, imageId, config);
+          // meta_aia cards are composited async and may not exist yet for a given car —
+          // verify the file is real before publishing the link, not just the placeholder.
+          if (config.channelCode === 'meta_aia' && !(await this.imageExists(url))) {
+            break;
+          }
           imageWithUrls.push({
             imageCodePredicted: imageCode,
-            url: this.getImagePathWithExtension(imageUrl, carId, imageId, config)
+            url,
           });
           break;
         }
@@ -208,6 +225,22 @@ export class ImagesService {
     return imageWithUrls.map(i => i.url);
   }
 
+  // Imbo serves a 400x300 JPEG placeholder (measured 7996 bytes on both auto.de and
+  // autode-dev.de) with a 404 status when a transformation isn't ready yet. nginx in front of
+  // Imbo has been seen caching that placeholder body regardless of status code (see
+  // nginx-image-cache-negative-caching), so check Content-Length rather than trusting the
+  // HTTP status alone.
+  private readonly PLACEHOLDER_MAX_BYTES = 8000;
+
+  private async imageExists(url: string): Promise<boolean> {
+    try {
+      const { status, headers } = await axios.head(url, { timeout: 5000 });
+      return status === 200 && Number(headers['content-length'] ?? 0) > this.PLACEHOLDER_MAX_BYTES;
+    } catch {
+      return false;
+    }
+  }
+
   private transformImagesArrayIntoObject(images: ImboImageResponseInterface[]): { [imageCode: string]: string } {
     return images.reduce((result, image) => {
       const imageCode = image?.imageCodePredicted?.split('-')[0];
@@ -224,7 +257,11 @@ export class ImagesService {
 
   protected getImagePathWithExtension(imageUrl: string, carId: string, imageId: string, config: MarketingImageConfigsInterface): string {
     const { channelCode, imageExtension } = config;
-    return `${this.getChannelPath(imageUrl, carId)}/${channelCode.replace(/ /g, '-')}-${imageId}.${imageExtension}`;
+    // image-generator's MetaAiaImagesService writes files as `meta-aia-financing-{imageId}` /
+    // `meta-aia-leasing-{imageId}` (hyphenated, mode baked into the name) — not derived from
+    // channelCode the way other channels are. FB only wants the financing variant.
+    const filenamePrefix = channelCode === 'meta_aia' ? 'meta-aia-financing' : channelCode.replace(/ /g, '-');
+    return `${this.getChannelPath(imageUrl, carId)}/${filenamePrefix}-${imageId}.${imageExtension}`;
   }
 
   sortImages(images: ImboImageResponseInterface[]): ImboImageResponseInterface[] {

package/src/services/user.service.ts

@@ -67,4 +67,17 @@ export class UserService {
 
     return result;
   }
+
+  // The per-environment fbMarketingImageId config.ts hardcodes doesn't reliably point at the
+  // meta_aia channel (dev's id 8 turned out to be a stale, never-populated "fb" channel) —
+  // resolve by channelCode instead of trusting a fixed id.
+  async getMarketingImageConfigByChannelCode(channelCode: string): Promise<MarketingImageConfigInterface | null> {
+    const configs = await this.getMarketingImageConfigs();
+    const match = configs.find(config => config.channelCode === channelCode);
+    if (!match) {
+      return null;
+    }
+
+    return this.getMarketingImageConfig(match.id);
+  }
 }