@bytebrand/export-cars 1.25.0 → 1.26.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.25.0",
+  "version": "1.26.0",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/constants/fb.constants.ts

@@ -8,12 +8,17 @@ export const TIMESTAMP_FIRST_YEAR = 1970;
 export const META_PUSH_PRIORITY_STANDARD = 'standard';
 export const META_PUSH_PRIORITY_ALLOWED_VALUES = ['dealer_priority_1', 'dealer_priority_2'];
 
+// Values must match Meta's Automotive Model Ads offer_type enum exactly (lease/finance/cash) —
+// the old 'financing'/'leasing'/'buy' values are not recognized by the AMA Vehicle Offers Feed.
 export enum OfferType {
-  financing = 'financing',
-  leasing = 'leasing',
-  buy = 'buy',
+  financing = 'finance',
+  leasing = 'lease',
+  buy = 'cash',
 }
 
+export const AMOUNT_QUALIFIER_APR = 'APR';
+export const TERM_QUALIFIER_MONTHS = 'months';
+
 export const OFFER_DISCLAIMER = 'Für Ihre Finanzierungswünsche stellen wir eine Bonitätsanfrage. Bonität ' +
   'vorausgesetzt, ist dies ein repräsentatives Berechnungsbeispiel gem. der Angaben, welches 2/3 aller Kunden, ' +
   'im Sinne des § 17a Abs. 4 PAngV, erhalten. Dieses freibleibende Angebot der Santander Consumer Bank AG, ' +

package/src/exporters/facebook-shop.exporter.ts

@@ -1,5 +1,6 @@
 import { Injectable } from '@nestjs/common';
 import { ModuleRef } from '@nestjs/core';
+import { basename } from 'path';
 
 import { CronicleUtils } from '@bytebrand/cronicle-helper';
 import { FsChunkInterface } from '@bytebrand/chunkable';
@@ -24,8 +25,9 @@ export class FacebookShopExporter implements Exporter {
     await CronicleUtils.ensureDir(this.configService.config.pathesConfig.localConvertedDirectory);
     await CronicleUtils.emptyDir(this.configService.config.pathesConfig.localConvertedDirectory);
 
-    const facebookShopXmkBuilder = new FacebookShopXmlBuilder(fileXml);
-    await facebookShopXmkBuilder.buildStart();
+    const selfUrl = `https://ftp.${this.configService.config.domain}/feeds/${basename(fileXml)}`;
+    const facebookShopXmlBuilder = new FacebookShopXmlBuilder(fileXml);
+    await facebookShopXmlBuilder.buildStart(selfUrl);
 
     const facebookShopTransformer = await this.moduleRef.create(FacebookShopTransformer);
 
@@ -45,13 +47,13 @@ export class FacebookShopExporter implements Exporter {
         }
 
         for (const item of items) {
-          await facebookShopXmkBuilder.addItem(item);
+          await facebookShopXmlBuilder.addItem(item);
         }
         this.carService.counter.countCar(data.images);
       }
     });
 
-    await facebookShopXmkBuilder.buildEnd();
+    await facebookShopXmlBuilder.buildEnd();
 
     console.log(this.carService.counter.getCountedCars());
   }

package/src/formats/facebook-shop.builder.ts

@@ -1,52 +1,59 @@
-import { escape, isNumber, isString } from 'lodash';
-import { XMLBuilderBase } from '@bytebrand/cronicle-helper';
-import { FacebookShopItem, FacebookShopTag } from '../interfaces';
-
-export class FacebookShopXmlBuilder extends XMLBuilderBase {
-  async buildStart(): Promise<void> {
-    await this.write(
-      '<?xml version="1.0" encoding="utf-8"?>\n<rss version="2.0" xmlns:g="http://base.google.com/ns/1.0" xmlns:atom="http://www.w3.org/2005/Atom">' +
-        '\n<channel>\n<title>Produkt für auto.de</title>\n<description>Produkt für auto.de</description> \n<link>https://www.auto.de/</link>\n' +
-        '<atom:link href="https://www.mydealsshop.foo/pages/test-feed" rel="self" type="application/rss+xml" />\n',
-    );
-  }
-
-  async addItem(car: FacebookShopItem): Promise<void> {
-    let item = '\n<item>\n';
-
-    const tags = Object.keys(car);
-
-    for (const tag of tags) {
-      if (tag === 'image' && Array.isArray(car[tag])) {
-        item += (car[tag] as unknown as string[])
-          .map((url: string) => `<image><url>${escape(url)}</url></image>\n`)
-          .join('');
-        continue;
-      }
-      item += this.buildTagElement(tag, car[tag]);
-    }
-    item += '</item>';
-
-    await this.write(item);
-  }
-
-  buildTagElement(tag: string, params: FacebookShopTag) {
-    // getElement() treats falsy values as "missing" — stringify numbers first so a
-    // legitimate 0 (e.g. down_payment/apr) still renders instead of an empty tag.
-    let value = params.value;
-    if (isString(value)) {
-      value = escape(value);
-    } else if (isNumber(value)) {
-      value = String(value);
-    }
-    if (params.isGoogle) {
-      return this.getElement(`g:${tag}`, value);
-    }
-    return this.getElement(tag, value);
-  }
-
-  async buildEnd(): Promise<void> {
-    await this.write('\n</channel>\n</rss>\n');
-    await this.end();
-  }
-}
+import { escape, isNil, isNumber, isString } from 'lodash';
+import { XMLBuilderBase } from '@bytebrand/cronicle-helper';
+import { FacebookShopItem } from '../interfaces';
+
+const MAX_IMAGES = 2;
+
+export class FacebookShopXmlBuilder extends XMLBuilderBase {
+  // No xmlns:g / g: prefixes here — that namespace belongs to the old Google Merchant /
+  // Facebook Shop product-catalog schema. Meta's Automotive Model Ads Vehicle Offers Feed
+  // uses plain, undecorated tag names (see facebook-shop.builder field reference above).
+  async buildStart(selfUrl?: string): Promise<void> {
+    await this.write(
+      '<?xml version="1.0" encoding="utf-8"?>\n<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">' +
+        '\n<channel>\n<title>auto.de Vehicle Offers Feed</title>' +
+        '\n<description>Automotive Model Ads Vehicle Offers Feed für auto.de</description>' +
+        '\n<link>https://www.auto.de/</link>' +
+        `\n<atom:link href="${escape(selfUrl)}" rel="self" type="application/rss+xml" />\n`,
+    );
+  }
+
+  async addItem(car: FacebookShopItem): Promise<void> {
+    let item = '\n<item>\n';
+
+    const { image, ...tags } = car;
+
+    for (const [tag, value] of Object.entries(tags)) {
+      item += this.buildTagElement(tag, value);
+    }
+
+    item += image
+      .slice(0, MAX_IMAGES)
+      .map((url: string) => `<image><url>${escape(url)}</url></image>\n`)
+      .join('');
+
+    item += '</item>';
+
+    await this.write(item);
+  }
+
+  private buildTagElement(tag: string, value: unknown): string {
+    if (isNil(value) || value === '') {
+      return '';
+    }
+    // getElement() treats falsy values as "missing" — stringify numbers first so a
+    // legitimate 0 (e.g. downpayment/term_length) still renders instead of an empty tag.
+    if (isString(value)) {
+      return this.getElement(tag, escape(value));
+    }
+    if (isNumber(value)) {
+      return this.getElement(tag, String(value));
+    }
+    return this.getElement(tag, value);
+  }
+
+  async buildEnd(): Promise<void> {
+    await this.write('\n</channel>\n</rss>\n');
+    await this.end();
+  }
+}

package/src/interfaces/export-item.interface.ts

@@ -346,45 +346,33 @@ export interface dealerItem {
   };
 }
 
+// Field set matches Meta's Automotive Model Ads "Vehicle Offers Feed File" reference
+// (https://developers.facebook.com/documentation/ads-commerce/marketing-api/auto-ads/reference#vehicle-offers-feed-file).
+// custom_label_4 is not part of that reference but is kept per ADV-159/161 (dealer push
+// priority) — Meta ignores catalog fields it doesn't recognize rather than rejecting the feed.
 export interface FacebookShopItem {
-  id: FacebookShopTag;
-  vehicle_id: FacebookShopTag;
-  title: FacebookShopTag;
-  description: FacebookShopTag;
-  availability: FacebookShopTag;
-  state_of_vehicle: FacebookShopTag;
-  price: FacebookShopTag;
-  link: FacebookShopTag;
+  vehicle_offer_id: string;
+  make: string;
+  model: string;
+  year: string;
+  offer_type: string;
+  title: string;
+  offer_description: string;
+  url: string;
+  offer_disclaimer?: string;
   image: string[];
-  make: FacebookShopTag;
-  model: FacebookShopTag;
-  year: FacebookShopTag;
-
-  user_id: FacebookShopTag;
-  custom_label_4: FacebookShopTag;
-  dealer_privacy_policy_url: FacebookShopTag;
 
-  offer_type: FacebookShopTag;
-  offer_disclaimer?: FacebookShopTag;
-  monthly_payment?: FacebookShopTag;
-  down_payment?: FacebookShopTag;
-  term_length?: FacebookShopTag;
-  apr?: FacebookShopTag;
-  final_payment?: FacebookShopTag;
-  total_amount?: FacebookShopTag;
-  net_loan_amount?: FacebookShopTag;
-
-  quantity_to_sell_on_facebook: FacebookShopTag;
-  google_product_category: FacebookShopTag;
-  sale_price: FacebookShopTag;
-  status: FacebookShopTag;
-  color: FacebookShopTag;
-  product_type: FacebookShopTag;
-}
+  price: string;
+  availability: string;
+  exterior_color: string;
+  custom_label_4: string;
 
-export interface FacebookShopTag {
-  isGoogle: boolean;
-  value: any;
+  amount_price?: string;
+  amount_percentage?: string;
+  amount_qualifier?: string;
+  term_length?: number;
+  term_qualifier?: string;
+  downpayment?: string;
 }
 
 export interface TrovitXmlItem {

package/src/transformers/facebook-shop.transformer.ts

@@ -9,13 +9,15 @@ import { TranslatorExtended } from '@bytebrand/schema-tools';
 import { DataSchemes } from '@bytebrand/car-schema';
 import { getComputedFinancing, normalizeRateObject } from '@bytebrand/fe-financing';
 
-import { FacebookShopItem, FacebookShopTag } from '../interfaces';
+import { FacebookShopItem } from '../interfaces';
 import { ConfigService, ImagesService, MappingService } from '../services';
 import {
+  AMOUNT_QUALIFIER_APR,
   META_PUSH_PRIORITY_ALLOWED_VALUES,
   META_PUSH_PRIORITY_STANDARD,
   OFFER_DISCLAIMER,
   OfferType,
+  TERM_QUALIFIER_MONTHS,
 } from '../constants/fb.constants';
 
 interface OfferFinancials {
@@ -77,35 +79,26 @@ export class FacebookShopTransformer {
     }
 
     const base = {
-      vehicle_id: this.tag(vehicleId, true),
-      availability: this.tag(this.getAvailability(car), false),
-      state_of_vehicle: this.tag(this.getCondition(car), false),
-      price: this.tag(`${price} EUR`, true),
-      sale_price: this.tag(`${price} EUR`, true),
-      link: this.tag(this.getCarLink(car), true),
+      make,
+      model,
+      year: this.getYear(car),
+      url: this.getCarLink(car),
       image: imageLinks.slice(0, 2), // main + 2nd image, per ticket
-      make: this.tag(make, false),
-      model: this.tag(model, false),
-      year: this.tag(this.getYear(car), false),
-      user_id: this.tag(ownerId, false),
-      custom_label_4: this.tag(customLabel4, false),
-      dealer_privacy_policy_url: this.tag('https://www.auto.de/einwilligungserklaerung/', false),
-      quantity_to_sell_on_facebook: this.tag(1, true),
-      google_product_category: this.tag('916', true),
-      status: this.tag('active', true),
-      color: this.tag(this.getColor(car), false),
-      product_type: this.tag('Vehicles & Parts > Vehicles > Motor Vehicles > Cars, Trucks & Vans', true),
+      price: `${price} EUR`,
+      availability: this.getAvailability(car),
+      exterior_color: this.getColor(car),
+      custom_label_4: customLabel4,
     };
 
     return offers.map((offer): FacebookShopItem => ({
       ...base,
-      id: this.tag(`${vehicleId}_${offer.offerType}`, true),
-      title: this.tag(offer.title, true),
-      description: this.tag(offer.description, true),
-      offer_type: this.tag(offer.offerType, false),
-      ...(offer.disclaimer ? { offer_disclaimer: this.tag(offer.disclaimer, false) } : {}),
+      vehicle_offer_id: `${vehicleId}_${offer.offerType}`,
+      title: offer.title,
+      offer_description: offer.description,
+      offer_type: offer.offerType,
+      ...(offer.disclaimer ? { offer_disclaimer: offer.disclaimer } : {}),
       ...(offer.financials ? this.financialTags(offer.financials) : {}),
-    } as FacebookShopItem));
+    }));
   }
 
   private buildOffers(car: DataSchemes.Car, common: { make: string; model: string; price: number }): Offer[] {
@@ -212,20 +205,15 @@ export class FacebookShopTransformer {
 
   private financialTags(financials: OfferFinancials): Partial<FacebookShopItem> {
     return {
-      monthly_payment: this.tag(financials.monthlyPayment, false),
-      down_payment: this.tag(financials.downPayment, false),
-      term_length: this.tag(financials.termLength, false),
-      apr: this.tag(financials.apr, false),
-      final_payment: this.tag(financials.finalPayment, false),
-      total_amount: this.tag(financials.totalAmount, false),
-      net_loan_amount: this.tag(financials.netLoanAmount, false),
+      amount_price: `${financials.monthlyPayment} EUR`,
+      amount_percentage: String(financials.apr),
+      amount_qualifier: AMOUNT_QUALIFIER_APR,
+      term_length: financials.termLength,
+      term_qualifier: TERM_QUALIFIER_MONTHS,
+      downpayment: `${financials.downPayment} EUR`,
     };
   }
 
-  private tag(value: any, isGoogle: boolean): FacebookShopTag {
-    return { value, isGoogle };
-  }
-
   // lodash's get() only falls back to the default for an *undefined* path — an explicit
   // `null` stored on the Car document (a common Mongo pattern for "not set") passes
   // straight through and ends up rendering as an empty XML tag. Coalesce it here instead.
@@ -249,18 +237,8 @@ export class FacebookShopTransformer {
     return firstRegistration ? moment(firstRegistration * 1000).format('YYYY') : moment().format('YYYY');
   }
 
-  private getCondition(car: DataSchemes.Car): string {
-    const available = {
-      selector_condition_new: 'New',
-      selector_condition_used: 'Used',
-      selector_unknown: 'Used',
-    };
-    const condition = get(car, 'mainData.condition', 'selector_unknown');
-    return get(available, condition);
-  }
-
   private getAvailability(car: DataSchemes.Car): string {
-    return get(car, 'state.isOnline', false) ? 'available' : 'not_available';
+    return get(car, 'state.isOnline', false) ? 'AVAILABLE' : 'NOT_AVAILABLE';
   }
 
   private getCarLink(car: DataSchemes.Car): string {