@bytebrand/export-cars 1.24.0 → 1.25.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.24.0",
+  "version": "1.25.0",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/exporters/fb.exporter.ts

@@ -41,6 +41,11 @@ export class FbExporter implements Exporter {
         const car = await fbTransformer.transform({ owner, ...data });
         console.timeEnd(`Transform ${data.car._id}`);
 
+        if (!car) {
+          console.log(`Skip car ${data.car._id} because it has no real images`);
+          continue;
+        }
+
         await fbXmlBuilder.addItem(car as FbXmlItem);
         this.carService.counter.countCar(data.images);
       }

package/src/formats/facebook-shop.builder.ts

@@ -17,6 +17,12 @@ export class FacebookShopXmlBuilder extends XMLBuilderBase {
     const tags = Object.keys(car);
 
     for (const tag of tags) {
+      if (tag === 'image' && Array.isArray(car[tag])) {
+        item += (car[tag] as unknown as string[])
+          .map((url: string) => `<image><url>${escape(url)}</url></image>\n`)
+          .join('');
+        continue;
+      }
       item += this.buildTagElement(tag, car[tag]);
     }
     item += '</item>';

package/src/formats/fb-xml.builder.ts

@@ -16,8 +16,17 @@ export class FbXmlBuilder extends XMLBuilderBase {
         if (key === 'description') {
           return this.getDescriptionElement(key, data);
         }
-        if (key === 'additional_image_link' && Array.isArray(data)) {
-          return data.map((value: string) => this.getElement(key, value, true)).join('');
+        if (key === 'image' && Array.isArray(data)) {
+          return this.getElementsArray(key, data.map((url: string) => ({ url })));
+        }
+        if (key === 'vehicle_specifications' && Array.isArray(data)) {
+          // getElement() treats falsy values as "missing" — stringify so a legitimate 0
+          // (e.g. CO2_emissions for an EV) still renders instead of an empty <value>.
+          const stringified = data.map((spec: { type: string; units: string; value: number }) => ({
+            ...spec,
+            value: String(spec.value),
+          }));
+          return this.getElementsArray(key, stringified);
         }
         if (Array.isArray(data)) {
           return this.getElementsArray(key, data);

package/src/interfaces/export-item.interface.ts

@@ -207,6 +207,7 @@ export interface GoogleXmlItem {
   identifier_exists: string,
   ads_redirect?: string;
   "certified_pre-owned"?: boolean;
+  user_id?: string;
   custom_label_0?: string;
   custom_label_1?: string,
   custom_label_2?: string,
@@ -351,11 +352,10 @@ export interface FacebookShopItem {
   title: FacebookShopTag;
   description: FacebookShopTag;
   availability: FacebookShopTag;
-  condition: FacebookShopTag;
+  state_of_vehicle: FacebookShopTag;
   price: FacebookShopTag;
   link: FacebookShopTag;
-  image_link: FacebookShopTag;
-  additional_image_link: FacebookShopTag;
+  image: string[];
   make: FacebookShopTag;
   model: FacebookShopTag;
   year: FacebookShopTag;

package/src/transformers/facebook-shop.transformer.ts

@@ -78,13 +78,12 @@ export class FacebookShopTransformer {
 
     const base = {
       vehicle_id: this.tag(vehicleId, true),
-      availability: this.tag('in stock', true),
-      condition: this.tag(this.getCondition(car), true),
+      availability: this.tag(this.getAvailability(car), false),
+      state_of_vehicle: this.tag(this.getCondition(car), false),
       price: this.tag(`${price} EUR`, true),
       sale_price: this.tag(`${price} EUR`, true),
       link: this.tag(this.getCarLink(car), true),
-      image_link: this.tag(imageLinks[0], true),
-      additional_image_link: this.tag(imageLinks[0], false),
+      image: imageLinks.slice(0, 2), // main + 2nd image, per ticket
       make: this.tag(make, false),
       model: this.tag(model, false),
       year: this.tag(this.getYear(car), false),
@@ -252,14 +251,18 @@ export class FacebookShopTransformer {
 
   private getCondition(car: DataSchemes.Car): string {
     const available = {
-      selector_condition_new: 'new',
-      selector_condition_used: 'used',
-      selector_unknown: 'used',
+      selector_condition_new: 'New',
+      selector_condition_used: 'Used',
+      selector_unknown: 'Used',
     };
     const condition = get(car, 'mainData.condition', 'selector_unknown');
     return get(available, condition);
   }
 
+  private getAvailability(car: DataSchemes.Car): string {
+    return get(car, 'state.isOnline', false) ? 'available' : 'not_available';
+  }
+
   private getCarLink(car: DataSchemes.Car): string {
     return `https://${this.configService.config.domain}/search/vehicle/${car._id}`;
   }

package/src/transformers/fb.transformer.ts

@@ -44,6 +44,9 @@ import {
   TIMESTAMP_FIRST_YEAR,
 } from '../constants/fb.constants';
 
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const vinGenerator = require('vin-generator');
+
 @Injectable()
 export class FbTransformer {
   private translator: TranslatorExtended;
@@ -71,6 +74,13 @@ export class FbTransformer {
     images: ImboImageResponseInterface[];
     owner: unknown;
   }): Promise<unknown> {
+    // ignoreDefImages=true: cars with no real photos must be excluded, not padded with
+    // placeholders (matches facebook-shop.transformer.ts's AMA feed policy).
+    const image_links = await this.imagesService.getImages(car, images, ImageType.marketing, true);
+    if (!image_links.length) {
+      return null;
+    }
+
     const autodeId = toString(get(car, '_id', ''));
     const year = this.getYear(car);
     const ownerId = get(car, 'metaData.ownerId', null);
@@ -78,9 +88,6 @@ export class FbTransformer {
     // console.time(`Address ${car._id}`);
     const address = await this.getAddress(car, owner);
     // console.timeEnd(`Address ${car._id}`);
-    // console.time(`Images ${car._id}`);
-    const image_links = await this.imagesService.getImages(car, images, ImageType.marketing, false);
-    // console.timeEnd(`Images ${car._id}`);
 
     return {
       fb_page_id: '176306386132',
@@ -99,8 +106,7 @@ export class FbTransformer {
       make: toString(get(car, 'mainData.make', '')),
       model: toString(get(car, 'mainData.model', '')),
       trim: this.getTrim(car),
-      image_link: image_links[0],
-      additional_image_link: image_links.slice(1, 21), // Meta allows max 20 additional images
+      image: image_links.slice(0, 20), // Meta caps the whole image array at 20 items
       year: toString(year),
       mileage: {
         value: this.getMileage(car),
@@ -114,7 +120,7 @@ export class FbTransformer {
       price: this.getPrice(car),
       exterior_color: this.getExteriorColor(car),
       interior_color: this.getInteriorColor(car),
-      condition: this.mapCondition(car),
+      state_of_vehicle: this.mapCondition(car),
       energy_efficiency_class_eu: this.getEnergyEfficiencyClass(car),
       vehicle_specifications: this.getVehicleSpecifications(car),
     };
@@ -218,6 +224,13 @@ export class FbTransformer {
       vin = get(car, 'marketing.fakeVIN', '');
     }
 
+    // Meta requires a vin on every listing. Real + fake VIN are both absent for a small
+    // share of cars (marketing.fakeVIN is populated by a different upstream service) —
+    // same generated-VIN fallback already used by mobile.transformer.ts/santander.transformer.ts.
+    if (!isValidVin(vin)) {
+      vin = vinGenerator.generateVin();
+    }
+
     return vin;
   }
 
@@ -381,16 +394,16 @@ export class FbTransformer {
 
   private mapCondition(car: DataSchemes.Car): string {
     const available = {
-      selector_condition_new: 'new',
-      selector_condition_used: 'used',
-      selector_unknown: 'used',
+      selector_condition_new: 'New',
+      selector_condition_used: 'Used',
+      selector_unknown: 'Used',
     };
     const condition = get(car, 'mainData.condition', 'selector_unknown');
     return get(available, condition);
   }
 
   private mapAvailability(car: DataSchemes.Car): string {
-    return get(car, 'state.isOnline', false) ? 'in stock' : 'out of stock';
+    return get(car, 'state.isOnline', false) ? 'available' : 'not_available';
   }
 
   private getEnergyEfficiencyClass(car: DataSchemes.Car): string {

package/src/transformers/google.transformer.ts

@@ -1,13 +1,17 @@
-import { escape, get, isNumber, join, round, toSafeInteger, toString, trim, truncate } from 'lodash';
+import { escape, get, includes, isNumber, join, round, toSafeInteger, toString, trim, truncate } from 'lodash';
 import { CarDescriptionFactory, DescriptionTypeEnum } from '@bytebrand/car-description';
 import { DataSchemes } from '@bytebrand/car-schema';
 import { TranslatorExtended } from '@bytebrand/schema-tools';
 import { de, deVehicleDetailsPage, deVehicleProps } from '@bytebrand/i18n-dictionaries';
 import { ImboImageResponseInterface } from '@bytebrand/chunkable';
 import { Injectable } from '@nestjs/common';
-import { ConfigService, ImagesService, TransformerService, UserService } from '../services';
+import { ConfigService, ImagesService, MappingService, TransformerService, UserService } from '../services';
 import { GoogleXmlItem } from '../interfaces';
 import { isValidVin } from '../utils';
+import {
+  META_PUSH_PRIORITY_ALLOWED_VALUES,
+  META_PUSH_PRIORITY_STANDARD,
+} from '../constants/fb.constants';
 
 const GOOGLE_MAX_TRIM_LENGTH = 50;
 const TIMESTAMP_FIRST_YEAR = 1970;
@@ -21,6 +25,7 @@ export class GoogleTransformer {
     private configService: ConfigService,
     private imageService: ImagesService,
     private readonly transformService: TransformerService,
+    private readonly mappingService: MappingService,
   ) {
     const dict = { ...de, ...deVehicleProps, ...deVehicleDetailsPage };
     this.translator = new TranslatorExtended(dict);
@@ -50,6 +55,8 @@ export class GoogleTransformer {
       ...transformedImages.feat
     ]
 
+    const ownerId = get(car, 'metaData.ownerId', null);
+
     const item: GoogleXmlItem = {
       google_product_category: '916',
       vehicle_fulfillment: {
@@ -92,11 +99,12 @@ export class GoogleTransformer {
       description: this.processText((await this.getDescription(car))),
       identifier_exists: 'yes',
       availability: 'in_stock',
+      user_id: ownerId,
+      custom_label_4: await this.getMetaPushPriority(ownerId),
       // custom_label_0: '',
       // custom_label_1: '',
       // custom_label_2: '',
       // custom_label_3: '',
-      // custom_label_4: '',
 
       // availability: this.getAvailability(car),
       // sale_price: this.getPrice(car),
@@ -131,6 +139,13 @@ export class GoogleTransformer {
     return item;
   }
 
+  private async getMetaPushPriority(ownerId: string): Promise<string> {
+    const priorities = await this.mappingService.getMetaPushPriorityMapping();
+    const entry = priorities.find(priority => priority.dealer_id === ownerId);
+    const value = get(entry, 'meta_push_priority', '');
+    return includes(META_PUSH_PRIORITY_ALLOWED_VALUES, value) ? value : META_PUSH_PRIORITY_STANDARD;
+  }
+
   private checkCarValidity(car: DataSchemes.Car, images: ImboImageResponseInterface[]) {
     if (images.length === 0)
       return false