@bytebrand/export-cars 1.24.0 → 1.24.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.24.0",
+  "version": "1.24.1",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/exporters/fb.exporter.ts

@@ -41,6 +41,11 @@ export class FbExporter implements Exporter {
         const car = await fbTransformer.transform({ owner, ...data });
         console.timeEnd(`Transform ${data.car._id}`);
 
+        if (!car) {
+          console.log(`Skip car ${data.car._id} because it has no real images`);
+          continue;
+        }
+
         await fbXmlBuilder.addItem(car as FbXmlItem);
         this.carService.counter.countCar(data.images);
       }

package/src/formats/fb-xml.builder.ts

@@ -19,6 +19,15 @@ export class FbXmlBuilder extends XMLBuilderBase {
         if (key === 'additional_image_link' && Array.isArray(data)) {
           return data.map((value: string) => this.getElement(key, value, true)).join('');
         }
+        if (key === 'vehicle_specifications' && Array.isArray(data)) {
+          // getElement() treats falsy values as "missing" — stringify so a legitimate 0
+          // (e.g. CO2_emissions for an EV) still renders instead of an empty <value>.
+          const stringified = data.map((spec: { type: string; units: string; value: number }) => ({
+            ...spec,
+            value: String(spec.value),
+          }));
+          return this.getElementsArray(key, stringified);
+        }
         if (Array.isArray(data)) {
           return this.getElementsArray(key, data);
         }

package/src/transformers/fb.transformer.ts

@@ -44,6 +44,9 @@ import {
   TIMESTAMP_FIRST_YEAR,
 } from '../constants/fb.constants';
 
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const vinGenerator = require('vin-generator');
+
 @Injectable()
 export class FbTransformer {
   private translator: TranslatorExtended;
@@ -71,6 +74,13 @@ export class FbTransformer {
     images: ImboImageResponseInterface[];
     owner: unknown;
   }): Promise<unknown> {
+    // ignoreDefImages=true: cars with no real photos must be excluded, not padded with
+    // placeholders (matches facebook-shop.transformer.ts's AMA feed policy).
+    const image_links = await this.imagesService.getImages(car, images, ImageType.marketing, true);
+    if (!image_links.length) {
+      return null;
+    }
+
     const autodeId = toString(get(car, '_id', ''));
     const year = this.getYear(car);
     const ownerId = get(car, 'metaData.ownerId', null);
@@ -78,9 +88,6 @@ export class FbTransformer {
     // console.time(`Address ${car._id}`);
     const address = await this.getAddress(car, owner);
     // console.timeEnd(`Address ${car._id}`);
-    // console.time(`Images ${car._id}`);
-    const image_links = await this.imagesService.getImages(car, images, ImageType.marketing, false);
-    // console.timeEnd(`Images ${car._id}`);
 
     return {
       fb_page_id: '176306386132',
@@ -218,6 +225,13 @@ export class FbTransformer {
       vin = get(car, 'marketing.fakeVIN', '');
     }
 
+    // Meta requires a vin on every listing. Real + fake VIN are both absent for a small
+    // share of cars (marketing.fakeVIN is populated by a different upstream service) —
+    // same generated-VIN fallback already used by mobile.transformer.ts/santander.transformer.ts.
+    if (!isValidVin(vin)) {
+      vin = vinGenerator.generateVin();
+    }
+
     return vin;
   }