@bytebrand/export-cars 1.23.3 → 1.24.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.23.3",
+  "version": "1.24.1",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/exporters/fb.exporter.ts

@@ -41,6 +41,11 @@ export class FbExporter implements Exporter {
         const car = await fbTransformer.transform({ owner, ...data });
         console.timeEnd(`Transform ${data.car._id}`);
 
+        if (!car) {
+          console.log(`Skip car ${data.car._id} because it has no real images`);
+          continue;
+        }
+
         await fbXmlBuilder.addItem(car as FbXmlItem);
         this.carService.counter.countCar(data.images);
       }

package/src/formats/fb-xml.builder.ts

@@ -19,6 +19,15 @@ export class FbXmlBuilder extends XMLBuilderBase {
         if (key === 'additional_image_link' && Array.isArray(data)) {
           return data.map((value: string) => this.getElement(key, value, true)).join('');
         }
+        if (key === 'vehicle_specifications' && Array.isArray(data)) {
+          // getElement() treats falsy values as "missing" — stringify so a legitimate 0
+          // (e.g. CO2_emissions for an EV) still renders instead of an empty <value>.
+          const stringified = data.map((spec: { type: string; units: string; value: number }) => ({
+            ...spec,
+            value: String(spec.value),
+          }));
+          return this.getElementsArray(key, stringified);
+        }
         if (Array.isArray(data)) {
           return this.getElementsArray(key, data);
         }

package/src/services/images.service.ts

@@ -202,7 +202,7 @@ export class ImagesService {
 
 
     if (!ignoreDefImages && imageWithUrls.length < FB_MAX_IMAGE_COUNT_FOR_DEAFULT) {
-      imageWithUrls.map(i => i.url).push(...this.DEFAULT_IMAGES);
+      this.DEFAULT_IMAGES.forEach(url => imageWithUrls.push({ url }));
     }
 
     return imageWithUrls.map(i => i.url);

package/src/transformers/fb.transformer.ts

@@ -44,6 +44,9 @@ import {
   TIMESTAMP_FIRST_YEAR,
 } from '../constants/fb.constants';
 
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const vinGenerator = require('vin-generator');
+
 @Injectable()
 export class FbTransformer {
   private translator: TranslatorExtended;
@@ -71,6 +74,13 @@ export class FbTransformer {
     images: ImboImageResponseInterface[];
     owner: unknown;
   }): Promise<unknown> {
+    // ignoreDefImages=true: cars with no real photos must be excluded, not padded with
+    // placeholders (matches facebook-shop.transformer.ts's AMA feed policy).
+    const image_links = await this.imagesService.getImages(car, images, ImageType.marketing, true);
+    if (!image_links.length) {
+      return null;
+    }
+
     const autodeId = toString(get(car, '_id', ''));
     const year = this.getYear(car);
     const ownerId = get(car, 'metaData.ownerId', null);
@@ -78,9 +88,6 @@ export class FbTransformer {
     // console.time(`Address ${car._id}`);
     const address = await this.getAddress(car, owner);
     // console.timeEnd(`Address ${car._id}`);
-    // console.time(`Images ${car._id}`);
-    const image_links = await this.imagesService.getImages(car, images, ImageType.marketing, false);
-    // console.timeEnd(`Images ${car._id}`);
 
     return {
       fb_page_id: '176306386132',
@@ -116,31 +123,24 @@ export class FbTransformer {
       interior_color: this.getInteriorColor(car),
       condition: this.mapCondition(car),
       energy_efficiency_class_eu: this.getEnergyEfficiencyClass(car),
-      vehicle_specifications: [
-        {
-          type: 'gas_mileage_combined',
-          units: 'l/100km',
-          value: get(car, 'consumption.wltpCombined', ''),
-        },
-        {
-          type: 'gas_mileage_city',
-          units: 'l/100km',
-          value: get(car, 'consumption.wltpSlow', ''),
-        },
-        {
-          type: 'gas_mileage_highway',
-          units: 'l/100km',
-          value: get(car, 'consumption.wltpVeryFast', ''),
-        },
-        {
-          type: 'CO2_emissions',
-          units: 'g/km',
-          value: get(car, 'environmentEmissions.wltpCo2', ''),
-        },
-      ],
+      vehicle_specifications: this.getVehicleSpecifications(car),
     };
   }
 
+  // wltp* fields are @IsOptional on the schema — genuinely absent for a meaningful share of
+  // cars (older listings, incomplete imports). Omit the whole entry rather than emit a spec
+  // with an empty <value>, but keep legitimate 0 (e.g. CO2 for an EV) — isPresent, not truthy.
+  private getVehicleSpecifications(car: DataSchemes.Car): { type: string; units: string; value: number }[] {
+    const isPresent = (value: unknown): value is number => value !== null && value !== undefined && value !== '';
+
+    return [
+      { type: 'gas_mileage_combined', units: 'l/100km', value: get(car, 'consumption.wltpCombined') },
+      { type: 'gas_mileage_city', units: 'l/100km', value: get(car, 'consumption.wltpSlow') },
+      { type: 'gas_mileage_highway', units: 'l/100km', value: get(car, 'consumption.wltpVeryFast') },
+      { type: 'CO2_emissions', units: 'g/km', value: get(car, 'environmentEmissions.wltpCo2') },
+    ].filter(spec => isPresent(spec.value));
+  }
+
   private getYear(car: DataSchemes.Car): number {
     const firstModelsProductionDate = get(car, 'mainData.firstModelsProductionDate', 0) as number;
     const firstModelsProductionYear = moment(firstModelsProductionDate * 1000).format('YYYY');
@@ -225,6 +225,13 @@ export class FbTransformer {
       vin = get(car, 'marketing.fakeVIN', '');
     }
 
+    // Meta requires a vin on every listing. Real + fake VIN are both absent for a small
+    // share of cars (marketing.fakeVIN is populated by a different upstream service) —
+    // same generated-VIN fallback already used by mobile.transformer.ts/santander.transformer.ts.
+    if (!isValidVin(vin)) {
+      vin = vinGenerator.generateVin();
+    }
+
     return vin;
   }
 
@@ -444,7 +451,7 @@ export class FbTransformer {
       { key: 'assistants.laneAssistant', type: 'lane_keep_assist', value: 'Spurhalte-Assistent' },
       { key: 'lights.ledHeadlights', type: 'led_headlights', value: 'LED Scheinwerfer' },
       { key: 'window.sunroof', type: 'moon_roof', value: 'Schiebedach' },
-      { key: 'multimedia.mp3Interface', type: 'mp3		MP3', value: 'Schnittstelle' },
+      { key: 'multimedia.mp3Interface', type: 'mp3', value: 'Schnittstelle' },
       { key: 'multimedia.navigationSystem', type: 'navigation', value: 'Navigationssystem' },
       { key: 'assistants.nightVisionAssistant', type: 'night_view', value: 'Nachsicht Assistent' },
       { key: 'window.panoramicGlassRoof', type: 'panorama_roof', value: 'Panoramaschiebedach' },
@@ -670,6 +677,12 @@ export class FbTransformer {
   }
 }
 
+// Upper-bounded so a raw unix timestamp leaking through a non-date field (e.g.
+// mainData.constructionYear stored as an epoch instead of a 4-digit year, seen in prod) can't
+// be mistaken for a valid year — a timestamp is astronomically larger than any real car year.
 function getFirstValidYear(...years: string[]): number {
-  return years.map((year: string) => toSafeInteger(year)).filter((year: number) => year > TIMESTAMP_FIRST_YEAR)[0];
+  const currentYear = toSafeInteger(moment().format('YYYY'));
+  return years
+    .map((year: string) => toSafeInteger(year))
+    .filter((year: number) => year > TIMESTAMP_FIRST_YEAR && year <= currentYear + 1)[0];
 }