@bytebrand/export-cars 1.23.2 → 1.24.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.23.2",
+  "version": "1.24.0",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/services/images.service.ts

@@ -202,7 +202,7 @@ export class ImagesService {
 
 
     if (!ignoreDefImages && imageWithUrls.length < FB_MAX_IMAGE_COUNT_FOR_DEAFULT) {
-      imageWithUrls.map(i => i.url).push(...this.DEFAULT_IMAGES);
+      this.DEFAULT_IMAGES.forEach(url => imageWithUrls.push({ url }));
     }
 
     return imageWithUrls.map(i => i.url);

package/src/transformers/facebook-shop.transformer.ts

@@ -122,15 +122,21 @@ export class FacebookShopTransformer {
       downPayment: this.getNum(car, 'rate.firstInstallment'),
       termLength: this.getNum(car, 'rate.paybackPeriod'),
     };
-    const rawLeasing = {
-      monthlyPayment: this.getNum(car, 'leasing.monthlyInstallment'),
-      downPayment: this.getNum(car, 'leasing.firstInstallment'),
-      termLength: this.getNum(car, 'leasing.paybackPeriod'),
-    };
     const leasingIsEligible = this.isLeasingEligible(car);
 
     const { financing: computedFinancing, leasing: computedLeasing } = this.computeFinancials(car);
 
+    // Unlike financing, the CDP never reads a pre-stored leasing.monthlyInstallment — it
+    // always computes it live from RWG + price (see fe-main SearchResultsStore/NewMainPage,
+    // same isLeasingEligible formula). The raw car.leasing.monthlyInstallment field can be
+    // stale/unset even when the CDP shows an active leasing tab, so the computed value is the
+    // one that actually matches what the customer sees.
+    const computedLeasingValues = {
+      monthlyPayment: this.getNum(computedLeasing, 'monthlyInstallment'),
+      downPayment: this.getNum(computedLeasing, 'firstInstallment'),
+      termLength: this.getNum(computedLeasing, 'paybackPeriod'),
+    };
+
     if (offersFinancing && rawFinancing.monthlyPayment && computedFinancing) {
       offers.push({
         offerType: OfferType.financing,
@@ -148,15 +154,15 @@ export class FacebookShopTransformer {
       });
     }
 
-    if (leasingIsEligible && rawLeasing.monthlyPayment && computedLeasing) {
+    if (leasingIsEligible && computedLeasingValues.monthlyPayment && computedLeasing) {
       offers.push({
         offerType: OfferType.leasing,
-        title: `${make} ${model} leasen – z. B. ab ${this.formatEUR(rawLeasing.monthlyPayment)} €/Monat`,
-        description: `${make} ${model} leasen – ${rawLeasing.termLength} Monate Laufzeit, ` +
-          `${this.formatEUR(rawLeasing.downPayment)} € Anzahlung`,
+        title: `${make} ${model} leasen – z. B. ab ${this.formatEUR(computedLeasingValues.monthlyPayment)} €/Monat`,
+        description: `${make} ${model} leasen – ${computedLeasingValues.termLength} Monate Laufzeit, ` +
+          `${this.formatEUR(computedLeasingValues.downPayment)} € Anzahlung`,
         disclaimer: OFFER_DISCLAIMER,
         financials: {
-          ...rawLeasing,
+          ...computedLeasingValues,
           apr: this.getNum(computedLeasing, 'annualPercentageRate'),
           finalPayment: this.getNum(computedLeasing, 'finalInstallment'),
           totalAmount: this.getNum(computedLeasing, 'grossLoanAmount'),

package/src/transformers/fb.transformer.ts

@@ -116,31 +116,24 @@ export class FbTransformer {
       interior_color: this.getInteriorColor(car),
       condition: this.mapCondition(car),
       energy_efficiency_class_eu: this.getEnergyEfficiencyClass(car),
-      vehicle_specifications: [
-        {
-          type: 'gas_mileage_combined',
-          units: 'l/100km',
-          value: get(car, 'consumption.wltpCombined', ''),
-        },
-        {
-          type: 'gas_mileage_city',
-          units: 'l/100km',
-          value: get(car, 'consumption.wltpSlow', ''),
-        },
-        {
-          type: 'gas_mileage_highway',
-          units: 'l/100km',
-          value: get(car, 'consumption.wltpVeryFast', ''),
-        },
-        {
-          type: 'CO2_emissions',
-          units: 'g/km',
-          value: get(car, 'environmentEmissions.wltpCo2', ''),
-        },
-      ],
+      vehicle_specifications: this.getVehicleSpecifications(car),
     };
   }
 
+  // wltp* fields are @IsOptional on the schema — genuinely absent for a meaningful share of
+  // cars (older listings, incomplete imports). Omit the whole entry rather than emit a spec
+  // with an empty <value>, but keep legitimate 0 (e.g. CO2 for an EV) — isPresent, not truthy.
+  private getVehicleSpecifications(car: DataSchemes.Car): { type: string; units: string; value: number }[] {
+    const isPresent = (value: unknown): value is number => value !== null && value !== undefined && value !== '';
+
+    return [
+      { type: 'gas_mileage_combined', units: 'l/100km', value: get(car, 'consumption.wltpCombined') },
+      { type: 'gas_mileage_city', units: 'l/100km', value: get(car, 'consumption.wltpSlow') },
+      { type: 'gas_mileage_highway', units: 'l/100km', value: get(car, 'consumption.wltpVeryFast') },
+      { type: 'CO2_emissions', units: 'g/km', value: get(car, 'environmentEmissions.wltpCo2') },
+    ].filter(spec => isPresent(spec.value));
+  }
+
   private getYear(car: DataSchemes.Car): number {
     const firstModelsProductionDate = get(car, 'mainData.firstModelsProductionDate', 0) as number;
     const firstModelsProductionYear = moment(firstModelsProductionDate * 1000).format('YYYY');
@@ -444,7 +437,7 @@ export class FbTransformer {
       { key: 'assistants.laneAssistant', type: 'lane_keep_assist', value: 'Spurhalte-Assistent' },
       { key: 'lights.ledHeadlights', type: 'led_headlights', value: 'LED Scheinwerfer' },
       { key: 'window.sunroof', type: 'moon_roof', value: 'Schiebedach' },
-      { key: 'multimedia.mp3Interface', type: 'mp3		MP3', value: 'Schnittstelle' },
+      { key: 'multimedia.mp3Interface', type: 'mp3', value: 'Schnittstelle' },
       { key: 'multimedia.navigationSystem', type: 'navigation', value: 'Navigationssystem' },
       { key: 'assistants.nightVisionAssistant', type: 'night_view', value: 'Nachsicht Assistent' },
       { key: 'window.panoramicGlassRoof', type: 'panorama_roof', value: 'Panoramaschiebedach' },
@@ -670,6 +663,12 @@ export class FbTransformer {
   }
 }
 
+// Upper-bounded so a raw unix timestamp leaking through a non-date field (e.g.
+// mainData.constructionYear stored as an epoch instead of a 4-digit year, seen in prod) can't
+// be mistaken for a valid year — a timestamp is astronomically larger than any real car year.
 function getFirstValidYear(...years: string[]): number {
-  return years.map((year: string) => toSafeInteger(year)).filter((year: number) => year > TIMESTAMP_FIRST_YEAR)[0];
+  const currentYear = toSafeInteger(moment().format('YYYY'));
+  return years
+    .map((year: string) => toSafeInteger(year))
+    .filter((year: number) => year > TIMESTAMP_FIRST_YEAR && year <= currentYear + 1)[0];
 }