@bytebrand/export-cars 1.23.1 → 1.23.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.23.1",
+  "version": "1.23.3",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/transformers/facebook-shop.transformer.ts

@@ -118,19 +118,25 @@ export class FacebookShopTransformer {
     // matching exactly what the CDP displays (per ticket: data.rate.*/data.leasing.*).
     const offersFinancing = get(car, 'rate.offersFinancing') !== false;
     const rawFinancing = {
-      monthlyPayment: get(car, 'rate.monthlyInstallment', 0),
-      downPayment: get(car, 'rate.firstInstallment', 0),
-      termLength: get(car, 'rate.paybackPeriod', 0),
-    };
-    const rawLeasing = {
-      monthlyPayment: get(car, 'leasing.monthlyInstallment', 0),
-      downPayment: get(car, 'leasing.firstInstallment', 0),
-      termLength: get(car, 'leasing.paybackPeriod', 0),
+      monthlyPayment: this.getNum(car, 'rate.monthlyInstallment'),
+      downPayment: this.getNum(car, 'rate.firstInstallment'),
+      termLength: this.getNum(car, 'rate.paybackPeriod'),
     };
     const leasingIsEligible = this.isLeasingEligible(car);
 
     const { financing: computedFinancing, leasing: computedLeasing } = this.computeFinancials(car);
 
+    // Unlike financing, the CDP never reads a pre-stored leasing.monthlyInstallment — it
+    // always computes it live from RWG + price (see fe-main SearchResultsStore/NewMainPage,
+    // same isLeasingEligible formula). The raw car.leasing.monthlyInstallment field can be
+    // stale/unset even when the CDP shows an active leasing tab, so the computed value is the
+    // one that actually matches what the customer sees.
+    const computedLeasingValues = {
+      monthlyPayment: this.getNum(computedLeasing, 'monthlyInstallment'),
+      downPayment: this.getNum(computedLeasing, 'firstInstallment'),
+      termLength: this.getNum(computedLeasing, 'paybackPeriod'),
+    };
+
     if (offersFinancing && rawFinancing.monthlyPayment && computedFinancing) {
       offers.push({
         offerType: OfferType.financing,
@@ -140,27 +146,27 @@ export class FacebookShopTransformer {
         disclaimer: OFFER_DISCLAIMER,
         financials: {
           ...rawFinancing,
-          apr: get(computedFinancing, 'annualPercentageRate', 0),
-          finalPayment: get(computedFinancing, 'finalInstallment', 0),
-          totalAmount: get(computedFinancing, 'grossLoanAmount', 0),
-          netLoanAmount: get(computedFinancing, 'netLoanAmount', 0),
+          apr: this.getNum(computedFinancing, 'annualPercentageRate'),
+          finalPayment: this.getNum(computedFinancing, 'finalInstallment'),
+          totalAmount: this.getNum(computedFinancing, 'grossLoanAmount'),
+          netLoanAmount: this.getNum(computedFinancing, 'netLoanAmount'),
         },
       });
     }
 
-    if (leasingIsEligible && rawLeasing.monthlyPayment && computedLeasing) {
+    if (leasingIsEligible && computedLeasingValues.monthlyPayment && computedLeasing) {
       offers.push({
         offerType: OfferType.leasing,
-        title: `${make} ${model} leasen – z. B. ab ${this.formatEUR(rawLeasing.monthlyPayment)} €/Monat`,
-        description: `${make} ${model} leasen – ${rawLeasing.termLength} Monate Laufzeit, ` +
-          `${this.formatEUR(rawLeasing.downPayment)} € Anzahlung`,
+        title: `${make} ${model} leasen – z. B. ab ${this.formatEUR(computedLeasingValues.monthlyPayment)} €/Monat`,
+        description: `${make} ${model} leasen – ${computedLeasingValues.termLength} Monate Laufzeit, ` +
+          `${this.formatEUR(computedLeasingValues.downPayment)} € Anzahlung`,
         disclaimer: OFFER_DISCLAIMER,
         financials: {
-          ...rawLeasing,
-          apr: get(computedLeasing, 'annualPercentageRate', 0),
-          finalPayment: get(computedLeasing, 'finalInstallment', 0),
-          totalAmount: get(computedLeasing, 'grossLoanAmount', 0),
-          netLoanAmount: get(computedLeasing, 'netLoanAmount', 0),
+          ...computedLeasingValues,
+          apr: this.getNum(computedLeasing, 'annualPercentageRate'),
+          finalPayment: this.getNum(computedLeasing, 'finalInstallment'),
+          totalAmount: this.getNum(computedLeasing, 'grossLoanAmount'),
+          netLoanAmount: this.getNum(computedLeasing, 'netLoanAmount'),
         },
       });
     }
@@ -194,10 +200,10 @@ export class FacebookShopTransformer {
   // Mirrors getLeasing.ts's isLeasingActive: same car ages out of leasing eligibility once
   // it's older than leasing.maxAge months or past leasing.maxMileage km.
   private isLeasingEligible(car: DataSchemes.Car): boolean {
-    const firstRegistration = get(car, 'mainData.firstRegistration', 0) as number;
-    const mileage = get(car, 'mainData.mileage', 0) as number;
-    const maxAge = get(car, 'leasing.maxAge', 24) as number;
-    const maxMileage = get(car, 'leasing.maxMileage', 1000000) as number;
+    const firstRegistration = this.getNum(car, 'mainData.firstRegistration');
+    const mileage = this.getNum(car, 'mainData.mileage');
+    const maxAge = this.getNum(car, 'leasing.maxAge', 24);
+    const maxMileage = this.getNum(car, 'leasing.maxMileage', 1000000);
 
     const registrationMs = firstRegistration ? firstRegistration * 1000 : Date.now();
     const maxCarAge = new Date().setMonth(new Date().getMonth() - maxAge);
@@ -221,6 +227,13 @@ export class FacebookShopTransformer {
     return { value, isGoogle };
   }
 
+  // lodash's get() only falls back to the default for an *undefined* path — an explicit
+  // `null` stored on the Car document (a common Mongo pattern for "not set") passes
+  // straight through and ends up rendering as an empty XML tag. Coalesce it here instead.
+  private getNum(source: any, path: string, fallback = 0): number {
+    return get(source, path) ?? fallback;
+  }
+
   private formatEUR(value: number): string {
     return Math.round(value || 0).toLocaleString(DE_LOCALE);
   }
@@ -233,7 +246,7 @@ export class FacebookShopTransformer {
   }
 
   private getYear(car: DataSchemes.Car): string {
-    const firstRegistration = get(car, 'mainData.firstRegistration', 0) as number;
+    const firstRegistration = this.getNum(car, 'mainData.firstRegistration');
     return firstRegistration ? moment(firstRegistration * 1000).format('YYYY') : moment().format('YYYY');
   }
 
@@ -252,7 +265,7 @@ export class FacebookShopTransformer {
   }
 
   private getPriceValue(car: DataSchemes.Car): number {
-    return round(get(car, 'price.currentSalesPrice', 0), 2);
+    return round(this.getNum(car, 'price.currentSalesPrice'), 2);
   }
 
   private getColor(car: DataSchemes.Car): string {