@bytebrand/export-cars 1.22.20 → 1.22.22

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.22.20",
+  "version": "1.22.22",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",

package/src/formats/google-xml.builder.ts

@@ -49,17 +49,17 @@ export class GoogleXmlBuilder extends XMLBuilderBase {
     </g:${rootTag}>`;
   }
 
-  private getCertificationElement(rootTag: string, data: {
+  private getCertificationElement(rootTag: string, data: Array<{
     certification_authority: string;
     certification_name: string;
     certification_code?: string;
     certification_value?: string;
-  }): string {
-    return `<g:${rootTag}>
-      <g:certification_authority>${data.certification_authority}</g:certification_authority>
-      <g:certification_name>${data.certification_name}</g:certification_name>
-      <g:certification_value>${data.certification_value}</g:certification_value>
-    </g:${rootTag}>`;
+  }>): string {
+    return data.map(certification => `<g:${rootTag}>
+      <g:certification_authority>${certification.certification_authority}</g:certification_authority>
+      <g:certification_name>${certification.certification_name}</g:certification_name>
+      <g:certification_value>${certification.certification_value}</g:certification_value>
+    </g:${rootTag}>`).join('');
   }
 
   private getInstallmentElement(rootTag: string, data: { paybackPeriod: string; monthlyInstallment: string; apr?: string }): string {

package/src/interfaces/export-item.interface.ts

@@ -173,27 +173,32 @@ export interface GoogleXmlItem {
   availability?: string;
   energy_efficiency_class?: string;
   installment?: { paybackPeriod: any; monthlyInstallment: any; apr: string };
+  vehicle_msrp?: string;
 
   vehicle_fulfillment: {
     option: string;
     store_code: string;
   };
-  certification?: {
+  certification?: Array<{
     certification_authority: string;
     certification_name: string;
     certification_code?: string;
     certification_value?: string;
-  };
+  }>;
   link_template: string;
   additional_image_link: string[];
   model: string;
-  VIN: string;
+  VIN?: string;
   trim: string;
   year: number;
   mileage: string;
   vehicle_option: string[];
-  body_style: string,
+  body_style?: string,
   engine: string,
+  transmission?: string;
+  drive?: string;
+  doors?: number;
+  capacity?: number;
   date_first_registered: string,
   fuel_consumption: string,
   energy_consumption?: string,

package/src/transformers/google.transformer.ts

@@ -7,6 +7,7 @@ import { ImboImageResponseInterface } from '@bytebrand/chunkable';
 import { Injectable } from '@nestjs/common';
 import { ConfigService, ImagesService, TransformerService, UserService } from '../services';
 import { GoogleXmlItem } from '../interfaces';
+import { isValidVin } from '../utils';
 import moment from 'moment';
 
 const GOOGLE_MAX_TRIM_LENGTH = 50;
@@ -59,7 +60,7 @@ export class GoogleTransformer {
       certification: this.getCertification(car),
       title: this.getTitle(car),
       product_type: this.getCategory(car),
-      VIN: this.transformService.vinCode(car),
+      VIN: this.getVin(car),
       id: carId,
       image_link: allImages[0],
       additional_image_link: allImages.slice(1, 10),
@@ -68,6 +69,7 @@ export class GoogleTransformer {
       link_template: `${this.getLink(car)}?store={store_code}`,
       condition: this.mapState(car),
       price: this.getPrice(car),
+      vehicle_msrp: this.getVehicleMsrp(car),
       // certified_pre-owned: '',
       brand: this.transformService.make(car),
       model: this.transformService.model(car),
@@ -78,6 +80,10 @@ export class GoogleTransformer {
       vehicle_option: this.getExtrasField(car),
       body_style: this.mapBodyStyle(car),
       engine: this.mapFuel(car),
+      transmission: this.mapTransmission(car),
+      drive: this.mapDrive(car),
+      doors: this.getDoors(car),
+      capacity: this.getCapacity(car),
       date_first_registered: this.getDateFirstRegistered(car),
       fuel_consumption: `${this.transformService.fuelConsumption(car)}l/100km`,
       energy_consumption: this.getEnergyConsumption(car),
@@ -85,7 +91,7 @@ export class GoogleTransformer {
       fuel_consumption_discharged_battery: this.getFuelConsumptionDischargedBattery(car),
       co2_emissions: `${this.transformService.cO2Emission(car)}g/km`,
       description: this.processText((await this.getDescription(car))),
-      identifier_exists: 'no',
+      identifier_exists: 'yes',
       availability: 'in_stock',
       // custom_label_0: '',
       // custom_label_1: '',
@@ -110,6 +116,12 @@ export class GoogleTransformer {
       'electric_range',
       'fuel_consumption_discharged_battery',
       'installment',
+      'body_style',
+      'vehicle_msrp',
+      'transmission',
+      'drive',
+      'doors',
+      'capacity',
     ];
     for (const key of optionalKeys) {
       if (!item[key]) {
@@ -124,12 +136,14 @@ export class GoogleTransformer {
     if (images.length === 0)
       return false
 
-    if (!this.mapBodyStyle(car))
-      return false
-
     return true
   }
 
+  private getVin(car: DataSchemes.Car): string {
+    const vin = get(car, 'metaData.vin', '');
+    return isValidVin(vin) ? vin : get(car, 'marketing.fakeVIN', '');
+  }
+
   private getTitle(car: DataSchemes.Car): string {
     const model = toString(get(car, 'mainData.model', ''));
     const brand = trim(this.getBrand(car));
@@ -200,12 +214,13 @@ export class GoogleTransformer {
     }
   }
 
-  private getRetailPrice(car: DataSchemes.Car): string {
-    const retailPrice = get(car, 'recommendedRetailPrice', '');
-    if (retailPrice) {
-      return `${round(retailPrice, 2)} EUR`;
+  private getVehicleMsrp(car: DataSchemes.Car): string | undefined {
+    const retailPrice = get(car, 'recommendedRetailPrice');
+    const salesPrice = get(car, 'price.currentSalesPrice', 0);
+    if (!retailPrice || round(retailPrice, 2) === round(salesPrice, 2)) {
+      return undefined;
     }
-    return this.getPrice(car);
+    return `${round(retailPrice, 2)} EUR`;
   }
 
   private getPrice(car: DataSchemes.Car): string {
@@ -241,7 +256,7 @@ export class GoogleTransformer {
     return get(available, availability);
   }
 
-  private getEnergyClass(car: DataSchemes.Car): string {
+  private mapEnergyClass(selector: string): string {
     const available = {
       selector_energyEfficiencyClass_a: 'A',
       selector_energyEfficiencyClass_ap: 'A+',
@@ -255,21 +270,42 @@ export class GoogleTransformer {
       selector_energyEfficiencyClass_g: 'G',
       selector_unknown: 'default',
     };
-    const energyClass = get(car, 'environmentEmissions.energyEfficiencyClass', 'selector_unknown');
-    const value = get(available, energyClass);
+    const value = get(available, selector);
     return value ? value.replace(/\+/g, '') : '';
   }
 
+  private getEnergyClass(car: DataSchemes.Car): string {
+    return this.mapEnergyClass(get(car, 'environmentEmissions.energyEfficiencyClass', 'selector_unknown'));
+  }
+
+  private getDischargedEnergyClass(car: DataSchemes.Car): string {
+    return this.mapEnergyClass(get(car, 'environmentEmissions.wltpDischargedEnergyEfficiencyClass', 'selector_unknown'));
+  }
+
   private getCertification(car: DataSchemes.Car) {
-    const value = this.getEnergyClass(car);
-    if (!value || value === 'default') {
-      return undefined;
+    const certifications: Array<{ certification_authority: string; certification_name: string; certification_value: string }> = [];
+
+    const co2Class = this.getEnergyClass(car);
+    if (co2Class && co2Class !== 'default') {
+      certifications.push({
+        certification_authority: 'BMWK',
+        certification_name: 'Vehicle_CO2_Class',
+        certification_value: co2Class,
+      });
     }
-    return {
-      certification_authority: 'BMWK',
-      certification_name: 'Vehicle_CO2_Class',
-      certification_value: value,
-    };
+
+    if (get(car, 'engineData.hybridPlugin')) {
+      const dischargedClass = this.getDischargedEnergyClass(car);
+      if (dischargedClass && dischargedClass !== 'default') {
+        certifications.push({
+          certification_authority: 'BMWK',
+          certification_name: 'Vehicle_CO2_Class_Discharged_Battery',
+          certification_value: dischargedClass,
+        });
+      }
+    }
+
+    return certifications.length ? certifications : undefined;
   }
 
   private getEnergyConsumption(car: DataSchemes.Car): string | undefined {
@@ -366,6 +402,32 @@ export class GoogleTransformer {
     return get(available, category);
   }
 
+  private mapTransmission(car: DataSchemes.Car): string | undefined {
+    const available = {
+      selector_gearbox_manualShift: 'MANUAL',
+      selector_gearbox_semiAutomatic: 'AUTOMATIC',
+      selector_gearbox_automatic: 'AUTOMATIC',
+    };
+    return get(available, get(car, 'driveSuspension.gearbox'));
+  }
+
+  private mapDrive(car: DataSchemes.Car): string | undefined {
+    const available = {
+      selector_driveType_frontWheelDrive: 'FWD',
+      selector_driveType_rearWheelDrive: 'RWD',
+      selector_driveType_allWheelDrive: 'AWD',
+    };
+    return get(available, get(car, 'driveSuspension.driveType'));
+  }
+
+  private getDoors(car: DataSchemes.Car): number | undefined {
+    return toSafeInteger(get(car, 'mainData.doors')) || undefined;
+  }
+
+  private getCapacity(car: DataSchemes.Car): number | undefined {
+    return toSafeInteger(get(car, 'engineData.cubicCapacity')) || undefined;
+  }
+
   private getExtrasField(car: DataSchemes.Car): string[] {
     const booleanFields: string[] = [
       'engineData.startStopSystem',
@@ -479,10 +541,9 @@ export class GoogleTransformer {
   }
 
   private getYear(car: DataSchemes.Car) {
-    const firstModelsProductionDate = +get(car, 'mainData.firstModelsProductionDate', 0);
-
-    const date = new Date(firstModelsProductionDate);
-    const firstModelsProductionYear = date.getFullYear();
+    // mainData.firstModelsProductionDate is already a 4-digit year (mobile.de "vintage"),
+    // not a timestamp — do not run it through `new Date(...)`.
+    const firstModelsProductionYear = toSafeInteger(get(car, 'mainData.firstModelsProductionDate', 0));
 
     return firstModelsProductionYear > TIMESTAMP_FIRST_YEAR ? firstModelsProductionYear : null
   }