@bytebrand/export-cars 1.21.0 → 1.21.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.21.0",
+  "version": "1.21.1",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",
@@ -62,5 +62,5 @@
   "engines": {
     "node": ">=14.0.0"
   },
-  "gitHead": "3ef72636ca23cee78df87f16e66089e1a532b053"
+  "gitHead": "ea5d40b0c028d75455818e481f87d74bd18f820c"
 }

package/src/exporters/mobile.exporter.ts

@@ -44,7 +44,7 @@ export class MobileExporter implements Exporter {
 
           if (this.configService.config.downloadImage) {
             const urls = await this.imageService.getImages(car, images, this.configService.config.imageType, true);
-            imagesPath.push(...await this.imageService.downloadInParallel(car.metaData.vehicleId, urls, this.configService.config, 10));
+            imagesPath.push(...await this.imageService.downloadInParallel(car.metaData.vehicleId, urls, this.configService.config));
           }
 
           await writeFile(fileName, Buffer.from(`${convertToCSV(transformedData)}\n`), { flag: 'a' });

package/src/services/images.service.ts

@@ -173,17 +173,14 @@ export class ImagesService {
     });
   }
 
-  async downloadInParallel(vehicleId: string, urls: string[], config: Config, concurrency = 1): Promise<string[]> {
-    for (let i = 0; i < urls.length; i += concurrency) {
-      const downloadPromises = urls.map(
-        (url: string, j: number) => this.download(
-          url,
-          `${config.pathesConfig.localConvertedDirectory}/${vehicleId}_${(i + 1).toLocaleString('en-US', { minimumIntegerDigits: 2 })}.jpeg`
-        )
-      );
-      return Promise.all(downloadPromises);
-    }
-    return [];
+  async downloadInParallel(vehicleId: string, urls: string[], config: Config): Promise<string[]> {
+    const downloadPromises = urls.map(
+      async (url: string, j: number) => await this.download(
+        url,
+        `${config.pathesConfig.localConvertedDirectory}/${vehicleId}_${(j + 1).toLocaleString('en-US', { minimumIntegerDigits: 2 })}.jpg`
+      )
+    );
+    return Promise.all(downloadPromises);
   }
 
   private async download(url: string, imagePath: string) {
@@ -192,7 +189,7 @@ export class ImagesService {
         const response = await axios.get(url, { responseType: 'stream' });
         response.data.pipe(
           createWriteStream(imagePath)
-            .on('finish', () => { console.log(`Downloaded: ${url}`); resolve(imagePath); })
+            .on('close', () => { console.log(`Downloaded: ${url}`, imagePath); resolve(imagePath); })
             .on('error', (err) => { console.error(`Failed to download: ${url}`); resolve(null); })
         );
       } catch (error) {