@bytebrand/export-cars 1.10.6 → 1.10.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bytebrand/export-cars",
-  "version": "1.10.6",
+  "version": "1.10.8",
   "description": "",
   "author": "bytebrand",
   "license": "UNLICENSED",
@@ -60,5 +60,5 @@
   "engines": {
     "node": ">=14.0.0"
   },
-  "gitHead": "612c022b995693ce437c548e3cc190de98545c91"
+  "gitHead": "26ce620428ff47711dc8142af5da04b9ddf380f0"
 }

package/src/services/images.service.ts

@@ -14,6 +14,12 @@ import { ImageType } from '../enums';
 
 @Injectable()
 export class ImagesService {
+  private readonly DEFAULT_IMAGES = [
+    'https://images.auto.de/carimage/noimage/7pNvWELuWhZX/large-cached.jpeg',
+    'https://images.auto.de/carimage/noimage/GvyXmrpaf1D6/large-cached.jpeg',
+    'https://images.auto.de/carimage/noimage/pFyfBsqBHEso/large-cached.jpeg',
+  ];
+
   constructor(private readonly configService: ConfigService, private readonly userService: UserService) { }
 
   async getImages(
@@ -24,63 +30,22 @@ export class ImagesService {
     if (imageType === ImageType.default) {
       return this.getDefaultImages(car, images);
     } else {
-      const carId = toString(get(car, '_id', ''));
-      return await this.getMarketingImages(images, carId);
+      return await this.getMarketingImages(car, images);
     }
   }
 
   getDefaultImages(car: DataSchemes.Car, images: ImboImageResponseInterface[]): Array<string> {
-    const defaultImages = [
-      'https://images.auto.de/carimage/noimage/7pNvWELuWhZX/large-cached.jpeg',
-      'https://images.auto.de/carimage/noimage/GvyXmrpaf1D6/large-cached.jpeg',
-      'https://images.auto.de/carimage/noimage/gY1zF8PXzH2W/large-cached.jpeg',
-      'https://images.auto.de/carimage/noimage/pFyfBsqBHEso/large-cached.jpeg',
-    ];
-
     if (!isNotEmptyArray(images)) {
-      return defaultImages;
-    }
-
-    const firstImageId = get(car, 'metaData.mainImageId', null);
-    const secondImageId = get(car, 'metaData.secImageId', null);
-    const thirdImageId = get(car, 'metaData.thirdImageId', null);
-
-    if (firstImageId) {
-      images.forEach((image, index) => {
-        if (firstImageId === image.imageIdentifier) {
-          const tmp = images[index];
-          images[index] = images[0];
-          images[0] = tmp;
-        }
-      });
-    }
-
-    if (secondImageId) {
-      images.forEach((image, index) => {
-        if (secondImageId === image.imageIdentifier) {
-          const tmp = images[index];
-          images[index] = images[1];
-          images[1] = tmp;
-        }
-      });
-    }
-
-    if (thirdImageId) {
-      images.forEach((image, index) => {
-        if (thirdImageId === image.imageIdentifier) {
-          const tmp = images[index];
-          images[index] = images[2];
-          images[2] = tmp;
-        }
-      });
+      return this.DEFAULT_IMAGES;
     }
 
-    const carId = toString(get(car, '_id', ''));
+    this.sortImages(images, car);
+    const transformedImages = this.generateImageLinks(images, get(car, '_id'));
 
-    const transformedImages = this.generateImageLinks(images.filter(i => i), carId);
     if (transformedImages.length < 17) {
-      transformedImages.push(...defaultImages);
+      transformedImages.push(...this.DEFAULT_IMAGES);
     }
+
     return transformedImages;
   }
 
@@ -90,40 +55,34 @@ export class ImagesService {
     });
   }
 
-  async getMarketingImages(images: any, carId: string): Promise<string[]> {
+  async getMarketingImages(car: DataSchemes.Car, images: ImboImageResponseInterface[]): Promise<string[]> {
     const imageUrl = this.configService.config.marketingImageUrl;
-    const transformedImages = this.transformImagesArrayIntoObject(images);
 
+    const transformedImages = this.transformImagesArrayIntoObject(images);
     const config = await this.userService.getMarketingImageConfig(this.configService.config.marketingImageConfigId);
     const marketingImageConfigs = config.marketingImages.map(i => ({ marketingImageCodes: i.imageCodes }));
 
-    const defImages = [
-      'https://images.auto.de/carimage/noimage/7pNvWELuWhZX/large-cached.jpeg',
-      'https://images.auto.de/carimage/noimage/GvyXmrpaf1D6/large-cached.jpeg',
-      'https://images.auto.de/carimage/noimage/gY1zF8PXzH2W/large-cached.jpeg',
-      'https://images.auto.de/carimage/noimage/pFyfBsqBHEso/large-cached.jpeg',
-    ];
-
     const imageUrls = [];
-
     for (let i = 0; i < marketingImageConfigs.length; i++) {
       const marketingImage = marketingImageConfigs[i];
       for (let i = 0; i < marketingImage.marketingImageCodes.length; i++) {
         const imageCode = marketingImage.marketingImageCodes[i];
         const imageId = transformedImages[imageCode];
         if (imageId) {
-          imageUrls.push(this.getImagePathWithExtenstion(imageUrl, carId, imageId, config));
+          imageUrls.push(this.getImagePathWithExtension(imageUrl, get(car, '_id', ''), imageId, config));
           break;
         }
       }
     }
+
     if (imageUrls.length < FB_MAX_IMAGE_COUNT_FOR_DEAFULT) {
-      imageUrls.push(...defImages);
+      imageUrls.push(...this.DEFAULT_IMAGES);
     }
+
     return imageUrls;
   }
 
-  private transformImagesArrayIntoObject(images: { [imageCode: string]: string }[]) {
+  private transformImagesArrayIntoObject(images: ImboImageResponseInterface[]) {
     const result: { [imageCode: string]: string } = {};
     images.forEach(image => {
       const imageCode = image.imageCodePredicted.split('-')[0];
@@ -136,7 +95,7 @@ export class ImagesService {
     return `${imageUrl}/${[carId[0], carId[1], carId[2], carId].join('/')}`;
   }
 
-  protected getImagePathWithExtenstion(
+  protected getImagePathWithExtension(
     imageUrl: string,
     carId: string,
     imageId: string,
@@ -145,4 +104,31 @@ export class ImagesService {
     const { channelCode, imageExtension } = config;
     return `${this.getChannelPath(imageUrl, carId)}/${channelCode.replace(/ /g, '-')}-${imageId}.${imageExtension}`;
   }
+
+  private sortImages(images: ImboImageResponseInterface[], car: DataSchemes.Car): void {
+    const firstImageId = get(car, 'metaData.mainImageId', null);
+    const secondImageId = get(car, 'metaData.secImageId', null);
+    const thirdImageId = get(car, 'metaData.thirdImageId', null);
+
+    if (firstImageId) {
+      images.forEach((image, index) => {
+        if (firstImageId === image?.imageIdentifier) {
+          const tmp = images[index];
+          images[index] = images[0];
+          images[0] = tmp;
+        }
+        if (secondImageId === image?.imageIdentifier) {
+          const tmp = images[index];
+          images[index] = images[1];
+          images[1] = tmp;
+        }
+        if (thirdImageId === image?.imageIdentifier) {
+          const tmp = images[index];
+          images[index] = images[2];
+          images[2] = tmp;
+        }
+      });
+      images.filter(i => i); // sometimes thirdImageId exists but image is not
+    }
+  }
 }

package/src/transformers/facebook-shop.transformer.ts

@@ -56,11 +56,9 @@ export class FacebookShopTransformer {
   }
 
   private getTitle(car: DataSchemes.Car): string {
-    const year = toString(get(car, 'mainData.constructionYear', ''));
     const make = toString(get(car, 'mainData.make', ''));
     const model = toString(get(car, 'mainData.model', ''));
-    const subModel = toString(get(car, 'mainData.subModel', ''));
-    return trim(escape(join([year, make, model, subModel], ' ')));
+    return trim(escape(join([make, model], ' ')));
   }
 
   private getCondition(car: DataSchemes.Car): string {

package/src/transformers/mobile.transformer.ts

@@ -1,11 +1,10 @@
 import { Injectable } from '@nestjs/common';
 import { DataSchemes } from '@bytebrand/car-schema';
 import { get, isEmpty, isNil, set, toString, upperFirst } from 'lodash';
-import { MappingService } from '../services/mapping.service';
+import { MappingService, UserService, ImagesService } from '../services';
 import { MappingRules } from '../interfaces/mapping-rules.interface';
-import { UserService } from '../services/user.service';
 import { CarDescriptionFactory, DescriptionTypeEnum } from '@bytebrand/car-description';
-import { ConfigService } from '../services/config.service';
+import { ConfigService } from '../services';
 import { isNotEmptyArray } from '../utils/validator.utils';
 import { LoggerService } from '@bytebrand/cronicle-helper';
 
@@ -19,6 +18,7 @@ export class MobileTransformer {
     private mappingService: MappingService,
     private userService: UserService,
     private configService: ConfigService,
+    private imagesService: ImagesService,
   ) {}
 
   async transform(carData: DataSchemes.Car, images: unknown[]): Promise<unknown> {
@@ -347,17 +347,11 @@ export class MobileTransformer {
     return `https://www.${this.configService.config.domain}${car._id}?source=classifieds&medium=listing&campaign=${this.configService.config.campaign}`;
   }
 
-  private getImages(car: DataSchemes.Car, images: unknown[]): string | null {
-    let res;
-    try {
-      res = this.getImagesField(car._id, get(car, 'metaData.mainImageId', null), images);
-    } catch (e) {
-      LoggerService.error(e);
-      throw e;
-    }
+  private async getImages(car: DataSchemes.Car, images): Promise<string | null> {
+    const transformedImages = await this.imagesService.getImages(car, images, this.configService.config.imageType);
     let imagesAsALine;
-    if (isNotEmptyArray(res)) {
-      imagesAsALine = res.map((el: { url: string }) => el.url).join(';');
+    if (isNotEmptyArray(transformedImages)) {
+      imagesAsALine = transformedImages.map((el: string) => el).join(';');
     }
     return imagesAsALine || null;
   }
@@ -474,32 +468,4 @@ export class MobileTransformer {
     }
     return mileage.toString();
   }
-
-  private getImagesField(carId: string, mainImageId: string, images: unknown[]): { url: string }[] {
-    const defImages = [
-      { url: 'https://images.auto.de/carimage/noimage/7pNvWELuWhZX/large-cached.jpeg' },
-      { url: 'https://images.auto.de/carimage/noimage/GvyXmrpaf1D6/large-cached.jpeg' },
-      { url: 'https://images.auto.de/carimage/noimage/gY1zF8PXzH2W/large-cached.jpeg' },
-      { url: 'https://images.auto.de/carimage/noimage/pFyfBsqBHEso/large-cached.jpeg' },
-    ];
-    if (isNotEmptyArray(images)) {
-      return images.sort(this.setMainImageFirst(mainImageId)).map((image: any) => {
-        return { url: this.buildLargeImageUrl(carId, image.imageIdentifier) };
-      });
-    }
-    return defImages;
-  }
-
-  private buildLargeImageUrl(carId: string, imageId: string): string {
-    const format = this.configService.config.campaign === 'eauto' ? 'jpeg' : 'webp';
-    return `${this.configService.config.imageUrl}/${carId}/${imageId}/large-cached.${format}`;
-  }
-
-  private setMainImageFirst(mainImageId: string): (current: any, next: any) => number {
-    return (current: any, next: any): number => {
-      if (current.imageIdentifier === mainImageId) return -1;
-      if (next.imageIdentifier === mainImageId) return 1;
-      return 0;
-    };
-  }
 }