@bytebase/dbhub 0.23.0 → 1.0.0

package/dist/{mysql-MZWCPISB.js → mysql-CDUKJMNN.js}

@@ -1,13 +1,18 @@
 import {
+  MissingDatabaseError,
   extractAffectedRows,
-  parseQueryResults
-} from "./chunk-RTB262PR.js";
+  isTiDBVersion,
+  parseQueryResults,
+  requireDatabaseInDSN,
+  withReadOnlyTransaction
+} from "./chunk-DUCNPMNW.js";
 import {
   quoteIdentifier
 } from "./chunk-JFWX35TB.js";
 import {
-  SQLRowLimiter
-} from "./chunk-BXXHWEQS.js";
+  SQLRowLimiter,
+  closeQuietly
+} from "./chunk-S2V6RZ3C.js";
 import {
   ConnectorRegistry,
   SafeURL,
@@ -34,11 +39,12 @@ Expected: ${expectedFormat}`
     }
     try {
       const url = new SafeURL(dsn);
+      const database = url.pathname ? url.pathname.substring(1) : "";
+      requireDatabaseInDSN(database, dsn, "MySQL");
       const config2 = {
         host: url.hostname,
         port: url.port ? parseInt(url.port) : 3306,
-        database: url.pathname ? url.pathname.substring(1) : "",
-        // Remove leading '/' if exists
+        database,
         user: url.username,
         password: url.password,
         multipleStatements: true,
@@ -79,6 +85,9 @@ Expected: ${expectedFormat}`
       }
       return config2;
     } catch (error) {
+      if (error instanceof MissingDatabaseError) {
+        throw error;
+      }
       throw new Error(
         `Failed to parse MySQL DSN: ${error instanceof Error ? error.message : String(error)}`
       );
@@ -103,6 +112,9 @@ var MySQLConnector = class _MySQLConnector {
     this.pool = null;
     // Source ID is set by ConnectorManager after cloning
     this.sourceId = "default";
+    // TiDB speaks the MySQL protocol but rejects `START TRANSACTION READ ONLY`
+    // unless tidb_enable_noop_functions is on. Detected once at connect time.
+    this.supportsReadOnlyTransaction = true;
   }
   getId() {
     return this.sourceId;
@@ -117,8 +129,14 @@ var MySQLConnector = class _MySQLConnector {
       if (config?.queryTimeoutSeconds !== void 0) {
         this.queryTimeoutMs = config.queryTimeoutSeconds * 1e3;
       }
-      const [rows] = await this.pool.query("SELECT 1");
+      const [rows] = await this.pool.query("SELECT VERSION() AS version");
+      this.supportsReadOnlyTransaction = !isTiDBVersion(rows[0]?.version);
     } catch (err) {
+      if (this.pool) {
+        const pool = this.pool;
+        this.pool = null;
+        await closeQuietly(() => pool.end());
+      }
       console.error("Failed to connect to MySQL database:", err);
       throw err;
     }
@@ -478,49 +496,34 @@ var MySQLConnector = class _MySQLConnector {
     }
     const conn = await this.pool.getConnection();
     try {
-      if (options.readonly) {
-        await conn.query("START TRANSACTION READ ONLY");
-      }
-      let processedSQL = sql;
-      if (options.maxRows) {
-        const statements = splitSQLStatements(sql, "mysql");
-        const processedStatements = statements.map(
-          (statement) => SQLRowLimiter.applyMaxRows(statement, options.maxRows)
-        );
-        processedSQL = processedStatements.join("; ");
-        if (sql.trim().endsWith(";")) {
-          processedSQL += ";";
-        }
-      }
-      let results;
-      if (parameters && parameters.length > 0) {
-        try {
-          results = await conn.query({ sql: processedSQL, timeout: this.queryTimeoutMs }, parameters);
-        } catch (error) {
-          console.error(`[MySQL executeSQL] ERROR: ${error.message}`);
-          console.error(`[MySQL executeSQL] SQL: ${processedSQL}`);
-          console.error(`[MySQL executeSQL] Parameters: ${JSON.stringify(parameters)}`);
-          throw error;
-        }
-      } else {
-        results = await conn.query({ sql: processedSQL, timeout: this.queryTimeoutMs });
-      }
-      const [firstResult] = results;
-      const rows = parseQueryResults(firstResult);
-      const rowCount = extractAffectedRows(firstResult);
-      if (options.readonly) {
-        await conn.query("COMMIT");
-      }
-      return { rows, rowCount };
-    } catch (error) {
-      if (options.readonly) {
-        try {
-          await conn.query("ROLLBACK");
-        } catch {
+      return await withReadOnlyTransaction(
+        conn,
+        options.readonly,
+        this.supportsReadOnlyTransaction,
+        async () => {
+          let processedSQL = sql;
+          if (options.maxRows) {
+            const statements = splitSQLStatements(sql, "mysql");
+            const processedStatements = statements.map(
+              (statement) => SQLRowLimiter.applyMaxRows(statement, options.maxRows)
+            );
+            processedSQL = processedStatements.join("; ");
+            if (sql.trim().endsWith(";")) {
+              processedSQL += ";";
+            }
+          }
+          let results;
+          if (parameters && parameters.length > 0) {
+            results = await conn.query({ sql: processedSQL, timeout: this.queryTimeoutMs }, parameters);
+          } else {
+            results = await conn.query({ sql: processedSQL, timeout: this.queryTimeoutMs });
+          }
+          const [firstResult] = results;
+          const rows = parseQueryResults(firstResult);
+          const rowCount = extractAffectedRows(firstResult);
+          return { rows, rowCount };
         }
-      }
-      console.error("Error executing query:", error);
-      throw error;
+      );
     } finally {
       conn.release();
     }

package/dist/{postgres-BKBCGDZS.js → postgres-YAYHDXVD.js}

@@ -2,8 +2,9 @@ import {
   quoteIdentifier
 } from "./chunk-JFWX35TB.js";
 import {
-  SQLRowLimiter
-} from "./chunk-BXXHWEQS.js";
+  SQLRowLimiter,
+  closeQuietly
+} from "./chunk-S2V6RZ3C.js";
 import {
   ConnectorRegistry,
   SafeURL,
@@ -148,6 +149,11 @@ var PostgresConnector = class _PostgresConnector {
       const client = await this.pool.connect();
       client.release();
     } catch (err) {
+      if (this.pool) {
+        const pool = this.pool;
+        this.pool = null;
+        await closeQuietly(() => pool.end());
+      }
       console.error("Failed to connect to PostgreSQL database:", err);
       throw err;
     }
@@ -502,24 +508,12 @@ var PostgresConnector = class _PostgresConnector {
               await client.query("ROLLBACK");
             } catch {
             }
-            console.error(`[PostgreSQL executeSQL] ERROR: ${error.message}`);
-            console.error(`[PostgreSQL executeSQL] SQL: ${processedStatement}`);
-            if (parameters && parameters.length > 0) {
-              console.error(`[PostgreSQL executeSQL] Parameters: ${JSON.stringify(parameters)}`);
-            }
             throw error;
           }
         }
         let result;
         if (parameters && parameters.length > 0) {
-          try {
-            result = await client.query(processedStatement, parameters);
-          } catch (error) {
-            console.error(`[PostgreSQL executeSQL] ERROR: ${error.message}`);
-            console.error(`[PostgreSQL executeSQL] SQL: ${processedStatement}`);
-            console.error(`[PostgreSQL executeSQL] Parameters: ${JSON.stringify(parameters)}`);
-            throw error;
-          }
+          result = await client.query(processedStatement, parameters);
         } else {
           result = await client.query(processedStatement);
         }

package/dist/{registry-ZME64VB2.js → registry-ZU6ZFNQ2.js}

@@ -2,7 +2,7 @@ import {
   ToolRegistry,
   getToolRegistry,
   initializeToolRegistry
-} from "./chunk-COEDRFSK.js";
+} from "./chunk-MQR6VX5F.js";
 import "./chunk-WVVMH6FJ.js";
 import "./chunk-JEZZN2YZ.js";
 export {

package/dist/{sqlite-CQ4LCBB6.js → sqlite-5M7SDAQZ.js}

@@ -2,8 +2,9 @@ import {
   quoteIdentifier
 } from "./chunk-JFWX35TB.js";
 import {
-  SQLRowLimiter
-} from "./chunk-BXXHWEQS.js";
+  SQLRowLimiter,
+  closeQuietly
+} from "./chunk-S2V6RZ3C.js";
 import {
   ConnectorRegistry,
   SafeURL,
@@ -150,6 +151,11 @@ var SQLiteConnector = class _SQLiteConnector {
         this.db.exec(initScript);
       }
     } catch (error) {
+      if (this.db) {
+        const db = this.db;
+        this.db = null;
+        await closeQuietly(() => db.close());
+      }
       console.error("Failed to connect to SQLite database:", error);
       throw error;
     }
@@ -333,15 +339,8 @@ var SQLiteConnector = class _SQLiteConnector {
         }
         if (isReadStatement) {
           if (parameters && parameters.length > 0) {
-            try {
-              const rows = this.prepare(processedStatement).all(...parameters);
-              return { rows, rowCount: rows.length };
-            } catch (error) {
-              console.error(`[SQLite executeSQL] ERROR: ${error.message}`);
-              console.error(`[SQLite executeSQL] SQL: ${processedStatement}`);
-              console.error(`[SQLite executeSQL] Parameters: ${JSON.stringify(parameters)}`);
-              throw error;
-            }
+            const rows = this.prepare(processedStatement).all(...parameters);
+            return { rows, rowCount: rows.length };
           } else {
             const rows = this.prepare(processedStatement).all();
             return { rows, rowCount: rows.length };
@@ -349,14 +348,7 @@ var SQLiteConnector = class _SQLiteConnector {
         } else {
           let result;
           if (parameters && parameters.length > 0) {
-            try {
-              result = this.prepare(processedStatement).run(...parameters);
-            } catch (error) {
-              console.error(`[SQLite executeSQL] ERROR: ${error.message}`);
-              console.error(`[SQLite executeSQL] SQL: ${processedStatement}`);
-              console.error(`[SQLite executeSQL] Parameters: ${JSON.stringify(parameters)}`);
-              throw error;
-            }
+            result = this.prepare(processedStatement).run(...parameters);
           } else {
             result = this.prepare(processedStatement).run();
           }