@bymax-one/nest-logger 1.3.0 → 1.4.0

package/dist/server/index.mjs

@@ -765,12 +765,26 @@ var HTTP_SERVER_ERROR_MIN = 500;
 var UNKNOWN_USER_AGENT = "unknown";
 var RECORDER_ACTIVE = /* @__PURE__ */ Symbol("bymax-one/nest-logger:recorder");
 var RECORDED_ERROR = /* @__PURE__ */ Symbol("bymax-one/nest-logger:error");
+var OWN_REQUEST_ID = /* @__PURE__ */ Symbol("bymax-one/nest-logger:request-id");
+var CORRELATION_OPENED = /* @__PURE__ */ Symbol("bymax-one/nest-logger:correlation");
 function markRecorderActive(req) {
   Reflect.set(req, RECORDER_ACTIVE, true);
 }
 function isRecorderActive(req) {
   return Reflect.get(req, RECORDER_ACTIVE) === true;
 }
+function markCorrelationOpened(req) {
+  Reflect.set(req, CORRELATION_OPENED, true);
+}
+function isCorrelationOpened(req) {
+  return Reflect.get(req, CORRELATION_OPENED) === true;
+}
+function markOwnRequestId(req, requestId) {
+  Reflect.set(req, OWN_REQUEST_ID, requestId);
+}
+function readOwnRequestId(req) {
+  return Reflect.get(req, OWN_REQUEST_ID);
+}
 function recordError(req, error) {
   Reflect.set(req, RECORDED_ERROR, { error });
 }
@@ -788,6 +802,16 @@ function readUserAgent(req) {
   return typeof raw === "string" ? raw : UNKNOWN_USER_AGENT;
 }
 
+// src/server/utils/matches-exclude-path.util.ts
+function matchesExcludePath(patterns, path2) {
+  return patterns.some((pattern) => {
+    if (pattern.global || pattern.sticky) {
+      pattern.lastIndex = 0;
+    }
+    return pattern.test(path2);
+  });
+}
+
 // src/server/interceptors/http-logging.interceptor.ts
 var HTTP_SUCCESS_MIN = 200;
 var HttpLoggingInterceptor = class {
@@ -809,7 +833,7 @@ var HttpLoggingInterceptor = class {
    * @returns `true` when the path matches a configured exclude pattern.
    */
   isExcluded(path2) {
-    return this.excludePaths.some((pattern) => pattern.test(path2));
+    return matchesExcludePath(this.excludePaths, path2);
   }
   /**
    * Emit the START entry, then attach success/redirect/error logging to the
@@ -1134,7 +1158,6 @@ function safeMinLevel(destination) {
     const read = destination.minLevel;
     resolved = isLogLevel(read) ? read : void 0;
   } catch {
-    resolved = void 0;
   }
   resolvedMinLevels.set(destination, resolved);
   return resolved;
@@ -2092,8 +2115,21 @@ var LogContextService = class {
    * Run `callback` inside a fresh context scope. Every log emitted
    * synchronously or asynchronously within the callback inherits `context`.
    *
+   * **A nested `run()` REPLACES the enclosing context, it does not extend it.**
+   * The scope starts from `context` alone, so a field an outer scope had set —
+   * a `tenantId` resolved at the edge, say — is absent for the whole inner
+   * scope: nothing throws, `get()` simply returns `undefined`, and the field is
+   * missing from every entry the callback emits. Reach for {@link runMerged}
+   * when the inner scope should extend the outer one.
+   *
+   * Replacement is the deliberate default because the opposite leaks: a
+   * background job started inside a request scope would silently inherit the
+   * caller's `userId` and attribute its entries to a user who never triggered
+   * it. A missing field is visibly missing; an inherited one is wrong while
+   * looking right.
+   *
    * @typeParam T - Return type of the callback.
-   * @param context - Initial context bag for the scope.
+   * @param context - Initial context bag for the scope. Becomes the WHOLE scope.
    * @param callback - Function executed within the scope.
    * @returns Whatever `callback` returns.
    * @example
@@ -2104,6 +2140,35 @@ var LogContextService = class {
   run(context, callback) {
     return this.als.run(this.sanitizeContext(context), callback);
   }
+  /**
+   * Run `callback` inside a scope that EXTENDS the enclosing one: the active
+   * context's fields are carried in, and `context` overrides them key by key.
+   *
+   * The explicit counterpart to {@link run}'s replacement semantics, for the
+   * case where an inner scope is genuinely a refinement of the outer — adding a
+   * `userId` once authentication resolved it, without having to restate the
+   * `requestId` the middleware already set.
+   *
+   * Outside any scope there is nothing to merge and this behaves exactly like
+   * {@link run}. Writes inside the new scope never reach the enclosing one: the
+   * merge produces a fresh object, so the outer context is intact after the
+   * callback returns.
+   *
+   * @typeParam T - Return type of the callback.
+   * @param context - Fields to add or override on top of the active context.
+   * @param callback - Function executed within the merged scope.
+   * @returns Whatever `callback` returns.
+   * @example
+   *   logContext.run({ requestId: 'r_1' }, () => {
+   *     logContext.runMerged({ userId: 'u_1' }, () => {
+   *       logContext.get('requestId') // 'r_1' — carried in from the outer scope
+   *     })
+   *   })
+   */
+  runMerged(context, callback) {
+    const merged = { ...this.als.getStore(), ...this.sanitizeContext(context) };
+    return this.als.run(merged, callback);
+  }
   /**
    * Read the active context, or `undefined` when called outside any scope.
    *
@@ -2556,13 +2621,17 @@ var HttpAccessLogMiddleware = class {
    * @param next - The next handler in the chain.
    */
   use(req, res, next) {
+    if (isRecorderActive(req)) {
+      next();
+      return;
+    }
     if (!this.isEnabled) {
       next();
       return;
     }
     const target = req.originalUrl ?? req.url;
     const path2 = stripQueryString(target);
-    if (this.excludePaths.some((pattern) => pattern.test(path2))) {
+    if (matchesExcludePath(this.excludePaths, path2)) {
       next();
       return;
     }
@@ -2658,6 +2727,7 @@ HttpAccessLogMiddleware = __decorateClass([
 var REQUEST_ID_HEADER = "x-request-id";
 var MAX_CORRELATION_ID_LENGTH = 256;
 var CORRELATION_ID_CHARSET = /^[A-Za-z0-9._:/+=-]+$/;
+var INHERITABLE_CONTEXT_KEYS = ["requestId", "tenantId"];
 function isAcceptableHeaderValue(value) {
   return typeof value === "string" && value.length <= MAX_CORRELATION_ID_LENGTH && CORRELATION_ID_CHARSET.test(value);
 }
@@ -2676,27 +2746,128 @@ var RequestIdMiddleware = class {
   }
   /**
    * Echo or mint the `x-request-id`, expose it on the response, and run the
-   * remainder of the request inside a fresh log-context scope.
+   * remainder of the request inside its own log-context scope.
+   *
+   * Idempotent: mounting this middleware twice on the same request mints one id,
+   * not two. The request gets its OWN store, started from the enclosing scope's
+   * correlation fields — see {@link INHERITABLE_CONTEXT_KEYS} — and nothing
+   * else, because no other field can be known to belong to this request.
+   *
+   * An enclosing scope's `requestId` is never adopted and never echoed: adoption
+   * reads a value this middleware recorded on the REQUEST, which a scope opened
+   * elsewhere does not have. What the two generation modes do with one, measured
+   * on two requests sharing a long-lived enclosing scope:
+   *
+   *   - `shouldGenerateRequestId: true` (default) — each request mints its own
+   *     id, the two requests differ, and the enclosing value reaches neither the
+   *     header nor the entries.
+   *   - `shouldGenerateRequestId: false` with no inbound header — nothing is
+   *     minted, so the request scope inherits the enclosing `requestId` and every
+   *     request inside that scope logs under it. No header is exposed. That is
+   *     the consumer's own scope being inherited, not correlation being reused,
+   *     and it is the configuration that says the gateway owns the id.
    *
    * @param req - The incoming request (Express satisfies the contract).
    * @param res - The outgoing response (Express satisfies the contract).
    * @param next - The next handler in the chain.
    */
   use(req, res, next) {
-    const incoming = Reflect.get(req.headers, REQUEST_ID_HEADER);
-    const fromHeader = isAcceptableHeaderValue(incoming) ? incoming : void 0;
-    const requestId = fromHeader ?? (this.shouldGenerateRequestId ? randomUUID() : void 0);
-    const context = {};
+    if (isCorrelationOpened(req)) {
+      const ownRequestId = readOwnRequestId(req);
+      if (ownRequestId !== void 0) {
+        this.adoptExistingScope(ownRequestId, req, res);
+      }
+      next();
+      return;
+    }
+    markCorrelationOpened(req);
+    const context = this.inheritableContext();
+    const requestId = this.resolveRequestId(req);
     if (requestId !== void 0) {
       res.setHeader(REQUEST_ID_HEADER, requestId);
       context.requestId = requestId;
+      markOwnRequestId(req, requestId);
     }
-    const rawTenantId = Reflect.get(req.headers, this.tenantIdHeader);
-    if (isAcceptableHeaderValue(rawTenantId)) {
-      context.tenantId = rawTenantId;
+    if (context.tenantId === void 0) {
+      const tenantId = this.resolveTenantId(req);
+      if (tenantId !== void 0) {
+        context.tenantId = tenantId;
+      }
     }
     this.logContext.run(context, () => next());
   }
+  /**
+   * The enclosing scope's fields that a request scope may start from.
+   *
+   * Plain `run()` would discard everything the caller had set and a plain merge
+   * would carry identity across requests; {@link INHERITABLE_CONTEXT_KEYS} is
+   * the middle a request scope actually needs.
+   *
+   * @returns A fresh bag, never the enclosing store itself, so writes inside the
+   *   request never reach the scope that opened it.
+   */
+  inheritableContext() {
+    const store = { ...this.logContext.getStore() };
+    const inherited = {};
+    for (const key of INHERITABLE_CONTEXT_KEYS) {
+      const value = Reflect.get(store, key);
+      if (value !== void 0) {
+        Reflect.set(inherited, key, value);
+      }
+    }
+    return inherited;
+  }
+  /**
+   * Second mount on a request that already carries a correlation id: echo the id
+   * onto the response and fill in a tenant the scope does not have yet, without
+   * opening another scope.
+   *
+   * Nothing is minted and nothing already set is overwritten, so a third mount —
+   * or a thirtieth — changes nothing. The response header is written on every
+   * pass because the enclosing scope may have been opened by consumer code that
+   * never exposed it.
+   *
+   * @param requestId - The id already in scope, which wins.
+   * @param req - The incoming request, read for the tenant header.
+   * @param res - The outgoing response, where the effective id is exposed.
+   */
+  adoptExistingScope(requestId, req, res) {
+    res.setHeader(REQUEST_ID_HEADER, requestId);
+    this.logContext.set("requestId", requestId);
+    if (this.logContext.get("tenantId") === void 0) {
+      const tenantId = this.resolveTenantId(req);
+      if (tenantId !== void 0) {
+        this.logContext.set("tenantId", tenantId);
+      }
+    }
+  }
+  /**
+   * The correlation id for this request: the inbound header when acceptable,
+   * otherwise a fresh UUID — or nothing at all when `shouldGenerateRequestId` is
+   * off and the caller sent none, which leaves correlation to the upstream
+   * gateway.
+   *
+   * @param req - The incoming request.
+   * @returns The id, or `undefined` when none is available and none is minted.
+   */
+  resolveRequestId(req) {
+    const incoming = Reflect.get(req.headers, REQUEST_ID_HEADER);
+    const fromHeader = isAcceptableHeaderValue(incoming) ? incoming : void 0;
+    return fromHeader ?? (this.shouldGenerateRequestId ? randomUUID() : void 0);
+  }
+  /**
+   * The tenant id carried by the configured header, when it is acceptable.
+   *
+   * Never minted: a tenant is an assertion about who the request belongs to, and
+   * inventing one would be a fabricated claim rather than a correlation aid.
+   *
+   * @param req - The incoming request.
+   * @returns The tenant id, or `undefined`.
+   */
+  resolveTenantId(req) {
+    const raw = Reflect.get(req.headers, this.tenantIdHeader);
+    return isAcceptableHeaderValue(raw) ? raw : void 0;
+  }
 };
 RequestIdMiddleware = __decorateClass([
   Injectable(),
@@ -2704,6 +2875,32 @@ RequestIdMiddleware = __decorateClass([
   __decorateParam(1, Inject(LOGGER_OPTIONS_TOKEN))
 ], RequestIdMiddleware);
 
+// src/server/middlewares/apply-access-log.ts
+function resolveDependencies(app) {
+  try {
+    return {
+      logger: app.get(PinoLoggerService),
+      logContext: app.get(LogContextService),
+      options: app.get(LOGGER_OPTIONS_TOKEN)
+    };
+  } catch (cause) {
+    throw new Error(
+      "[BymaxLoggerModule] applyAccessLog(app) called but BymaxLoggerModule was not imported",
+      { cause }
+    );
+  }
+}
+function applyAccessLog(app) {
+  const { logger, logContext, options } = resolveDependencies(app);
+  const requestId = new RequestIdMiddleware(logContext, options);
+  const accessLog = new HttpAccessLogMiddleware(logger, logContext, options);
+  app.use((req, res, next) => {
+    requestId.use(req, res, () => {
+      accessLog.use(req, res, next);
+    });
+  });
+}
+
 // src/server/middlewares/apply-request-id-middleware.ts
 var ALL_ROUTES = "/";
 function applyRequestIdMiddleware(consumer, routes = ALL_ROUTES) {
@@ -2770,4 +2967,4 @@ function LogPerformance(thresholdMs = DEFAULT_THRESHOLD_MS) {
 // src/shared/constants/log-keys-convention.constants.ts
 var LOG_KEYS_CONVENTION_REGEX = /^[A-Z][A-Z0-9_]+_[A-Z][A-Z0-9_]+(_[A-Z][A-Z0-9_]+)?$/;
 
-export { BymaxLoggerModule, DEFAULT_REDACT_PATHS, DefaultStdoutDestination, HttpExceptionFilter, HttpLoggingInterceptor, InjectLogger, LOGGER_DESTINATIONS_TOKEN, LOGGER_OPTIONS_TOKEN, LOGGER_PINO_INSTANCE_TOKEN, LOG_CONTEXT_METADATA_KEY, LOG_CONTEXT_TOKEN, LOG_KEYS_CONVENTION_REGEX, LogContext, LogContextService, LogPerformance, PINO_LEVEL_NAMES, PINO_LEVEL_NUMBERS, PinoLoggerService, PrettyDevDestination, RESERVED_LOG_KEYS, RESERVED_LOG_KEYS_NOT_EMITTED, RequestIdMiddleware, applyRequestIdMiddleware };
+export { BymaxLoggerModule, DEFAULT_REDACT_PATHS, DefaultStdoutDestination, HttpAccessLogMiddleware, HttpExceptionFilter, HttpLoggingInterceptor, InjectLogger, LOGGER_DESTINATIONS_TOKEN, LOGGER_OPTIONS_TOKEN, LOGGER_PINO_INSTANCE_TOKEN, LOG_CONTEXT_METADATA_KEY, LOG_CONTEXT_TOKEN, LOG_KEYS_CONVENTION_REGEX, LogContext, LogContextService, LogPerformance, PINO_LEVEL_NAMES, PINO_LEVEL_NUMBERS, PinoLoggerService, PrettyDevDestination, RESERVED_LOG_KEYS, RESERVED_LOG_KEYS_NOT_EMITTED, RequestIdMiddleware, applyAccessLog, applyRequestIdMiddleware };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bymax-one/nest-logger",
-  "version": "1.3.0",
+  "version": "1.4.0",
   "description": "Structured JSON logging for NestJS based on Pino 10, with optional OpenTelemetry correlation.",
   "author": "Bymax One <support@bymax.one>",
   "license": "MIT",