@bymax-one/nest-core 1.3.2 → 1.5.0

package/dist/index.d.ts

@@ -1,5 +1,5 @@
 import * as _nestjs_common from '@nestjs/common';
-import { DynamicModule, ExceptionFilter, ArgumentsHost, NestInterceptor, ExecutionContext, CallHandler } from '@nestjs/common';
+import { NestModule, MiddlewareConsumer, DynamicModule, ExceptionFilter, ArgumentsHost, NestInterceptor, ExecutionContext, CallHandler, NestMiddleware } from '@nestjs/common';
 import { HttpAdapterHost } from '@nestjs/core';
 import { Observable } from 'rxjs';
 
@@ -106,6 +106,21 @@ type OpenApiOperationKey = `${OpenApiHttpMethod} /${string}`;
  * An empty array marks the operation public, overriding any document default.
  */
 type OperationSecurityMap = Readonly<Record<OpenApiOperationKey, readonly OpenApiSecurityRequirement[]>>;
+/**
+ * Names the operation a route handler produced, in the generated document.
+ *
+ * Matches `@nestjs/swagger`'s own factory signature so a consumer's existing one
+ * can be handed over unchanged. This package installs a factory of its own to
+ * learn which handler produced which operation — a contract a library keys its
+ * contributed fragments against — and delegates the id string to this one when
+ * it is set, so nothing an application already generates is renamed.
+ *
+ * @param controllerKey - The controller class name.
+ * @param methodKey - The handler method name.
+ * @param version - The route's version, when the application versions routes.
+ * @returns The operation id to publish.
+ */
+type OpenApiOperationIdFactory = (controllerKey: string, methodKey: string, version?: string) => string;
 /**
  * OpenAPI document configuration.
  *
@@ -171,6 +186,16 @@ interface OpenApiOptions {
      *   }
      */
     operationSecurity?: OperationSecurityMap;
+    /**
+     * Name the operations in the generated document. Default: the format
+     * `@nestjs/swagger` itself produces, `<ControllerKey>_<methodKey>`.
+     *
+     * Set it to control the ids a client generator will use. This package always
+     * installs a factory of its own so it can learn which handler produced which
+     * operation, and delegates to this one when it is set — so supplying it
+     * changes the published ids, and leaving it unset changes nothing.
+     */
+    operationIdFactory?: OpenApiOperationIdFactory;
     /**
      * Contribute the schemas this package owns — the error envelope, the health
      * response, and the pagination shapes — to the document's components, and
@@ -304,6 +329,7 @@ interface ResolvedOpenApiOptions {
     securitySchemes: Readonly<Record<string, OpenApiSecurityScheme>>;
     security: readonly OpenApiSecurityRequirement[];
     operationSecurity: OperationSecurityMap;
+    operationIdFactory?: OpenApiOperationIdFactory;
     includeCoreSchemas: boolean;
 }
 /**
@@ -338,7 +364,69 @@ declare const ASYNC_OPTIONS_TYPE: _nestjs_common.ConfigurableModuleAsyncOptions<
 /**
  * `BymaxCoreModule`, the application foundation module for NestJS 11.
  */
-declare class BymaxCoreModule extends BymaxCoreModuleBase {
+declare class BymaxCoreModule extends BymaxCoreModuleBase implements NestModule {
+    private readonly resolved;
+    private readonly adapterHost?;
+    /**
+     * @param options - The resolved snapshot, read to decide whether the timing
+     *   middleware is applied at all.
+     */
+    constructor(resolved: ResolvedCoreOptions, adapterHost?: HttpAdapterHost | undefined);
+    /**
+     * Apply the request-timing middleware to every route.
+     *
+     * Middleware rather than the interceptor this replaced, because guards run
+     * before interceptors: a request rejected by an authentication, authorization
+     * or throttling guard never reached the interceptor, and one matching no
+     * route never reached a controller at all. A deployment could therefore be
+     * under a credential-stuffing run — a flood of 401s — with a flat error
+     * graph, which is why this is a security fix rather than a metrics
+     * improvement.
+     *
+     * Applied on both registration paths, and only when timing is enabled: the
+     * middleware is the sole recorder now, since a second one would count every
+     * matched request twice.
+     *
+     * There is no single pattern that covers both adapters, which is the whole
+     * reason this reads the adapter first. Measured, requesting the root, a
+     * parameterised route, a nested path and an unmatched path, with and without
+     * `setGlobalPrefix('api')`:
+     *
+     * | `forRoutes(...)` | Express          | Fastify              |
+     * | ---------------- | ---------------- | -------------------- |
+     * | `'*splat'`       | skips the root   | —                    |
+     * | `'{*splat}'`     | skips `/api`     | every path           |
+     * | `'/'`            | every path       | matches `/` only     |
+     *
+     * On Express `'/'` is a mount and matches everything beneath whatever prefix
+     * it is scoped to, while `'{*splat}'` — the form Nest 11's migration guide
+     * prescribes for "all routes" — stops matching the prefixed root once an
+     * application calls `setGlobalPrefix`. That was reported as nest#14520 and
+     * fixed by nest#14522, whose regression test covers Fastify; on
+     * `@nestjs/core` 11.1.28 with the Express adapter the prefixed root still
+     * reaches no middleware while resolving to `200`.
+     *
+     * On Fastify the same `'/'` is an exact match rather than a mount — one of
+     * three requests reached the middleware — so the wildcard is the only form
+     * that works there.
+     *
+     * A recorder that quietly omits one route is the same class of defect this
+     * middleware exists to fix, so each adapter gets the form that omits none.
+     *
+     * Fastify also needs {@link bridgeFastifyRouteMetadata}, because middie hands
+     * middleware the raw request, which carries no route metadata at all; see
+     * that file for why the label would otherwise be `<unmatched>` for every
+     * request.
+     *
+     * One limit stays and is documented in the README: Nest scopes module
+     * middleware to the global prefix, so with `setGlobalPrefix('api')` a request
+     * to `/nope` — outside the prefix entirely — reaches no middleware and is not
+     * recorded, while `/api/nope` is. No `forRoutes` argument changes that, and
+     * nothing this module can register reaches outside its own scope.
+     *
+     * @param consumer - Nest's middleware consumer.
+     */
+    configure(consumer: MiddlewareConsumer): void;
     /**
      * Register the module synchronously. Options are known now, so disabled
      * features are omitted from the providers and controllers arrays and the
@@ -428,7 +516,7 @@ declare const BYMAX_CORE_OPTIONS: unique symbol;
  */
 declare const BYMAX_CORRELATION_PROVIDER: unique symbol;
 /**
- * Provide the `ITimingSink` that receives one sample per completed request.
+ * Provide the `ITimingSink` that receives one sample per closed request.
  * Defaults to a no-op sink.
  */
 declare const BYMAX_TIMING_SINK: unique symbol;
@@ -745,9 +833,11 @@ interface MonotonicClock {
 }
 
 /**
- * @fileoverview Request-timing contracts. The timing interceptor emits one
- * {@link RequestTimingSample} per completed request to the bound
- * {@link ITimingSink}. The default sink is a no-op; consumers plug in a logger
+ * @fileoverview Request-timing contracts. `BymaxTimingMiddleware` emits one
+ * {@link RequestTimingSample} per **closed** request to the bound
+ * {@link ITimingSink} — every request the server finished with, including the
+ * ones a guard rejected, the ones that matched no route, and the ones a client
+ * abandoned mid-flight. The default sink is a no-op; consumers plug in a logger
  * bridge or the metrics bridge through the `BYMAX_TIMING_SINK` token.
  * @layer Contract
  */
@@ -777,12 +867,16 @@ interface RequestTimingSample {
 }
 /**
  * Receive request-timing samples. Implementations must never throw: a sink
- * failure is caught and silenced by the interceptor so timing never breaks a
+ * failure is caught and silenced by the recorder so timing never breaks a
  * request.
  */
 interface ITimingSink {
     /**
-     * Record one sample for a completed request.
+     * Record one sample for a closed request, however it ended.
+     *
+     * Called once per request the server closed — not only the ones a handler
+     * answered. A rejection issued by a guard, a request matching no route, and a
+     * client that hung up mid-response all arrive here.
      *
      * @param sample - The timing sample to record.
      */
@@ -790,10 +884,15 @@ interface ITimingSink {
 }
 
 /**
- * Request-timing interceptor. Registered as the `APP_INTERCEPTOR` when the
- * timing feature is enabled, on both the sync and async registration paths.
- * Non-HTTP execution contexts (GraphQL, RPC) pass through untouched: this
- * feature is HTTP-first, matching the exception filter's documented scope.
+ * Request-timing interceptor. No longer registered by `BymaxCoreModule`, which
+ * records through {@link BymaxTimingMiddleware} instead so that requests ended
+ * by a guard or by no route matching are counted too. Non-HTTP execution
+ * contexts (GraphQL, RPC) pass through untouched: this feature is HTTP-first,
+ * matching the exception filter's documented scope.
+ *
+ * @deprecated Since 1.4.0, superseded by `BymaxTimingMiddleware`, which the
+ *   module registers automatically. Registering this interceptor as well
+ *   records a second sample for every request that reaches a handler.
  */
 declare class TimingInterceptor implements NestInterceptor {
     private readonly options;
@@ -842,9 +941,9 @@ declare class TimingInterceptor implements NestInterceptor {
      */
     private readErrorStatus;
     /**
-     * Build the sample, compute the slow flag, and deliver it to the sink inside
-     * a try/catch that silences any failure: a throwing sink must never affect
-     * the request it is observing.
+     * Build the sample and deliver it to the sink inside a try/catch that
+     * silences any failure: a throwing sink must never affect the request it is
+     * observing.
      *
      * @param method - HTTP method of the request.
      * @param route - Route template of the request.
@@ -854,6 +953,133 @@ declare class TimingInterceptor implements NestInterceptor {
     private recordSample;
 }
 
+/**
+ * @fileoverview Neutral request-info accessor for request timing. Reads the
+ * HTTP method and the route template off a request without assuming Express or
+ * Fastify, so `RequestTimingSample.route` always carries a bounded-cardinality
+ * label instead of the raw URL.
+ *
+ * The bound is a security property, not a tidiness one. Requests that match no
+ * route are exactly the ones a scanner produces, each at a different path, so a
+ * label taken from the URL would mint one time series per probe — turning the
+ * scrape endpoint into the most expensive route in the service and the metric
+ * into the outage. Every unmatched request therefore shares one label.
+ *
+ * Dropping the raw-URL fallback bought a **second** guarantee that is worth
+ * stating because it was a side effect rather than the intent, and anyone
+ * weighing the fallback again would otherwise only re-weigh the cardinality
+ * argument. The recorder is middleware mounted at `'/'`, and Express gives
+ * mounted middleware a `req.url` relative to its mount point: under
+ * `setGlobalPrefix('api')` a request to `/api` arrives as `/`, so a path read
+ * there reports somewhere the caller never asked for. Nothing in this file
+ * reads `req.url` any more — the only `.url` left is Fastify's
+ * `routeOptions.url`, which is a template, not a path — so that class of bug
+ * has nowhere to land. Reintroducing a path-derived label brings both problems
+ * back, not just the cardinality one. If a raw path is ever genuinely needed,
+ * the correct read is `req.originalUrl ?? req.url`: `originalUrl` is Express's
+ * and carries the mount prefix, and the `??` covers an adapter that supplies
+ * only `url`, where no mount trimmed it in the first place.
+ * @layer Utility
+ */
+
+/**
+ * The route label carried by every request that matched no route.
+ *
+ * A single constant rather than the request's own path, and exported rather
+ * than inlined: it is the value an alert rule matches on to see a scan, so it
+ * belongs to the contract and must not drift from what this package writes.
+ * Reading `route="<unmatched>"` in a dashboard says what happened; an empty
+ * label — which Prometheus treats as equivalent to no label at all — reads as
+ * missing data and gets scrolled past, which for a signal whose purpose is to
+ * be noticed is the same as not emitting it.
+ */
+declare const UNMATCHED_ROUTE = "<unmatched>";
+/** Structural shape of an Express request's route metadata. */
+interface ExpressRouteShape {
+    route?: {
+        path?: string;
+    };
+    baseUrl?: string;
+}
+/** Structural shape of a Fastify request's route metadata. */
+interface FastifyRouteShape {
+    routeOptions?: {
+        url?: string;
+    };
+}
+/** Structural shape shared by both frameworks for the method. */
+interface RawRequestShape {
+    method?: string;
+}
+/** The combined structural shape read off the request object. */
+type RequestShape = ExpressRouteShape & FastifyRouteShape & RawRequestShape;
+
+/** The part of a response this middleware reads and listens on. */
+interface ResponseShape {
+    /** Node's event emitter, used for the single `'close'` subscription. */
+    on(event: 'close', listener: () => void): unknown;
+    /**
+     * Final status code. Optional and explicitly nullable: a connection can close
+     * before anything settled one, and that case has to be expressible rather
+     * than assumed away.
+     */
+    statusCode?: number | undefined;
+}
+/**
+ * Records one timing sample per request, whatever ended it.
+ *
+ * Registered by `BymaxCoreModule` for every route when the timing feature is
+ * enabled. It replaces the interceptor as the recorder rather than joining it:
+ * two recorders would count every matched request twice, which is a worse
+ * defect than the one being fixed because it is silent and plausible.
+ */
+declare class BymaxTimingMiddleware implements NestMiddleware {
+    private readonly options;
+    private readonly clock;
+    /** The bound sink, or an in-code no-op when nothing is bound. */
+    private readonly sink;
+    /** The bound trace reader, or an in-code no-op when nothing is bound. */
+    private readonly traceContext;
+    /**
+     * @param options - The resolved options, read for the slow-request threshold.
+     * @param sink - The bound timing sink; its failures are swallowed, because a
+     *   throwing sink must never affect the request it is observing.
+     * @param clock - Monotonic clock seam, so a test advances time by controlled
+     *   amounts instead of sleeping.
+     * @param traceContext - Reads the active span's identifiers. Optional: the
+     *   middleware stays constructible on its own, and a no-op resolves nothing.
+     */
+    constructor(options: ResolvedCoreOptions, sink: ITimingSink | undefined, clock?: MonotonicClock, traceContext?: ITraceContextProvider);
+    /**
+     * Start the measurement and arrange for the sample to be recorded once the
+     * connection closes, then hand the request straight on.
+     *
+     * The route is read inside the listener rather than here: at middleware time
+     * the router has not matched yet, so `req.route` is still empty. By the time
+     * the connection closes it is populated — including for a request a guard
+     * rejected, since matching happens before guards run.
+     *
+     * The trace lookup is tried in the live context first and in this moment's
+     * captured context second; see this file's header for the measurements that
+     * decided that order.
+     *
+     * @param request - The framework request object.
+     * @param response - The framework response object.
+     * @param next - Continues the chain; called synchronously and unconditionally.
+     */
+    use(request: RequestShape, response: ResponseShape, next: () => void): void;
+    /**
+     * Build the sample and hand it to the sink, guarding both steps.
+     *
+     * @param request - The framework request object.
+     * @param response - The framework response object.
+     * @param start - Monotonic timestamp captured before the chain ran.
+     * @param trace - The span identifiers already resolved by the caller, which
+     *   owns the choice of which context to read them from.
+     */
+    private record;
+}
+
 /**
  * @fileoverview Stable `BYMAX_*` error-code catalog and HTTP-status derivation.
  * These codes are the machine-readable half of the error envelope contract and
@@ -907,4 +1133,4 @@ declare const BYMAX_GATEWAY_TIMEOUT = "BYMAX_GATEWAY_TIMEOUT";
  */
 declare function codeForStatus(status: number): string;
 
-export { BYMAX_BAD_GATEWAY, BYMAX_BAD_REQUEST, BYMAX_CLIENT_ERROR, BYMAX_CONFLICT, BYMAX_CORE_OPTIONS, BYMAX_CORRELATION_PROVIDER, BYMAX_FORBIDDEN, BYMAX_GATEWAY_TIMEOUT, BYMAX_HEALTH_INDICATORS, BYMAX_INTERNAL_ERROR, BYMAX_METRICS_REGISTRY, BYMAX_NOT_FOUND, BYMAX_NOT_IMPLEMENTED, BYMAX_PAYLOAD_TOO_LARGE, BYMAX_SERVICE_UNAVAILABLE, BYMAX_TIMING_SINK, BYMAX_TOO_MANY_REQUESTS, BYMAX_TRACE_CONTEXT, BYMAX_UNAUTHORIZED, BYMAX_UNPROCESSABLE_ENTITY, BYMAX_UNSUPPORTED_MEDIA_TYPE, BYMAX_VALIDATION_FAILED, type BuildErrorEnvelopeInput, BymaxCoreModule, type BymaxCoreModuleOptions, BymaxExceptionFilter, type EnvelopeOptions, type ErrorDetails, type ErrorEnvelope, type FilterErrorContext, type HealthOptions, type ICorrelationIdProvider, type ITimingSink, type ITraceContextProvider, type MetricsOptions, type OpenApiHttpMethod, type OpenApiOperationKey, type OpenApiOptions, type OpenApiSecurityRequirement, type OpenApiSecurityScheme, type OpenApiServerDescriptor, type OperationSecurityMap, type RequestTimingSample, type ResolvedCoreOptions, type TelemetryOptions, TimingInterceptor, type TimingOptions, type TraceContext, buildErrorEnvelope, codeForStatus };
+export { BYMAX_BAD_GATEWAY, BYMAX_BAD_REQUEST, BYMAX_CLIENT_ERROR, BYMAX_CONFLICT, BYMAX_CORE_OPTIONS, BYMAX_CORRELATION_PROVIDER, BYMAX_FORBIDDEN, BYMAX_GATEWAY_TIMEOUT, BYMAX_HEALTH_INDICATORS, BYMAX_INTERNAL_ERROR, BYMAX_METRICS_REGISTRY, BYMAX_NOT_FOUND, BYMAX_NOT_IMPLEMENTED, BYMAX_PAYLOAD_TOO_LARGE, BYMAX_SERVICE_UNAVAILABLE, BYMAX_TIMING_SINK, BYMAX_TOO_MANY_REQUESTS, BYMAX_TRACE_CONTEXT, BYMAX_UNAUTHORIZED, BYMAX_UNPROCESSABLE_ENTITY, BYMAX_UNSUPPORTED_MEDIA_TYPE, BYMAX_VALIDATION_FAILED, type BuildErrorEnvelopeInput, BymaxCoreModule, type BymaxCoreModuleOptions, BymaxExceptionFilter, BymaxTimingMiddleware, type EnvelopeOptions, type ErrorDetails, type ErrorEnvelope, type FilterErrorContext, type HealthOptions, type ICorrelationIdProvider, type ITimingSink, type ITraceContextProvider, type MetricsOptions, type OpenApiHttpMethod, type OpenApiOperationIdFactory, type OpenApiOperationKey, type OpenApiOptions, type OpenApiSecurityRequirement, type OpenApiSecurityScheme, type OpenApiServerDescriptor, type OperationSecurityMap, type RequestTimingSample, type ResolvedCoreOptions, type TelemetryOptions, TimingInterceptor, type TimingOptions, type TraceContext, UNMATCHED_ROUTE, buildErrorEnvelope, codeForStatus };