@bymax-one/nest-cache 1.0.4 → 1.0.6

package/CHANGELOG.md

@@ -6,6 +6,46 @@ project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [1.0.6] - 2026-08-06
+
+### Fixed
+
+- `ConnectionManager.onModuleInit()` assigned a freshly created client over the field
+  unconditionally. When something had already opened the main client through
+  `getClient()`, that first socket was left connected with no reference left to close it —
+  `onModuleDestroy()` quits only the current client, so the abandoned one stayed in Redis's
+  `CLIENT LIST` until its own timeout. Init now adopts an existing client instead of
+  replacing it, and the assignment lives in one private accessor so no other path can
+  strand a live connection.
+
+  Reaching it takes touching the cache before the cache module's own init hook runs, which
+  is possible in two ordinary shapes: NestJS orders `onModuleInit` by module depth, so a
+  consumer module deeper in the graph runs first, and `app.get()` works between
+  `NestFactory.create()` and `app.init()`. The ordinary boot path opened exactly one client
+  before this change and still does.
+
+## [1.0.5] - 2026-08-06
+
+**Documentation, tests and E2E only.** `dist/` is byte-identical to `1.0.4`.
+
+### Fixed
+
+- The Redis Cluster E2E was flaky at roughly one run in three, failing with `CLUSTERDOWN` or
+  "Too many Cluster redirections". The container log line proves `redis-cli --cluster create`
+  printed its coverage message, but what the client needs is the state each node serves on the
+  port the test dials. The helper now polls `CLUSTER INFO` on every node until all six report
+  `cluster_state:ok` and full slot coverage. Six consecutive runs of the previously flaky spec
+  pass, where it failed three times in nine before.
+
+### Documentation
+
+- The mutation badge said **100%**; the measured score is **99.78%**.
+
+### Tests
+
+- `findProvider` gained a spec of its own; it had only ever been exercised through the module
+  suites, where either half of its disjunction covered for the other.
+
 ## [1.0.4] - 2026-08-04
 
 ### Security
@@ -128,6 +168,8 @@ type or export moved.
 - Published with npm OIDC provenance — no long-lived tokens
 - Zero direct runtime dependencies (`dependencies: {}`) — `ioredis` and NestJS via peer deps
 
+[1.0.6]: https://github.com/bymaxone/nest-cache/compare/v1.0.5...v1.0.6
+[1.0.5]: https://github.com/bymaxone/nest-cache/compare/v1.0.4...v1.0.5
 [1.0.4]: https://github.com/bymaxone/nest-cache/compare/v1.0.3...v1.0.4
 [1.0.3]: https://github.com/bymaxone/nest-cache/releases/tag/v1.0.3
 [1.0.2]: https://github.com/bymaxone/nest-cache/releases/tag/v1.0.2

package/README.md

@@ -14,7 +14,7 @@
   <a href="https://www.npmjs.com/package/@bymax-one/nest-cache"><img src="https://img.shields.io/npm/dm/@bymax-one/nest-cache?style=flat-square&colorA=000000&colorB=000000" alt="npm downloads" /></a>
   <a href="https://github.com/bymaxone/nest-cache/actions/workflows/ci.yml"><img src="https://img.shields.io/github/actions/workflow/status/bymaxone/nest-cache/ci.yml?branch=main&style=flat-square&colorA=000000&label=CI" alt="CI status" /></a>
   <a href="https://github.com/bymaxone/nest-cache/actions/workflows/ci.yml"><img src="https://img.shields.io/badge/coverage-100%25-brightgreen?style=flat-square&colorA=000000" alt="coverage" /></a>
-  <a href="https://github.com/bymaxone/nest-cache/blob/main/docs/mutation_testing_results.md"><img src="https://img.shields.io/badge/mutation-100%25-brightgreen?style=flat-square&colorA=000000" alt="mutation score" /></a>
+  <a href="https://github.com/bymaxone/nest-cache/blob/main/docs/mutation_testing_results.md"><img src="https://img.shields.io/badge/mutation-99.78%25-brightgreen?style=flat-square&colorA=000000" alt="mutation score" /></a>
   <a href="https://scorecard.dev/viewer/?uri=github.com/bymaxone/nest-cache"><img src="https://api.scorecard.dev/projects/github.com/bymaxone/nest-cache/badge?style=flat-square" alt="OpenSSF Scorecard" /></a>
   <a href="https://github.com/bymaxone/nest-cache/blob/main/LICENSE"><img src="https://img.shields.io/github/license/bymaxone/nest-cache?style=flat-square&colorA=000000&colorB=000000" alt="license" /></a>
   <a href="https://www.typescriptlang.org/"><img src="https://img.shields.io/badge/TypeScript-strict-3178C6?style=flat-square&logo=typescript&logoColor=white" alt="TypeScript" /></a>
@@ -526,7 +526,7 @@ When integrating `@bymax-one/nest-cache` in production, verify each of the follo
 A cache is consulted on the hot path of every request that touches it, so the suite is held to a bar beyond "it runs" — every behavior is pinned so that a regression **fails a test**.
 
 - ✅ **100% line coverage** — statements, branches, functions, and lines, enforced by `jest.coverage.config.ts` as a pre-publish gate, not a target
-- ✅ **100% mutation score** — verified with [Stryker](https://stryker-mutator.io/) at `break: 95` and `ignoreStatic: false`: 433 seeded faults detected (427 killed, 6 timed out), **no survivors**
+- ✅ **99.78% mutation score** — verified with [Stryker](https://stryker-mutator.io/) at `break: 95` and `ignoreStatic: false`; the single survivor is `configurable: false` on the withheld connection accessor, equivalent here because the resolved options are frozen on the way out, and [documented as such](./docs/mutation_testing_results.md)
 - ✅ **Zero suppressions** — the production source carries no coverage or mutation directives; the one would-be equivalent mutant was refactored away rather than silenced, so the score is an accounting rather than a number
 - ✅ **No real Redis in unit tests** — `ioredis-mock` throughout; e2e tests exercise the wired module through `@nestjs/testing` and Testcontainers against a real Redis for connection lifecycle, Pub/Sub, and Lua scripts
 - ✅ **Published-package smoke test** — `scripts/dogfood-smoke-test.mjs` validates exports, tarball shape, and a consumer install before tagging

package/dist/server/index.cjs

@@ -227,6 +227,7 @@ function applyDefaults(options) {
     Object.defineProperty(resolved, key, {
       get: () => value,
       enumerable: false,
+      // Stryker disable next-line BooleanLiteral: equivalent HERE — `resolved` is `Object.freeze`d on the way out and freezing makes every property non-configurable anyway, so flipping this flag changes nothing observable. It stays because it states the guarantee where the accessor is defined, and nest-storage withholds its credentials the same way WITHOUT freezing, where this flag is the only thing enforcing it.
       configurable: false
     });
   }
@@ -259,12 +260,19 @@ exports.ConnectionManager = class ConnectionManager {
     this.defaultReconnectOnError = (err) => err.message.includes("READONLY");
     __privateSet(this, _redisOptionsResolved, this.buildRedisOptions(options));
   }
-  /** Opens the main client and waits for readiness unless `lazyConnect`. */
+  /**
+   * Opens the main client and waits for readiness unless `lazyConnect`.
+   *
+   * Adopts a client {@link getClient} already opened rather than replacing it:
+   * NestJS orders `onModuleInit` by module depth, and `app.get()` works before
+   * `app.init()`, so a consumer can reach the cache first. Overwriting here
+   * would strand that socket with no reference left to close it — teardown
+   * quits only the current client.
+   */
   async onModuleInit() {
-    __privateSet(this, _client, this.createClient());
-    this.registerListeners(__privateGet(this, _client), "main");
+    const client = this.ensureClient();
     if (!this.options.connection?.lazyConnect) {
-      await this.waitUntilReady(__privateGet(this, _client));
+      await this.waitUntilReady(client);
     }
   }
   /**
@@ -274,11 +282,7 @@ exports.ConnectionManager = class ConnectionManager {
    * @returns The shared main client.
    */
   getClient() {
-    if (!__privateGet(this, _client)) {
-      __privateSet(this, _client, this.createClient());
-      this.registerListeners(__privateGet(this, _client), "main");
-    }
-    return __privateGet(this, _client);
+    return this.ensureClient();
   }
   /**
    * Creates a brand-new dedicated connection for subscriber mode (a subscriber
@@ -336,6 +340,20 @@ exports.ConnectionManager = class ConnectionManager {
     }
   }
   // ─── Private ──────────────────────────────────────────────────────────────
+  /**
+   * Returns the main client, opening and wiring it on the first call. The only
+   * place a live client is assigned, so no caller can replace one; teardown
+   * only clears the field back to `null`.
+   *
+   * @returns The shared main client.
+   */
+  ensureClient() {
+    if (!__privateGet(this, _client)) {
+      __privateSet(this, _client, this.createClient());
+      this.registerListeners(__privateGet(this, _client), "main");
+    }
+    return __privateGet(this, _client);
+  }
   /**
    * Instantiates the client matching the configured mode.
    *

package/dist/server/index.d.cts

@@ -369,7 +369,15 @@ declare class ConnectionManager implements OnModuleInit, OnModuleDestroy {
      *   module can provide `null` when the consumer omits `events`.
      */
     constructor(options: ResolvedOptions, events?: ICacheEvents | undefined);
-    /** Opens the main client and waits for readiness unless `lazyConnect`. */
+    /**
+     * Opens the main client and waits for readiness unless `lazyConnect`.
+     *
+     * Adopts a client {@link getClient} already opened rather than replacing it:
+     * NestJS orders `onModuleInit` by module depth, and `app.get()` works before
+     * `app.init()`, so a consumer can reach the cache first. Overwriting here
+     * would strand that socket with no reference left to close it — teardown
+     * quits only the current client.
+     */
     onModuleInit(): Promise<void>;
     /**
      * Returns the singleton main client, creating it on first access if the
@@ -398,6 +406,14 @@ declare class ConnectionManager implements OnModuleInit, OnModuleDestroy {
     createSubscriberClient(): AnyRedis;
     /** Quits the main client gracefully, forcing `disconnect()` on timeout. */
     onModuleDestroy(): Promise<void>;
+    /**
+     * Returns the main client, opening and wiring it on the first call. The only
+     * place a live client is assigned, so no caller can replace one; teardown
+     * only clears the field back to `null`.
+     *
+     * @returns The shared main client.
+     */
+    private ensureClient;
     /**
      * Instantiates the client matching the configured mode.
      *

package/dist/server/index.d.ts

@@ -369,7 +369,15 @@ declare class ConnectionManager implements OnModuleInit, OnModuleDestroy {
      *   module can provide `null` when the consumer omits `events`.
      */
     constructor(options: ResolvedOptions, events?: ICacheEvents | undefined);
-    /** Opens the main client and waits for readiness unless `lazyConnect`. */
+    /**
+     * Opens the main client and waits for readiness unless `lazyConnect`.
+     *
+     * Adopts a client {@link getClient} already opened rather than replacing it:
+     * NestJS orders `onModuleInit` by module depth, and `app.get()` works before
+     * `app.init()`, so a consumer can reach the cache first. Overwriting here
+     * would strand that socket with no reference left to close it — teardown
+     * quits only the current client.
+     */
     onModuleInit(): Promise<void>;
     /**
      * Returns the singleton main client, creating it on first access if the
@@ -398,6 +406,14 @@ declare class ConnectionManager implements OnModuleInit, OnModuleDestroy {
     createSubscriberClient(): AnyRedis;
     /** Quits the main client gracefully, forcing `disconnect()` on timeout. */
     onModuleDestroy(): Promise<void>;
+    /**
+     * Returns the main client, opening and wiring it on the first call. The only
+     * place a live client is assigned, so no caller can replace one; teardown
+     * only clears the field back to `null`.
+     *
+     * @returns The shared main client.
+     */
+    private ensureClient;
     /**
      * Instantiates the client matching the configured mode.
      *

package/dist/server/index.mjs

@@ -225,6 +225,7 @@ function applyDefaults(options) {
     Object.defineProperty(resolved, key, {
       get: () => value,
       enumerable: false,
+      // Stryker disable next-line BooleanLiteral: equivalent HERE — `resolved` is `Object.freeze`d on the way out and freezing makes every property non-configurable anyway, so flipping this flag changes nothing observable. It stays because it states the guarantee where the accessor is defined, and nest-storage withholds its credentials the same way WITHOUT freezing, where this flag is the only thing enforcing it.
       configurable: false
     });
   }
@@ -257,12 +258,19 @@ var ConnectionManager = class {
     this.defaultReconnectOnError = (err) => err.message.includes("READONLY");
     __privateSet(this, _redisOptionsResolved, this.buildRedisOptions(options));
   }
-  /** Opens the main client and waits for readiness unless `lazyConnect`. */
+  /**
+   * Opens the main client and waits for readiness unless `lazyConnect`.
+   *
+   * Adopts a client {@link getClient} already opened rather than replacing it:
+   * NestJS orders `onModuleInit` by module depth, and `app.get()` works before
+   * `app.init()`, so a consumer can reach the cache first. Overwriting here
+   * would strand that socket with no reference left to close it — teardown
+   * quits only the current client.
+   */
   async onModuleInit() {
-    __privateSet(this, _client, this.createClient());
-    this.registerListeners(__privateGet(this, _client), "main");
+    const client = this.ensureClient();
     if (!this.options.connection?.lazyConnect) {
-      await this.waitUntilReady(__privateGet(this, _client));
+      await this.waitUntilReady(client);
     }
   }
   /**
@@ -272,11 +280,7 @@ var ConnectionManager = class {
    * @returns The shared main client.
    */
   getClient() {
-    if (!__privateGet(this, _client)) {
-      __privateSet(this, _client, this.createClient());
-      this.registerListeners(__privateGet(this, _client), "main");
-    }
-    return __privateGet(this, _client);
+    return this.ensureClient();
   }
   /**
    * Creates a brand-new dedicated connection for subscriber mode (a subscriber
@@ -334,6 +338,20 @@ var ConnectionManager = class {
     }
   }
   // ─── Private ──────────────────────────────────────────────────────────────
+  /**
+   * Returns the main client, opening and wiring it on the first call. The only
+   * place a live client is assigned, so no caller can replace one; teardown
+   * only clears the field back to `null`.
+   *
+   * @returns The shared main client.
+   */
+  ensureClient() {
+    if (!__privateGet(this, _client)) {
+      __privateSet(this, _client, this.createClient());
+      this.registerListeners(__privateGet(this, _client), "main");
+    }
+    return __privateGet(this, _client);
+  }
   /**
    * Instantiates the client matching the configured mode.
    *

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bymax-one/nest-cache",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "description": "Typed Redis cache for NestJS based on ioredis 5, with namespace strategy, Pub/Sub and Lua script management.",
   "author": "Bymax One <support@bymax.one>",
   "license": "MIT",
@@ -56,6 +56,7 @@
   "scripts": {
     "build": "pnpm clean && tsup",
     "check:exports": "attw --pack .",
+    "check:mutants": "node scripts/check-mutation-directives.mjs",
     "check:published": "node scripts/check-published-surface.mjs",
     "clean": "rm -rf dist coverage",
     "lint": "eslint src scripts",
@@ -64,7 +65,7 @@
     "mutation:dry-run": "stryker run --dryRunOnly",
     "mutation:incremental": "stryker run --incremental",
     "prepare": "husky",
-    "prepublishOnly": "pnpm clean && pnpm typecheck && pnpm test:types && pnpm lint && pnpm test:cov:all && pnpm build && pnpm check:published",
+    "prepublishOnly": "pnpm clean && pnpm typecheck && pnpm test:types && pnpm lint && pnpm check:mutants && pnpm test:cov:all && pnpm build && pnpm check:published",
     "release": "npm publish --provenance --access public",
     "size": "node scripts/check-size.mjs",
     "test": "jest",
@@ -139,26 +140,12 @@
     "pubsub",
     "lua"
   ],
-  "packageManager": "pnpm@10.8.1",
+  "packageManager": "pnpm@11.20.0",
   "engines": {
     "node": ">=24.0.0"
   },
   "publishConfig": {
     "access": "public",
     "registry": "https://registry.npmjs.org/"
-  },
-  "pnpm": {
-    "overrides": {
-      "brace-expansion@1": "^1.1.18",
-      "brace-expansion@2": "^2.1.4",
-      "brace-expansion@5": "^5.0.9",
-      "esbuild": "^0.28.1",
-      "fast-uri": "^3.1.5",
-      "js-yaml@3": "^3.15.0",
-      "js-yaml@4": "^4.3.0",
-      "protobufjs": "^7.6.5",
-      "qs": "^6.15.2",
-      "undici": "^7.28.0"
-    }
   }
 }