@byline/richtext-lexical 3.20.1 → 3.20.3

package/dist/field/editor-context.js

@@ -16,9 +16,11 @@ function EditorContext(props) {
     const editable = true !== readOnly;
     const rootExtension = useMemo(()=>{
         const extensionsList = editorConfig.extensions ?? defaultExtensionsList();
-        const dependencies = extensionsList.clone().configure(InlineImageExtension, {
+        const configured = extensionsList.clone();
+        if (configured.has(InlineImageExtension)) configured.configure(InlineImageExtension, {
             collection: editorConfig.settings.inlineImageUploadCollection
-        }).toArray();
+        });
+        const dependencies = configured.toArray();
         return defineExtension({
             name: '[root]',
             namespace: editorConfig.lexical.namespace,

package/package.json

@@ -3,7 +3,7 @@
   "private": false,
   "type": "module",
   "license": "MPL-2.0",
-  "version": "3.20.1",
+  "version": "3.20.3",
   "engines": {
     "node": ">=20.9.0"
   },
@@ -73,10 +73,10 @@
     "lexical": "0.46.0",
     "npm-run-all": "^4.1.5",
     "react-error-boundary": "^6.1.2",
-    "@byline/admin": "3.20.1",
-    "@byline/ui": "3.20.1",
-    "@byline/core": "3.20.1",
-    "@byline/client": "3.20.1"
+    "@byline/core": "3.20.3",
+    "@byline/admin": "3.20.3",
+    "@byline/ui": "3.20.3",
+    "@byline/client": "3.20.3"
   },
   "peerDependencies": {
     "react": "^19.0.0",

package/src/field/config/extensions-list.test.node.ts

@@ -0,0 +1,61 @@
+/**
+ * This Source Code is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * Copyright (c) Infonomic Company Limited
+ */
+
+import type { AnyLexicalExtensionArgument } from '@lexical/extension'
+import { describe, expect, it } from 'vitest'
+
+import { ExtensionsList } from './extensions-list'
+
+// Structural stand-ins — ExtensionsList compares by `.name`, so plain
+// objects are sufficient and keep the heavy extension classes (React,
+// Lexical nodes) out of this node-mode test.
+const extA = { name: 'test/A' } as unknown as AnyLexicalExtensionArgument
+const extB = { name: 'test/B' } as unknown as AnyLexicalExtensionArgument
+
+describe('ExtensionsList', () => {
+  it('remove() by name string drops the entry; has() reflects it', () => {
+    const list = new ExtensionsList([extA, extB])
+    expect(list.has('test/A')).toBe(true)
+    list.remove('test/A')
+    expect(list.has('test/A')).toBe(false)
+    expect(list.has('test/B')).toBe(true)
+  })
+
+  it('configure() upserts — documented behaviour: absent extension is ADDED', () => {
+    const list = new ExtensionsList([extB])
+    // biome-ignore lint/suspicious/noExplicitAny: structural stand-in
+    list.configure(extA as any, {})
+    expect(list.has('test/A')).toBe(true)
+  })
+
+  it('REGRESSION: callers forwarding settings must gate configure() on has() — the clone survives a prior remove', () => {
+    // Mirrors editor-context.tsx: settings forwarding used to call
+    // `.configure(InlineImageExtension, …)` unconditionally, and the
+    // upsert resurrected an extension the registration had deliberately
+    // removed. The gated pattern must leave the removal intact.
+    const list = new ExtensionsList([extA, extB])
+    list.remove('test/A')
+
+    const configured = list.clone()
+    if (configured.has('test/A')) {
+      // biome-ignore lint/suspicious/noExplicitAny: structural stand-in
+      configured.configure(extA as any, {})
+    }
+
+    expect(configured.has('test/A')).toBe(false)
+    expect(configured.toArray().length).toBe(1)
+  })
+
+  it('clone() is independent — mutations do not leak back', () => {
+    const list = new ExtensionsList([extA, extB])
+    const copy = list.clone()
+    copy.remove('test/B')
+    expect(list.has('test/B')).toBe(true)
+    expect(copy.has('test/B')).toBe(false)
+  })
+})

package/src/field/editor-context.tsx

@@ -80,14 +80,19 @@ export function EditorContext(props: {
     const extensionsList = editorConfig.extensions ?? defaultExtensionsList()
 
     // Forward the inline-image upload collection from the settings facade
-    // onto the InlineImageExtension's typed config, but only when the
-    // user hasn't already configured the extension explicitly.
-    const dependencies = extensionsList
-      .clone()
-      .configure(InlineImageExtension, {
+    // onto the InlineImageExtension's typed config — but ONLY when the
+    // extension is actually present. `configure()` has upsert semantics
+    // (absent → added), so an ungated call here silently resurrected
+    // InlineImageExtension on every editor build for registrations that
+    // had deliberately removed it via
+    // `lexicalEditor((c) => c.extensions.remove(builtInExtensions.InlineImage))`.
+    const configured = extensionsList.clone()
+    if (configured.has(InlineImageExtension)) {
+      configured.configure(InlineImageExtension, {
         collection: editorConfig.settings.inlineImageUploadCollection,
       })
-      .toArray()
+    }
+    const dependencies = configured.toArray()
 
     return defineExtension({
       name: '[root]',