@byline/cli 2.4.0 → 2.4.1

package/dist/templates/host/vite.config.ts

@@ -44,14 +44,21 @@ const bylineSsrNoExternal = [/^@byline\//]
 //   - sharp + @byline/storage-local — image processing (libvips)
 //   - @byline/storage-s3 — bundles the AWS SDK; keep external for Node resolution
 //   - @byline/db-postgres — depends on `pg` native bindings
-//   - @byline/admin — re-exports server-only code that imports the above
 //   - pino — CJS entrypoints don't execute under Vite's module runner
+//
+// `@byline/admin` is intentionally NOT externalised: it now hosts
+// React admin UI subpaths (`/admin-users/components/*`, `/services`,
+// `/auth/components/sign-in-form`, etc.) whose compiled JS does
+// `import './foo_module.css'`. Node's ESM loader can't handle `.css`,
+// so admin must flow through Vite's SSR pipeline where the CSS plugin
+// resolves the side-effect imports. Server-only admin subpaths reach
+// db-postgres / storage adapters through composition at runtime, not
+// through `@byline/admin`'s own import graph, so this is safe.
 const ssrExternal = [
   'sharp',
   'pino',
   '@byline/storage-local',
   '@byline/storage-s3',
-  '@byline/admin',
   '@byline/db-postgres',
 ]
 
@@ -143,14 +150,13 @@ const config = defineConfig({
     devtools(),
     nitro({
       preset: 'node',
-      // @byline/ui ships compiled JS that does `import './foo_module.css'`.
-      // @byline/host-tanstack-start re-exports route factories from
-      // @byline/ui at runtime in the SSR graph. Nitro externalizes
-      // node_modules by default, which sends those imports to Node's
-      // ESM loader — which can't handle .css. Inlining both packages
-      // through Nitro's pipeline lets Vite's CSS plugin process the
-      // side-effect imports.
-      noExternals: ['@byline/ui', '@byline/host-tanstack-start'],
+      // @byline/ui, @byline/admin, and @byline/host-tanstack-start all
+      // ship compiled JS that does `import './foo_module.css'`. Nitro
+      // externalizes node_modules by default, which would send those
+      // imports to Node's ESM loader — which can't handle .css.
+      // Inlining these three packages through Nitro's pipeline lets
+      // Vite's CSS plugin process the side-effect imports.
+      noExternals: ['@byline/ui', '@byline/admin', '@byline/host-tanstack-start'],
       // When Nitro inlines `@byline/host-tanstack-start` it pulls in
       // `@byline/core`, which depends on pino. Pino's CJS entry can't be
       // bundled, so we externalize it (and other native deps) here at
@@ -179,7 +185,7 @@ const config = defineConfig({
           'react-dom',
           'pino',
           'sharp',
-          /^@byline\/(admin|db-postgres|storage-local|storage-s3)/,
+          /^@byline\/(db-postgres|storage-local|storage-s3)/,
         ],
       },
     }),

package/package.json

@@ -2,7 +2,7 @@
   "name": "@byline/cli",
   "private": false,
   "license": "MPL-2.0",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "engines": {
     "node": ">=20.9.0"
   },

package/dist/phases/wire/root-tsx.d.ts

@@ -1,3 +0,0 @@
-import type { SubEdit } from './shared.js';
-export declare const wireRootTsx: SubEdit;
-//# sourceMappingURL=root-tsx.d.ts.map

package/dist/phases/wire/root-tsx.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"root-tsx.d.ts","sourceRoot":"","sources":["../../../src/phases/wire/root-tsx.ts"],"names":[],"mappings":"AAKA,OAAO,KAAK,EAAE,OAAO,EAAiB,MAAM,aAAa,CAAA;AASzD,eAAO,MAAM,WAAW,EAAE,OASzB,CAAA"}

package/dist/phases/wire/root-tsx.js

@@ -1,57 +0,0 @@
-import { existsSync, readFileSync } from 'node:fs';
-import { Project } from 'ts-morph';
-const REL = 'src/routes/__root.tsx';
-const IMPORT_SPECIFIER = '../../byline/admin.config';
-const SNIPPET = `// Initialize Byline admin config — must be imported here so it runs in both
-// the SSR rendering and client module graphs (see byline/admin.config.ts).
-import '${IMPORT_SPECIFIER}'
-`;
-export const wireRootTsx = {
-    key: 'root-tsx',
-    title: `Inject side-effect import into ${REL}`,
-    async preview(ctx) {
-        return run(ctx, true);
-    },
-    async apply(ctx) {
-        return run(ctx, false);
-    },
-};
-async function run(ctx, dryRun) {
-    const path = ctx.resolve(REL);
-    if (!existsSync(path)) {
-        return { status: 'blocked', message: `${REL} not found — host phase should have caught this` };
-    }
-    const text = readFileSync(path, 'utf8');
-    if (hasImport(text, IMPORT_SPECIFIER)) {
-        return { status: 'skipped', message: `${REL}: admin config import already present` };
-    }
-    if (dryRun) {
-        return { status: 'done', message: `${REL}: will inject \`import '${IMPORT_SPECIFIER}'\`` };
-    }
-    const project = new Project({ useInMemoryFileSystem: false, skipAddingFilesFromTsConfig: true });
-    let source;
-    try {
-        source = project.addSourceFileAtPath(path);
-    }
-    catch {
-        return {
-            status: 'manual',
-            message: `${REL}: could not parse — please add the import manually`,
-            snippet: SNIPPET,
-        };
-    }
-    // Place after the last existing import — admin config registration only
-    // needs to run once at module load; ordering with other side-effect
-    // imports doesn't matter as long as it lands in the route module graph.
-    const imports = source.getImportDeclarations();
-    const insertIndex = imports.length;
-    source.insertImportDeclaration(insertIndex, { moduleSpecifier: IMPORT_SPECIFIER });
-    source.saveSync();
-    return { status: 'done', message: `${REL}: injected \`import '${IMPORT_SPECIFIER}'\`` };
-}
-function hasImport(source, specifier) {
-    const escaped = specifier.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-    const re = new RegExp(`import\\s+['"]${escaped}(?:\\.ts|\\.tsx)?['"]`);
-    return re.test(source);
-}
-//# sourceMappingURL=root-tsx.js.map

package/dist/phases/wire/root-tsx.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"root-tsx.js","sourceRoot":"","sources":["../../../src/phases/wire/root-tsx.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,SAAS,CAAA;AAElD,OAAO,EAAE,OAAO,EAAmB,MAAM,UAAU,CAAA;AAKnD,MAAM,GAAG,GAAG,uBAAuB,CAAA;AACnC,MAAM,gBAAgB,GAAG,2BAA2B,CAAA;AACpD,MAAM,OAAO,GAAG;;UAEN,gBAAgB;CACzB,CAAA;AAED,MAAM,CAAC,MAAM,WAAW,GAAY;IAClC,GAAG,EAAE,UAAU;IACf,KAAK,EAAE,kCAAkC,GAAG,EAAE;IAC9C,KAAK,CAAC,OAAO,CAAC,GAAG;QACf,OAAO,GAAG,CAAC,GAAG,EAAE,IAAI,CAAC,CAAA;IACvB,CAAC;IACD,KAAK,CAAC,KAAK,CAAC,GAAG;QACb,OAAO,GAAG,CAAC,GAAG,EAAE,KAAK,CAAC,CAAA;IACxB,CAAC;CACF,CAAA;AAED,KAAK,UAAU,GAAG,CAAC,GAAY,EAAE,MAAe;IAC9C,MAAM,IAAI,GAAG,GAAG,CAAC,OAAO,CAAC,GAAG,CAAC,CAAA;IAC7B,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;QACtB,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,GAAG,GAAG,iDAAiD,EAAE,CAAA;IAChG,CAAC;IAED,MAAM,IAAI,GAAG,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,CAAA;IACvC,IAAI,SAAS,CAAC,IAAI,EAAE,gBAAgB,CAAC,EAAE,CAAC;QACtC,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,GAAG,GAAG,uCAAuC,EAAE,CAAA;IACtF,CAAC;IAED,IAAI,MAAM,EAAE,CAAC;QACX,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,GAAG,GAAG,2BAA2B,gBAAgB,KAAK,EAAE,CAAA;IAC5F,CAAC;IAED,MAAM,OAAO,GAAG,IAAI,OAAO,CAAC,EAAE,qBAAqB,EAAE,KAAK,EAAE,2BAA2B,EAAE,IAAI,EAAE,CAAC,CAAA;IAChG,IAAI,MAAkB,CAAA;IACtB,IAAI,CAAC;QACH,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAA;IAC5C,CAAC;IAAC,MAAM,CAAC;QACP,OAAO;YACL,MAAM,EAAE,QAAQ;YAChB,OAAO,EAAE,GAAG,GAAG,oDAAoD;YACnE,OAAO,EAAE,OAAO;SACjB,CAAA;IACH,CAAC;IAED,wEAAwE;IACxE,oEAAoE;IACpE,wEAAwE;IACxE,MAAM,OAAO,GAAG,MAAM,CAAC,qBAAqB,EAAE,CAAA;IAC9C,MAAM,WAAW,GAAG,OAAO,CAAC,MAAM,CAAA;IAClC,MAAM,CAAC,uBAAuB,CAAC,WAAW,EAAE,EAAE,eAAe,EAAE,gBAAgB,EAAE,CAAC,CAAA;IAClF,MAAM,CAAC,QAAQ,EAAE,CAAA;IAEjB,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,GAAG,GAAG,wBAAwB,gBAAgB,KAAK,EAAE,CAAA;AACzF,CAAC;AAED,SAAS,SAAS,CAAC,MAAc,EAAE,SAAiB;IAClD,MAAM,OAAO,GAAG,SAAS,CAAC,OAAO,CAAC,qBAAqB,EAAE,MAAM,CAAC,CAAA;IAChE,MAAM,EAAE,GAAG,IAAI,MAAM,CAAC,iBAAiB,OAAO,uBAAuB,CAAC,CAAA;IACtE,OAAO,EAAE,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;AACxB,CAAC"}