@bycrux/editor 0.8.4 → 0.8.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bycrux/editor",
-  "version": "0.8.4",
+  "version": "0.8.5",
   "private": false,
   "type": "module",
   "exports": {

package/src/video/RenderModal.tsx

@@ -61,6 +61,16 @@ const STEPPER_PHASES: RenderPhase[] = RENDER_PHASES.filter(p => p !== 'done')
 
 const POLL_INTERVAL_MS = 2500
 
+/**
+ * Consecutive status-poll failures tolerated before the modal declares the
+ * render failed. A multi-minute 4K render polls many times; a transient network
+ * blip (a Cloudflare-tunnel hiccup, a backend redeploy, a flaky hop) must not be
+ * mistaken for a render failure — the render keeps running server-side. ~12 ×
+ * 2.5s ≈ 30s of continuous unreachability before giving up. An explicit backend
+ * `error` status is still terminal immediately.
+ */
+const MAX_POLL_FAILURES = 12
+
 // ── Stepper ───────────────────────────────────────────────────────────────────
 
 function PhaseStepper({ current }: { current: RenderPhase }) {
@@ -144,16 +154,28 @@ export default function RenderModal<P extends Project = Project>({ projectId, ad
           await adapter.renderAsync!(projectId)
           if (unmountedRef.current || cancelledRef.current) return
 
+          let pollFailures = 0
           const tick = async () => {
             if (unmountedRef.current || cancelledRef.current) return
             let snap: RenderStatus
             try {
               snap = await adapter.getRenderStatus!(projectId)
+              pollFailures = 0
             } catch (e) {
               if (unmountedRef.current || cancelledRef.current) return
-              stopPolling()
-              setError(e instanceof Error ? e.message : String(e))
-              setStatus('error')
+              // A transient network blip (Cloudflare-tunnel hiccup, a backend
+              // redeploy, a flaky hop) must NOT be mistaken for a render
+              // failure — the render is still running server-side. This is what
+              // surfaced as "Render failed: Failed to fetch" while the render
+              // actually completed and was delivered. Keep polling; only give
+              // up after MAX_POLL_FAILURES consecutive failures. An explicit
+              // { status: 'error' } reply is still terminal (handled below).
+              pollFailures += 1
+              if (pollFailures >= MAX_POLL_FAILURES) {
+                stopPolling()
+                setError(e instanceof Error ? e.message : String(e))
+                setStatus('error')
+              }
               return
             }
             if (unmountedRef.current || cancelledRef.current) return

package/src/video/__tests__/render-progress.test.tsx

@@ -172,6 +172,56 @@ describe('RenderModal (poll-driven)', () => {
     expect(screen.getByText(/interrupted on the server/i)).toBeTruthy()
     expect(screen.getByText('Close')).toBeTruthy()
   })
+
+  it('tolerates a transient poll failure and still completes', async () => {
+    vi.useFakeTimers()
+    // poll #1 throws (network blip), then it recovers and finishes. The modal
+    // must NOT flip to "Render failed" on the transient throw — the render is
+    // still running server-side.
+    const steps: Array<() => RenderStatus> = [
+      () => { throw new Error('Failed to fetch') },
+      () => ({ status: 'running', phase: 'rendering' } as RenderStatus),
+      () => ({ status: 'done', phase: 'done', media: [DONE_MEDIA] } as RenderStatus),
+    ]
+    let call = 0
+    const adapter = baseAdapter()
+    adapter.renderAsync = vi.fn(async () => ({ status: 'running' }))
+    adapter.getRenderStatus = vi.fn(async () => steps[Math.min(call++, steps.length - 1)]())
+
+    render(<RenderModal adapter={adapter} projectId="vid-1" onClose={vi.fn()} />)
+
+    // Kick + the first poll (which throws) — still "Rendering…", not failed.
+    await act(async () => { for (let i = 0; i < 10; i++) await Promise.resolve() })
+    expect(screen.queryByText('Render failed')).toBeNull()
+    expect(screen.getByText('Rendering…')).toBeTruthy()
+
+    // Subsequent polls recover → running → done.
+    await act(async () => { await vi.advanceTimersByTimeAsync(2500) })
+    await act(async () => { await vi.advanceTimersByTimeAsync(2500) })
+
+    vi.useRealTimers()
+    await waitFor(() => {
+      expect(document.querySelector('video')?.getAttribute('src')).toBe('https://r2/x.mp4')
+    })
+  })
+
+  it('gives up only after sustained consecutive poll failures', async () => {
+    vi.useFakeTimers()
+    const adapter = baseAdapter()
+    adapter.renderAsync = vi.fn(async () => ({ status: 'running' }))
+    adapter.getRenderStatus = vi.fn(async () => { throw new Error('Failed to fetch') })
+
+    render(<RenderModal adapter={adapter} projectId="vid-1" onClose={vi.fn()} />)
+
+    // First poll throws — still running, NOT failed (one blip is tolerated).
+    await act(async () => { for (let i = 0; i < 10; i++) await Promise.resolve() })
+    expect(screen.queryByText('Render failed')).toBeNull()
+
+    // Keep failing past MAX_POLL_FAILURES (~12 × 2.5s) → terminal error.
+    await act(async () => { await vi.advanceTimersByTimeAsync(2500 * 15) })
+    expect(screen.getByText('Render failed')).toBeTruthy()
+    expect(screen.getByText('Failed to fetch')).toBeTruthy()
+  })
 })
 
 // ── Component (SSE fallback when poll methods absent) ──────────────────────────