@bushizhanghan/dsh-publish-gate 0.19.0 → 0.20.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.20.0
+
+- `publish_gate_commands` now agrees with the rules: a prerelease version gets `npm publish --tag next`
+  instead of a bare publish that would move `latest`.
+- New step `tag the shipped commit` (`git tag v<version> && git push origin v<version>`). The gate has
+  warned about a missing tag since 0.5.0 and the command list never mentioned tagging — I wrote a
+  separate script to do it because the instructions never said to.
+
 ## 0.19.0
 
 - `prerelease-published-as-latest` (warn): a `-beta` / `-rc` version with no `publishConfig.tag`.

package/README.md

@@ -45,7 +45,7 @@ dsh plugin --profile desktop add @bushizhanghan/dsh-publish-gate
 | `publish_gate_market` | 校验市场条目 YAML（url/name/category/description 双语）；传 `dir` 则改查只有线上才能回答的三件事：这个仓库**已经在目录里**（再开 PR 就是重复条目）、另一个条目也在发同一个 npm 包、仓库还**不满 24 小时**（提交门禁会失败并自己重跑） |
 | `publish_gate_next_version` | 当前版本、是否已被 registry 占用、建议 bump 到多少（本地比 npm 旧时从 npm 的 latest 往上加，不会推荐一个已被占用的版本） |
 | `publish_gate_doctor` | 扫整个目录，按 blocker 数排序，附带每个插件的真实包体积，看哪个还不能发 |
-| `publish_gate_commands` | 按顺序列出发布命令，并标出这台机器已经走到哪一步。命令是**这台机器上真能跑的形式**：Windows 下 `npm publish` 走 `cmd /c`（PowerShell 的 `npm.ps1` 常被执行策略拦掉），`npm publish` 后面紧跟一条 `publish_gate_verify` |
+| `publish_gate_commands` | 按顺序列出发布命令，并标出这台机器已经走到哪一步。命令是**这台机器上真能跑的形式**：Windows 下 `npm publish` 走 `cmd /c`（PowerShell 的 `npm.ps1` 常被执行策略拦掉），`npm publish` 后面紧跟一条 `publish_gate_verify`；版本是预发版时命令自带 `--tag next`；最后一步是给发出去的 commit 打 tag |
 
 ## 检查清单
 
@@ -236,7 +236,7 @@ dsh plugin --profile desktop add @bushizhanghan/dsh-publish-gate
 
 ```sh
 node --test                      # 120 个引擎单测
-node test/integration.test.mjs   # 27 条集成断言（9 个真实插件作 fixture）
+node test/integration.test.mjs   # 28 条集成断言（9 个真实插件作 fixture）
 ```
 
 ## License

package/lib/index.js

@@ -28,8 +28,8 @@ import {
   compareVersions,
   latestPublished,
   renderReport,
-  runArtifactChecks,
-  checkTestRun,
+  runArtifactChecks,
+  checkTestRun,
   straySeverities,
   runStaticChecks,
 } from './engine.js'
@@ -104,7 +104,7 @@ export function apply(ctx, config = {}) {
           skipNetwork: { type: 'boolean', description: 'Skip the npm registry and GitHub checks (default false).' },
           skipPack: { type: 'boolean', description: 'Skip `npm pack --dry-run` (default false). Faster, but says nothing about the real tarball.' },
           skipTools: { type: 'boolean', description: 'Skip the isolated import of the plugin entry (default false).' },
-          skipClient: { type: 'boolean', description: 'Skip the isolated load of the browser bundle (default false).' },
+          skipClient: { type: 'boolean', description: 'Skip the isolated load of the browser bundle (default false).' },
           skipTests: { type: 'boolean', description: 'Skip running the test suite (default false). The suite is the only check that reads the code rather than the paperwork.' },
         },
       },
@@ -114,21 +114,21 @@ export function apply(ctx, config = {}) {
         const findings = runStaticChecks(dir)
         const artifact = await runArtifactChecks(dir, { skipPack: args.skipPack, skipTools: args.skipTools, skipClient: args.skipClient })
         findings.push(...artifact.findings)
-        const tests = args.skipTests ? null : await checkTestRun(dir, { timeoutMs: cfg.testTimeoutMs })
-        if (tests) findings.push(...tests)
+        const tests = args.skipTests ? null : await checkTestRun(dir, { timeoutMs: cfg.testTimeoutMs })
+        if (tests) findings.push(...tests)
         if (!args.skipNetwork) findings.push(...(await networkGate(dir)))
-        // A finding with an unexpected severity is invisible to the counters
-        // below, so the rule silently never reports. Make that loud instead.
-        const stray = straySeverities(findings)
-        if (stray.length > 0) {
-          findings.push({
-            rule: 'internal-bad-severity',
-            severity: 'error',
-            title: `these rules built a finding with an unknown severity: ${stray.join(", ")}`,
-            detail: 'The gate counted them as nothing, so they never appeared in a report. This is a bug in publish-gate, not in the plugin being gated.',
-            fix: 'Report it: the severity slot of F(...) took something other than error/warn/info.',
-          })
-        }
+        // A finding with an unexpected severity is invisible to the counters
+        // below, so the rule silently never reports. Make that loud instead.
+        const stray = straySeverities(findings)
+        if (stray.length > 0) {
+          findings.push({
+            rule: 'internal-bad-severity',
+            severity: 'error',
+            title: `these rules built a finding with an unknown severity: ${stray.join(", ")}`,
+            detail: 'The gate counted them as nothing, so they never appeared in a report. This is a bug in publish-gate, not in the plugin being gated.',
+            fix: 'Report it: the severity slot of F(...) took something other than error/warn/info.',
+          })
+        }
         const counts = {
           error: findings.filter((f) => f.severity === 'error').length,
           warn: findings.filter((f) => f.severity === 'warn').length,
@@ -412,6 +412,11 @@ export function apply(ctx, config = {}) {
         const repo = json.repository?.url?.match(/github\.com[:/]([^/]+)\/([^/.]+)/)?.[2] || json.name.replace(/^@[^/]+\//, '')
         const { existsSync } = await import('node:fs')
         const hasGit = existsSync(join(dir, '.git'))
+        // npm publishes to `latest` whatever the version suffix says, so a
+        // prerelease needs an explicit tag or it goes out to everyone.
+        const preTag = /^\d+\.\d+\.\d+-/.test(json.version || '')
+        const tag = preTag ? (json.publishConfig?.tag && json.publishConfig.tag !== 'latest' ? json.publishConfig.tag : 'next') : null
+        const publishCmd = `npm publish --access public${tag ? ` --tag ${tag}` : ''}`
         const steps = [
           {
             name: 'git init and commit',
@@ -433,7 +438,7 @@ export function apply(ctx, config = {}) {
           },
           {
             name: 'npm publish',
-            command: process.platform === 'win32' ? 'cmd /c "npm publish --access public"' : 'npm publish --access public',
+            command: process.platform === 'win32' ? `cmd /c "${publishCmd}"` : publishCmd,
             done: false,
             note:
               `a bare (unscoped) name can return 403 with a granular token — "${json.name}" is ${json.name.startsWith('@') ? 'scoped, fine' : 'UNSCOPED, rename it'}` +
@@ -447,7 +452,14 @@ export function apply(ctx, config = {}) {
             command: `publish_gate_verify({ dir: "${dir.replace(/\\/g, '\\\\')}" })`,
             done: false,
             note: 'the registry answers 202 and then 404s for about a minute, so a mismatch right after publish is normal; the shasum comparison is exact once it settles',
-          },          {
+          },
+          {
+            name: 'tag the shipped commit',
+            command: `git tag v${json.version} && git push origin v${json.version}`,
+            done: false,
+            note: 'a GitHub release, a changelog entry and the market listing all point at a commit — none of them can point at one that was never tagged',
+          },
+          {
             name: 'market entry',
             command: `write data/plugins/${owner}__${repo}.yml with url / name / category / description{en,zh}`,
             done: false,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bushizhanghan/dsh-publish-gate",
-  "version": "0.19.0",
+  "version": "0.20.0",
   "description": "Pre-publish gate for DSH plugins: manifest, dependencies, artifact, runtime, browser half, traceability and market readiness — plus an input fuzzer that drives every declared parameter with the wrong type. 发布前的七层门禁 + 入参模糊测试。",
   "type": "module",
   "main": "lib/index.js",