@bushizhanghan/dsh-publish-gate 0.14.0 → 0.15.0

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## 0.15.0
+
+- Three rules shipped with a *rule name* in their severity slot: `market-repo-too-new`,
+  `test-script-dir-arg` and `tool-missing-output-schema` were built as
+  `F(rule, "some-other-rule", "a-third-rule", "warn", title, ...)`, because a string replace aimed at
+  RULE_ORDER matched an earlier `F(...)` call instead and pushed the new names into its arguments.
+  Nothing failed: a finding whose severity is not error/warn/info falls out of every counter and never
+  reaches the report, so the rules looked like they simply never fired. Fixed all three, added the six
+  rule names that never made it into RULE_ORDER, and added a source scan that fails when any `F(...)`
+  call passes something other than an error/warn/info literal (or a ternary of two of them).
+
 ## 0.14.0
 
 - New test layer: `checkTestRun` runs `node --test` in the plugin directory and reports `tests-fail`

package/README.md

@@ -227,7 +227,7 @@ dsh plugin --profile desktop add @bushizhanghan/dsh-publish-gate
 ## 开发
 
 ```sh
-node --test                      # 110 个引擎单测
+node --test                      # 113 个引擎单测
 node test/integration.test.mjs   # 27 条集成断言（9 个真实插件作 fixture）
 ```
 

package/lib/engine.js

@@ -931,7 +931,7 @@ export async function checkMarketReadiness(dir, opts = {}) {
       if (hours < 24) {
         out.push(
           F(
-            'market-repo-too-new', 'market-fork-of-listed', 'market-fork-undisclosed',
+            'market-repo-too-new',
             'warn',
             `the repo is ${hours.toFixed(1)}h old; the submission gate needs 24h`,
             'The gate fails with a "repo too new" message and reruns on its own, so the PR is not lost — but nothing merges until it passes.',
@@ -1044,10 +1044,7 @@ export function checkTests(dir) {
   // while the tests themselves are fine. Auto-discovery needs no argument.
   const testScript = pkgJson?.scripts?.test || ''
   const dirArg = testScript.match(/\bnode\s+--test\s+(?!-)(\S+)/)
-  if (dirArg) out.push(F('test-script-dir-arg',
-  'tests-fail',
-  'tests-timeout',
-  'tests-not-run', 'warn', `test script passes a path to node --test ("${dirArg[1]}")`, 'Node 22+ treats that argument as a module path, not a directory to glob: `node --test test/` throws MODULE_NOT_FOUND, so npm test can never pass even though the tests are fine.', 'Drop the path — "test": "node --test" auto-discovers test/**/*.test.mjs.'))
+  if (dirArg) out.push(F('test-script-dir-arg', 'warn', `test script passes a path to node --test ("${dirArg[1]}")`, 'Node 22+ treats that argument as a module path, not a directory to glob: `node --test test/` throws MODULE_NOT_FOUND, so npm test can never pass even though the tests are fine.', 'Drop the path — "test": "node --test" auto-discovers test/**/*.test.mjs.'))
   return out
 }
 
@@ -1069,12 +1066,12 @@ export async function checkTestRun(dir, opts = {}) {
   let stdout = ''
   let code = 0
   let timedOut = false
-  // NODE_TEST_CONTEXT is inherited from whoever called us: when this gate runs
-  // inside `node --test` itself, the child starts in test-child mode and prints
-  // no summary at all, which reads as "no tests" — a false alarm.
-  const env = { ...process.env }
-  delete env.NODE_TEST_CONTEXT
-  try {
+  // NODE_TEST_CONTEXT is inherited from whoever called us: when this gate runs
+  // inside `node --test` itself, the child starts in test-child mode and prints
+  // no summary at all, which reads as "no tests" — a false alarm.
+  const env = { ...process.env }
+  delete env.NODE_TEST_CONTEXT
+  try {
     const r = await runFile(process.execPath, ['--test'], { cwd: dir, env, timeout: timeoutMs, maxBuffer: 16 * 1024 * 1024, windowsHide: true })
     stdout = String(r.stdout || '')
   } catch (error) {
@@ -1634,7 +1631,7 @@ export async function checkToolRegistrations(dir, opts = {}) {
         ),
       )
     }
-    if (!t.hasOutputSchema) out.push(F('tool-missing-output-schema', 'tool-no-description', 'tool-description-thin', 'tool-no-parameters', 'warn', `tool "${label}" declares no output.schema`, 'The host validates tool output against output.schema; without one the contract is implicit and a malformed result reaches the caller.', "Add output: { schema: { type: 'json' }, render }."))
+    if (!t.hasOutputSchema) out.push(F('tool-missing-output-schema', 'warn', `tool "${label}" declares no output.schema`, 'The host validates tool output against output.schema; without one the contract is implicit and a malformed result reaches the caller.', "Add output: { schema: { type: 'json' }, render }."))
     if (t.cardKind && typeof t.cardKind === 'object') {
       out.push(F('tool-present-call-throws', 'error', `tool "${label}" presentCall() throws`, `presentCall renders the transcript card and must be total: ${t.cardKind.threw}`, 'Do not read args fields that may be absent.'))
     } else if (typeof t.cardKind === 'string' && !CARD_KINDS.has(t.cardKind)) {
@@ -2471,12 +2468,12 @@ const RULE_ORDER = [
   'client-factory-throws', 'client-no-apply', 'client-apply-throws', 'client-no-registration', 'client-double-load',
   'client-inject-missing-slots', 'client-inject-missing-sidebarRightTabs', 'client-unavailable',
   'no-patch-file', 'no-insert-row', 'insert-missing-name', 'insert-name-mismatch',
-  'patch-name-unresolvable', 'no-name-export', 'no-apply-export', 'no-inject', 'require-in-esm',
+  'patch-name-unresolvable', 'tests-fail', 'tests-timeout', 'tests-not-run', 'no-name-export', 'no-apply-export', 'no-inject', 'require-in-esm',
   'entry-import-failed', 'apply-threw', 'tools-unavailable',
   'inject-missing-tools', 'inject-missing-web', 'inject-missing-webServer', 'inject-missing-timer',
   'inject-unused-service',
   'tool-missing-name', 'tool-duplicate-name', 'tool-missing-execute', 'tool-present-call-throws',
-  'tool-bad-card-kind', 'tool-missing-output-schema', 'tool-none-registered', 'tool-bad-parameter-type', 'tool-undeclared-param', 'tool-input-throws', 'tool-call-throws', 'tool-output-invalid', 'tool-call-slow',
+  'tool-bad-card-kind', 'tool-no-description', 'tool-description-thin', 'tool-no-parameters', 'tool-missing-output-schema', 'tool-none-registered', 'tool-bad-parameter-type', 'tool-undeclared-param', 'tool-input-throws', 'tool-call-throws', 'tool-output-invalid', 'tool-call-slow',
   'lib-debugger', 'lib-console-log', 'lib-hardcoded-path', 'lib-url-pathname', 'node-too-old', 'stale-build', 'hand-edited-build',
   'undeclared-import', 'dep-in-dev-only', 'unused-dependency',
   'pack-omits-lib', 'pack-omits-patch', 'pack-omits-client', 'pack-oversize', 'pack-omits-readme', 'pack-omits-license', 'pack-ships-secret',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bushizhanghan/dsh-publish-gate",
-  "version": "0.14.0",
+  "version": "0.15.0",
   "description": "Pre-publish gate for DSH plugins: manifest, dependencies, artifact, runtime, browser half, traceability and market readiness — plus an input fuzzer that drives every declared parameter with the wrong type. 发布前的七层门禁 + 入参模糊测试。",
   "type": "module",
   "main": "lib/index.js",