@bunbase-ae/js 2.3.1 → 2.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bunbase-ae/js",
-  "version": "2.3.1",
+  "version": "2.4.0",
   "type": "module",
   "description": "TypeScript/JavaScript SDK for BunBase",
   "license": "UNLICENSED",

package/src/storage.ts

@@ -24,6 +24,10 @@ export interface SignedUploadResult {
   url: string;
   key: string;
   expires_in: number;
+  // HMAC-signed token binding this sign call to the caller. S3 provider only
+  // — `null` for local (no confirm step). Required by /storage/confirm so the
+  // server can use server-signed metadata instead of trusting the client.
+  confirm_token: string | null;
 }
 
 export class StorageClient {
@@ -121,7 +125,7 @@ export class StorageClient {
     options: UploadOptions & { expiresIn?: number } = {},
   ): Promise<FileRecord> {
     const filename = file instanceof File ? file.name : `upload-${Date.now()}`;
-    const { url, key } = await this.signedUpload(filename, {
+    const { url, confirm_token } = await this.signedUpload(filename, {
       ...options,
       contentType: file.type || "application/octet-stream",
     });
@@ -146,39 +150,40 @@ export class StorageClient {
     }
 
     // S3 provider: PUT succeeded (200/204) — register metadata with BunBase.
+    // The server uses the HMAC-signed token's fields as the source of truth;
+    // `size`, `collection`, `recordId` are the only body fields still honoured.
+    if (!confirm_token) {
+      throw new BunBaseError(
+        "Missing confirm_token in sign response — server may be running a pre-#231 build.",
+        500,
+        null,
+      );
+    }
     return this.confirmUpload({
-      key,
-      bucket: options.bucket,
-      filename,
+      confirmToken: confirm_token,
       collection: options.collection,
       recordId: options.recordId,
-      isPublic: options.isPublic,
-      mimeType: file.type || "application/octet-stream",
       size: file.size,
     });
   }
 
   // Confirm an S3 presigned upload by registering the file metadata in BunBase.
   // Not needed for local provider (the PUT handler registers metadata automatically).
+  //
+  // `confirmToken` (from the sign response) is required — it carries the
+  // server-signed key / bucket / is_public / mime_type / owner. Body fields
+  // outside `size`, `collection`, `recordId` are ignored by the server.
   async confirmUpload(options: {
-    key: string;
-    bucket?: string;
-    filename?: string;
+    confirmToken: string;
     collection?: string;
     recordId?: string;
-    isPublic?: boolean;
-    mimeType?: string;
     size?: number;
   }): Promise<FileRecord> {
     return this.http.request<FileRecord>("POST", "/api/v1/storage/confirm", {
       body: {
-        key: options.key,
-        bucket: options.bucket,
-        filename: options.filename,
+        confirm_token: options.confirmToken,
         collection: options.collection,
         record_id: options.recordId,
-        is_public: options.isPublic,
-        mime_type: options.mimeType,
         size: options.size,
       },
     });