@bun-native/react 0.33.0 → 0.33.1

package/README.md

@@ -2,4 +2,4 @@
 
 React renderer for Bun Native desktop windows.
 
-Part of [Bun Native](https://github.com/0xPlayerOne/bun-native), an experimental developer preview. Version 0.33.0 was built from [fa8bef754122](https://github.com/0xPlayerOne/bun-native/tree/fa8bef754122621d4235eb06e30bb1085b4f7b1e) and published from GitHub Actions with npm provenance. Use the Bun revision pinned in that commit's toolchain.json. Start with the [getting-started guide](https://github.com/0xPlayerOne/bun-native/blob/fa8bef754122621d4235eb06e30bb1085b4f7b1e/docs/getting-started.md); `bun-native host install` fetches the matching release host. The license notice is in LICENSE.
+Part of [Bun Native](https://github.com/0xPlayerOne/bun-native), an experimental developer preview. Version 0.33.1 was built from [c56fdd675365](https://github.com/0xPlayerOne/bun-native/tree/c56fdd6753653a10144a4167c1d3dfb3c38a0647) and published from GitHub Actions with npm provenance. Use the Bun revision pinned in that commit's toolchain.json. Start with the [getting-started guide](https://github.com/0xPlayerOne/bun-native/blob/c56fdd6753653a10144a4167c1d3dfb3c38a0647/docs/getting-started.md); `bun-native host install` fetches the matching release host. The license notice is in LICENSE.

package/bun-native-source.json

@@ -1,11 +1,11 @@
 {
   "schemaVersion": 1,
-  "commit": "fa8bef754122621d4235eb06e30bb1085b4f7b1e",
-  "tree": "f805e2eb19a4e10fc29d1dc827cf5bc617b5773b",
+  "commit": "c56fdd6753653a10144a4167c1d3dfb3c38a0647",
+  "tree": "c6e81b3f9d041e11dd0413b5fdd7a50910383854",
   "files": {
     "package.json": {
-      "bytes": 2164,
-      "sha256": "db50b6f81f25c113a46f8c9b038bc548a92effaeb4ad9562e5e95044baa7b66f"
+      "bytes": 2115,
+      "sha256": "caf866d56f3cd7530d5735ecbf62512e9e22526bc44c75a4b48a18c26352c0b8"
     },
     "packages/react/package.json": {
       "bytes": 402,
@@ -32,16 +32,16 @@
       "sha256": "4458ba8196591d768d0c7d1a333e47fb2902f44b3e848b9fd7289f68092b8502"
     },
     "packages/react/src/mount.ts": {
-      "bytes": 7530,
-      "sha256": "73b271cb21be8774674a428550cd3cab42c065b6b8286f7c1c914e86fe65addd"
+      "bytes": 7595,
+      "sha256": "259ed7e24ef6f2943c889deadea3c337e627c3633c514a62dd2c1de781c3097f"
     },
     "packages/react/src/reconciler.ts": {
-      "bytes": 9500,
-      "sha256": "f29e9099e177009760406e4164bf8b740715d89bf6bc12b450cb4d575880615a"
+      "bytes": 8349,
+      "sha256": "6036ac4f997f965f0bfbcf73719d6cdf8a59e6706bc9f25e1e3d3db1777e8a6f"
     },
     "packages/react/src/root-errors.ts": {
-      "bytes": 963,
-      "sha256": "2380b9bcc709010f9f09bef444fda47fdda9f64f1fd22d0a4b351069ce09826a"
+      "bytes": 1234,
+      "sha256": "963071b9e1086f551fef172ee6d53a78d07aeaa674f6d3bf746f8774fabfe780"
     },
     "LICENSE": {
       "bytes": 1075,
@@ -49,8 +49,8 @@
     }
   },
   "toolchain": {
-    "bytes": 3012,
-    "sha256": "00c3f707aae8abe9ca75cd2e162f5e1c7c34362a03675da39afead60d856066a"
+    "bytes": 3234,
+    "sha256": "9f4d9362cb4cc38c0f4e705295789a0cbfec46ffdd007e0541b9441a7c3003a7"
   },
   "dependencyLock": {
     "bytes": 28357,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bun-native/react",
-  "version": "0.33.0",
+  "version": "0.33.1",
   "type": "module",
   "license": "MIT",
   "files": [
@@ -19,13 +19,15 @@
   },
   "description": "React renderer for Bun Native desktop windows.",
   "dependencies": {
-    "@bun-native/core": "0.33.0",
-    "@bun-native/renderer": "0.33.0",
-    "react": "19.3.1",
+    "@bun-native/core": "0.33.1",
+    "@bun-native/renderer": "0.33.1",
     "react-reconciler": "0.34.0",
-    "@types/react": "19.3.0",
     "@types/react-reconciler": "0.34.1"
   },
+  "peerDependencies": {
+    "react": "19.3.1",
+    "@types/react": "19.3.0"
+  },
   "repository": {
     "type": "git",
     "url": "git+https://github.com/0xPlayerOne/bun-native.git",

package/src/mount.ts

@@ -2,7 +2,7 @@ import { NativeStateError, type NativeWindow, type Style } from '@bun-native/cor
 import { createRenderRoot, type RenderOptions, type RenderRoot } from '@bun-native/renderer'
 import type { ErrorInfo, ReactNode } from 'react'
 import { ConcurrentRoot } from 'react-reconciler/constants'
-import { reconciler } from './reconciler.ts'
+import { dispatchDiscrete, reconciler } from './reconciler.ts'
 import { createRootErrors } from './root-errors.ts'
 import { createCommitBarrier } from './commit-barrier.ts'
 
@@ -57,7 +57,7 @@ class Root implements ReactRenderRoot {
           this.errors.uncaught,
           this.errors.caught,
           this.errors.recoverable,
-          this.errors.transition,
+          this.errors.transitionIndicator,
           null
         )
         onCleanup(() => {
@@ -82,7 +82,8 @@ class Root implements ReactRenderRoot {
         if (this.failure !== undefined) throw this.failure
         reconciler.flushPassiveEffects()
       },
-      style === undefined ? {} : { style }
+      style === undefined ? {} : { style },
+      { dispatch: dispatchDiscrete }
     )
     this.ready = this.native.ready.then(() => {
       if (this.phase !== 'active')

package/src/reconciler.ts

@@ -8,7 +8,6 @@ import {
   replaceText,
   setProperty,
   type ElementTag,
-  type EventProperty,
   type Node,
   type PropertyName,
   type RendererNode,
@@ -48,11 +47,6 @@ type Config = Reconciler.HostConfig<
 const context: HostContext = Object.freeze({})
 let updatePriority: Reconciler.EventPriority = NoEventPriority
 let activeEvent: { type: string; observedAt: number } | undefined
-type EventBinding = {
-  listener: Listener<NativeUIEvent> | undefined
-  dispatch: Listener<NativeUIEvent>
-}
-const bindings = new WeakMap<Node, Map<EventProperty, EventBinding>>()
 
 function unsupported(feature: string): never {
   throw new UnsupportedFeatureError('react-' + feature)
@@ -65,52 +59,30 @@ const noInstance = () => null
 const returnFalse = () => false
 const hostContext = () => context
 
-function createBinding(listener: Listener<NativeUIEvent>): EventBinding {
-  const binding: EventBinding = { listener, dispatch }
-  function dispatch(event: NativeUIEvent): void | Promise<void> {
-    const current = binding.listener
-    if (!current) return
-    const previous = activeEvent
-    activeEvent = { type: event.type, observedAt: performance.now() }
-    try {
-      return reconciler.discreteUpdates(current, event, undefined, undefined, undefined)
-    } finally {
-      activeEvent = previous
-      reconciler.flushSyncWork()
-    }
-  }
-  return binding
-}
-
-function updateEvent(node: Node, name: EventProperty, value: unknown): void {
-  const registered = bindings.get(node)
-  const existing = registered?.get(name)
-  if (value === undefined) {
-    if (existing) existing.listener = undefined
-    registered?.delete(name)
-    setProperty(node, name, undefined)
-    return
-  }
-  if (typeof value !== 'function') throw new TypeError('Native event listeners must be functions')
-  // The callable boundary is checked here; core supplies the validated event.
-  const listener = value as Listener<NativeUIEvent>
-  if (existing) {
-    // React replaces inline closures on ordinary rerenders. Keep the node's
-    // native type/phase registration alive so queued events retain their ordering.
-    existing.listener = listener
-    return
+/**
+ * Run a native callback as a discrete React update. The shared renderer keeps
+ * one registration per node/type/phase and calls the latest committed handler,
+ * so inline closures replaced on ordinary rerenders keep queued events.
+ */
+export function dispatchDiscrete(
+  listener: Listener<NativeUIEvent>,
+  event: NativeUIEvent
+): void | Promise<void> {
+  const previous = activeEvent
+  activeEvent = { type: event.type, observedAt: performance.now() }
+  try {
+    return reconciler.discreteUpdates(listener, event, undefined, undefined, undefined)
+  } finally {
+    activeEvent = previous
+    reconciler.flushSyncWork()
   }
-  const binding = createBinding(listener)
-  setProperty(node, name, binding.dispatch)
-  const next = registered ?? new Map<EventProperty, EventBinding>()
-  next.set(name, binding)
-  bindings.set(node, next)
 }
 
 function updateProperty(node: Node, name: string, value: unknown): void {
-  if (isEventProperty(name)) updateEvent(node, name, value)
+  if (isEventProperty(name) && value !== undefined && typeof value !== 'function')
+    throw new TypeError('Native event listeners must be functions')
   // React props arrive as strings; the renderer rejects unknown names at runtime.
-  else setProperty(node, name as PropertyName, value)
+  setProperty(node, name as PropertyName, value)
 }
 
 const reserved = (name: string) => name === 'children' || name === 'ref' || name === 'key'
@@ -200,8 +172,6 @@ const host: Config = {
   prepareScopeUpdate: unsupported.bind(null, 'scope'),
   getInstanceFromScope: noInstance,
   detachDeletedInstance(node) {
-    for (const binding of bindings.get(node)?.values() ?? []) binding.listener = undefined
-    bindings.delete(node)
     node.children.length = 0
     node.parent = undefined
     for (const name of Object.keys(node.properties)) {

package/src/root-errors.ts

@@ -6,16 +6,21 @@ export interface RootErrorOwner {
   report: ((error: unknown, info: Readonly<ErrorInfo>) => void) | undefined
 }
 
-function ignore(): void {}
-
 /** Created outside the Root constructor so callback scopes cannot capture its arguments. */
 export function createRootErrors(owner: RootErrorOwner) {
   return {
     uncaught(error: unknown): void {
       owner.terminate?.(error)
     },
-    caught: ignore,
-    transition: ignore,
+    /**
+     * An error a boundary handled is logged like React DOM's default instead
+     * of disappearing; it does not end the root.
+     */
+    caught(error: unknown): void {
+      if (owner.terminate) console.error(error)
+    },
+    /** React's default transition indicator: native views show none. */
+    transitionIndicator(): void {},
     recoverable(error: unknown, info: ErrorInfo): void {
       const report = owner.report
       if (!report) return