@builttocreate/engine-utils 1.9.5 → 1.10.0-rc1

package/dist/activityHelper.js

@@ -87,7 +87,6 @@ var addDocumentDataToActivities = function addDocumentDataToActivities(activitie
   }
 
   var fieldValues = doc && doc.fields ? doc.fields : null;
-  var fieldSettings = doc && doc.fieldSettings ? doc.fieldSettings : {};
   if (!activities || activities.length < 1 || !templateFieldLookup || !fieldValues) return activities;
   var fieldRowsLookup = {};
   var fieldRowIndexLookup = {};
@@ -95,7 +94,7 @@ var addDocumentDataToActivities = function addDocumentDataToActivities(activitie
   activities.forEach(function (activity) {
     var nextActivity = _objectSpread({}, activity);
 
-    if (activity.document && activity.document.field) {
+    if (activity.document && activity.document._id && activity.document.field) {
       var docFieldValue = fieldValues[activity.document.field];
       var templateField = templateFieldLookup[activity.document.field];
       nextActivity.document.title = templateField.title;
@@ -130,7 +129,7 @@ var addDocumentDataToActivities = function addDocumentDataToActivities(activitie
 
 
         if (!fieldRowIndexLookup[templateField._id]) {
-          fieldRowIndexLookup[templateField._id] = (0, _tableHelper.getRowIndexLookup)(templateField._id, fieldSettings, docFieldValue);
+          fieldRowIndexLookup[templateField._id] = (0, _tableHelper.getRowIndexLookup)(templateField._id, template.fieldSettings, docFieldValue);
         }
         /**
          * Table Step 3: Add row and rowIndex to the activity.document object for easy reference.
@@ -139,10 +138,8 @@ var addDocumentDataToActivities = function addDocumentDataToActivities(activitie
          */
 
 
-        if (fieldRowsLookup[activity.document.field] && fieldRowIndexLookup[activity.document.field]) {
-          nextActivity.document.value = fieldRowsLookup[activity.document.field][activity.document.row];
-          nextActivity.document.rowIndex = fieldRowIndexLookup[activity.document.field][activity.document.row];
-        }
+        nextActivity.document.value = fieldRowsLookup[activity.document.field][activity.document.row];
+        nextActivity.document.rowIndex = fieldRowIndexLookup[activity.document.field][activity.document.row];
       } else if (docFieldValue && templateField.type === _FieldTypes["default"].inputGroup) {
         /**
          * Input Group Step 1: create an easy way to lookup a row with the dropdown cells populated.
@@ -156,9 +153,7 @@ var addDocumentDataToActivities = function addDocumentDataToActivities(activitie
          * whole row because input group display components are treated like regular field and not like table rows.
          */
 
-        if (fieldRowsLookup[activity.document.field] && fieldRowsLookup[activity.document.field][activity.document.row] && fieldRowsLookup[activity.document.field][activity.document.row].cells[activity.document.column]) {
-          nextActivity.document.value = fieldRowsLookup[activity.document.field][activity.document.row].cells[activity.document.column];
-        }
+        nextActivity.document.value = fieldRowsLookup[activity.document.field][activity.document.row].cells[activity.document.column];
       } else if (docFieldValue && templateField.type === _FieldTypes["default"].multiSelect) {
         var parsedDocFieldValue = docFieldValue && typeof docFieldValue === 'string' ? docFieldValue.split(',') : docFieldValue;
         var _nextDocFieldValue = '';
@@ -166,8 +161,7 @@ var addDocumentDataToActivities = function addDocumentDataToActivities(activitie
         if (parsedDocFieldValue.length > 0) {
           parsedDocFieldValue.forEach(function (item) {
             var option = templateField.optionsLookup[item];
-            if (!option) return;
-            _nextDocFieldValue = _nextDocFieldValue.concat(option.value, ', ');
+            _nextDocFieldValue = _nextDocFieldValue.concat(' ', option.value);
           });
         }
 

package/dist/tableHelper.js

@@ -15,8 +15,6 @@ var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers
 
 var _shortid = _interopRequireDefault(require("shortid"));
 
-var _moment = _interopRequireDefault(require("moment"));
-
 var _hotFormulaParser = require("@builttocreate/hot-formula-parser");
 
 var _Table = _interopRequireWildcard(require("./constants/Table"));
@@ -41,7 +39,7 @@ exports.getTableFieldLookupKey = getTableFieldLookupKey;
 
 var getDefaultRow = function getDefaultRow() {
   return {
-    _id: "".concat(_shortid["default"].generate()).concat((0, _moment["default"])().valueOf()),
+    _id: _shortid["default"].generate(),
     deleted: false,
     cells: {}
   };
@@ -100,17 +98,6 @@ var getFilteredRowOrder = function getFilteredRowOrder(rowOrder, rows, filters)
       return row._id;
     });
   }
-  /**
-   * Remove any duplicate rowIds. We have had instances where
-   * users encounter duplicate rowIds in the rowOrder.
-   * See: https://github.com/zionlabs/Issues/issues/1589
-   */
-
-
-  var cleanedValidRowOrder = [];
-  validRowOrder.forEach(function (rowId) {
-    if (cleanedValidRowOrder.indexOf(rowId) === -1) cleanedValidRowOrder.push(rowId);
-  });
 
   if (filteredColumnIds.length > 0) {
     var matchedRows = {};
@@ -124,11 +111,11 @@ var getFilteredRowOrder = function getFilteredRowOrder(rowOrder, rows, filters)
       });
       if (rowMatched) matchedRows[row._id] = true;
     });
-    return cleanedValidRowOrder.filter(function (rowId) {
+    return validRowOrder.filter(function (rowId) {
       return matchedRows[rowId];
     });
   } else {
-    return cleanedValidRowOrder;
+    return validRowOrder;
   }
 };
 /**
@@ -670,7 +657,7 @@ var generateInputGroupFields = function generateInputGroupFields(field, columns)
     activity.forEach(function (act) {
       var rowId = act.document.row;
       var columnId = act.document.column;
-      var cellKey = "".concat(field._id).concat(rowId).concat(columnId);
+      var cellKey = "".concat(field._id, "-").concat(rowId, "-").concat(columnId);
       if (!cellActivityLookup[cellKey]) cellActivityLookup[cellKey] = 0;
       cellActivityLookup[cellKey] += 1;
     });
@@ -684,7 +671,7 @@ var generateInputGroupFields = function generateInputGroupFields(field, columns)
      */
 
     tableReferences.push({
-      uniqueId: "".concat(field._id).concat(row._id),
+      uniqueId: "".concat(field._id, "-").concat(row._id),
       _id: field._id,
       title: field.title,
       type: _Table.inputGroupFieldTypes.inputGroupRowHeader,
@@ -703,7 +690,7 @@ var generateInputGroupFields = function generateInputGroupFields(field, columns)
       var lastColumnIndex = columnIndex === tableColumns.length - 1;
       var value = row && row.cells ? row.cells[column._id] : '';
       var displayValue = column.type === _FieldTableColumnTypes["default"].dropdown ? columnOptionValueLookup[column._id][value] : value;
-      var cellKey = "".concat(field._id).concat(row._id).concat(column._id);
+      var cellKey = "".concat(field._id, "-").concat(row._id, "-").concat(column._id);
       tableReferences.push({
         uniqueId: cellKey,
         _id: field._id,
@@ -781,7 +768,7 @@ exports.getTableRowLookupWithPopulatedDropdownCells = getTableRowLookupWithPopul
 
 var getInputGroupRowLookupWithPopulatedDropdownCells = function getInputGroupRowLookupWithPopulatedDropdownCells(columns, rows) {
   var rowsLookup = {};
-  var validRows = typeof rows === 'string' ? JSON.parse(rows) : rows;
+  var validRows = typeof row === 'string' ? JSON.parse(rows) : rows;
   validRows.forEach(function (row) {
     var nextRow = _objectSpread(_objectSpread({}, row), {}, {
       cells: _objectSpread({}, row.cells)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@builttocreate/engine-utils",
-  "version": "1.9.5",
+  "version": "1.10.0-rc1",
   "description": "Utility library for common logic shared across web and mobile",
   "main": "dist/index.js",
   "files": [
@@ -46,7 +46,6 @@
   "dependencies": {
     "@babel/polyfill": "^7.12.1",
     "@builttocreate/hot-formula-parser": "4.0.1",
-    "moment": "^2.29.1",
     "shortid": "^2.2.16"
   },
   "jest": {