@buildonspark/spark-sdk 0.2.5 → 0.2.6

package/src/tests/integration/ssp/static_deposit.test.ts

@@ -1,175 +1,482 @@
-import { describe, expect, it } from "@jest/globals";
-import { SparkWalletTesting } from "../../utils/spark-testing-wallet.js";
+import {
+  SparkWalletTesting,
+  initWallet,
+} from "../../utils/spark-testing-wallet.js";
+import { bytesToHex } from "@noble/hashes/utils";
 import { BitcoinFaucet } from "../../utils/test-faucet.js";
+import { ValidationError } from "../../../errors/types.js";
 
-const DEPOSIT_AMOUNT = 10000n;
+const SMALL_DEPOSIT_AMOUNT = 10n;
+export const DEPOSIT_AMOUNT = 10000n;
 const SECOND_DEPOSIT_AMOUNT = 20000n;
 const THIRD_DEPOSIT_AMOUNT = 30000n;
 
 describe("SSP static deposit address integration", () => {
-  it("should claim deposits to a static deposit address", async () => {
-    const faucet = BitcoinFaucet.getInstance();
+  describe("Happy path testing", () => {
+    it("should claim deposits to a static deposit address", async () => {
+      const faucet = BitcoinFaucet.getInstance();
+      const { wallet: userWallet } = await SparkWalletTesting.initialize(
+        {
+          options: {
+            network: "LOCAL",
+          },
+        },
+        false,
+      );
+
+      const depositAddress = await userWallet.getStaticDepositAddress();
+      expect(depositAddress).toBeDefined();
+      const signedTx = await faucet.sendToAddress(
+        depositAddress,
+        DEPOSIT_AMOUNT,
+      );
+
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
+      expect(signedTx).toBeDefined();
+      const transactionId = signedTx.id;
+      let vout;
+      for (let i = 0; i < signedTx.outputsLength; i++) {
+        const output = signedTx.getOutput(i);
+        if (output.amount === DEPOSIT_AMOUNT) {
+          vout = i;
+          break;
+        }
+      }
 
-    const { wallet: userWallet } = await SparkWalletTesting.initialize(
-      {
-        options: {
-          network: "LOCAL",
+      const quote = await userWallet.getClaimStaticDepositQuote(
+        transactionId,
+        vout!,
+      );
+
+      await new Promise((resolve) => setTimeout(resolve, 1000));
+
+      const quoteAmount = quote!.creditAmountSats;
+      const sspSignature = quote!.signature;
+
+      await userWallet.claimStaticDeposit({
+        transactionId,
+        creditAmountSats: quoteAmount,
+        sspSignature,
+        outputIndex: vout!,
+      });
+      await new Promise((resolve) => setTimeout(resolve, 1000));
+      const { balance } = await userWallet.getBalance();
+      expect(balance).toBe(BigInt(quoteAmount));
+
+      // Test depositing money to the same address and second time and claiming.
+      const signedTx2 = await faucet.sendToAddress(
+        depositAddress,
+        SECOND_DEPOSIT_AMOUNT,
+      );
+      const transactionId2 = signedTx2.id;
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
+      // Test claiming and getting the quote without passing in the output index.
+      const quote2 =
+        await userWallet.getClaimStaticDepositQuote(transactionId2);
+      const quoteAmount2 = quote2!.creditAmountSats;
+      const sspSignature2 = quote2!.signature;
+      await userWallet.claimStaticDeposit({
+        transactionId: transactionId2,
+        creditAmountSats: quoteAmount2,
+        sspSignature: sspSignature2,
+      });
+      await new Promise((resolve) => setTimeout(resolve, 1000));
+      const { balance: balance2 } = await userWallet.getBalance();
+      expect(balance2).toBe(BigInt(quoteAmount + quoteAmount2));
+
+      // Test depositing money to the same address and test claim with max fee flow.
+      const signedTx3 = await faucet.sendToAddress(
+        depositAddress,
+        THIRD_DEPOSIT_AMOUNT,
+      );
+      const transactionId3 = signedTx3.id;
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
+      // Get quote so we can calculate the expected balance. Not needed for actual flow.
+      const quote3 =
+        await userWallet.getClaimStaticDepositQuote(transactionId3);
+      const quoteAmount3 = quote3!.creditAmountSats;
+      await userWallet.claimStaticDepositWithMaxFee({
+        transactionId: transactionId3,
+        maxFee: 1000,
+      });
+      await new Promise((resolve) => setTimeout(resolve, 1000));
+      const { balance: balance3 } = await userWallet.getBalance();
+      expect(balance3).toBe(BigInt(quoteAmount + quoteAmount2 + quoteAmount3));
+      // Get transfers should include static deposit transfers.
+      const transfers = await userWallet.getTransfers();
+      expect(transfers.transfers.length).toBe(3);
+    }, 60000);
+
+    it("should create a refund transaction", async () => {
+      const faucet = BitcoinFaucet.getInstance();
+
+      const { wallet: userWallet } = await SparkWalletTesting.initialize(
+        {
+          options: {
+            network: "LOCAL",
+          },
         },
-      },
-      false,
-    );
+        false,
+      );
 
-    const depositAddress = await userWallet.getStaticDepositAddress();
-    expect(depositAddress).toBeDefined();
+      const depositAddress = await userWallet.getStaticDepositAddress();
+      expect(depositAddress).toBeDefined();
 
-    const signedTx = await faucet.sendToAddress(depositAddress, DEPOSIT_AMOUNT);
+      const signedTx = await faucet.sendToAddress(
+        depositAddress,
+        DEPOSIT_AMOUNT,
+      );
 
-    // Wait for the transaction to be mined
-    await faucet.mineBlocks(6);
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
 
-    expect(signedTx).toBeDefined();
+      expect(signedTx).toBeDefined();
 
-    const transactionId = signedTx.id;
+      const transactionId = signedTx.id;
 
-    let vout;
+      let vout: number | undefined;
 
-    for (let i = 0; i < signedTx.outputsLength; i++) {
-      const output = signedTx.getOutput(i);
-      if (output.amount === DEPOSIT_AMOUNT) {
-        vout = i;
-        break;
+      for (let i = 0; i < signedTx.outputsLength; i++) {
+        const output = signedTx.getOutput(i);
+        if (output.amount === DEPOSIT_AMOUNT) {
+          vout = i;
+          break;
+        }
       }
-    }
-
-    const quote = await userWallet.getClaimStaticDepositQuote(
-      transactionId,
-      vout!,
-    );
-
-    const quoteAmount = quote!.creditAmountSats;
-    const sspSignature = quote!.signature;
-
-    await userWallet.claimStaticDeposit({
-      transactionId,
-      creditAmountSats: quoteAmount,
-      sspSignature,
-      outputIndex: vout!,
-    });
 
-    await new Promise((resolve) => setTimeout(resolve, 1000));
+      const refundAddress = await faucet.getNewAddress();
+
+      const refundTx = await userWallet.refundStaticDeposit({
+        depositTransactionId: transactionId,
+        destinationAddress: refundAddress,
+        satsPerVbyteFee: 2,
+      });
+
+      expect(refundTx).toBeDefined();
+
+      // Calling it again should create a new transaction.
+      const refundTx2 = await userWallet.refundStaticDeposit({
+        depositTransactionId: transactionId,
+        destinationAddress: refundAddress,
+        outputIndex: vout!,
+        satsPerVbyteFee: 2,
+      });
+
+      expect(refundTx2).toBeDefined();
+
+      expect(refundTx).not.toBe(refundTx2);
+    }, 60000);
+  });
+
+  describe("Quote unhappy path testing", () => {
+    it("should error claim quote from a different wallet", async () => {
+      const { wallet: aliceWallet } = await SparkWalletTesting.initialize(
+        {
+          options: {
+            network: "LOCAL",
+          },
+        },
+        false,
+      );
+
+      const { wallet: bobWallet } = await SparkWalletTesting.initialize(
+        {
+          options: {
+            network: "LOCAL",
+          },
+        },
+        false,
+      );
 
-    const { balance } = await userWallet.getBalance();
-    expect(balance).toBe(BigInt(quoteAmount));
+      const faucet = BitcoinFaucet.getInstance();
 
-    // Test depositing money to the same address and second time and claiming.
-    const signedTx2 = await faucet.sendToAddress(
-      depositAddress,
-      SECOND_DEPOSIT_AMOUNT,
-    );
-    const transactionId2 = signedTx2.id;
-    // Wait for the transaction to be mined
-    await faucet.mineBlocks(6);
+      const depositAddress = await aliceWallet.getStaticDepositAddress();
+      expect(depositAddress).toBeDefined();
 
-    // Test claiming and getting the quote without passing in the output index.
-    const quote2 = await userWallet.getClaimStaticDepositQuote(transactionId2);
+      const signedTx = await faucet.sendToAddress(
+        depositAddress,
+        DEPOSIT_AMOUNT,
+      );
 
-    const quoteAmount2 = quote2!.creditAmountSats;
-    const sspSignature2 = quote2!.signature;
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
 
-    await userWallet.claimStaticDeposit({
-      transactionId: transactionId2,
-      creditAmountSats: quoteAmount2,
-      sspSignature: sspSignature2,
-    });
+      expect(signedTx).toBeDefined();
 
-    await new Promise((resolve) => setTimeout(resolve, 1000));
+      const transactionId = signedTx.id;
 
-    const { balance: balance2 } = await userWallet.getBalance();
-    expect(balance2).toBe(BigInt(quoteAmount + quoteAmount2));
+      await expect(
+        bobWallet.getClaimStaticDepositQuote(transactionId),
+      ).rejects.toThrow();
+    }, 60000);
 
-    // Test depositing money to the same address and test claim with max fee flow.
-    const signedTx3 = await faucet.sendToAddress(
-      depositAddress,
-      THIRD_DEPOSIT_AMOUNT,
-    );
-    const transactionId3 = signedTx3.id;
-    // Wait for the transaction to be mined
-    await faucet.mineBlocks(6);
+    it("should error if txid does not exist", async () => {
+      const { wallet: aliceWallet } = await SparkWalletTesting.initialize(
+        {
+          options: {
+            network: "LOCAL",
+          },
+        },
+        false,
+      );
 
-    // Get quote so we can calculate the expected balance. Not needed for actual flow.
-    const quote3 = await userWallet.getClaimStaticDepositQuote(transactionId3);
+      const faucet = BitcoinFaucet.getInstance();
 
-    const quoteAmount3 = quote3!.creditAmountSats;
+      const depositAddress = await aliceWallet.getStaticDepositAddress();
+      expect(depositAddress).toBeDefined();
 
-    await userWallet.claimStaticDepositWithMaxFee({
-      transactionId: transactionId3,
-      maxFee: 1000,
-    });
+      const signedTx = await faucet.sendToAddress(
+        depositAddress,
+        DEPOSIT_AMOUNT,
+      );
 
-    await new Promise((resolve) => setTimeout(resolve, 1000));
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
 
-    const { balance: balance3 } = await userWallet.getBalance();
-    expect(balance3).toBe(BigInt(quoteAmount + quoteAmount2 + quoteAmount3));
+      expect(signedTx).toBeDefined();
 
-    // Get transfers should include static deposit transfers.
-    const transfers = await userWallet.getTransfers();
-    expect(transfers.transfers.length).toBe(3);
-  }, 60000);
+      const transactionId = signedTx.id;
 
-  it("should create a refund transaction", async () => {
-    const faucet = BitcoinFaucet.getInstance();
+      await expect(
+        aliceWallet.getClaimStaticDepositQuote(
+          `${transactionId.slice(0, -6)}abcdef`,
+        ),
+      ).rejects.toThrow();
+    });
 
-    const { wallet: userWallet } = await SparkWalletTesting.initialize(
-      {
-        options: {
-          network: "LOCAL",
+    it("should error if tx amount does not cover fees", async () => {
+      const { wallet: aliceWallet } = await SparkWalletTesting.initialize(
+        {
+          options: {
+            network: "LOCAL",
+          },
         },
-      },
-      false,
-    );
-
-    const depositAddress = await userWallet.getStaticDepositAddress();
-    expect(depositAddress).toBeDefined();
-
-    const signedTx = await faucet.sendToAddress(depositAddress, DEPOSIT_AMOUNT);
-
-    // Wait for the transaction to be mined
-    await faucet.mineBlocks(6);
-
-    expect(signedTx).toBeDefined();
+        false,
+      );
 
-    const transactionId = signedTx.id;
+      const faucet = BitcoinFaucet.getInstance();
 
-    let vout: number | undefined;
+      const depositAddress = await aliceWallet.getStaticDepositAddress();
+      expect(depositAddress).toBeDefined();
 
-    for (let i = 0; i < signedTx.outputsLength; i++) {
-      const output = signedTx.getOutput(i);
-      if (output.amount === DEPOSIT_AMOUNT) {
-        vout = i;
-        break;
-      }
-    }
+      const signedTx = await faucet.sendToAddress(
+        depositAddress,
+        SMALL_DEPOSIT_AMOUNT,
+      );
 
-    const refundAddress = await faucet.getNewAddress();
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
 
-    const refundTx = await userWallet.refundStaticDeposit({
-      depositTransactionId: transactionId,
-      destinationAddress: refundAddress,
-      satsPerVbyteFee: 2,
-    });
+      expect(signedTx).toBeDefined();
 
-    expect(refundTx).toBeDefined();
+      const transactionId = signedTx.id;
 
-    // Calling it again should create a new transaction.
-    const refundTx2 = await userWallet.refundStaticDeposit({
-      depositTransactionId: transactionId,
-      destinationAddress: refundAddress,
-      outputIndex: vout!,
-      satsPerVbyteFee: 2,
-    });
+      await expect(
+        aliceWallet.getClaimStaticDepositQuote(transactionId),
+      ).rejects.toThrow();
+    }, 60000);
 
-    expect(refundTx2).toBeDefined();
-
-    expect(refundTx).not.toBe(refundTx2);
-  }, 60000);
+    it("should error claim quote if tx already claimed", async () => {
+      const { wallet: aliceWallet } = await SparkWalletTesting.initialize(
+        {
+          options: {
+            network: "LOCAL",
+          },
+        },
+        false,
+      );
+
+      const faucet = BitcoinFaucet.getInstance();
+
+      const depositAddress = await aliceWallet.getStaticDepositAddress();
+      expect(depositAddress).toBeDefined();
+
+      const signedTx = await faucet.sendToAddress(
+        depositAddress,
+        DEPOSIT_AMOUNT,
+      );
+
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
+
+      expect(signedTx).toBeDefined();
+
+      const transactionId = signedTx.id;
+
+      const quote = await aliceWallet.getClaimStaticDepositQuote(transactionId);
+
+      await aliceWallet.claimStaticDeposit({
+        transactionId: transactionId,
+        creditAmountSats: quote.creditAmountSats,
+        sspSignature: quote.signature,
+      });
+      await new Promise((resolve) => setTimeout(resolve, 40000));
+
+      const { balance } = await aliceWallet.getBalance();
+
+      expect(balance).toBe(BigInt(quote.creditAmountSats));
+
+      await expect(
+        aliceWallet.getClaimStaticDepositQuote(transactionId),
+      ).rejects.toThrow();
+    }, 60000);
+  });
+
+  describe("Claim unhappy path testing", () => {
+    it("should reject claim with fake SSP signature", async () => {
+      console.log("Initializing wallet for fake SSP signature test...");
+      const {
+        wallet: userWallet,
+        signedTx,
+        vout,
+        faucet,
+      } = await initWallet(DEPOSIT_AMOUNT, "LOCAL");
+
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
+
+      const transactionId = signedTx.id;
+
+      console.log("Fetching claim quote for static deposit...");
+      const quote = await userWallet.getClaimStaticDepositQuote(
+        transactionId,
+        vout!,
+      );
+
+      await new Promise((resolve) => setTimeout(resolve, 10000));
+
+      const quoteAmount = quote!.creditAmountSats;
+
+      // Generate a fake signature (64 bytes of random data to simulate a signature)
+      const fakeSignature = new Uint8Array(64);
+      crypto.getRandomValues(fakeSignature);
+      console.log("Expecting error when claiming with fake signature...");
+      await expect(
+        userWallet.claimStaticDeposit({
+          transactionId,
+          creditAmountSats: quoteAmount,
+          sspSignature: bytesToHex(fakeSignature),
+          outputIndex: vout!,
+        }),
+      ).rejects.toThrow(
+        'Request ClaimStaticDeposit failed. [{"message":"Something went wrong."',
+      );
+    }, 600000);
+
+    it("should reject claiming the same deposit twice", async () => {
+      console.log("Initializing wallet for double-claim test...");
+      const {
+        wallet: userWallet,
+        signedTx,
+        vout,
+        faucet,
+      } = await initWallet(DEPOSIT_AMOUNT, "LOCAL");
+
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
+
+      const transactionId = signedTx.id;
+
+      console.log("Fetching claim quote for static deposit...");
+      const quote = await userWallet.getClaimStaticDepositQuote(
+        transactionId,
+        vout!,
+      );
+
+      await new Promise((resolve) => setTimeout(resolve, 10000));
+
+      const quoteAmount = quote!.creditAmountSats;
+      const sspSignature = quote!.signature;
+
+      console.log("Attempting to claim static deposit for the first time...");
+      const outputs = await userWallet.claimStaticDeposit({
+        transactionId,
+        creditAmountSats: quoteAmount,
+        sspSignature,
+        outputIndex: vout!,
+      });
+
+      await new Promise((resolve) => setTimeout(resolve, 30000));
+
+      expect(outputs).toBeDefined();
+
+      console.log(
+        "Expecting error when attempting to claim the same deposit twice...",
+      );
+      await expect(
+        userWallet.claimStaticDeposit({
+          transactionId,
+          creditAmountSats: quoteAmount,
+          sspSignature,
+          outputIndex: vout!,
+        }),
+      ).rejects.toThrow("UTXO is spent or not found.");
+    }, 600000);
+
+    it("Claim, then try to refund.", async () => {
+      console.log("Initializing wallet for claim and refund test...");
+      const {
+        wallet: userWallet,
+        depositAddress,
+        signedTx,
+        vout,
+        faucet,
+      } = await initWallet(DEPOSIT_AMOUNT, "LOCAL");
+
+      // Wait for the transaction to be mined
+      await faucet.mineBlocks(6);
+
+      expect(signedTx).toBeDefined();
+
+      const transactionId = signedTx.id;
+
+      const quote = await userWallet.getClaimStaticDepositQuote(
+        transactionId,
+        vout!,
+      );
+
+      const quoteAmount = quote!.creditAmountSats;
+      const sspSignature = quote!.signature;
+
+      console.log("Attempting to claim static deposit...");
+      await userWallet.claimStaticDeposit({
+        transactionId,
+        creditAmountSats: quoteAmount,
+        sspSignature,
+        outputIndex: vout!,
+      });
+
+      await new Promise((resolve) => setTimeout(resolve, 30000));
+
+      console.log("Fetching wallet balance after claim...");
+      const { balance } = await userWallet.getBalance();
+      expect(balance).toBe(BigInt(quoteAmount));
+
+      console.log(`Alice balance: ${balance}`);
+
+      console.log("Initiating transfer to Spark address...");
+      const sparkAddress = await userWallet.getSparkAddress();
+      const transfer = await userWallet.transfer({
+        amountSats: Number(balance),
+        receiverSparkAddress: sparkAddress,
+      });
+
+      expect(transfer).toBeDefined();
+
+      await new Promise((resolve) => setTimeout(resolve, 1000));
+
+      // Try to refund the deposit after claiming and transfer
+      console.log("Attempting refund of claimed deposit...");
+      await expect(
+        userWallet.refundStaticDeposit({
+          depositTransactionId: transactionId,
+          destinationAddress: depositAddress,
+          fee: 301,
+        }),
+      ).rejects.toThrow();
+    }, 600000);
+  });
 });

package/src/tests/integration/ssp/transfers.test.ts

@@ -7,7 +7,7 @@ const DEPOSIT_AMOUNT = 10000n;
 const SECOND_DEPOSIT_AMOUNT = 20000n;
 
 describe("SSP Transfers Test", () => {
-  it("getTransfers should return the corresponding ssp request if it exists", async () => {
+  it("getTransfers and getTransfer should return the corresponding ssp request if it exists", async () => {
     const faucet = BitcoinFaucet.getInstance();
 
     const { wallet: userWallet } = await SparkWalletTesting.initialize(
@@ -75,7 +75,6 @@ describe("SSP Transfers Test", () => {
       receiverSparkAddress: await userWallet2.getSparkAddress(),
     });
 
-    // Get transfers should include static deposit transfers.
     const transfers = await userWallet.getTransfers();
     expect(transfers.transfers.length).toBe(2);
 
@@ -86,6 +85,9 @@ describe("SSP Transfers Test", () => {
       transferTypeToJSON(TransferType.TRANSFER),
     );
 
+    const sparkTransfer = await userWallet.getTransfer(firstTransfer!.id);
+    expect(sparkTransfer?.userRequest).not.toBeDefined();
+
     const secondTransfer = transfers.transfers[1];
     expect(secondTransfer).toBeDefined();
     expect(secondTransfer?.userRequest).toBeDefined();
@@ -93,5 +95,8 @@ describe("SSP Transfers Test", () => {
       transferTypeToJSON(TransferType.UTXO_SWAP),
     );
     expect(secondTransfer?.userRequest?.typename).toBe("ClaimStaticDeposit");
+
+    const utxoSwapTransfer = await userWallet.getTransfer(secondTransfer!.id);
+    expect(utxoSwapTransfer?.userRequest).toBeDefined();
   }, 60000);
 });