@buildinternet/uploads 0.52.0 → 0.52.1

package/dist/commands.js

@@ -655,7 +655,7 @@ export async function syncAttachmentsComment(client, target, run, workspace, opt
         target: { kind: target.kind, num: target.num },
     });
     const prefixes = ghListPrefixes(ghKeyPrefix(target), ghPrefix, (id) => ghPrivateKeyPrefix(id, target));
-    const items = await ghMergedList(prefixes, undefined, async (prefix) => (await client.listAll({ prefix, metadata: true })).map(({ key, url, embedUrl, pageUrl, metadata }) => {
+    const items = await ghMergedList(prefixes, undefined, async (prefix) => (await client.listAll({ prefix, metadata: true })).map(({ key, url, embedUrl, pageUrl, size, metadata }) => {
         // The list endpoint returns every metadata key; the comment
         // renders only these two. Narrowing here keeps both render paths
         // byte-identical.
@@ -673,6 +673,7 @@ export async function syncAttachmentsComment(client, target, run, workspace, opt
             url,
             embedUrl,
             pageUrl,
+            ...(size != null ? { size } : {}),
             ...(path || state
                 ? { meta: { ...(path ? { path } : {}), ...(state ? { state } : {}) } }
                 : {}),

package/dist/comment-render.generated.d.ts

@@ -120,6 +120,10 @@ export interface AttachmentItem {
         width?: number;
         height?: number;
     };
+    /** Object size in bytes, when known — drives the non-media file table's Size column. */
+    size?: number;
+    /** Stored content type, when known — preferred over name-based inference for file classification and the table's Type column. */
+    contentType?: string;
 }
 /** A public gallery linked to the PR or issue whose managed comment is syncing. */
 export interface GalleryCommentItem {

package/dist/comment-render.generated.js

@@ -285,6 +285,47 @@ function formatMetaCaption(meta, options, mode) {
     })
         .join(" · ");
 }
+/**
+ * Decimal-SI byte size for the non-media file table's Size column: whole
+ * bytes below 1000, one decimal place at KB/MB/GB and above. `"—"` when the
+ * size is unknown.
+ */
+function formatBytes(bytes) {
+    if (bytes == null || !Number.isFinite(bytes) || bytes < 0)
+        return "—";
+    if (bytes < 1000)
+        return `${Math.round(bytes)} B`;
+    const units = [
+        [1e9, "GB"],
+        [1e6, "MB"],
+        [1e3, "KB"],
+    ];
+    for (const [threshold, label] of units) {
+        if (bytes >= threshold)
+            return `${(bytes / threshold).toFixed(1)} ${label}`;
+    }
+    return `${Math.round(bytes)} B`;
+}
+/**
+ * Type label for the non-media file table: uppercase filename extension
+ * first, then the content type's subtype, then a bare "FILE" fallback.
+ */
+function fileTypeLabel(name, contentType) {
+    const dot = name.lastIndexOf(".");
+    if (dot !== -1 && dot < name.length - 1)
+        return name.slice(dot + 1).toUpperCase();
+    if (contentType) {
+        const slash = contentType.indexOf("/");
+        if (slash !== -1 && slash < contentType.length - 1) {
+            return contentType.slice(slash + 1).toUpperCase();
+        }
+    }
+    return "FILE";
+}
+/** Escape `|` so a filename can't break out of a markdown table cell. */
+function escapeTableCell(s) {
+    return s.replace(/\|/g, "\\|");
+}
 /** Resolved pixel width for an image site, or `null` meaning "omit the width
  * attribute". `"auto"` defers to the caller's per-item heuristic (`autoPx`);
  * `"full"` always omits; a number always wins. */
@@ -485,6 +526,10 @@ export function attachmentsCommentBody(items, galleries = [], marker = ATTACHMEN
     const consumedByPair = new Set();
     let inlinedImages = 0;
     const overflowImages = [];
+    // Non-media attachments (PDFs, archives, text/data files) never inline and
+    // never overflow into the <details> link list — they render as one table
+    // after the image/video section instead (issue #946).
+    const fileItems = [];
     for (let idx = 0; idx < sorted.length; idx++) {
         if (consumedByPair.has(idx))
             continue;
@@ -510,8 +555,21 @@ export function attachmentsCommentBody(items, galleries = [], marker = ATTACHMEN
         const stable = item.url;
         const src = item.embedUrl ?? item.url;
         const link = item.pageUrl ?? stable; // click-through: file page when known, else raw
-        const isImage = Boolean(src) && inferContentType(name).startsWith("image/");
-        const isPosterVideo = Boolean(item.posterUrl) && inferContentType(name).startsWith("video/");
+        // "application/octet-stream" is the server's generic fallback for an
+        // object stored without an explicit content type — not a real signal —
+        // so it defers to the filename the same as an absent `contentType`.
+        const effectiveType = item.contentType && item.contentType !== "application/octet-stream"
+            ? item.contentType
+            : inferContentType(name);
+        const isImage = Boolean(src) && effectiveType.startsWith("image/");
+        const isPosterVideo = Boolean(item.posterUrl) && effectiveType.startsWith("video/");
+        if (!effectiveType.startsWith("image/") && !effectiveType.startsWith("video/")) {
+            // Neither an image nor a video by content type — a non-media
+            // attachment goes into the file table, never the bullet list or
+            // overflow details.
+            fileItems.push(item);
+            continue;
+        }
         const inlines = isImage || isPosterVideo;
         if (inlines && inlinedImages >= options.maxInlineImages) {
             // Cap hit — defer to the collapsed overflow list below rather than
@@ -604,6 +662,23 @@ export function attachmentsCommentBody(items, galleries = [], marker = ATTACHMEN
             lines.push(`- ${name}${cap ? ` · ${cap}` : ""}`);
         }
     }
+    if (fileItems.length > 0) {
+        lines.push("| File | Type | Size |", "| --- | --- | --- |");
+        for (const item of fileItems) {
+            const name = item.key.slice(item.key.lastIndexOf("/") + 1);
+            const escapedName = escapeTableCell(name);
+            let fileCell = item.url ? `[${escapedName}](${item.url})` : escapedName;
+            if (item.pageUrl)
+                fileCell += ` · [page](${item.pageUrl})`;
+            const cap = formatMetaCaption(item.meta, options, "markdown");
+            if (cap)
+                fileCell += ` · ${cap}`;
+            const typeLabel = fileTypeLabel(name, item.contentType);
+            const sizeLabel = formatBytes(item.size);
+            lines.push(`| ${fileCell} | ${typeLabel} | ${sizeLabel} |`);
+        }
+        lines.push("");
+    }
     if (overflowImages.length > 0) {
         const n = overflowImages.length;
         lines.push(`<details><summary>${n} more attachment${n === 1 ? "" : "s"}</summary>`, "");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@buildinternet/uploads",
-  "version": "0.52.0",
+  "version": "0.52.1",
   "mcpName": "sh.uploads/mcp",
   "description": "CLI and client for uploads.sh — workspace-scoped image hosting for GitHub embeds",
   "type": "module",