@buildinternet/uploads 0.25.0 → 0.26.0

package/dist/commands.js

@@ -527,16 +527,16 @@ export async function syncAttachmentsComment(client, target, run, workspace) {
             return gallery;
         }
     }));
-    if (items.length === 0 && previewGalleries.length === 0)
-        return { action: "skipped", count: 0, via: "gh" };
     const marker = attachmentsMarker(workspace);
     const body = attachmentsCommentBody(items, previewGalleries, marker);
-    const { created } = upsertAttachmentsComment(target, body, run, marker);
-    return {
-        action: created ? "created" : "updated",
-        count: items.length + previewGalleries.length,
-        via: "gh",
-    };
+    const count = items.length + previewGalleries.length;
+    // Empty (count 0) renders the neutral empty-state body but must not create a
+    // comment — it only rewrites one that already exists (`action: "skipped"`
+    // when none does).
+    const { action } = upsertAttachmentsComment(target, body, run, marker, {
+        createIfMissing: count > 0,
+    });
+    return { action, count, via: "gh" };
 }
 // --- attach ---
 const ATTACH_HELP = `uploads attach <file...> [options]
@@ -2247,9 +2247,18 @@ export async function runComment(ctx, args, help = false, run = execRunner) {
     }
     else if (!ctx.quiet) {
         const via = commentViaSuffix(result.via);
-        process.stderr.write(result.action === "skipped"
-            ? `no attachments under ${ghKeyPrefix(target)} — nothing to do\n`
-            : `${result.action} attachments comment on ${target.repo}#${target.num} (${result.count} file${result.count === 1 ? "" : "s"})${via}\n`);
+        let line;
+        if (result.action === "skipped") {
+            line = `no attachments under ${ghKeyPrefix(target)} — nothing to do\n`;
+        }
+        else if (result.count === 0) {
+            // An existing comment rewritten to the empty state (every file removed).
+            line = `cleared attachments comment on ${target.repo}#${target.num} — no files remaining${via}\n`;
+        }
+        else {
+            line = `${result.action} attachments comment on ${target.repo}#${target.num} (${result.count} file${result.count === 1 ? "" : "s"})${via}\n`;
+        }
+        process.stderr.write(line);
     }
     return 0;
 }

package/dist/github-gh.d.ts

@@ -64,6 +64,8 @@ export declare function ghMetadataFromTargetWithTitle(target: GhTarget, run?: Co
  * an adopted legacy comment migrates it to the namespaced marker in place.
  * Defaults to the shared legacy marker for backward compatibility.
  */
-export declare function upsertAttachmentsComment(target: GhTarget, body: string, run?: CommandRunner, marker?: string): {
-    created: boolean;
+export declare function upsertAttachmentsComment(target: GhTarget, body: string, run?: CommandRunner, marker?: string, opts?: {
+    createIfMissing?: boolean;
+}): {
+    action: "created" | "updated" | "skipped";
 };

package/dist/github-gh.js

@@ -221,7 +221,8 @@ function findManagedComment(target, run, marker) {
  * an adopted legacy comment migrates it to the namespaced marker in place.
  * Defaults to the shared legacy marker for backward compatibility.
  */
-export function upsertAttachmentsComment(target, body, run = execRunner, marker = ATTACHMENTS_MARKER) {
+export function upsertAttachmentsComment(target, body, run = execRunner, marker = ATTACHMENTS_MARKER, opts = {}) {
+    const createIfMissing = opts.createIfMissing ?? true;
     const existing = findManagedComment(target, run, marker);
     if (existing) {
         run("gh", [
@@ -232,8 +233,12 @@ export function upsertAttachmentsComment(target, body, run = execRunner, marker
             "-F",
             "body=@-",
         ], body);
-        return { created: false };
+        return { action: "updated" };
     }
+    // Patch-only (createIfMissing false, i.e. an empty body) with no existing
+    // comment: nothing to do — never create one just to say it's empty.
+    if (!createIfMissing)
+        return { action: "skipped" };
     run("gh", ["api", `repos/${target.repo}/issues/${target.num}/comments`, "-F", "body=@-"], body);
-    return { created: true };
+    return { action: "created" };
 }

package/dist/github.js

@@ -482,6 +482,14 @@ export function attachmentsCommentBody(items, galleries = [], marker = ATTACHMEN
         }
         lines.push("", "</details>", "");
     }
+    // Emptied state: a PR/issue whose attachments and galleries were all removed
+    // still keeps its managed comment (a later push can repopulate it) — show a
+    // neutral resting state under the heading rather than a bare heading. Only
+    // the truly-empty case (no attachments, no galleries); a galleries-only
+    // comment has no Attachments heading and must not get this line.
+    if (sorted.length === 0 && sortedGalleries.length === 0) {
+        lines.push("_No attachments are currently associated with this pull request._", "");
+    }
     lines.push('<sub>Maintained by <a href="https://uploads.sh">uploads.sh</a> — re-uploading a file with the same name updates it everywhere it is embedded.</sub>');
     lines.push('<sub>Add media: <code>uploads put &lt;file&gt; --pr &lt;N&gt; --comment</code> (or <code>--issue &lt;N&gt;</code>) · <a href="https://uploads.sh/docs/github-app">docs</a></sub>');
     return lines.join("\n");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@buildinternet/uploads",
-  "version": "0.25.0",
+  "version": "0.26.0",
   "description": "CLI and client for uploads.sh — workspace-scoped image hosting for GitHub embeds",
   "type": "module",
   "sideEffects": false,