@buildinternet/releases-lib 0.42.0 → 0.44.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@buildinternet/releases-lib",
-  "version": "0.42.0",
+  "version": "0.44.0",
   "description": "Runtime-neutral helpers for the Releases CLI — logger, errors, config.",
   "type": "module",
   "license": "MIT",
@@ -11,6 +11,7 @@
   },
   "exports": {
     "./config": "./src/config.ts",
+    "./legacy-env": "./src/legacy-env.ts",
     "./logger": "./src/logger.ts"
   },
   "files": [

package/src/config.ts

@@ -1,12 +1,21 @@
 import { mkdirSync } from "fs";
 import { join } from "path";
 import { homedir } from "os";
+import { legacyEnv } from "./legacy-env";
 
 let _dataDir: string | null = null;
+let _dataDirEnv: string | undefined;
 
 export function getDataDir(): string {
-  if (!_dataDir) {
-    _dataDir = process.env.RELEASED_DATA_DIR || join(homedir(), ".releases");
+  // Cache the resolved dir, but invalidate when the env var changes. In prod
+  // the env is fixed at startup so this stays memoized (mkdir runs once); in
+  // tests, each file points RELEASED_DATA_DIR at its own temp dir, and the
+  // comparison re-resolves instead of returning a stale dir cached by another
+  // file. (This is what `bun test --isolate` used to paper over — see #211.)
+  const env = legacyEnv("RELEASES_DATA_DIR", "RELEASED_DATA_DIR");
+  if (_dataDir === null || env !== _dataDirEnv) {
+    _dataDirEnv = env;
+    _dataDir = env || join(homedir(), ".releases");
     mkdirSync(_dataDir, { recursive: true });
   }
   return _dataDir;

package/src/legacy-env.ts

@@ -0,0 +1,35 @@
+import { logger } from "./logger";
+
+const warned = new Set<string>();
+
+/** Reset warn-once state. Test-only. */
+export function __resetLegacyEnvWarnings(): void {
+  warned.clear();
+}
+
+/**
+ * Resolve an env var migrating from a legacy name to a canonical one. Prefers
+ * `canonical`; falls back to `legacy` with a one-time deprecation warning.
+ * Empty string counts as unset. Returns `undefined` when neither is set.
+ *
+ * `warn` is injectable for tests; defaults to the shared logger.
+ */
+export function legacyEnv(
+  canonical: string,
+  legacy: string,
+  warn: (msg: string) => void = (msg) => logger.warn(msg),
+): string | undefined {
+  const next = process.env[canonical];
+  if (next) return next;
+  const old = process.env[legacy];
+  if (old) {
+    if (!warned.has(legacy)) {
+      warned.add(legacy);
+      warn(
+        `${legacy} is deprecated; rename it to ${canonical}. The legacy name still works for now but will be removed.`,
+      );
+    }
+    return old;
+  }
+  return undefined;
+}